| Message ID | 20191023154505.30521-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | exec: Improve code for TARGET_PAGE_BITS_VARY | expand |
Patchew URL: https://patchew.org/QEMU/20191023154505.30521-1-richard.henderson@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 0/7] exec: Improve code for TARGET_PAGE_BITS_VARY Type: series Message-id: 20191023154505.30521-1-richard.henderson@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 19cd753 exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY 606b070 exec: Promote TARGET_PAGE_MASK to target_long 896d42b exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG 722d22e exec: Use const alias for TARGET_PAGE_BITS_VARY 6ac4efc configure: Detect compiler support for __attribute__((alias)) e28d025 exec: Split out variable page size support to exec-vary.c 1d02251 cpu: use ROUND_UP() to define xxx_PAGE_ALIGN === OUTPUT BEGIN === 1/7 Checking commit 1d0225166fde (cpu: use ROUND_UP() to define xxx_PAGE_ALIGN) 2/7 Checking commit e28d025c7c6c (exec: Split out variable page size support to exec-vary.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #33: new file mode 100644 total: 0 errors, 1 warnings, 125 lines checked Patch 2/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/7 Checking commit 6ac4efc3168c (configure: Detect compiler support for __attribute__((alias))) 4/7 Checking commit 722d22e4af52 (exec: Use const alias for TARGET_PAGE_BITS_VARY) ERROR: externs should be avoided in .c files #65: FILE: exec-vary.c:57: +extern const TargetPageBits target_page total: 1 errors, 0 warnings, 103 lines checked Patch 4/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/7 Checking commit 896d42b9ac68 (exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG) 6/7 Checking commit 606b070ea74e (exec: Promote TARGET_PAGE_MASK to target_long) 7/7 Checking commit 19cd7537b926 (exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20191023154505.30521-1-richard.henderson@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Richard Henderson <richard.henderson@linaro.org> writes: > Changes since v1: > * Replace my patch for TARGET_PAGE_ALIGN with Wei Yang's. > * Detect __attribute__((alias)) support in configure. > If unsupported, as for Apple Xcode9, use preprocessor trickery. > Passes travis build tests for xcode9. > > Link for v1: > https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg04519.html > Reviewed-by: Alex Bennée <alex.bennee@linaro.org> FWIW POW2_ROUND_UP is a better name than it currently has. > > r~ > > > Richard Henderson (6): > exec: Split out variable page size support to exec-vary.c > configure: Detect compiler support for __attribute__((alias)) > exec: Use const alias for TARGET_PAGE_BITS_VARY > exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG > exec: Promote TARGET_PAGE_MASK to target_long > exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY > > Wei Yang (1): > cpu: use ROUND_UP() to define xxx_PAGE_ALIGN > > Makefile.target | 2 +- > include/exec/cpu-all.h | 33 +++++++++---- > include/qemu-common.h | 6 +++ > exec-vary.c | 102 +++++++++++++++++++++++++++++++++++++++++ > exec.c | 34 -------------- > configure | 19 ++++++++ > 6 files changed, 151 insertions(+), 45 deletions(-) > create mode 100644 exec-vary.c -- Alex Bennée
Changes since v1: * Replace my patch for TARGET_PAGE_ALIGN with Wei Yang's. * Detect __attribute__((alias)) support in configure. If unsupported, as for Apple Xcode9, use preprocessor trickery. Passes travis build tests for xcode9. Link for v1: https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg04519.html r~ Richard Henderson (6): exec: Split out variable page size support to exec-vary.c configure: Detect compiler support for __attribute__((alias)) exec: Use const alias for TARGET_PAGE_BITS_VARY exec: Restrict TARGET_PAGE_BITS_VARY assert to CONFIG_DEBUG_TCG exec: Promote TARGET_PAGE_MASK to target_long exec: Cache TARGET_PAGE_MASK for TARGET_PAGE_BITS_VARY Wei Yang (1): cpu: use ROUND_UP() to define xxx_PAGE_ALIGN Makefile.target | 2 +- include/exec/cpu-all.h | 33 +++++++++---- include/qemu-common.h | 6 +++ exec-vary.c | 102 +++++++++++++++++++++++++++++++++++++++++ exec.c | 34 -------------- configure | 19 ++++++++ 6 files changed, 151 insertions(+), 45 deletions(-) create mode 100644 exec-vary.c -- 2.17.1