| Message ID | 20191106163128.1980714-1-vkoul@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] dmaengine: milbeaut-hdmac: remove redundant error log | expand |
On 06-11-19, 22:01, Vinod Koul wrote: > platform_get_irq() prints the error message, so caller need not do so, > remove the error line in this driver for platform_get_irq() Applied these now -- ~Vinod
diff --git a/drivers/dma/milbeaut-hdmac.c b/drivers/dma/milbeaut-hdmac.c index 2bb33535ab9e..8853d442430b 100644 --- a/drivers/dma/milbeaut-hdmac.c +++ b/drivers/dma/milbeaut-hdmac.c @@ -431,11 +431,8 @@ static int milbeaut_hdmac_chan_init(struct platform_device *pdev, int irq, ret; irq = platform_get_irq(pdev, chan_id); - if (irq < 0) { - dev_err(&pdev->dev, "failed to get IRQ number for ch%d\n", - chan_id); + if (irq < 0) return irq; - } irq_name = devm_kasprintf(dev, GFP_KERNEL, "milbeaut-hdmac-%d", chan_id);
platform_get_irq() prints the error message, so caller need not do so, remove the error line in this driver for platform_get_irq() Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Vinod Koul <vkoul@kernel.org> --- drivers/dma/milbeaut-hdmac.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.23.0