mbox series

[v1,00/15] testing and plugin updates

Message ID 20200520140541.30256-1-alex.bennee@linaro.org
Headers show
Series testing and plugin updates | expand

Message

Alex Bennée May 20, 2020, 2:05 p.m. UTC 
Hi,

Here is the current status of various testing and plugin related
patches. Most of the patches should be uncontroversial although I
would draw attention to the cpu and linux-user QOM object lifetime
patches. I think properly de-referencing the vCPU object associated
with the linux-user thread is the cleaner solution but it does involve
also changing some assumptions about the cpu indexing.

The following patches need review:
  - plugins: new lockstep plugin for debugging TCG changes
  - linux-user: properly "unrealize" vCPU object
  - cpus-common: ensure auto-assigned cpu_indexes don't clash
  - tests/docker: use a gcc-10 based image for arm64 tests
  - tests/docker: add debian11 base image
  - tests/docker: bump fedora to 32
  - tests/tcg: better detect confused gdb which can't connect
  - tests/fp: split and audit the conversion tests
  - tests/fp: enable extf80_le_quite tests
  - configure: add alternate binary for genisoimage

Alex Bennée (13):
  configure: add alternate binary for genisoimage
  tests/vm: pass --genisoimage to basevm script
  tests/tcg: fix invocation of the memory record/replay tests
  tests/fp: enable extf80_le_quite tests
  tests/fp: split and audit the conversion tests
  tests/tcg: better detect confused gdb which can't connect
  tests/docker: bump fedora to 32
  tests/docker: add debian11 base image
  tests/docker: use a gcc-10 based image for arm64 tests
  cpus-common: ensure auto-assigned cpu_indexes don't clash
  linux-user: properly "unrealize" vCPU object
  tests/tcg: add new threadcount test
  plugins: new lockstep plugin for debugging TCG changes

Richard Henderson (1):
  tests/tcg/aarch64: Add bti smoke test

Thomas Huth (1):
  travis.yml: Use clang++ in the Clang tests

 configure                                     |   2 +-
 cpus-common.c                                 |  10 +-
 linux-user/syscall.c                          |  19 +-
 tests/plugin/lockstep.c                       | 340 ++++++++++++++++++
 tests/tcg/aarch64/bti-1.c                     |  62 ++++
 tests/tcg/aarch64/bti-crt.inc.c               |  51 +++
 tests/tcg/multiarch/threadcount.c             |  64 ++++
 .travis.yml                                   |   8 +-
 tests/Makefile.include                        |  44 ++-
 tests/docker/Makefile.include                 |   4 +-
 .../debian-arm64-test-cross.docker            |  13 +
 tests/docker/dockerfiles/debian11.docker      |  18 +
 tests/docker/dockerfiles/fedora.docker        |   2 +-
 tests/plugin/Makefile                         |   1 +
 tests/tcg/Makefile.target                     |   2 +-
 tests/tcg/aarch64/Makefile.softmmu-target     |   2 +-
 tests/tcg/aarch64/Makefile.target             |   9 +
 tests/tcg/configure.sh                        |   8 +-
 tests/tcg/multiarch/Makefile.target           |   2 +
 tests/tcg/multiarch/gdbstub/sha1.py           |   4 +
 tests/vm/Makefile.include                     |   1 +
 tests/vm/basevm.py                            |  16 +-
 22 files changed, 641 insertions(+), 41 deletions(-)
 create mode 100644 tests/plugin/lockstep.c
 create mode 100644 tests/tcg/aarch64/bti-1.c
 create mode 100644 tests/tcg/aarch64/bti-crt.inc.c
 create mode 100644 tests/tcg/multiarch/threadcount.c
 create mode 100644 tests/docker/dockerfiles/debian-arm64-test-cross.docker
 create mode 100644 tests/docker/dockerfiles/debian11.docker

-- 
2.20.1

Comments

no-reply@patchew.org May 20, 2020, 4:37 p.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20200520140541.30256-1-alex.bennee@linaro.org/



Hi,

This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===

 perl-Encode-devel                       x86_64  4:3.06-445.fc32                    updates   42 k
 perl-Env                                noarch  1.04-440.fc32                      fedora    19 k
 perl-Errno                              x86_64  1.30-452.fc32                      fedora    24 k
 perl-Error                              noarch  1:0.17029-1.fc32                   fedora    42 k
 perl-Exporter                           noarch  5.74-2.fc32                        fedora    32 k
 perl-Exporter-Tiny                      noarch  1.002001-5.fc32                    fedora    51 k
 perl-ExtUtils-CBuilder                  noarch  1:0.280234-2.fc32                  fedora    47 k
---
(497/699): perl-Env-1.04-440.fc32.noarch.rpm    198 kB/s |  19 kB     00:00    
(498/699): perl-Digest-SHA-6.02-442.fc32.x86_64 325 kB/s |  64 kB     00:00    
(499/699): perl-Errno-1.30-452.fc32.x86_64.rpm  245 kB/s |  24 kB     00:00    
(500/699): perl-Error-0.17029-1.fc32.noarch.rpm 415 kB/s |  42 kB     00:00    
(501/699): perl-Exporter-5.74-2.fc32.noarch.rpm 318 kB/s |  32 kB     00:00    
(502/699): perl-Exporter-Tiny-1.002001-5.fc32.n 497 kB/s |  51 kB     00:00    
(503/699): perl-ExtUtils-CBuilder-0.280234-2.fc 455 kB/s |  47 kB     00:00    
---
  Installing       : perl-DB_File-1.853-2.fc32.x86_64                   175/700 
  Installing       : perl-Devel-Size-0.83-5.fc32.x86_64                 176/700 
  Installing       : perl-Env-1.04-440.fc32.noarch                      177/700 
  Installing       : perl-Error-1:0.17029-1.fc32.noarch                 178/700 
  Installing       : perl-ExtUtils-MM-Utils-2:7.44-2.fc32.noarch        179/700 
  Installing       : perl-IPC-SysV-2.07-442.fc32.x86_64                 180/700 
  Installing       : perl-IPC-System-Simple-1.30-1.fc32.noarch          181/700 
---
  Verifying        : perl-Encode-Locale-1.05-15.fc32.noarch             497/700 
  Verifying        : perl-Env-1.04-440.fc32.noarch                      498/700 
  Verifying        : perl-Errno-1.30-452.fc32.x86_64                    499/700 
  Verifying        : perl-Error-1:0.17029-1.fc32.noarch                 500/700 
  Verifying        : perl-Exporter-5.74-2.fc32.noarch                   501/700 
  Verifying        : perl-Exporter-Tiny-1.002001-5.fc32.noarch          502/700 
  Verifying        : perl-ExtUtils-CBuilder-1:0.280234-2.fc32.noarch    503/700 
---
  perl-Encode-devel-4:3.06-445.fc32.x86_64                                      
  perl-Env-1.04-440.fc32.noarch                                                 
  perl-Errno-1.30-452.fc32.x86_64                                               
  perl-Error-1:0.17029-1.fc32.noarch                                            
  perl-Exporter-5.74-2.fc32.noarch                                              
  perl-Exporter-Tiny-1.002001-5.fc32.noarch                                     
  perl-ExtUtils-CBuilder-1:0.280234-2.fc32.noarch                               
---
  CC      backends/tpm.o
  CC      backends/hostmem.o
  CC      backends/hostmem-ram.o
/tmp/qemu-test/src/audio/mixeng.c:274:34: error: implicit conversion from 'unsigned int' to 'float' changes value from 4294967295 to 4294967296 [-Werror,-Wimplicit-int-float-conversion]
static const float float_scale = UINT_MAX / 2.f;
                                 ^~~~~~~~ ~
/usr/lib64/clang/10.0.0/include/limits.h:56:37: note: expanded from macro 'UINT_MAX'
#define UINT_MAX  (__INT_MAX__  *2U +1U)
                   ~~~~~~~~~~~~~~~~~^~~
1 error generated.
make: *** [/tmp/qemu-test/src/rules.mak:69: audio/mixeng.o] Error 1
make: *** Waiting for unfinished jobs....
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 664, in <module>
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=07d8739029c2460480f2e8f49878e61e', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=x86_64-softmmu', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-juuwuycm/src/docker-src.2020-05-20-12.32.55.601:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-debug']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=07d8739029c2460480f2e8f49878e61e
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-juuwuycm/src'
make: *** [docker-run-test-debug@fedora] Error 2

real    4m16.571s
user    0m9.425s


The full log is available at
http://patchew.org/logs/20200520140541.30256-1-alex.bennee@linaro.org/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org May 20, 2020, 4:38 p.m. UTC | #2 
Patchew URL: https://patchew.org/QEMU/20200520140541.30256-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200520140541.30256-1-alex.bennee@linaro.org
Subject: [PATCH  v1 00/15] testing and plugin updates
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
a1f3009 plugins: new lockstep plugin for debugging TCG changes
f8ab9f1 tests/tcg: add new threadcount test
bbaf5c2 linux-user: properly "unrealize" vCPU object
8d602ed cpus-common: ensure auto-assigned cpu_indexes don't clash
a31d8dd tests/tcg/aarch64: Add bti smoke test
46efafc tests/docker: use a gcc-10 based image for arm64 tests
c62d664 tests/docker: add debian11 base image
c5590fe tests/docker: bump fedora to 32
5eea6f1 tests/tcg: better detect confused gdb which can't connect
63db898 tests/fp: split and audit the conversion tests
d484715 tests/fp: enable extf80_le_quite tests
da123f1 tests/tcg: fix invocation of the memory record/replay tests
0667cc3 travis.yml: Use clang++ in the Clang tests
03334db tests/vm: pass --genisoimage to basevm script
f49c9ff configure: add alternate binary for genisoimage

=== OUTPUT BEGIN ===
1/15 Checking commit f49c9ff28400 (configure: add alternate binary for genisoimage)
2/15 Checking commit 03334db3deeb (tests/vm: pass --genisoimage to basevm script)
3/15 Checking commit 0667cc3737a6 (travis.yml: Use clang++ in the Clang tests)
4/15 Checking commit da123f1fc347 (tests/tcg: fix invocation of the memory record/replay tests)
5/15 Checking commit d484715faabe (tests/fp: enable extf80_le_quite tests)
6/15 Checking commit 63db8983c952 (tests/fp: split and audit the conversion tests)
7/15 Checking commit 5eea6f17d0e4 (tests/tcg: better detect confused gdb which can't connect)
8/15 Checking commit c5590fe1a910 (tests/docker: bump fedora to 32)
9/15 Checking commit c62d664e2b07 (tests/docker: add debian11 base image)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

total: 0 errors, 1 warnings, 26 lines checked

Patch 9/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/15 Checking commit 46efafc4e520 (tests/docker: use a gcc-10 based image for arm64 tests)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

total: 0 errors, 1 warnings, 34 lines checked

Patch 10/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/15 Checking commit a31d8ddc748b (tests/tcg/aarch64: Add bti smoke test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

ERROR: externs should be avoided in .c files
#121: FILE: tests/tcg/aarch64/bti-crt.inc.c:13:
+int main(void);

total: 1 errors, 1 warnings, 138 lines checked

Patch 11/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

12/15 Checking commit 8d602ed77a25 (cpus-common: ensure auto-assigned cpu_indexes don't clash)
13/15 Checking commit bbaf5c2f62be (linux-user: properly "unrealize" vCPU object)
14/15 Checking commit f8ab9f1fcc96 (tests/tcg: add new threadcount test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 72 lines checked

Patch 14/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/15 Checking commit a1f3009ce1f2 (plugins: new lockstep plugin for debugging TCG changes)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#55: 
new file mode 100644

total: 0 errors, 1 warnings, 355 lines checked

Patch 15/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200520140541.30256-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com