| Message ID | 20200629212038.1153054-3-elder@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | net: ipa: three bug fixes | expand |
On Mon, 29 Jun 2020 16:20:37 -0500 Alex Elder wrote: > The AP LAN RX endpoint should not have download checksum offload > enabled. > > The receive handler does properly accomodate the trailer that's > added by the hardware, but we ignore it. > > Signed-off-by: Alex Elder <elder@linaro.org> For this net series - would you mind adding Fixes tags to each patch? Also checkpatch sayeth: WARNING: 'accomodate' may be misspelled - perhaps 'accommodate'? #10: The receive handler does properly accomodate the trailer that's
On 6/29/20 7:10 PM, Jakub Kicinski wrote: > On Mon, 29 Jun 2020 16:20:37 -0500 Alex Elder wrote: >> The AP LAN RX endpoint should not have download checksum offload >> enabled. >> >> The receive handler does properly accomodate the trailer that's >> added by the hardware, but we ignore it. >> >> Signed-off-by: Alex Elder <elder@linaro.org> > > For this net series - would you mind adding Fixes tags to each patch? Yes. That hasn't been my practice in the past; I guess I'll add it to my checklist... I will fix the spelling error in version 2. -Alex > > Also checkpatch sayeth: > > WARNING: 'accomodate' may be misspelled - perhaps 'accommodate'? > #10: > The receive handler does properly accomodate the trailer that's >
diff --git a/drivers/net/ipa/ipa_data-sdm845.c b/drivers/net/ipa/ipa_data-sdm845.c index 52d4b84e0dac..de2768d71ab5 100644 --- a/drivers/net/ipa/ipa_data-sdm845.c +++ b/drivers/net/ipa/ipa_data-sdm845.c @@ -44,7 +44,6 @@ static const struct ipa_gsi_endpoint_data ipa_gsi_endpoint_data[] = { .endpoint = { .seq_type = IPA_SEQ_INVALID, .config = { - .checksum = true, .aggregation = true, .status_enable = true, .rx = {
The AP LAN RX endpoint should not have download checksum offload enabled. The receive handler does properly accomodate the trailer that's added by the hardware, but we ignore it. Signed-off-by: Alex Elder <elder@linaro.org> --- drivers/net/ipa/ipa_data-sdm845.c | 1 - 1 file changed, 1 deletion(-) -- 2.25.1