| Message ID | 1582049733-17050-1-git-send-email-tdas@codeaurora.org |
|---|---|
| Headers | show |
| Series | Add modem Clock controller (MSS CC) driver for SC7180 | expand |
On Tue, 18 Feb 2020 23:45:29 +0530, Taniya Das wrote: > Add clock ids for GCC MSS clocks which are required to bring the modem > out of reset. > > Signed-off-by: Taniya Das <tdas@codeaurora.org> > --- > include/dt-bindings/clock/qcom,gcc-sc7180.h | 5 +++++ > 1 file changed, 5 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
Hey Taniya, + <&gcc GCC_MSS_NAV_AXIS_CLK>, error is because of ^^ typo it should be GCC_MSS_NAV_AXI_CLK instead, with that dt_bindings check will go though. On 2020-02-19 09:35, Taniya Das wrote: > Hi Rob, > > On 2/19/2020 4:30 AM, Rob Herring wrote: >> On Tue, 18 Feb 2020 23:45:31 +0530, Taniya Das wrote: >>> The Modem Subsystem clock provider have a bunch of generic properties >>> that are needed in a device tree. Add a YAML schemas for those. >>> >>> Signed-off-by: Taniya Das <tdas@codeaurora.org> >>> --- >>> .../devicetree/bindings/clock/qcom,sc7180-mss.yaml | 62 >>> ++++++++++++++++++++++ >>> 1 file changed, 62 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/clock/qcom,sc7180-mss.yaml >>> >> >> My bot found errors running 'make dt_binding_check' on your patch: >> >> Error: >> Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dts:21.26-27 >> syntax error >> FATAL ERROR: Unable to parse input tree >> scripts/Makefile.lib:300: recipe for target >> 'Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dt.yaml' >> failed >> make[1]: *** >> [Documentation/devicetree/bindings/clock/qcom,sc7180-mss.example.dt.yaml] >> Error 1 >> Makefile:1263: recipe for target 'dt_binding_check' failed >> make: *** [dt_binding_check] Error 2 >> >> See https://patchwork.ozlabs.org/patch/1240251 >> Please check and re-submit. >> > > I did see the same issue and then when I re-ordered by patches > dt-bindings: clock: Add support for Modem clocks in GCC (dependent) on > this binding patch, I no longer encountered the issue. > https://patchwork.kernel.org/patch/11389243/ > > Please let me know.
On 2/20/2020 4:48 PM, Sibi Sankar wrote: > Hey Taniya, > > + <&gcc GCC_MSS_NAV_AXIS_CLK>, > > error is because of ^^ typo > it should be GCC_MSS_NAV_AXI_CLK > instead, with that dt_bindings > check will go though. > > Thanks Sibi for pointing the typo.
[v4] * Split the GCC MSS clocks and Modem clock driver. * Update mss_regmap_config to const. * Rename the Documentation binding as per the latest convention. * Minor comments of clock-names/clocks properties updated. [v3] * Add clocks/clock-names required for the MSS clock controller. * Add pm_ops to enable/disable the required dependent clock. * Add parent_data for the MSS clocks. * Update the GCC MSS clocks from _CBCR to _CLK. [v2] * Update the license for the documentation and fix minor comments in the YAML bindings. [v1] * Add driver support for Modem clock controller for SC7180 and also update device tree bindings for the various clocks supported in the clock controller. Taniya Das (5): dt-bindings: clock: Add support for Modem clocks in GCC clk: qcom: gcc: Add support for modem clocks in GCC dt-bindings: clock: Add YAML schemas for the QCOM MSS clock bindings dt-bindings: clock: Introduce QCOM Modem clock bindings clk: qcom: Add modem clock controller driver for SC7180 .../devicetree/bindings/clock/qcom,sc7180-mss.yaml | 62 +++++++++ drivers/clk/qcom/Kconfig | 9 ++ drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/gcc-sc7180.c | 70 ++++++++++ drivers/clk/qcom/mss-sc7180.c | 143 +++++++++++++++++++++ include/dt-bindings/clock/qcom,gcc-sc7180.h | 5 + include/dt-bindings/clock/qcom,mss-sc7180.h | 12 ++ 7 files changed, 302 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/qcom,sc7180-mss.yaml create mode 100644 drivers/clk/qcom/mss-sc7180.c create mode 100644 include/dt-bindings/clock/qcom,mss-sc7180.h -- Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.