| Message ID | 20200131135009.31477-1-manivannan.sadhasivam@linaro.org |
|---|---|
| Headers | show |
| Series | Add MHI bus support | expand |
On 1/31/2020 6:49 AM, Manivannan Sadhasivam wrote: > This commit adds support for registering MHI client drivers with the > MHI stack. MHI client drivers binds to one or more MHI devices inorder > to sends and receive the upper-layer protocol packets like IP packets, > modem control messages, and diagnostics messages over MHI bus. > > This is based on the patch submitted by Sujeev Dias: > https://lkml.org/lkml/2018/7/9/987 > > Signed-off-by: Sujeev Dias <sdias@codeaurora.org> > Signed-off-by: Siddartha Mohanadoss <smohanad@codeaurora.org> > [mani: splitted and cleaned up for upstream] > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org> Tested-by: Jeffrey Hugo <jhugo@codeaurora.org>
On Fri, Jan 31, 2020 at 3:53 PM Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > > Add MAINTAINERS entry for MHI bus. > +MHI BUS > +M: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > +M: Hemant Kumar <hemantk@codeaurora.org> > +L: linux-arm-msm@vger.kernel.org > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git > +S: Maintained > +F: drivers/bus/mhi/ > +F: include/linux/mhi.h > +F: Documentation/mhi/ Had you run parse-maintainers.pl afterwards to see if everything is okay?
Hi Andy, On Mon, Feb 03, 2020 at 12:16:16PM +0200, Andy Shevchenko wrote: > On Fri, Jan 31, 2020 at 3:53 PM Manivannan Sadhasivam > <manivannan.sadhasivam@linaro.org> wrote: > > > > Add MAINTAINERS entry for MHI bus. > > > +MHI BUS > > +M: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > +M: Hemant Kumar <hemantk@codeaurora.org> > > +L: linux-arm-msm@vger.kernel.org > > +T: git git://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git > > +S: Maintained > > +F: drivers/bus/mhi/ > > +F: include/linux/mhi.h > > +F: Documentation/mhi/ > > Had you run parse-maintainers.pl afterwards to see if everything is okay? > Hmm. I didn't run it before but now looks like the entries need to be sorted as below: M: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> M: Hemant Kumar <hemantk@codeaurora.org> L: linux-arm-msm@vger.kernel.org S: Maintained T: git git://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git F: Documentation/mhi/ F: drivers/bus/mhi/ F: include/linux/mhi.h Will address this in next revision. Thanks, Mani > -- > With Best Regards, > Andy Shevchenko
On 2/6/2020 9:41 AM, Jeffrey Hugo wrote: > On 1/31/2020 6:50 AM, Manivannan Sadhasivam wrote: >> MHI protocol supports downloading RDDM (RAM Dump) image from the >> device through BHIE. This is useful to debugging as the RDDM image >> can capture the firmware state. >> >> This is based on the patch submitted by Sujeev Dias: >> https://lkml.org/lkml/2018/7/9/989 >> >> Signed-off-by: Sujeev Dias <sdias@codeaurora.org> >> Signed-off-by: Siddartha Mohanadoss <smohanad@codeaurora.org> >> [mani: splitted the data transfer patch and cleaned up for upstream] >> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >> --- >> drivers/bus/mhi/core/boot.c | 157 +++++++++++++++++++++++++++++++- >> drivers/bus/mhi/core/init.c | 38 ++++++++ >> drivers/bus/mhi/core/internal.h | 2 + >> drivers/bus/mhi/core/pm.c | 31 +++++++ >> include/linux/mhi.h | 24 +++++ >> 5 files changed, 249 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c >> index 36956fb6eff2..564d61f98257 100644 >> --- a/drivers/bus/mhi/core/boot.c >> +++ b/drivers/bus/mhi/core/boot.c >> @@ -20,7 +20,159 @@ >> #include <linux/wait.h> >> #include "internal.h" >> -/* Download AMSS image to device */ > > Seems a bit odd to add this line in patch 8, only to remove it here in > patch 9. Feels like never adding it in the first place would be better. > Not something to warrant a v3 through. > Since my nit is minor- Reviewed-by: Jeffrey Hugo <jhugo@codeaurora.org> Tested-by: Jeffrey Hugo <jhugo@codeaurora.org>
Hello, This is the second attempt at adding the MHI (Modem Host Interface) bus interface to Linux kernel. MHI is a communication protocol used by the host processors to control and communicate with modems over a high speed peripheral bus or shared memory. The MHI protocol has been designed and developed by Qualcomm Innovation Center, Inc., for use in their modems. The first submission was made by Sujeev Dias of Qualcomm: https://lkml.org/lkml/2018/4/26/1159 https://lkml.org/lkml/2018/7/9/987 This series addresses most of the review comments by Greg and Arnd for the initial patchset. Furthermore, in order to ease the review process I've splitted the patches logically and dropped few of them which were not required for this initial submission. Below is the high level changelog: 1. Removed all DT related code 2. Got rid of pci specific struct members from top level mhi structs 3. Moved device specific callbacks like ul_xfer() to driver struct. It doesn’t make sense to have callbacks in device struct as suggested by Greg 4. Used priv data of `struct device` instead of own priv data in `mhi_device` as suggested by Greg. This will allow us to use dev_set{get}_drvdata() APIs in client drivers 5. Removed all debugfs related code 6. Changes to the APIs to look uniform 7. Converted the documentation to .rst and placed in its own subdirectory 8. Changes to the MHI device naming 9. Converted all uppercase variable names to appropriate lowercase ones 10. Removed custom debug code and used the dev_* ones where applicable 11. Dropped timesync, DTR, UCI, and Qcom controller related codes 12. Added QRTR client driver patch 13. Added modalias support for the MHI stack as well as client driver for autoloading of modules (client drivers) by udev once the MHI devices are created This series includes the MHI stack as well as the QRTR client driver which falls under the networking subsystem. The reference controller implementation is here: https://git.linaro.org/people/manivannan.sadhasivam/linux.git/tree/drivers/net/wireless/ath/ath11k/mhi.c?h=ath11k-qca6390-mhi It will be submitted later along with ath11k patches. Following developers deserve explicit acknowledgements for their contributions to the MHI code: Sujeev Dias Siddartha Mohanadoss Hemant Kumar Jeff Hugo Thanks, Mani Changes in v2: * Added put_device to mhi_dealloc_device * Removed unused members from struct mhi_controller * Removed the atomicity of dev_wake in struct mhi_device as it is not required * Reordered MHI structs to avoid holes * Used struct device name for the controller device * Marked the required and optional mhi_controller members for helping the controller driver implementation * Cleanups to the MHI doc * Removed _relaxed variants and used readl/writel * Added comments for MHI specific acronyms * Removed the usage of bitfields and used bitmasks for mhi_event_ctxt and mhi_chan_ctxt * Used __64/__u32 types for structures representing hw states * Added Hemant as a co-maintainer of MHI bus. He is from the MHI team of Qualcomm and he will take up reviews and if possible, maintainership in future. Manivannan Sadhasivam (16): docs: Add documentation for MHI bus bus: mhi: core: Add support for registering MHI controllers bus: mhi: core: Add support for registering MHI client drivers bus: mhi: core: Add support for creating and destroying MHI devices bus: mhi: core: Add support for ringing channel/event ring doorbells bus: mhi: core: Add support for PM state transitions bus: mhi: core: Add support for basic PM operations bus: mhi: core: Add support for downloading firmware over BHIe bus: mhi: core: Add support for downloading RDDM image during panic bus: mhi: core: Add support for processing events from client device bus: mhi: core: Add support for data transfer bus: mhi: core: Add uevent support for module autoloading MAINTAINERS: Add entry for MHI bus net: qrtr: Add MHI transport layer net: qrtr: Do not depend on ARCH_QCOM soc: qcom: Do not depend on ARCH_QCOM for QMI helpers Documentation/index.rst | 1 + Documentation/mhi/index.rst | 18 + Documentation/mhi/mhi.rst | 218 ++++ Documentation/mhi/topology.rst | 60 ++ MAINTAINERS | 10 + drivers/bus/Kconfig | 1 + drivers/bus/Makefile | 3 + drivers/bus/mhi/Kconfig | 14 + drivers/bus/mhi/Makefile | 2 + drivers/bus/mhi/core/Makefile | 3 + drivers/bus/mhi/core/boot.c | 508 ++++++++++ drivers/bus/mhi/core/init.c | 1301 ++++++++++++++++++++++++ drivers/bus/mhi/core/internal.h | 699 +++++++++++++ drivers/bus/mhi/core/main.c | 1576 +++++++++++++++++++++++++++++ drivers/bus/mhi/core/pm.c | 967 ++++++++++++++++++ drivers/soc/qcom/Kconfig | 1 - include/linux/mhi.h | 661 ++++++++++++ include/linux/mod_devicetable.h | 13 + net/qrtr/Kconfig | 8 +- net/qrtr/Makefile | 2 + net/qrtr/mhi.c | 207 ++++ scripts/mod/devicetable-offsets.c | 3 + scripts/mod/file2alias.c | 10 + 23 files changed, 6284 insertions(+), 2 deletions(-) create mode 100644 Documentation/mhi/index.rst create mode 100644 Documentation/mhi/mhi.rst create mode 100644 Documentation/mhi/topology.rst create mode 100644 drivers/bus/mhi/Kconfig create mode 100644 drivers/bus/mhi/Makefile create mode 100644 drivers/bus/mhi/core/Makefile create mode 100644 drivers/bus/mhi/core/boot.c create mode 100644 drivers/bus/mhi/core/init.c create mode 100644 drivers/bus/mhi/core/internal.h create mode 100644 drivers/bus/mhi/core/main.c create mode 100644 drivers/bus/mhi/core/pm.c create mode 100644 include/linux/mhi.h create mode 100644 net/qrtr/mhi.c