mbox series

[0/7] media: kill off broken soc_camera

Message ID 20200626115321.1898798-1-hverkuil-cisco@xs4all.nl
Headers show
Series media: kill off broken soc_camera | expand

Message

Hans Verkuil June 26, 2020, 11:53 a.m. UTC
The soc_camera driver (and soc_camera.h header) is obsolete and depends
on BROKEN. It's time to remove this driver and the last references to it.

The first two patches remove a SoC Camera reference in two media drivers.
These references are obsolete (these drivers no longer use soc_camera),
so update the MODULE_DESCRIPTION.

The next three patches remove soc_camera depencies in three board files.
This has been compile tested. Note that the camera support for those
boards has been dead for a long time, so this really removes it. These
three patches are independent of the other patches in this series.

Then the soc_camera driver itself is removed (including soc_camera
dependent sensor drivers). This patch is also independent of the
other patches.

The final patch removes the soc_camera.h header, and that requires
that patches 3-6 are all merged.

Regards,

	Hans

Hans Verkuil (7):
  ov9640: update MODULE_DESCRIPTION
  pxa_camera: update MODULE_DESCRIPTION
  mach-imx: mach-imx27_visstrim_m10.c: remove soc_camera dependencies
  mach-omap1: board-ams-delta.c: remove soc_camera dependencies
  mach-pxa: palmz72/pcm990: remove soc_camera dependencies
  staging/media/soc_camera: remove this driver
  soc_camera.h: remove this unused header

 arch/arm/mach-imx/mach-imx27_visstrim_m10.c   |   31 -
 arch/arm/mach-omap1/board-ams-delta.c         |   32 -
 arch/arm/mach-omap1/camera.h                  |   14 -
 arch/arm/mach-omap1/devices.c                 |   43 -
 arch/arm/mach-pxa/palmz72.c                   |  112 -
 arch/arm/mach-pxa/pcm990-baseboard.c          |  157 --
 drivers/media/i2c/ov9640.c                    |    2 +-
 drivers/media/platform/pxa_camera.c           |    2 +-
 drivers/staging/media/Kconfig                 |    2 -
 drivers/staging/media/Makefile                |    1 -
 drivers/staging/media/soc_camera/Kconfig      |   51 -
 drivers/staging/media/soc_camera/Makefile     |    7 -
 drivers/staging/media/soc_camera/TODO         |    4 -
 drivers/staging/media/soc_camera/imx074.c     |  492 ----
 drivers/staging/media/soc_camera/mt9t031.c    |  853 -------
 .../staging/media/soc_camera/soc-camera.rst   |  171 --
 drivers/staging/media/soc_camera/soc_camera.c | 2164 -----------------
 .../staging/media/soc_camera/soc_mediabus.c   |  529 ----
 .../staging/media/soc_camera/soc_mt9v022.c    | 1008 --------
 drivers/staging/media/soc_camera/soc_ov5642.c | 1085 ---------
 drivers/staging/media/soc_camera/soc_ov9740.c |  992 --------
 .../linux/platform_data/media/omap1_camera.h  |   32 -
 include/media/drv-intf/soc_mediabus.h         |  107 -
 include/media/soc_camera.h                    |  397 ---
 24 files changed, 2 insertions(+), 8286 deletions(-)
 delete mode 100644 arch/arm/mach-omap1/camera.h
 delete mode 100644 drivers/staging/media/soc_camera/Kconfig
 delete mode 100644 drivers/staging/media/soc_camera/Makefile
 delete mode 100644 drivers/staging/media/soc_camera/TODO
 delete mode 100644 drivers/staging/media/soc_camera/imx074.c
 delete mode 100644 drivers/staging/media/soc_camera/mt9t031.c
 delete mode 100644 drivers/staging/media/soc_camera/soc-camera.rst
 delete mode 100644 drivers/staging/media/soc_camera/soc_camera.c
 delete mode 100644 drivers/staging/media/soc_camera/soc_mediabus.c
 delete mode 100644 drivers/staging/media/soc_camera/soc_mt9v022.c
 delete mode 100644 drivers/staging/media/soc_camera/soc_ov5642.c
 delete mode 100644 drivers/staging/media/soc_camera/soc_ov9740.c
 delete mode 100644 include/linux/platform_data/media/omap1_camera.h
 delete mode 100644 include/media/drv-intf/soc_mediabus.h
 delete mode 100644 include/media/soc_camera.h

Comments

Robert Jarzmik July 8, 2020, 10:33 a.m. UTC | #1
Hans Verkuil <hverkuil-cisco@xs4all.nl> writes:

> Remove the confusing SoC Camera reference.

Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>


Cheers.

--
Robert
Robert Jarzmik July 11, 2020, 7:44 p.m. UTC | #2
Arnd Bergmann <arnd@arndb.de> writes:

> On Fri, Jun 26, 2020 at 1:53 PM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:

>>

>> The soc_camera driver is about to be removed, so drop camera

>> support from this board. Note that the soc_camera driver itself has

>> long since been deprecated and can't be compiled anymore (it depends

>> on BROKEN), so camera support on this board has been broken for a long

>> time (at least since 4.9 when the pxa_camera.c was removed from soc_camera).

>>

>> Note that there is a new pxa_camera.c driver that replaced the old

>> soc_camera based driver, but using that would require these boards to

>> be converted to use the device tree.

This statement is not accurate, pxa_camera should be working in platform_data
based boards, it's just that the solution to make it work was not found yet if I
remember correctly, since the evolutions to the clocking in v4l2 hit it.

> Acked-by: Arnd Bergmann <arnd@arndb.de>

>

> Please merge this through the media tree if there are no objections.

So be it.

--
Robert