| Message ID | 20200701090642.232739-1-wolfgang.wallner@br-automation.com |
|---|---|
| Headers | show |
| Series | x86: p2sb: P2SB fixes | expand |
Hi Wolfgang, On Wed, Jul 1, 2020 at 5:06 PM Wolfgang Wallner <wolfgang.wallner at br-automation.com> wrote: > > Currently it is possible to select the P2SB driver without selecting the > P2SB uclass, which can't work. Fix this by adding a "depends on" in > Kconfig. > > While at it, correct the meaning of P2SB (according to Intel's > documentation P2SB stands for "Primary to Sideband Bridge"). > > Remark: I have resent this series as V2 as I had messed up the cover > letter in V1. > > Changes in v2: > - Fixed cover letter > Is this series needed for v2020.07? Does this break anything? Regards, Bin
Hi Bin, -----"Bin Meng" <bmeng.cn at gmail.com> schrieb: ----- > Betreff: Re: [PATCH v2 0/2] x86: p2sb: P2SB fixes > > Hi Wolfgang, > > On Wed, Jul 1, 2020 at 5:06 PM Wolfgang Wallner > <wolfgang.wallner at br-automation.com> wrote: > > > > Currently it is possible to select the P2SB driver without selecting the > > P2SB uclass, which can't work. Fix this by adding a "depends on" in > > Kconfig. > > > > While at it, correct the meaning of P2SB (according to Intel's > > documentation P2SB stands for "Primary to Sideband Bridge"). > > > > Remark: I have resent this series as V2 as I had messed up the cover > > letter in V1. > > > > Changes in v2: > > - Fixed cover letter > > > > Is this series needed for v2020.07? Does this break anything? No, it is not needed for v2020.07. This patch is only a precaution to avoid creating configs that won't work. regards, Wolfgang
Currently it is possible to select the P2SB driver without selecting the P2SB uclass, which can't work. Fix this by adding a "depends on" in Kconfig. While at it, correct the meaning of P2SB (according to Intel's documentation P2SB stands for "Primary to Sideband Bridge"). Remark: I have resent this series as V2 as I had messed up the cover letter in V1. Changes in v2: - Fixed cover letter Wolfgang Wallner (2): drivers: p2sb: replace Primary-to-Sideband Bus with Primary to Sideband Bridge x86: p2sb: make P2SB driver depend on P2SB uclass arch/x86/Kconfig | 1 + drivers/misc/Kconfig | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-)