| Message ID | 1584017626-8547-2-git-send-email-madalin.bucur@oss.nxp.com |
|---|---|
| State | Accepted |
| Commit | e219d7d0f1dbf16ec2547a9f7136cf0a9d642402 |
| Headers | show |
| Series | armv8/ls104xardb: RGMII ports require internal delay | expand |
>-----Original Message----- >From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Madalin Bucur >Sent: Thursday, March 12, 2020 6:24 PM >To: joe.hershberger at ni.com; u-boot at lists.denx.de >Cc: Madalin Bucur (OSS) <madalin.bucur at oss.nxp.com> >Subject: [PATCH 1/3] net: fman: add support for all RGMII delay modes > >The RGMII modes that include internal delay were not all properly treated in >the memac code. Add support for all RGMII delay modes. > >Fixes: 111fd19e3b9e ("fm/mEMAC: add mEMAC frame work") >Signed-off-by: Madalin Bucur <madalin.bucur at oss.nxp.com> >--- > drivers/net/fm/memac.c | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/drivers/net/fm/memac.c b/drivers/net/fm/memac.c index >2c49951..bed8f14 100644 >--- a/drivers/net/fm/memac.c >+++ b/drivers/net/fm/memac.c >@@ -83,6 +83,8 @@ static void memac_set_interface_mode(struct >fsl_enet_mac *mac, > if_mode |= IF_MODE_GMII; > break; > case PHY_INTERFACE_MODE_RGMII: >+ case PHY_INTERFACE_MODE_RGMII_ID: >+ case PHY_INTERFACE_MODE_RGMII_RXID: > case PHY_INTERFACE_MODE_RGMII_TXID: > if_mode |= (IF_MODE_GMII | IF_MODE_RG); > break; >@@ -107,6 +109,8 @@ static void memac_set_interface_mode(struct >fsl_enet_mac *mac, > if_mode |= IF_MODE_EN_AUTO; > > if (type == PHY_INTERFACE_MODE_RGMII || >+ type == PHY_INTERFACE_MODE_RGMII_ID || >+ type == PHY_INTERFACE_MODE_RGMII_RXID || > type == PHY_INTERFACE_MODE_RGMII_TXID) { > if_mode &= ~IF_MODE_EN_AUTO; > if_mode &= ~IF_MODE_SETSP_MASK; >-- >2.1.0 Reviewed-by: Priyanka Jain <priyanka.jain at nxp.com> Joe, Can you please review/provide ack to this patch series Priyanka
>-----Original Message----- >From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Madalin Bucur >Sent: Thursday, March 12, 2020 6:24 PM >To: joe.hershberger at ni.com; u-boot at lists.denx.de >Cc: Madalin Bucur (OSS) <madalin.bucur at oss.nxp.com> >Subject: [PATCH 1/3] net: fman: add support for all RGMII delay modes > >The RGMII modes that include internal delay were not all properly treated in >the memac code. Add support for all RGMII delay modes. > >Fixes: 111fd19e3b9e ("fm/mEMAC: add mEMAC frame work") >Signed-off-by: Madalin Bucur <madalin.bucur at oss.nxp.com> >--- Series applied to u-boot-fsl-qoriq. Waiting upstream Thanks Priyanka
diff --git a/drivers/net/fm/memac.c b/drivers/net/fm/memac.c index 2c49951..bed8f14 100644 --- a/drivers/net/fm/memac.c +++ b/drivers/net/fm/memac.c @@ -83,6 +83,8 @@ static void memac_set_interface_mode(struct fsl_enet_mac *mac, if_mode |= IF_MODE_GMII; break; case PHY_INTERFACE_MODE_RGMII: + case PHY_INTERFACE_MODE_RGMII_ID: + case PHY_INTERFACE_MODE_RGMII_RXID: case PHY_INTERFACE_MODE_RGMII_TXID: if_mode |= (IF_MODE_GMII | IF_MODE_RG); break; @@ -107,6 +109,8 @@ static void memac_set_interface_mode(struct fsl_enet_mac *mac, if_mode |= IF_MODE_EN_AUTO; if (type == PHY_INTERFACE_MODE_RGMII || + type == PHY_INTERFACE_MODE_RGMII_ID || + type == PHY_INTERFACE_MODE_RGMII_RXID || type == PHY_INTERFACE_MODE_RGMII_TXID) { if_mode &= ~IF_MODE_EN_AUTO; if_mode &= ~IF_MODE_SETSP_MASK;
The RGMII modes that include internal delay were not all properly treated in the memac code. Add support for all RGMII delay modes. Fixes: 111fd19e3b9e ("fm/mEMAC: add mEMAC frame work") Signed-off-by: Madalin Bucur <madalin.bucur at oss.nxp.com> --- drivers/net/fm/memac.c | 4 ++++ 1 file changed, 4 insertions(+)