| Message ID | 20200504124523.23484-11-s.nawrocki@samsung.com |
|---|---|
| State | New |
| Headers | show |
| Series | USB host support for Raspberry Pi 4 board | expand |
On Mon, May 4, 2020 at 8:45 PM Sylwester Nawrocki <s.nawrocki at samsung.com> wrote: > > From: Marek Szyprowski <m.szyprowski at samsung.com> > > This requires enabling BRCMSTB PCIe and XHCI_PCI drivers as well as PCI > and USB commands. To get it working one has to call the following commands: > "pci enum; usb start;", thus such commands have been added to the default > "preboot" environment variable. One has to update their environment if it > is already configured to get this feature working out of the box. > > Signed-off-by: Marek Szyprowski <m.szyprowski at samsung.com> > Signed-off-by: Sylwester Nawrocki <s.nawrocki at samsung.com> > --- > Changes since v1: > - removed unneeded CONFIG_XHCI_64BIT_DWORD_ACCESS_ONLY entry. > > Changes since RFC: > - none. > --- > configs/rpi_4_32b_defconfig | 9 +++++++++ > configs/rpi_4_defconfig | 9 +++++++++ > configs/rpi_arm64_defconfig | 8 +++++++- > 3 files changed, 25 insertions(+), 1 deletion(-) > What are these 3 defconfigs files for? Seems there is no MAINTAINERS mentioning them. I assume rpi_4_32b_defconfig is for 32-bit U-Boot and rpi_4_defconfig is for 64-bit U-Boot for RPi 4? What is rpi_arm64_defconfig? Regards, Bin
[ Adding Matthias as he's the board maintainer ] On Tue, 2020-05-05 at 19:15 +0800, Bin Meng wrote: > On Mon, May 4, 2020 at 8:45 PM Sylwester Nawrocki > <s.nawrocki at samsung.com> wrote: > > From: Marek Szyprowski <m.szyprowski at samsung.com> > > > > This requires enabling BRCMSTB PCIe and XHCI_PCI drivers as well as PCI > > and USB commands. To get it working one has to call the following commands: > > "pci enum; usb start;", thus such commands have been added to the default > > "preboot" environment variable. One has to update their environment if it > > is already configured to get this feature working out of the box. > > > > Signed-off-by: Marek Szyprowski <m.szyprowski at samsung.com> > > Signed-off-by: Sylwester Nawrocki <s.nawrocki at samsung.com> > > --- > > Changes since v1: > > - removed unneeded CONFIG_XHCI_64BIT_DWORD_ACCESS_ONLY entry. > > > > Changes since RFC: > > - none. > > --- > > configs/rpi_4_32b_defconfig | 9 +++++++++ > > configs/rpi_4_defconfig | 9 +++++++++ > > configs/rpi_arm64_defconfig | 8 +++++++- > > 3 files changed, 25 insertions(+), 1 deletion(-) > > > > What are these 3 defconfigs files for? Seems there is no MAINTAINERS > mentioning them. > > I assume rpi_4_32b_defconfig is for 32-bit U-Boot and rpi_4_defconfig > is for 64-bit U-Boot for RPi 4? What is rpi_arm64_defconfig? I think rpi_arm64_defconfig is for both rpi3 & rpi4. Regards, Nicolas -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: This is a digitally signed message part URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200505/274a0129/attachment.sig>
Hi On 05.05.2020 13:15, Bin Meng wrote: > On Mon, May 4, 2020 at 8:45 PM Sylwester Nawrocki > <s.nawrocki at samsung.com> wrote: >> From: Marek Szyprowski <m.szyprowski at samsung.com> >> >> This requires enabling BRCMSTB PCIe and XHCI_PCI drivers as well as PCI >> and USB commands. To get it working one has to call the following commands: >> "pci enum; usb start;", thus such commands have been added to the default >> "preboot" environment variable. One has to update their environment if it >> is already configured to get this feature working out of the box. >> >> Signed-off-by: Marek Szyprowski <m.szyprowski at samsung.com> >> Signed-off-by: Sylwester Nawrocki <s.nawrocki at samsung.com> >> --- >> Changes since v1: >> - removed unneeded CONFIG_XHCI_64BIT_DWORD_ACCESS_ONLY entry. >> >> Changes since RFC: >> - none. >> --- >> configs/rpi_4_32b_defconfig | 9 +++++++++ >> configs/rpi_4_defconfig | 9 +++++++++ >> configs/rpi_arm64_defconfig | 8 +++++++- >> 3 files changed, 25 insertions(+), 1 deletion(-) >> > What are these 3 defconfigs files for? Seems there is no MAINTAINERS > mentioning them. > > I assume rpi_4_32b_defconfig is for 32-bit U-Boot and rpi_4_defconfig > is for 64-bit U-Boot for RPi 4? What is rpi_arm64_defconfig? rpi_arm64_defconfig is for common image, which works on both RPi 3 and RPi 4. Best regards
diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig index 72cda5d..0dd763f 100644 --- a/configs/rpi_4_32b_defconfig +++ b/configs/rpi_4_32b_defconfig @@ -8,6 +8,8 @@ CONFIG_NR_DRAM_BANKS=2 CONFIG_DISTRO_DEFAULTS=y CONFIG_OF_BOARD_SETUP=y # CONFIG_ARCH_FIXUP_FDT_MEMORY is not set +CONFIG_USE_PREBOOT=y +CONFIG_PREBOOT="pci enum; usb start;" CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_CPUINFO is not set # CONFIG_DISPLAY_BOARDINFO is not set @@ -15,6 +17,8 @@ CONFIG_SYS_PROMPT="U-Boot> " CONFIG_CMD_DFU=y CONFIG_CMD_GPIO=y CONFIG_CMD_MMC=y +CONFIG_CMD_PCI=y +CONFIG_CMD_USB=y CONFIG_CMD_FS_UUID=y CONFIG_OF_BOARD=y CONFIG_ENV_FAT_INTERFACE="mmc" @@ -28,12 +32,17 @@ CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_BCM2835=y CONFIG_DM_ETH=y CONFIG_BCMGENET=y +CONFIG_PCI=y +CONFIG_DM_PCI=y +CONFIG_PCI_BRCMSTB=y CONFIG_PINCTRL=y # CONFIG_PINCTRL_GENERIC is not set # CONFIG_REQUIRE_SERIAL_CONSOLE is not set CONFIG_USB=y CONFIG_DM_USB=y CONFIG_DM_USB_GADGET=y +CONFIG_USB_XHCI_HCD=y +CONFIG_USB_XHCI_PCI=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="FSL" CONFIG_USB_GADGET_VENDOR_NUM=0x0525 diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig index 6d148da..3f1a1b5 100644 --- a/configs/rpi_4_defconfig +++ b/configs/rpi_4_defconfig @@ -8,6 +8,8 @@ CONFIG_NR_DRAM_BANKS=2 CONFIG_DISTRO_DEFAULTS=y CONFIG_OF_BOARD_SETUP=y # CONFIG_ARCH_FIXUP_FDT_MEMORY is not set +CONFIG_USE_PREBOOT=y +CONFIG_PREBOOT="pci enum; usb start;" CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_CPUINFO is not set # CONFIG_DISPLAY_BOARDINFO is not set @@ -15,6 +17,8 @@ CONFIG_SYS_PROMPT="U-Boot> " CONFIG_CMD_DFU=y CONFIG_CMD_GPIO=y CONFIG_CMD_MMC=y +CONFIG_CMD_PCI=y +CONFIG_CMD_USB=y CONFIG_CMD_FS_UUID=y CONFIG_OF_BOARD=y CONFIG_ENV_FAT_INTERFACE="mmc" @@ -28,12 +32,17 @@ CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_BCM2835=y CONFIG_DM_ETH=y CONFIG_BCMGENET=y +CONFIG_PCI=y +CONFIG_DM_PCI=y +CONFIG_PCI_BRCMSTB=y CONFIG_PINCTRL=y # CONFIG_PINCTRL_GENERIC is not set # CONFIG_REQUIRE_SERIAL_CONSOLE is not set CONFIG_USB=y CONFIG_DM_USB=y CONFIG_DM_USB_GADGET=y +CONFIG_USB_XHCI_HCD=y +CONFIG_USB_XHCI_PCI=y CONFIG_USB_GADGET=y CONFIG_USB_GADGET_MANUFACTURER="FSL" CONFIG_USB_GADGET_VENDOR_NUM=0x0525 diff --git a/configs/rpi_arm64_defconfig b/configs/rpi_arm64_defconfig index fea86be..f12d1e3 100644 --- a/configs/rpi_arm64_defconfig +++ b/configs/rpi_arm64_defconfig @@ -7,13 +7,14 @@ CONFIG_NR_DRAM_BANKS=2 CONFIG_DISTRO_DEFAULTS=y CONFIG_OF_BOARD_SETUP=y CONFIG_USE_PREBOOT=y -CONFIG_PREBOOT="usb start" +CONFIG_PREBOOT="pci enum; usb start;" CONFIG_MISC_INIT_R=y # CONFIG_DISPLAY_CPUINFO is not set # CONFIG_DISPLAY_BOARDINFO is not set CONFIG_SYS_PROMPT="U-Boot> " CONFIG_CMD_GPIO=y CONFIG_CMD_MMC=y +CONFIG_CMD_PCI=y CONFIG_CMD_USB=y CONFIG_CMD_FS_UUID=y CONFIG_OF_BOARD=y @@ -26,11 +27,16 @@ CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_BCM2835=y CONFIG_DM_ETH=y CONFIG_BCMGENET=y +CONFIG_PCI=y +CONFIG_DM_PCI=y +CONFIG_PCI_BRCMSTB=y CONFIG_PINCTRL=y # CONFIG_PINCTRL_GENERIC is not set # CONFIG_REQUIRE_SERIAL_CONSOLE is not set CONFIG_USB=y CONFIG_DM_USB=y +CONFIG_USB_XHCI_HCD=y +CONFIG_USB_XHCI_PCI=y CONFIG_USB_DWC2=y CONFIG_USB_KEYBOARD=y CONFIG_USB_HOST_ETHER=y