mbox series

[v2,0/6] wcn36xx misc fixes

Message ID 1595586052-16081-1-git-send-email-loic.poulain@linaro.org
Headers show
Series wcn36xx misc fixes | expand

Message

Loic Poulain July 24, 2020, 10:20 a.m. UTC
This series contains various fixes for the wcn36xx driver.
This has been tested with wcn3620, wcn3660 and wcn3680.

v2: - Move TX retries change into its own commit
    - Additional patch for sequence number assignment
    - Reword TX ack commit log (timeout detection)
    - Fix checkpatch issues reported by Bryan

Loic Poulain (6):
  wcn36xx: Fix multiple AMPDU sessions support
  wcn36xx: Add TX ack support
  wcn36xx: Increase number of TX retries
  wcn36xx: Fix TX data path
  wcn36xx: Fix software-driven scan
  wcn36xx: Use sequence number allocated by mac80211

 drivers/net/wireless/ath/wcn36xx/dxe.c     |  57 +++++++++-
 drivers/net/wireless/ath/wcn36xx/main.c    | 172 +++++++++++++++--------------
 drivers/net/wireless/ath/wcn36xx/smd.c     |  59 ++++++++--
 drivers/net/wireless/ath/wcn36xx/smd.h     |  12 +-
 drivers/net/wireless/ath/wcn36xx/txrx.c    |  57 ++++++----
 drivers/net/wireless/ath/wcn36xx/wcn36xx.h |   7 +-
 6 files changed, 241 insertions(+), 123 deletions(-)

-- 
2.7.4

Comments

Ramon Fried July 24, 2020, 1:47 p.m. UTC | #1
On Fri, Jul 24, 2020 at 1:15 PM Loic Poulain <loic.poulain@linaro.org> wrote:
>

> This series contains various fixes for the wcn36xx driver.

> This has been tested with wcn3620, wcn3660 and wcn3680.

>

> v2: - Move TX retries change into its own commit

>     - Additional patch for sequence number assignment

>     - Reword TX ack commit log (timeout detection)

>     - Fix checkpatch issues reported by Bryan

>

> Loic Poulain (6):

>   wcn36xx: Fix multiple AMPDU sessions support

>   wcn36xx: Add TX ack support

>   wcn36xx: Increase number of TX retries

>   wcn36xx: Fix TX data path

>   wcn36xx: Fix software-driven scan

>   wcn36xx: Use sequence number allocated by mac80211

>

>  drivers/net/wireless/ath/wcn36xx/dxe.c     |  57 +++++++++-

>  drivers/net/wireless/ath/wcn36xx/main.c    | 172 +++++++++++++++--------------

>  drivers/net/wireless/ath/wcn36xx/smd.c     |  59 ++++++++--

>  drivers/net/wireless/ath/wcn36xx/smd.h     |  12 +-

>  drivers/net/wireless/ath/wcn36xx/txrx.c    |  57 ++++++----

>  drivers/net/wireless/ath/wcn36xx/wcn36xx.h |   7 +-

>  6 files changed, 241 insertions(+), 123 deletions(-)

>

> --

> 2.7.4

>

>

> _______________________________________________

> wcn36xx mailing list

> wcn36xx@lists.infradead.org

> http://lists.infradead.org/mailman/listinfo/wcn36xx



Hi Loic,
What about upstreaming the fixes for several TP-Link AP's ?
The WCN36xx is not usable on those networks and your own tree patches seems to
be working properly.

Thanks,
Ramon.

Acked-By: Ramon Fried <rfried.dev@gmail.com>
Loic Poulain July 24, 2020, 2:02 p.m. UTC | #2
Hi Ramon,

On Fri, 24 Jul 2020 at 15:47, Ramon Fried <ramon.fried@gmail.com> wrote:
>

> On Fri, Jul 24, 2020 at 1:15 PM Loic Poulain <loic.poulain@linaro.org> wrote:

> >

> > This series contains various fixes for the wcn36xx driver.

> > This has been tested with wcn3620, wcn3660 and wcn3680.

> >

> > v2: - Move TX retries change into its own commit

> >     - Additional patch for sequence number assignment

> >     - Reword TX ack commit log (timeout detection)

> >     - Fix checkpatch issues reported by Bryan

> >

> > Loic Poulain (6):

> >   wcn36xx: Fix multiple AMPDU sessions support

> >   wcn36xx: Add TX ack support

> >   wcn36xx: Increase number of TX retries

> >   wcn36xx: Fix TX data path

> >   wcn36xx: Fix software-driven scan

> >   wcn36xx: Use sequence number allocated by mac80211

> >

> >  drivers/net/wireless/ath/wcn36xx/dxe.c     |  57 +++++++++-

> >  drivers/net/wireless/ath/wcn36xx/main.c    | 172 +++++++++++++++--------------

> >  drivers/net/wireless/ath/wcn36xx/smd.c     |  59 ++++++++--

> >  drivers/net/wireless/ath/wcn36xx/smd.h     |  12 +-

> >  drivers/net/wireless/ath/wcn36xx/txrx.c    |  57 ++++++----

> >  drivers/net/wireless/ath/wcn36xx/wcn36xx.h |   7 +-

> >  6 files changed, 241 insertions(+), 123 deletions(-)

> >

> > --

> > 2.7.4

> >

> >

> > _______________________________________________

> > wcn36xx mailing list

> > wcn36xx@lists.infradead.org

> > http://lists.infradead.org/mailman/listinfo/wcn36xx

>

>

> Hi Loic,

> What about upstreaming the fixes for several TP-Link AP's ?

> The WCN36xx is not usable on those networks and your own tree patches seems to

> be working properly.


Which ones do you have in mind?
This series normally contains the most important (and clean) patches.

Cheers,
Loic
Ramon Fried July 24, 2020, 6:51 p.m. UTC | #3
On Fri, Jul 24, 2020 at 4:57 PM Loic Poulain <loic.poulain@linaro.org> wrote:
>

> Hi Ramon,

>

> On Fri, 24 Jul 2020 at 15:47, Ramon Fried <ramon.fried@gmail.com> wrote:

> >

> > On Fri, Jul 24, 2020 at 1:15 PM Loic Poulain <loic.poulain@linaro.org> wrote:

> > >

> > > This series contains various fixes for the wcn36xx driver.

> > > This has been tested with wcn3620, wcn3660 and wcn3680.

> > >

> > > v2: - Move TX retries change into its own commit

> > >     - Additional patch for sequence number assignment

> > >     - Reword TX ack commit log (timeout detection)

> > >     - Fix checkpatch issues reported by Bryan

> > >

> > > Loic Poulain (6):

> > >   wcn36xx: Fix multiple AMPDU sessions support

> > >   wcn36xx: Add TX ack support

> > >   wcn36xx: Increase number of TX retries

> > >   wcn36xx: Fix TX data path

> > >   wcn36xx: Fix software-driven scan

> > >   wcn36xx: Use sequence number allocated by mac80211

> > >

> > >  drivers/net/wireless/ath/wcn36xx/dxe.c     |  57 +++++++++-

> > >  drivers/net/wireless/ath/wcn36xx/main.c    | 172 +++++++++++++++--------------

> > >  drivers/net/wireless/ath/wcn36xx/smd.c     |  59 ++++++++--

> > >  drivers/net/wireless/ath/wcn36xx/smd.h     |  12 +-

> > >  drivers/net/wireless/ath/wcn36xx/txrx.c    |  57 ++++++----

> > >  drivers/net/wireless/ath/wcn36xx/wcn36xx.h |   7 +-

> > >  6 files changed, 241 insertions(+), 123 deletions(-)

> > >

> > > --

> > > 2.7.4

> > >

> > >

> > > _______________________________________________

> > > wcn36xx mailing list

> > > wcn36xx@lists.infradead.org

> > > http://lists.infradead.org/mailman/listinfo/wcn36xx

> >

> >

> > Hi Loic,

> > What about upstreaming the fixes for several TP-Link AP's ?

> > The WCN36xx is not usable on those networks and your own tree patches seems to

> > be working properly.

>

> Which ones do you have in mind?

I didn't inspect each patch, I just took your tree and everything now
works as expected on  my TP-Link setup.
I did notice this patch -   "wcn36xx: Fix power-saving with some APs"
that was missing.
And there are some patches in your tree that hack the mac802111 core,
Do you think there's a way to upstream those ?

Thanks,
Ramon.


> This series normally contains the most important (and clean) patches.

>

> Cheers,

> Loic
Loic Poulain July 28, 2020, 10:13 a.m. UTC | #4
Hi Ramon,

On Fri, 24 Jul 2020 at 20:51, Ramon Fried <ramon.fried@gmail.com> wrote:
>

> On Fri, Jul 24, 2020 at 4:57 PM Loic Poulain <loic.poulain@linaro.org> wrote:

> >

> > Hi Ramon,

> >

> > On Fri, 24 Jul 2020 at 15:47, Ramon Fried <ramon.fried@gmail.com> wrote:

> > >

> > > On Fri, Jul 24, 2020 at 1:15 PM Loic Poulain <loic.poulain@linaro.org> wrote:

> > > >

> > > > This series contains various fixes for the wcn36xx driver.

> > > > This has been tested with wcn3620, wcn3660 and wcn3680.

> > > >

> > > > v2: - Move TX retries change into its own commit

> > > >     - Additional patch for sequence number assignment

> > > >     - Reword TX ack commit log (timeout detection)

> > > >     - Fix checkpatch issues reported by Bryan

> > > >

> > > > Loic Poulain (6):

> > > >   wcn36xx: Fix multiple AMPDU sessions support

> > > >   wcn36xx: Add TX ack support

> > > >   wcn36xx: Increase number of TX retries

> > > >   wcn36xx: Fix TX data path

> > > >   wcn36xx: Fix software-driven scan

> > > >   wcn36xx: Use sequence number allocated by mac80211

> > > >

> > > >  drivers/net/wireless/ath/wcn36xx/dxe.c     |  57 +++++++++-

> > > >  drivers/net/wireless/ath/wcn36xx/main.c    | 172 +++++++++++++++--------------

> > > >  drivers/net/wireless/ath/wcn36xx/smd.c     |  59 ++++++++--

> > > >  drivers/net/wireless/ath/wcn36xx/smd.h     |  12 +-

> > > >  drivers/net/wireless/ath/wcn36xx/txrx.c    |  57 ++++++----

> > > >  drivers/net/wireless/ath/wcn36xx/wcn36xx.h |   7 +-

> > > >  6 files changed, 241 insertions(+), 123 deletions(-)

> > > >

> > > > --

> > > > 2.7.4

> > > >

> > > >

> > > > _______________________________________________

> > > > wcn36xx mailing list

> > > > wcn36xx@lists.infradead.org

> > > > http://lists.infradead.org/mailman/listinfo/wcn36xx

> > >

> > >

> > > Hi Loic,

> > > What about upstreaming the fixes for several TP-Link AP's ?

> > > The WCN36xx is not usable on those networks and your own tree patches seems to

> > > be working properly.

> >

> > Which ones do you have in mind?

> I didn't inspect each patch, I just took your tree and everything now

> works as expected on  my TP-Link setup.

> I did notice this patch -   "wcn36xx: Fix power-saving with some APs"

> that was missing.

> And there are some patches in your tree that hack the mac802111 core,

> Do you think there's a way to upstream those ?


Indeed I've additional fixes in my tree, but they are either not
strictly required or I need more time for proper testing.


Loic