| Message ID | 1600091917-7464-1-git-send-email-skakit@codeaurora.org |
|---|---|
| Headers | show |
| Series | Add wakeup support over UART RX | expand |
On Mon, Sep 14, 2020 at 07:28:35PM +0530, satya priya wrote: > Add the necessary pinctrl, interrupt property and a suitable sleep config > to support Bluetooth wakeup feature. > > GPIO mode is configured in sleep state to drive the RTS/RFR line low. > If QUP function is selected in sleep state, UART RTS/RFR is pulled high > during suspend and BT SoC not able to send wakeup bytes. > > Signed-off-by: satya priya <skakit@codeaurora.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
On Mon, Sep 14, 2020 at 07:28:36PM +0530, satya priya wrote: > Add the necessary pinctrl, interrupt property and a suitable sleep config > to support Bluetooth wakeup feature. > > GPIO mode is configured in sleep state to drive the RTS/RFR line low. > If QUP function is selected in sleep state, UART RTS/RFR is pulled high > during suspend and BT SoC not able to send wakeup bytes. > > Signed-off-by: satya priya <skakit@codeaurora.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org> Tested-by: Matthias Kaehlcke <mka@chromium.org>
Hi, On Mon, Sep 14, 2020 at 6:59 AM satya priya <skakit@codeaurora.org> wrote: > > Add the necessary pinctrl, interrupt property and a suitable sleep config > to support Bluetooth wakeup feature. > > GPIO mode is configured in sleep state to drive the RTS/RFR line low. > If QUP function is selected in sleep state, UART RTS/RFR is pulled high > during suspend and BT SoC not able to send wakeup bytes. > > Signed-off-by: satya priya <skakit@codeaurora.org> > --- > Changes in V2: > - This patch adds sleep state for BT UART. Newly added in V2. > > Changes in V3: > - Remove "output-high" for TX from both sleep and default states > as it is not required. Configure pull-up for TX in sleep state. > > Changes in V4: > - As per Matthias's comment, removed drive-strength for sleep state > and fixed nit-pick. > > Changes in V5: > - As per Matthias's comments, moved pinmux change for sleep state, > pinctrl and interrupt config to the board specific file. > > Changes in V6: > - As per Doug's comments changed subject, deleted interrupts property. > - As per Bjorn's comments changed commit text and rationale for RTS, > TX and RX. > > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 55 +++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) Reviewed-by: Douglas Anderson <dianders@chromium.org>
Hi, On Mon, Sep 14, 2020 at 6:59 AM satya priya <skakit@codeaurora.org> wrote: > > Add the necessary pinctrl, interrupt property and a suitable sleep config > to support Bluetooth wakeup feature. > > GPIO mode is configured in sleep state to drive the RTS/RFR line low. > If QUP function is selected in sleep state, UART RTS/RFR is pulled high > during suspend and BT SoC not able to send wakeup bytes. > > Signed-off-by: satya priya <skakit@codeaurora.org> > --- > Changes in V5: > - Newly added in V5. This patch adds wakeup support for trogdor board files. > > Changes in V6: > - As per Doug's comment deleted interrupts property and sorted the qup sleep > state before trackpad. > - As per Bjorn's comment canged the commit text, rationale for RTS, TX, RX. > > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 54 ++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Mon 14 Sep 13:58 UTC 2020, satya priya wrote: > Changes in V2: > - As per Matthias's comment added wakeup support for all the UARTs > of SC7180. > - Added sleep state in sc7180-idp.dts file. > - Modify the if check in set_mctrl API in serial driver to avoid > making RFR high during suspend. > > Changes in V3: > - As per Matthias's comments modify the idp dts pin config to keep > only the required pin settings. > - Remove the extra parentheses from serial driver patch. > > Changes in V4: > - As per Matthias's comments, change the commit text to mention why > GPIO function needs to be selected in sleep. > - Add separate patch for improvements made in pin conf settings. > > Changes in V5: > - Moved pinctrl and interrupt configuration to board specific files. > - Added new patch for trogdor board specific changes. > > Changes in V6: > - As per Doug's comments, fixed nits in patch 2 and 3. > - As per Bjorn's comments changed the commit text and rationale for > rts, tx and rx in patch 2 and 3. > > satya priya (4): > arm64: dts: qcom: sc7180: Improve the uart3 pin config for sc7180-idp > arm64: dts: qcom: sc7180: Add wakeup support for BT UART on sc7180-idp > arm64: dts: qcom: sc7180-trogdor: Add wakeup support for BT UART Applied these... > tty: serial: qcom_geni_serial: Fix the UART wakeup issue ...expecting Greg to pick this one up. Thanks, Bjorn > > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 65 +++++++++++++++++++++++++--- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 54 +++++++++++++++++++++++ > drivers/tty/serial/qcom_geni_serial.c | 2 +- > 3 files changed, 114 insertions(+), 7 deletions(-) > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >