| Message ID | 20200929220604.833631-1-andriin@fb.com |
|---|---|
| State | New |
| Headers | show |
| Series | [bpf-next,1/3] libbpf: fix uninitialized variable in btf_parse_type_sec | expand |
On Tue, Sep 29, 2020 at 03:06:02PM -0700, Andrii Nakryiko wrote: > Fix obvious unitialized variable use that wasn't reported by compiler. libbpf > Makefile changes to catch such errors are added separately. Acked-by: Martin KaFai Lau <kafai@fb.com>
On Tue, Sep 29, 2020 at 03:06:03PM -0700, Andrii Nakryiko wrote: > For some reason compiler doesn't complain about uninitialized variable, fixed > in previous patch, if libbpf is compiled without -O2 optimization level. So do > compile it with -O2 and never let similar issue slip by again. -Wall is added > unconditionally, so no need to specify it again. Acked-by: Martin KaFai Lau <kafai@fb.com>
diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c index e1dbd766c698..398b1f345b3c 100644 --- a/tools/lib/bpf/btf.c +++ b/tools/lib/bpf/btf.c @@ -347,7 +347,7 @@ static int btf_parse_type_sec(struct btf *btf) struct btf_header *hdr = btf->hdr; void *next_type = btf->types_data; void *end_type = next_type + hdr->type_len; - int err, i, type_size; + int err, i = 0, type_size; /* VOID (type_id == 0) is specially handled by btf__get_type_by_id(), * so ensure we can never properly use its offset from index by
Fix obvious unitialized variable use that wasn't reported by compiler. libbpf Makefile changes to catch such errors are added separately. Fixes: 3289959b97ca ("libbpf: Support BTF loading and raw data output in both endianness") Signed-off-by: Andrii Nakryiko <andriin@fb.com> --- tools/lib/bpf/btf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)