mbox series

[v4,0/3] i2c: imx: Fix handling of arbitration loss

Message ID 20201006160814.22047-1-ceggers@arri.de
Headers show
Series i2c: imx: Fix handling of arbitration loss | expand

Message

Christian Eggers Oct. 6, 2020, 4:08 p.m. UTC 
Changes in v3:
---------------
- dedicated function for clearing an irq

Changes in v4:
---------------
- Extend comment (W1C vs. W0C)

Comments

Uwe Kleine-König Oct. 6, 2020, 6:46 p.m. UTC | #1 
On Tue, Oct 06, 2020 at 06:08:12PM +0200, Christian Eggers wrote:
> According to the "VFxxx Controller Reference Manual" (and the comment
> block starting at line 97), Vybrid requires writing a one for clearing
> an interrupt flag. Syncing the method for clearing I2SR_IIF in
> i2c_imx_isr().
> 
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> Cc: stable@vger.kernel.org

Fixes: 4b775022f6fd ("i2c: imx: add struct to hold more configurable quirks")
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards and thanks
Uwe
Krzysztof Kozlowski Oct. 7, 2020, 7:50 a.m. UTC | #2 
On Tue, 6 Oct 2020 at 18:10, Christian Eggers <ceggers@arri.de> wrote:
>
> According to the "VFxxx Controller Reference Manual" (and the comment
> block starting at line 97), Vybrid requires writing a one for clearing
> an interrupt flag. Syncing the method for clearing I2SR_IIF in
> i2c_imx_isr().
>
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> Cc: stable@vger.kernel.org
> ---
>  drivers/i2c/busses/i2c-imx.c | 20 +++++++++++++++-----
>  1 file changed, 15 insertions(+), 5 deletions(-)

I replied to your v2 with testing, so what happened with all my tested tags?

Best regards,
Krzysztof
Christian Eggers Oct. 7, 2020, 8:17 a.m. UTC | #3 
On Wednesday, 7 October 2020, 09:50:23 CEST, Krzysztof Kozlowski wrote:
> I replied to your v2 with testing, so what happened with all my tested tags?

I am quite new to the kernel development process. Seems that I should 
integrate all "Tested-by" tags into following version of my patches.

In which cases shall the tested tags be kept and in which cases they become 
invalid?

Best regards
Christian