diff mbox series

mpt3sas: a small correction in _base_process_reply_queue

Message ID 20200911180057.14633-1-thenzl@redhat.com
State New
Headers show
Series mpt3sas: a small correction in _base_process_reply_queue | expand

Commit Message

Tomas Henzl Sept. 11, 2020, 6 p.m. UTC
There is no need to compute module a simple comparision
is good enough.

Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
 drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen Sept. 15, 2020, 10:38 p.m. UTC | #1
Tomas,

> There is no need to compute module a simple comparision is good
> enough.

Applied to 5.10/scsi-staging, thanks!
Martin K. Petersen Sept. 22, 2020, 3:56 a.m. UTC | #2
On Fri, 11 Sep 2020 20:00:57 +0200, Tomas Henzl wrote:

> There is no need to compute module a simple comparision

> is good enough.


Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: mpt3sas: A small correction in _base_process_reply_queue
      https://git.kernel.org/mkp/scsi/c/3d49f7426e6c

-- 
Martin K. Petersen	Oracle Linux Engineering
diff mbox series

Patch

diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index a67749c8f4ab..ea51fd04e3f1 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -1627,7 +1627,7 @@  _base_process_reply_queue(struct adapter_reply_queue *reply_q)
 		 * So that FW can find enough entries to post the Reply
 		 * Descriptors in the reply descriptor post queue.
 		 */
-		if (!base_mod64(completed_cmds, ioc->thresh_hold)) {
+		if (completed_cmds >= ioc->thresh_hold) {
 			if (ioc->combined_reply_queue) {
 				writel(reply_q->reply_post_host_index |
 						((msix_index  & 7) <<