mbox series

[0/5] qspi binding and DTS fixes

Message ID 20200827181842.1000451-1-f.fainelli@gmail.com
Headers show
Series qspi binding and DTS fixes | expand

Message

Florian Fainelli Aug. 27, 2020, 6:18 p.m. UTC
Hi all,

This patch series fixes incorrectly defined compatible strings for the
Broadcom QSPI controller which resulted in the strings not being
ordered from most to least compatible.

We will need to apply some changes to the spi-bcm-qspi.c driver in
the future to assume no revision register exist, and these patches
are a preliminary step towards that goal.

Florian Fainelli (5):
  dt-bindings: spi: Fix spi-bcm-qspi compatible ordering
  ARM: dts: bcm: HR2: Fixed QSPI compatible string
  ARM: dts: NSP: Fixed QSPI compatible string
  ARM: dts: BCM5301X: Fixed QSPI compatible string
  arm64: dts: ns2: Fixed QSPI compatible string

 .../bindings/spi/brcm,spi-bcm-qspi.txt           | 16 ++++++++--------
 arch/arm/boot/dts/bcm-hr2.dtsi                   |  2 +-
 arch/arm/boot/dts/bcm-nsp.dtsi                   |  2 +-
 arch/arm/boot/dts/bcm5301x.dtsi                  |  2 +-
 arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi |  2 +-
 5 files changed, 12 insertions(+), 12 deletions(-)

Comments

Florian Fainelli Aug. 31, 2020, 6:37 p.m. UTC | #1
On 8/27/2020 11:18 AM, Florian Fainelli wrote:
> Hi all,
> 
> This patch series fixes incorrectly defined compatible strings for the
> Broadcom QSPI controller which resulted in the strings not being
> ordered from most to least compatible.
> 
> We will need to apply some changes to the spi-bcm-qspi.c driver in
> the future to assume no revision register exist, and these patches
> are a preliminary step towards that goal.

Rob, can I get your tag for this patch series so it can be sent out? Thanks!

> 
> Florian Fainelli (5):
>    dt-bindings: spi: Fix spi-bcm-qspi compatible ordering
>    ARM: dts: bcm: HR2: Fixed QSPI compatible string
>    ARM: dts: NSP: Fixed QSPI compatible string
>    ARM: dts: BCM5301X: Fixed QSPI compatible string
>    arm64: dts: ns2: Fixed QSPI compatible string
> 
>   .../bindings/spi/brcm,spi-bcm-qspi.txt           | 16 ++++++++--------
>   arch/arm/boot/dts/bcm-hr2.dtsi                   |  2 +-
>   arch/arm/boot/dts/bcm-nsp.dtsi                   |  2 +-
>   arch/arm/boot/dts/bcm5301x.dtsi                  |  2 +-
>   arch/arm64/boot/dts/broadcom/northstar2/ns2.dtsi |  2 +-
>   5 files changed, 12 insertions(+), 12 deletions(-)
>
Rob Herring (Arm) Sept. 9, 2020, 8:41 p.m. UTC | #2
On Thu, 27 Aug 2020 11:18:38 -0700, Florian Fainelli wrote:
> The binding is currently incorrectly defining the compatible strings
> from least specific to most specific instead of the converse. Re-order
> them from most specific (left) to least specific (right) and fix the
> examples as well.
> 
> Fixes: 5fc78f4c842a ("spi: Broadcom BRCMSTB, NSP, NS2 SoC bindings")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  .../bindings/spi/brcm,spi-bcm-qspi.txt           | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Florian Fainelli Sept. 9, 2020, 9:14 p.m. UTC | #3
On 8/27/2020 11:18 AM, Florian Fainelli wrote:
> Hi all,
> 
> This patch series fixes incorrectly defined compatible strings for the
> Broadcom QSPI controller which resulted in the strings not being
> ordered from most to least compatible.
> 
> We will need to apply some changes to the spi-bcm-qspi.c driver in
> the future to assume no revision register exist, and these patches
> are a preliminary step towards that goal.

Series applied to devicetree/fixes, sending the PR shortly.