| Message ID | 20200913195348.1064154-1-philmd@redhat.com |
|---|---|
| Headers | show |
| Series | user-mode: Prune build dependencies (part 2) | expand |
Philippe Mathieu-Daudé <philmd@redhat.com> writes: > Acked-by: Markus Armbruster <armbru@redhat.com> > Acked-by: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Unlike the other patches that move code out of misc.json, this one doesn't say "allows pulling less declarations/definitions to user-mode." Intentional?
+Laurent and David On 9/14/20 11:16 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé <philmd@redhat.com> writes: > >> Only qemu-system-FOO and qemu-storage-daemon provide QMP >> monitors, therefore such declarations and definitions are >> irrelevant for user-mode emulation. >> >> Restricting the balloon-related commands to machine.json >> allows pulling less declarations/definitions to user-mode. > > How this affects user mode is not obvious to (ignorant) me. Can you > provide a clue? I guess this was discussed with David at some point. Maybe the QMP commands are not exposed via HMP, making this code unreachable? Anyhow user-mode binaries don't use the memory ballooning feature, this is specific to system-mode emulation. Laurent/David, do you have some more trivial explanation? Thanks, Phil.
Philippe Mathieu-Daudé <philmd@redhat.com> writes: > +Laurent + qemu-block@ > > On 9/14/20 11:14 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé <philmd@redhat.com> writes: >> >>> Acked-by: Markus Armbruster <armbru@redhat.com> >>> Acked-by: Paolo Bonzini <pbonzini@redhat.com> >>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> >> Unlike the other patches that move code out of misc.json, this one >> doesn't say "allows pulling less declarations/definitions to user-mode." >> Intentional? > > TBH I don't remember as this is 6months old. > > IIUC the "tick lost" feature is only meaningful when running > virtualized with a RTC profile, so this is pointless for > user-mode binaries and tools. Your reply to my question on PATCH 3 "What exactly is being pulled where before the series, and no more afterwards?" leads me to believe this patch is no different. Suggest to add the same rationale to this commit message.
Philippe Mathieu-Daudé <philmd@redhat.com> writes: > This is the second part of a series reducing user-mode > dependencies. By stripping out unused code, the build > and testing time is reduced (as is space used by objects). > > Series is fully Acked. One more: Acked-by: Markus Armbruster <armbru@redhat.com> I suggested commit message tweaks. Happy to do them in my tree, if you agree.
On 9/15/20 8:29 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé <philmd@redhat.com> writes: > >> This is the second part of a series reducing user-mode >> dependencies. By stripping out unused code, the build >> and testing time is reduced (as is space used by objects). >> >> Series is fully Acked. > > One more: > Acked-by: Markus Armbruster <armbru@redhat.com> > > I suggested commit message tweaks. Happy to do them in my tree, if you > agree. Sure, no problem! Thanks :) Phil.
Philippe Mathieu-Daudé <philmd@redhat.com> writes: > This is the second part of a series reducing user-mode > dependencies. By stripping out unused code, the build > and testing time is reduced (as is space used by objects). > > Series is fully Acked. Queued, thanks!