| Message ID | 20200918084111.15339-1-ani@anisinha.ca |
|---|---|
| Headers | show |
| Series | i440fx/acpi: addition of feature and bug fixes. | expand |
On 9/18/20 10:40 AM, Ani Sinha wrote: > Final patch series with all the patches reviewed or ack'd and marked as such. > Thanks Julia and Igor for the reviews. Hope this series gets pulled in soon. FYI there is no need to collect tags on the final version. Tools already do that for you, see: https://patchew.org/QEMU/20200918072325.9933-1-ani@anisinha.ca/ The maintainer can import the patches with the proper Message-Id / Reviewed-by / Acked-by / Tested-by tags added using: https://patchew.org/QEMU/20200918072325.9933-1-ani@anisinha.ca/mbox Regards, Phil.
On Fri, Sep 18, 2020 at 3:26 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > On 9/18/20 10:40 AM, Ani Sinha wrote: > > Final patch series with all the patches reviewed or ack'd and marked as such. > > Thanks Julia and Igor for the reviews. Hope this series gets pulled in soon. > > FYI there is no need to collect tags on the final version. > Tools already do that for you, see: > https://patchew.org/QEMU/20200918072325.9933-1-ani@anisinha.ca/ > > The maintainer can import the patches with the proper Message-Id / > Reviewed-by / Acked-by / Tested-by tags added using: > https://patchew.org/QEMU/20200918072325.9933-1-ani@anisinha.ca/mbox Interesting! > > Regards, > > Phil. >
On Fri, Sep 18, 2020 at 11:55:54AM +0200, Philippe Mathieu-Daudé wrote: > On 9/18/20 10:40 AM, Ani Sinha wrote: > > Final patch series with all the patches reviewed or ack'd and marked as such. > > Thanks Julia and Igor for the reviews. Hope this series gets pulled in soon. > > FYI there is no need to collect tags on the final version. Right but if a new version is posted then yes you want to include tags. > Tools already do that for you, see: > https://patchew.org/QEMU/20200918072325.9933-1-ani@anisinha.ca/ > > The maintainer can import the patches with the proper Message-Id / > Reviewed-by / Acked-by / Tested-by tags added using: > https://patchew.org/QEMU/20200918072325.9933-1-ani@anisinha.ca/mbox > > Regards, > > Phil.
On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote: > > This change adds a new DSDT golden master table blob to test disabling > > hotplug on both pci root bus and pci bridges. Also reverts the change > > in file bios-tables-test-allowed-diff.h to make sure its now empty so that > > future modifications to acpi tables can be caught. > > > > The following is the disassembled diff between DSDT.hpbridge and DSDT.hpbrroot: > > > > @@ -1,30 +1,30 @@ > > /* > > * Intel ACPI Component Architecture > > * AML/ASL+ Disassembler version 20180105 (64-bit version) > > * Copyright (c) 2000 - 2018 Intel Corporation > > * > > * Disassembling to symbolic ASL+ operators > > * > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Wed Sep 16 09:45:56 2020 > > + * Disassembly of /tmp/aml-ECV9Q0, Wed Sep 16 09:45:56 2020 > > * > > * Original Table Header: > > * Signature "DSDT" > > - * Length 0x0000131F (4895) > > + * Length 0x00000B89 (2953) > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > - * Checksum 0xF9 > > + * Checksum 0xA2 > > * OEM ID "BOCHS " > > * OEM Table ID "BXPCDSDT" > > * OEM Revision 0x00000001 (1) > > * Compiler ID "BXPC" > > * Compiler Version 0x00000001 (1) > > */ > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) > > { > > Scope (\) > > { > > OperationRegion (DBG, SystemIO, 0x0402, One) > > Field (DBG, ByteAcc, NoLock, Preserve) > > { > > DBGB, 8 > > } > > > > @@ -234,64 +234,32 @@ > > { > > Name (_HID, EisaId ("PNP0B00") /* AT Real-Time Clock */) // _HID: Hardware ID > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > { > > IO (Decode16, > > 0x0070, // Range Minimum > > 0x0070, // Range Maximum > > 0x01, // Alignment > > 0x08, // Length > > ) > > IRQNoFlags () > > {8} > > }) > > } > > } > > > > - Scope (_SB.PCI0) > > - { > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > - { > > - PCIU, 32, > > - PCID, 32 > > - } > > - > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > - { > > - B0EJ, 32 > > - } > > - > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > - { > > - BNUM, 32 > > - } > > - > > - Mutex (BLCK, 0x00) > > - Method (PCEJ, 2, NotSerialized) > > - { > > - Acquire (BLCK, 0xFFFF) > > - BNUM = Arg0 > > - B0EJ = (One << Arg1) > > - Release (BLCK) > > - Return (Zero) > > - } > > - } > > - > > Scope (_SB) > > { > > Scope (PCI0) > > { > > Method (_PRT, 0, NotSerialized) // _PRT: PCI Routing Table > > { > > Local0 = Package (0x80){} > > Local1 = Zero > > While ((Local1 < 0x80)) > > { > > Local2 = (Local1 >> 0x02) > > Local3 = ((Local1 + Local2) & 0x03) > > If ((Local3 == Zero)) > > { > > Local4 = Package (0x04) > > { > > @@ -690,38 +658,32 @@ > > Method (_OST, 3, Serialized) // _OST: OSPM Status Indication > > { > > COST (Zero, Arg0, Arg1, Arg2) > > } > > } > > } > > } > > > > Method (\_GPE._E02, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > { > > \_SB.CPUS.CSCN () > > } > > > > Scope (_GPE) > > { > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > - { > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > - \_SB.PCI0.PCNT () > > - Release (\_SB.PCI0.BLCK) > > - } > > } > > > > Scope (\_SB.PCI0) > > { > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > { > > WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode, > > 0x0000, // Granularity > > 0x0000, // Range Minimum > > 0x00FF, // Range Maximum > > 0x0000, // Translation Offset > > 0x0100, // Length > > ,, ) > > IO (Decode16, > > 0x0CF8, // Range Minimum > > 0x0CF8, // Range Maximum > > @@ -766,48 +728,32 @@ > > }) > > Device (GPE0) > > { > > Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > Name (_UID, "GPE0 resources") // _UID: Unique ID > > Name (_STA, 0x0B) // _STA: Status > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > { > > IO (Decode16, > > 0xAFE0, // Range Minimum > > 0xAFE0, // Range Maximum > > 0x01, // Alignment > > 0x04, // Length > > ) > > }) > > } > > - > > - Device (PHPR) > > - { > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > - Name (_STA, 0x0B) // _STA: Status > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > - { > > - IO (Decode16, > > - 0xAE00, // Range Minimum > > - 0xAE00, // Range Maximum > > - 0x01, // Alignment > > - 0x14, // Length > > - ) > > - }) > > - } > > } > > > > Scope (\) > > { > > Name (_S3, Package (0x04) // _S3_: S3 System State > > { > > One, > > One, > > Zero, > > Zero > > }) > > Name (_S4, Package (0x04) // _S4_: S4 System State > > { > > 0x02, > > 0x02, > > Zero, > > @@ -831,479 +777,48 @@ > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > { > > IO (Decode16, > > 0x0510, // Range Minimum > > 0x0510, // Range Maximum > > 0x01, // Alignment > > 0x0C, // Length > > ) > > }) > > } > > } > > > > Scope (\_SB) > > { > > Scope (PCI0) > > { > > - Name (BSEL, Zero) > > Device (S00) > > { > > Name (_ADR, Zero) // _ADR: Address > > } > > > > Device (S10) > > { > > Name (_ADR, 0x00020000) // _ADR: Address > > Method (_S1D, 0, NotSerialized) // _S1D: S1 Device State > > { > > Return (Zero) > > } > > > > Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State > > { > > Return (Zero) > > } > > > > Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State > > { > > Return (Zero) > > } > > } > > > > Device (S18) > > { > > Name (_ADR, 0x00030000) // _ADR: Address > > } > > - > > - Device (S20) > > - { > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > - Name (_ADR, 0x00040000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S28) > > - { > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > - Name (_ADR, 0x00050000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S30) > > - { > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > - Name (_ADR, 0x00060000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S38) > > - { > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > - Name (_ADR, 0x00070000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S40) > > - { > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > - Name (_ADR, 0x00080000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S48) > > - { > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > - Name (_ADR, 0x00090000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S50) > > - { > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > - Name (_ADR, 0x000A0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S58) > > - { > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > - Name (_ADR, 0x000B0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S60) > > - { > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > - Name (_ADR, 0x000C0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S68) > > - { > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > - Name (_ADR, 0x000D0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S70) > > - { > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > - Name (_ADR, 0x000E0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S78) > > - { > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > - Name (_ADR, 0x000F0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S80) > > - { > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > - Name (_ADR, 0x00100000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S88) > > - { > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > - Name (_ADR, 0x00110000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S90) > > - { > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > - Name (_ADR, 0x00120000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S98) > > - { > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > - Name (_ADR, 0x00130000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SA0) > > - { > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > - Name (_ADR, 0x00140000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SA8) > > - { > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > - Name (_ADR, 0x00150000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SB0) > > - { > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > - Name (_ADR, 0x00160000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SB8) > > - { > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > - Name (_ADR, 0x00170000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SC0) > > - { > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > - Name (_ADR, 0x00180000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SC8) > > - { > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > - Name (_ADR, 0x00190000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SD0) > > - { > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > - Name (_ADR, 0x001A0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SD8) > > - { > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > - Name (_ADR, 0x001B0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SE0) > > - { > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > - Name (_ADR, 0x001C0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SE8) > > - { > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > - Name (_ADR, 0x001D0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SF0) > > - { > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > - Name (_ADR, 0x001E0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SF8) > > - { > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > - Name (_ADR, 0x001F0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Method (DVNT, 2, NotSerialized) > > - { > > - If ((Arg0 & 0x10)) > > - { > > - Notify (S20, Arg1) > > - } > > - > > - If ((Arg0 & 0x20)) > > - { > > - Notify (S28, Arg1) > > - } > > - > > - If ((Arg0 & 0x40)) > > - { > > - Notify (S30, Arg1) > > - } > > - > > - If ((Arg0 & 0x80)) > > - { > > - Notify (S38, Arg1) > > - } > > - > > - If ((Arg0 & 0x0100)) > > - { > > - Notify (S40, Arg1) > > - } > > - > > - If ((Arg0 & 0x0200)) > > - { > > - Notify (S48, Arg1) > > - } > > - > > - If ((Arg0 & 0x0400)) > > - { > > - Notify (S50, Arg1) > > - } > > - > > - If ((Arg0 & 0x0800)) > > - { > > - Notify (S58, Arg1) > > - } > > - > > - If ((Arg0 & 0x1000)) > > - { > > - Notify (S60, Arg1) > > - } > > - > > - If ((Arg0 & 0x2000)) > > - { > > - Notify (S68, Arg1) > > - } > > - > > - If ((Arg0 & 0x4000)) > > - { > > - Notify (S70, Arg1) > > - } > > - > > - If ((Arg0 & 0x8000)) > > - { > > - Notify (S78, Arg1) > > - } > > - > > - If ((Arg0 & 0x00010000)) > > - { > > - Notify (S80, Arg1) > > - } > > - > > - If ((Arg0 & 0x00020000)) > > - { > > - Notify (S88, Arg1) > > - } > > - > > - If ((Arg0 & 0x00040000)) > > - { > > - Notify (S90, Arg1) > > - } > > - > > - If ((Arg0 & 0x00080000)) > > - { > > - Notify (S98, Arg1) > > - } > > - > > - If ((Arg0 & 0x00100000)) > > - { > > - Notify (SA0, Arg1) > > - } > > - > > - If ((Arg0 & 0x00200000)) > > - { > > - Notify (SA8, Arg1) > > - } > > - > > - If ((Arg0 & 0x00400000)) > > - { > > - Notify (SB0, Arg1) > > - } > > - > > - If ((Arg0 & 0x00800000)) > > - { > > - Notify (SB8, Arg1) > > - } > > - > > - If ((Arg0 & 0x01000000)) > > - { > > - Notify (SC0, Arg1) > > - } > > - > > - If ((Arg0 & 0x02000000)) > > - { > > - Notify (SC8, Arg1) > > - } > > - > > - If ((Arg0 & 0x04000000)) > > - { > > - Notify (SD0, Arg1) > > - } > > - > > - If ((Arg0 & 0x08000000)) > > - { > > - Notify (SD8, Arg1) > > - } > > - > > - If ((Arg0 & 0x10000000)) > > - { > > - Notify (SE0, Arg1) > > - } > > - > > - If ((Arg0 & 0x20000000)) > > - { > > - Notify (SE8, Arg1) > > - } > > - > > - If ((Arg0 & 0x40000000)) > > - { > > - Notify (SF0, Arg1) > > - } > > - > > - If ((Arg0 & 0x80000000)) > > - { > > - Notify (SF8, Arg1) > > - } > > - } > > - > > - Method (PCNT, 0, NotSerialized) > > - { > > - BNUM = Zero > > - DVNT (PCIU, One) > > - DVNT (PCID, 0x03) > > - } > > } > > } > > } > > This is not the only diff I see if I apply this patchset on > top of master. > Dropped this and the previous patch. > Please check what is going on and repost as appropriate. Which two ACPI DSDT files are you diffing? What diff are you getting? > > > > > Signed-off-by: Ani Sinha <ani@anisinha.ca> > > Acked-by: Igor Mammedov <imammedo@redhat.com> > > --- >
On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote: > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote: > > > This change adds a new DSDT golden master table blob to test disabling > > > hotplug on both pci root bus and pci bridges. Also reverts the change > > > in file bios-tables-test-allowed-diff.h to make sure its now empty so that > > > future modifications to acpi tables can be caught. > > > > > > The following is the disassembled diff between DSDT.hpbridge and DSDT.hpbrroot: > > > > > > @@ -1,30 +1,30 @@ > > > /* > > > * Intel ACPI Component Architecture > > > * AML/ASL+ Disassembler version 20180105 (64-bit version) > > > * Copyright (c) 2000 - 2018 Intel Corporation > > > * > > > * Disassembling to symbolic ASL+ operators > > > * > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Wed Sep 16 09:45:56 2020 > > > + * Disassembly of /tmp/aml-ECV9Q0, Wed Sep 16 09:45:56 2020 > > > * > > > * Original Table Header: > > > * Signature "DSDT" > > > - * Length 0x0000131F (4895) > > > + * Length 0x00000B89 (2953) > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > - * Checksum 0xF9 > > > + * Checksum 0xA2 > > > * OEM ID "BOCHS " > > > * OEM Table ID "BXPCDSDT" > > > * OEM Revision 0x00000001 (1) > > > * Compiler ID "BXPC" > > > * Compiler Version 0x00000001 (1) > > > */ > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) > > > { > > > Scope (\) > > > { > > > OperationRegion (DBG, SystemIO, 0x0402, One) > > > Field (DBG, ByteAcc, NoLock, Preserve) > > > { > > > DBGB, 8 > > > } > > > > > > @@ -234,64 +234,32 @@ > > > { > > > Name (_HID, EisaId ("PNP0B00") /* AT Real-Time Clock */) // _HID: Hardware ID > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > { > > > IO (Decode16, > > > 0x0070, // Range Minimum > > > 0x0070, // Range Maximum > > > 0x01, // Alignment > > > 0x08, // Length > > > ) > > > IRQNoFlags () > > > {8} > > > }) > > > } > > > } > > > > > > - Scope (_SB.PCI0) > > > - { > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > > - { > > > - PCIU, 32, > > > - PCID, 32 > > > - } > > > - > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > > - { > > > - B0EJ, 32 > > > - } > > > - > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > > - { > > > - BNUM, 32 > > > - } > > > - > > > - Mutex (BLCK, 0x00) > > > - Method (PCEJ, 2, NotSerialized) > > > - { > > > - Acquire (BLCK, 0xFFFF) > > > - BNUM = Arg0 > > > - B0EJ = (One << Arg1) > > > - Release (BLCK) > > > - Return (Zero) > > > - } > > > - } > > > - > > > Scope (_SB) > > > { > > > Scope (PCI0) > > > { > > > Method (_PRT, 0, NotSerialized) // _PRT: PCI Routing Table > > > { > > > Local0 = Package (0x80){} > > > Local1 = Zero > > > While ((Local1 < 0x80)) > > > { > > > Local2 = (Local1 >> 0x02) > > > Local3 = ((Local1 + Local2) & 0x03) > > > If ((Local3 == Zero)) > > > { > > > Local4 = Package (0x04) > > > { > > > @@ -690,38 +658,32 @@ > > > Method (_OST, 3, Serialized) // _OST: OSPM Status Indication > > > { > > > COST (Zero, Arg0, Arg1, Arg2) > > > } > > > } > > > } > > > } > > > > > > Method (\_GPE._E02, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > > { > > > \_SB.CPUS.CSCN () > > > } > > > > > > Scope (_GPE) > > > { > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > > - { > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > > - \_SB.PCI0.PCNT () > > > - Release (\_SB.PCI0.BLCK) > > > - } > > > } > > > > > > Scope (\_SB.PCI0) > > > { > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > { > > > WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode, > > > 0x0000, // Granularity > > > 0x0000, // Range Minimum > > > 0x00FF, // Range Maximum > > > 0x0000, // Translation Offset > > > 0x0100, // Length > > > ,, ) > > > IO (Decode16, > > > 0x0CF8, // Range Minimum > > > 0x0CF8, // Range Maximum > > > @@ -766,48 +728,32 @@ > > > }) > > > Device (GPE0) > > > { > > > Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > > Name (_UID, "GPE0 resources") // _UID: Unique ID > > > Name (_STA, 0x0B) // _STA: Status > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > { > > > IO (Decode16, > > > 0xAFE0, // Range Minimum > > > 0xAFE0, // Range Maximum > > > 0x01, // Alignment > > > 0x04, // Length > > > ) > > > }) > > > } > > > - > > > - Device (PHPR) > > > - { > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > > - Name (_STA, 0x0B) // _STA: Status > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > - { > > > - IO (Decode16, > > > - 0xAE00, // Range Minimum > > > - 0xAE00, // Range Maximum > > > - 0x01, // Alignment > > > - 0x14, // Length > > > - ) > > > - }) > > > - } > > > } > > > > > > Scope (\) > > > { > > > Name (_S3, Package (0x04) // _S3_: S3 System State > > > { > > > One, > > > One, > > > Zero, > > > Zero > > > }) > > > Name (_S4, Package (0x04) // _S4_: S4 System State > > > { > > > 0x02, > > > 0x02, > > > Zero, > > > @@ -831,479 +777,48 @@ > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > { > > > IO (Decode16, > > > 0x0510, // Range Minimum > > > 0x0510, // Range Maximum > > > 0x01, // Alignment > > > 0x0C, // Length > > > ) > > > }) > > > } > > > } > > > > > > Scope (\_SB) > > > { > > > Scope (PCI0) > > > { > > > - Name (BSEL, Zero) > > > Device (S00) > > > { > > > Name (_ADR, Zero) // _ADR: Address > > > } > > > > > > Device (S10) > > > { > > > Name (_ADR, 0x00020000) // _ADR: Address > > > Method (_S1D, 0, NotSerialized) // _S1D: S1 Device State > > > { > > > Return (Zero) > > > } > > > > > > Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State > > > { > > > Return (Zero) > > > } > > > > > > Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State > > > { > > > Return (Zero) > > > } > > > } > > > > > > Device (S18) > > > { > > > Name (_ADR, 0x00030000) // _ADR: Address > > > } > > > - > > > - Device (S20) > > > - { > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > > - Name (_ADR, 0x00040000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S28) > > > - { > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > > - Name (_ADR, 0x00050000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S30) > > > - { > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > > - Name (_ADR, 0x00060000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S38) > > > - { > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > > - Name (_ADR, 0x00070000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S40) > > > - { > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > > - Name (_ADR, 0x00080000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S48) > > > - { > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > > - Name (_ADR, 0x00090000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S50) > > > - { > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S58) > > > - { > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S60) > > > - { > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S68) > > > - { > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S70) > > > - { > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S78) > > > - { > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S80) > > > - { > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > > - Name (_ADR, 0x00100000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S88) > > > - { > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > > - Name (_ADR, 0x00110000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S90) > > > - { > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > > - Name (_ADR, 0x00120000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S98) > > > - { > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > > - Name (_ADR, 0x00130000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SA0) > > > - { > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > > - Name (_ADR, 0x00140000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SA8) > > > - { > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > > - Name (_ADR, 0x00150000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SB0) > > > - { > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > > - Name (_ADR, 0x00160000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SB8) > > > - { > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > > - Name (_ADR, 0x00170000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SC0) > > > - { > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > > - Name (_ADR, 0x00180000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SC8) > > > - { > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > > - Name (_ADR, 0x00190000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SD0) > > > - { > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SD8) > > > - { > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SE0) > > > - { > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SE8) > > > - { > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SF0) > > > - { > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SF8) > > > - { > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Method (DVNT, 2, NotSerialized) > > > - { > > > - If ((Arg0 & 0x10)) > > > - { > > > - Notify (S20, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x20)) > > > - { > > > - Notify (S28, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x40)) > > > - { > > > - Notify (S30, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x80)) > > > - { > > > - Notify (S38, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x0100)) > > > - { > > > - Notify (S40, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x0200)) > > > - { > > > - Notify (S48, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x0400)) > > > - { > > > - Notify (S50, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x0800)) > > > - { > > > - Notify (S58, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x1000)) > > > - { > > > - Notify (S60, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x2000)) > > > - { > > > - Notify (S68, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x4000)) > > > - { > > > - Notify (S70, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x8000)) > > > - { > > > - Notify (S78, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x00010000)) > > > - { > > > - Notify (S80, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x00020000)) > > > - { > > > - Notify (S88, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x00040000)) > > > - { > > > - Notify (S90, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x00080000)) > > > - { > > > - Notify (S98, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x00100000)) > > > - { > > > - Notify (SA0, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x00200000)) > > > - { > > > - Notify (SA8, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x00400000)) > > > - { > > > - Notify (SB0, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x00800000)) > > > - { > > > - Notify (SB8, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x01000000)) > > > - { > > > - Notify (SC0, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x02000000)) > > > - { > > > - Notify (SC8, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x04000000)) > > > - { > > > - Notify (SD0, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x08000000)) > > > - { > > > - Notify (SD8, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x10000000)) > > > - { > > > - Notify (SE0, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x20000000)) > > > - { > > > - Notify (SE8, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x40000000)) > > > - { > > > - Notify (SF0, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x80000000)) > > > - { > > > - Notify (SF8, Arg1) > > > - } > > > - } > > > - > > > - Method (PCNT, 0, NotSerialized) > > > - { > > > - BNUM = Zero > > > - DVNT (PCIU, One) > > > - DVNT (PCID, 0x03) > > > - } > > > } > > > } > > > } > > > > This is not the only diff I see if I apply this patchset on > > top of master. > > Dropped this and the previous patch. > > Please check what is going on and repost as appropriate. > > Which two ACPI DSDT files are you diffing? What diff are you getting? diff -rup ./tests/data/acpi/pc/DSDT.hpbridge.dsl ./tests/data/acpi/pc/DSDT.hpbrroot.dsl --- ./tests/data/acpi/pc/DSDT.hpbridge.dsl 2020-09-29 02:44:43.874622404 -0400 +++ ./tests/data/acpi/pc/DSDT.hpbrroot.dsl 2020-09-29 02:44:43.876622403 -0400 @@ -5,13 +5,13 @@ * * Disassembling to symbolic ASL+ operators * - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 02:44:43 2020 + * Disassembly of tests/data/acpi/pc/DSDT.hpbrroot, Tue Sep 29 02:44:43 2020 * * Original Table Header: * Signature "DSDT" - * Length 0x0000139D (5021) + * Length 0x00000B89 (2953) * Revision 0x01 **** 32-bit table (V1), no 64-bit math support - * Checksum 0x05 + * Checksum 0xA2 * OEM ID "BOCHS " * OEM Table ID "BXPCDSDT" * OEM Revision 0x00000001 (1) @@ -247,38 +247,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " } } - Scope (_SB.PCI0) - { - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) - Field (PCST, DWordAcc, NoLock, WriteAsZeros) - { - PCIU, 32, - PCID, 32 - } - - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) - { - B0EJ, 32 - } - - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) - { - BNUM, 32 - } - - Mutex (BLCK, 0x00) - Method (PCEJ, 2, NotSerialized) - { - Acquire (BLCK, 0xFFFF) - BNUM = Arg0 - B0EJ = (One << Arg1) - Release (BLCK) - Return (Zero) - } - } - Scope (_SB) { Scope (PCI0) @@ -643,56 +611,22 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " Method (CSCN, 0, Serialized) { Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF) - Name (CNEW, Package (0xFF){}) - Local3 = Zero - Local4 = One - While ((Local4 == One)) + Local0 = One + While ((Local0 == One)) { - Local4 = Zero - Local0 = One - Local1 = Zero - While (((Local0 == One) && (Local3 < One))) + Local0 = Zero + \_SB.PCI0.PRES.CCMD = Zero + If ((\_SB.PCI0.PRES.CINS == One)) { - Local0 = Zero - \_SB.PCI0.PRES.CSEL = Local3 - \_SB.PCI0.PRES.CCMD = Zero - If ((\_SB.PCI0.PRES.CDAT < Local3)) - { - Break - } - - If ((Local1 == 0xFF)) - { - Local4 = One - Break - } - - Local3 = \_SB.PCI0.PRES.CDAT - If ((\_SB.PCI0.PRES.CINS == One)) - { - CNEW [Local1] = Local3 - Local1++ - Local0 = One - } - ElseIf ((\_SB.PCI0.PRES.CRMV == One)) - { - CTFY (Local3, 0x03) - \_SB.PCI0.PRES.CRMV = One - Local0 = One - } - - Local3++ + CTFY (\_SB.PCI0.PRES.CDAT, One) + \_SB.PCI0.PRES.CINS = One + Local0 = One } - - Local2 = Zero - While ((Local2 < Local1)) + ElseIf ((\_SB.PCI0.PRES.CRMV == One)) { - Local3 = DerefOf (CNEW [Local2]) - CTFY (Local3, One) - Debug = Local3 - \_SB.PCI0.PRES.CSEL = Local3 - \_SB.PCI0.PRES.CINS = One - Local2++ + CTFY (\_SB.PCI0.PRES.CDAT, 0x03) + \_SB.PCI0.PRES.CRMV = One + Local0 = One } } @@ -737,12 +671,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " Scope (_GPE) { Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE, xx=0x00-0xFF - { - Acquire (\_SB.PCI0.BLCK, 0xFFFF) - \_SB.PCI0.PCNT () - Release (\_SB.PCI0.BLCK) - } } Scope (\_SB.PCI0) @@ -813,22 +741,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " ) }) } - - Device (PHPR) - { - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID - Name (_STA, 0x0B) // _STA: Status - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings - { - IO (Decode16, - 0xAE00, // Range Minimum - 0xAE00, // Range Maximum - 0x01, // Alignment - 0x14, // Length - ) - }) - } } Scope (\) @@ -878,7 +790,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " { Scope (PCI0) { - Name (BSEL, Zero) Device (S00) { Name (_ADR, Zero) // _ADR: Address @@ -907,436 +818,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " { Name (_ADR, 0x00030000) // _ADR: Address } - - Device (S20) - { - Name (_SUN, 0x04) // _SUN: Slot User Number - Name (_ADR, 0x00040000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (S28) - { - Name (_SUN, 0x05) // _SUN: Slot User Number - Name (_ADR, 0x00050000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (S30) - { - Name (_SUN, 0x06) // _SUN: Slot User Number - Name (_ADR, 0x00060000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (S38) - { - Name (_SUN, 0x07) // _SUN: Slot User Number - Name (_ADR, 0x00070000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (S40) - { - Name (_SUN, 0x08) // _SUN: Slot User Number - Name (_ADR, 0x00080000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (S48) - { - Name (_SUN, 0x09) // _SUN: Slot User Number - Name (_ADR, 0x00090000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (S50) - { - Name (_SUN, 0x0A) // _SUN: Slot User Number - Name (_ADR, 0x000A0000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (S58) - { - Name (_SUN, 0x0B) // _SUN: Slot User Number - Name (_ADR, 0x000B0000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (S60) - { - Name (_SUN, 0x0C) // _SUN: Slot User Number - Name (_ADR, 0x000C0000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (S68) - { - Name (_SUN, 0x0D) // _SUN: Slot User Number - Name (_ADR, 0x000D0000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (S70) - { - Name (_SUN, 0x0E) // _SUN: Slot User Number - Name (_ADR, 0x000E0000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (S78) - { - Name (_SUN, 0x0F) // _SUN: Slot User Number - Name (_ADR, 0x000F0000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (S80) - { - Name (_SUN, 0x10) // _SUN: Slot User Number - Name (_ADR, 0x00100000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (S88) - { - Name (_SUN, 0x11) // _SUN: Slot User Number - Name (_ADR, 0x00110000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (S90) - { - Name (_SUN, 0x12) // _SUN: Slot User Number - Name (_ADR, 0x00120000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (S98) - { - Name (_SUN, 0x13) // _SUN: Slot User Number - Name (_ADR, 0x00130000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (SA0) - { - Name (_SUN, 0x14) // _SUN: Slot User Number - Name (_ADR, 0x00140000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (SA8) - { - Name (_SUN, 0x15) // _SUN: Slot User Number - Name (_ADR, 0x00150000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (SB0) - { - Name (_SUN, 0x16) // _SUN: Slot User Number - Name (_ADR, 0x00160000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (SB8) - { - Name (_SUN, 0x17) // _SUN: Slot User Number - Name (_ADR, 0x00170000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (SC0) - { - Name (_SUN, 0x18) // _SUN: Slot User Number - Name (_ADR, 0x00180000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (SC8) - { - Name (_SUN, 0x19) // _SUN: Slot User Number - Name (_ADR, 0x00190000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (SD0) - { - Name (_SUN, 0x1A) // _SUN: Slot User Number - Name (_ADR, 0x001A0000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (SD8) - { - Name (_SUN, 0x1B) // _SUN: Slot User Number - Name (_ADR, 0x001B0000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (SE0) - { - Name (_SUN, 0x1C) // _SUN: Slot User Number - Name (_ADR, 0x001C0000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (SE8) - { - Name (_SUN, 0x1D) // _SUN: Slot User Number - Name (_ADR, 0x001D0000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (SF0) - { - Name (_SUN, 0x1E) // _SUN: Slot User Number - Name (_ADR, 0x001E0000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Device (SF8) - { - Name (_SUN, 0x1F) // _SUN: Slot User Number - Name (_ADR, 0x001F0000) // _ADR: Address - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 - { - PCEJ (BSEL, _SUN) - } - } - - Method (DVNT, 2, NotSerialized) - { - If ((Arg0 & 0x10)) - { - Notify (S20, Arg1) - } - - If ((Arg0 & 0x20)) - { - Notify (S28, Arg1) - } - - If ((Arg0 & 0x40)) - { - Notify (S30, Arg1) - } - - If ((Arg0 & 0x80)) - { - Notify (S38, Arg1) - } - - If ((Arg0 & 0x0100)) - { - Notify (S40, Arg1) - } - - If ((Arg0 & 0x0200)) - { - Notify (S48, Arg1) - } - - If ((Arg0 & 0x0400)) - { - Notify (S50, Arg1) - } - - If ((Arg0 & 0x0800)) - { - Notify (S58, Arg1) - } - - If ((Arg0 & 0x1000)) - { - Notify (S60, Arg1) - } - - If ((Arg0 & 0x2000)) - { - Notify (S68, Arg1) - } - - If ((Arg0 & 0x4000)) - { - Notify (S70, Arg1) - } - - If ((Arg0 & 0x8000)) - { - Notify (S78, Arg1) - } - - If ((Arg0 & 0x00010000)) - { - Notify (S80, Arg1) - } - - If ((Arg0 & 0x00020000)) - { - Notify (S88, Arg1) - } - - If ((Arg0 & 0x00040000)) - { - Notify (S90, Arg1) - } - - If ((Arg0 & 0x00080000)) - { - Notify (S98, Arg1) - } - - If ((Arg0 & 0x00100000)) - { - Notify (SA0, Arg1) - } - - If ((Arg0 & 0x00200000)) - { - Notify (SA8, Arg1) - } - - If ((Arg0 & 0x00400000)) - { - Notify (SB0, Arg1) - } - - If ((Arg0 & 0x00800000)) - { - Notify (SB8, Arg1) - } - - If ((Arg0 & 0x01000000)) - { - Notify (SC0, Arg1) - } - - If ((Arg0 & 0x02000000)) - { - Notify (SC8, Arg1) - } - - If ((Arg0 & 0x04000000)) - { - Notify (SD0, Arg1) - } - - If ((Arg0 & 0x08000000)) - { - Notify (SD8, Arg1) - } - - If ((Arg0 & 0x10000000)) - { - Notify (SE0, Arg1) - } - - If ((Arg0 & 0x20000000)) - { - Notify (SE8, Arg1) - } - - If ((Arg0 & 0x40000000)) - { - Notify (SF0, Arg1) - } - - If ((Arg0 & 0x80000000)) - { - Notify (SF8, Arg1) - } - } - - Method (PCNT, 0, NotSerialized) - { - BNUM = Zero - DVNT (PCIU, One) - DVNT (PCID, 0x03) - } } } }
On Tue, Sep 29, 2020 at 12:56 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote: > > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote: > > > > This change adds a new DSDT golden master table blob to test disabling > > > > hotplug on both pci root bus and pci bridges. Also reverts the change > > > > in file bios-tables-test-allowed-diff.h to make sure its now empty so that > > > > future modifications to acpi tables can be caught. > > > > > > > > The following is the disassembled diff between DSDT.hpbridge and DSDT.hpbrroot: > > > > > > > > @@ -1,30 +1,30 @@ > > > > /* > > > > * Intel ACPI Component Architecture > > > > * AML/ASL+ Disassembler version 20180105 (64-bit version) > > > > * Copyright (c) 2000 - 2018 Intel Corporation > > > > * > > > > * Disassembling to symbolic ASL+ operators > > > > * > > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Wed Sep 16 09:45:56 2020 > > > > + * Disassembly of /tmp/aml-ECV9Q0, Wed Sep 16 09:45:56 2020 > > > > * > > > > * Original Table Header: > > > > * Signature "DSDT" > > > > - * Length 0x0000131F (4895) > > > > + * Length 0x00000B89 (2953) > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > > - * Checksum 0xF9 > > > > + * Checksum 0xA2 > > > > * OEM ID "BOCHS " > > > > * OEM Table ID "BXPCDSDT" > > > > * OEM Revision 0x00000001 (1) > > > > * Compiler ID "BXPC" > > > > * Compiler Version 0x00000001 (1) > > > > */ > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) > > > > { > > > > Scope (\) > > > > { > > > > OperationRegion (DBG, SystemIO, 0x0402, One) > > > > Field (DBG, ByteAcc, NoLock, Preserve) > > > > { > > > > DBGB, 8 > > > > } > > > > > > > > @@ -234,64 +234,32 @@ > > > > { > > > > Name (_HID, EisaId ("PNP0B00") /* AT Real-Time Clock */) // _HID: Hardware ID > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > { > > > > IO (Decode16, > > > > 0x0070, // Range Minimum > > > > 0x0070, // Range Maximum > > > > 0x01, // Alignment > > > > 0x08, // Length > > > > ) > > > > IRQNoFlags () > > > > {8} > > > > }) > > > > } > > > > } > > > > > > > > - Scope (_SB.PCI0) > > > > - { > > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > > > - { > > > > - PCIU, 32, > > > > - PCID, 32 > > > > - } > > > > - > > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > > > - { > > > > - B0EJ, 32 > > > > - } > > > > - > > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > > > - { > > > > - BNUM, 32 > > > > - } > > > > - > > > > - Mutex (BLCK, 0x00) > > > > - Method (PCEJ, 2, NotSerialized) > > > > - { > > > > - Acquire (BLCK, 0xFFFF) > > > > - BNUM = Arg0 > > > > - B0EJ = (One << Arg1) > > > > - Release (BLCK) > > > > - Return (Zero) > > > > - } > > > > - } > > > > - > > > > Scope (_SB) > > > > { > > > > Scope (PCI0) > > > > { > > > > Method (_PRT, 0, NotSerialized) // _PRT: PCI Routing Table > > > > { > > > > Local0 = Package (0x80){} > > > > Local1 = Zero > > > > While ((Local1 < 0x80)) > > > > { > > > > Local2 = (Local1 >> 0x02) > > > > Local3 = ((Local1 + Local2) & 0x03) > > > > If ((Local3 == Zero)) > > > > { > > > > Local4 = Package (0x04) > > > > { > > > > @@ -690,38 +658,32 @@ > > > > Method (_OST, 3, Serialized) // _OST: OSPM Status Indication > > > > { > > > > COST (Zero, Arg0, Arg1, Arg2) > > > > } > > > > } > > > > } > > > > } > > > > > > > > Method (\_GPE._E02, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > > > { > > > > \_SB.CPUS.CSCN () > > > > } > > > > > > > > Scope (_GPE) > > > > { > > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > > > - { > > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > > > - \_SB.PCI0.PCNT () > > > > - Release (\_SB.PCI0.BLCK) > > > > - } > > > > } > > > > > > > > Scope (\_SB.PCI0) > > > > { > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > { > > > > WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode, > > > > 0x0000, // Granularity > > > > 0x0000, // Range Minimum > > > > 0x00FF, // Range Maximum > > > > 0x0000, // Translation Offset > > > > 0x0100, // Length > > > > ,, ) > > > > IO (Decode16, > > > > 0x0CF8, // Range Minimum > > > > 0x0CF8, // Range Maximum > > > > @@ -766,48 +728,32 @@ > > > > }) > > > > Device (GPE0) > > > > { > > > > Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > > > Name (_UID, "GPE0 resources") // _UID: Unique ID > > > > Name (_STA, 0x0B) // _STA: Status > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > { > > > > IO (Decode16, > > > > 0xAFE0, // Range Minimum > > > > 0xAFE0, // Range Maximum > > > > 0x01, // Alignment > > > > 0x04, // Length > > > > ) > > > > }) > > > > } > > > > - > > > > - Device (PHPR) > > > > - { > > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > > > - Name (_STA, 0x0B) // _STA: Status > > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > - { > > > > - IO (Decode16, > > > > - 0xAE00, // Range Minimum > > > > - 0xAE00, // Range Maximum > > > > - 0x01, // Alignment > > > > - 0x14, // Length > > > > - ) > > > > - }) > > > > - } > > > > } > > > > > > > > Scope (\) > > > > { > > > > Name (_S3, Package (0x04) // _S3_: S3 System State > > > > { > > > > One, > > > > One, > > > > Zero, > > > > Zero > > > > }) > > > > Name (_S4, Package (0x04) // _S4_: S4 System State > > > > { > > > > 0x02, > > > > 0x02, > > > > Zero, > > > > @@ -831,479 +777,48 @@ > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > { > > > > IO (Decode16, > > > > 0x0510, // Range Minimum > > > > 0x0510, // Range Maximum > > > > 0x01, // Alignment > > > > 0x0C, // Length > > > > ) > > > > }) > > > > } > > > > } > > > > > > > > Scope (\_SB) > > > > { > > > > Scope (PCI0) > > > > { > > > > - Name (BSEL, Zero) > > > > Device (S00) > > > > { > > > > Name (_ADR, Zero) // _ADR: Address > > > > } > > > > > > > > Device (S10) > > > > { > > > > Name (_ADR, 0x00020000) // _ADR: Address > > > > Method (_S1D, 0, NotSerialized) // _S1D: S1 Device State > > > > { > > > > Return (Zero) > > > > } > > > > > > > > Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State > > > > { > > > > Return (Zero) > > > > } > > > > > > > > Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State > > > > { > > > > Return (Zero) > > > > } > > > > } > > > > > > > > Device (S18) > > > > { > > > > Name (_ADR, 0x00030000) // _ADR: Address > > > > } > > > > - > > > > - Device (S20) > > > > - { > > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00040000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S28) > > > > - { > > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00050000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S30) > > > > - { > > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00060000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S38) > > > > - { > > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00070000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S40) > > > > - { > > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00080000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S48) > > > > - { > > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00090000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S50) > > > > - { > > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S58) > > > > - { > > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S60) > > > > - { > > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S68) > > > > - { > > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S70) > > > > - { > > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S78) > > > > - { > > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S80) > > > > - { > > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00100000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S88) > > > > - { > > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00110000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S90) > > > > - { > > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00120000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S98) > > > > - { > > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00130000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SA0) > > > > - { > > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00140000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SA8) > > > > - { > > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00150000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SB0) > > > > - { > > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00160000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SB8) > > > > - { > > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00170000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SC0) > > > > - { > > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00180000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SC8) > > > > - { > > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00190000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SD0) > > > > - { > > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SD8) > > > > - { > > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SE0) > > > > - { > > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SE8) > > > > - { > > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SF0) > > > > - { > > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SF8) > > > > - { > > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Method (DVNT, 2, NotSerialized) > > > > - { > > > > - If ((Arg0 & 0x10)) > > > > - { > > > > - Notify (S20, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x20)) > > > > - { > > > > - Notify (S28, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x40)) > > > > - { > > > > - Notify (S30, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x80)) > > > > - { > > > > - Notify (S38, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x0100)) > > > > - { > > > > - Notify (S40, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x0200)) > > > > - { > > > > - Notify (S48, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x0400)) > > > > - { > > > > - Notify (S50, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x0800)) > > > > - { > > > > - Notify (S58, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x1000)) > > > > - { > > > > - Notify (S60, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x2000)) > > > > - { > > > > - Notify (S68, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x4000)) > > > > - { > > > > - Notify (S70, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x8000)) > > > > - { > > > > - Notify (S78, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x00010000)) > > > > - { > > > > - Notify (S80, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x00020000)) > > > > - { > > > > - Notify (S88, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x00040000)) > > > > - { > > > > - Notify (S90, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x00080000)) > > > > - { > > > > - Notify (S98, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x00100000)) > > > > - { > > > > - Notify (SA0, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x00200000)) > > > > - { > > > > - Notify (SA8, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x00400000)) > > > > - { > > > > - Notify (SB0, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x00800000)) > > > > - { > > > > - Notify (SB8, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x01000000)) > > > > - { > > > > - Notify (SC0, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x02000000)) > > > > - { > > > > - Notify (SC8, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x04000000)) > > > > - { > > > > - Notify (SD0, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x08000000)) > > > > - { > > > > - Notify (SD8, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x10000000)) > > > > - { > > > > - Notify (SE0, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x20000000)) > > > > - { > > > > - Notify (SE8, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x40000000)) > > > > - { > > > > - Notify (SF0, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x80000000)) > > > > - { > > > > - Notify (SF8, Arg1) > > > > - } > > > > - } > > > > - > > > > - Method (PCNT, 0, NotSerialized) > > > > - { > > > > - BNUM = Zero > > > > - DVNT (PCIU, One) > > > > - DVNT (PCID, 0x03) > > > > - } > > > > } > > > > } > > > > } > > > > > > This is not the only diff I see if I apply this patchset on > > > top of master. > > > Dropped this and the previous patch. > > > Please check what is going on and repost as appropriate. > > > > Which two ACPI DSDT files are you diffing? What diff are you getting? > > > diff -rup ./tests/data/acpi/pc/DSDT.hpbridge.dsl ./tests/data/acpi/pc/DSDT.hpbrroot.dsl I re-based my patchset on top of the latest qemu master and did a make && make check-qtest-x86_64 V=1. They pass. I am seeing this diff: https://pastebin.ubuntu.com/p/BXy9GFfB2R/ and it looks good to me. Not sure why your diff looks different. Maybe you can regenerate the blob? > > > > --- ./tests/data/acpi/pc/DSDT.hpbridge.dsl 2020-09-29 02:44:43.874622404 -0400 > +++ ./tests/data/acpi/pc/DSDT.hpbrroot.dsl 2020-09-29 02:44:43.876622403 -0400 > @@ -5,13 +5,13 @@ > * > * Disassembling to symbolic ASL+ operators > * > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 02:44:43 2020 > + * Disassembly of tests/data/acpi/pc/DSDT.hpbrroot, Tue Sep 29 02:44:43 2020 > * > * Original Table Header: > * Signature "DSDT" > - * Length 0x0000139D (5021) > + * Length 0x00000B89 (2953) > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > - * Checksum 0x05 > + * Checksum 0xA2 > * OEM ID "BOCHS " > * OEM Table ID "BXPCDSDT" > * OEM Revision 0x00000001 (1) > @@ -247,38 +247,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > } > } > > - Scope (_SB.PCI0) > - { > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > - { > - PCIU, 32, > - PCID, 32 > - } > - > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > - { > - B0EJ, 32 > - } > - > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > - { > - BNUM, 32 > - } > - > - Mutex (BLCK, 0x00) > - Method (PCEJ, 2, NotSerialized) > - { > - Acquire (BLCK, 0xFFFF) > - BNUM = Arg0 > - B0EJ = (One << Arg1) > - Release (BLCK) > - Return (Zero) > - } > - } > - > Scope (_SB) > { > Scope (PCI0) > @@ -643,56 +611,22 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > Method (CSCN, 0, Serialized) > { > Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF) > - Name (CNEW, Package (0xFF){}) > - Local3 = Zero > - Local4 = One > - While ((Local4 == One)) > + Local0 = One > + While ((Local0 == One)) > { > - Local4 = Zero > - Local0 = One > - Local1 = Zero > - While (((Local0 == One) && (Local3 < One))) > + Local0 = Zero > + \_SB.PCI0.PRES.CCMD = Zero > + If ((\_SB.PCI0.PRES.CINS == One)) > { > - Local0 = Zero > - \_SB.PCI0.PRES.CSEL = Local3 > - \_SB.PCI0.PRES.CCMD = Zero > - If ((\_SB.PCI0.PRES.CDAT < Local3)) > - { > - Break > - } > - > - If ((Local1 == 0xFF)) > - { > - Local4 = One > - Break > - } > - > - Local3 = \_SB.PCI0.PRES.CDAT > - If ((\_SB.PCI0.PRES.CINS == One)) > - { > - CNEW [Local1] = Local3 > - Local1++ > - Local0 = One > - } > - ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > - { > - CTFY (Local3, 0x03) > - \_SB.PCI0.PRES.CRMV = One > - Local0 = One > - } > - > - Local3++ > + CTFY (\_SB.PCI0.PRES.CDAT, One) > + \_SB.PCI0.PRES.CINS = One > + Local0 = One > } > - > - Local2 = Zero > - While ((Local2 < Local1)) > + ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > { > - Local3 = DerefOf (CNEW [Local2]) > - CTFY (Local3, One) > - Debug = Local3 > - \_SB.PCI0.PRES.CSEL = Local3 > - \_SB.PCI0.PRES.CINS = One > - Local2++ > + CTFY (\_SB.PCI0.PRES.CDAT, 0x03) > + \_SB.PCI0.PRES.CRMV = One > + Local0 = One > } > } > > @@ -737,12 +671,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > Scope (_GPE) > { > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE, xx=0x00-0xFF > - { > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > - \_SB.PCI0.PCNT () > - Release (\_SB.PCI0.BLCK) > - } > } > > Scope (\_SB.PCI0) > @@ -813,22 +741,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > ) > }) > } > - > - Device (PHPR) > - { > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > - Name (_STA, 0x0B) // _STA: Status > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > - { > - IO (Decode16, > - 0xAE00, // Range Minimum > - 0xAE00, // Range Maximum > - 0x01, // Alignment > - 0x14, // Length > - ) > - }) > - } > } > > Scope (\) > @@ -878,7 +790,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > { > Scope (PCI0) > { > - Name (BSEL, Zero) > Device (S00) > { > Name (_ADR, Zero) // _ADR: Address > @@ -907,436 +818,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > { > Name (_ADR, 0x00030000) // _ADR: Address > } > - > - Device (S20) > - { > - Name (_SUN, 0x04) // _SUN: Slot User Number > - Name (_ADR, 0x00040000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (S28) > - { > - Name (_SUN, 0x05) // _SUN: Slot User Number > - Name (_ADR, 0x00050000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (S30) > - { > - Name (_SUN, 0x06) // _SUN: Slot User Number > - Name (_ADR, 0x00060000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (S38) > - { > - Name (_SUN, 0x07) // _SUN: Slot User Number > - Name (_ADR, 0x00070000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (S40) > - { > - Name (_SUN, 0x08) // _SUN: Slot User Number > - Name (_ADR, 0x00080000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (S48) > - { > - Name (_SUN, 0x09) // _SUN: Slot User Number > - Name (_ADR, 0x00090000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (S50) > - { > - Name (_SUN, 0x0A) // _SUN: Slot User Number > - Name (_ADR, 0x000A0000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (S58) > - { > - Name (_SUN, 0x0B) // _SUN: Slot User Number > - Name (_ADR, 0x000B0000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (S60) > - { > - Name (_SUN, 0x0C) // _SUN: Slot User Number > - Name (_ADR, 0x000C0000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (S68) > - { > - Name (_SUN, 0x0D) // _SUN: Slot User Number > - Name (_ADR, 0x000D0000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (S70) > - { > - Name (_SUN, 0x0E) // _SUN: Slot User Number > - Name (_ADR, 0x000E0000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (S78) > - { > - Name (_SUN, 0x0F) // _SUN: Slot User Number > - Name (_ADR, 0x000F0000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (S80) > - { > - Name (_SUN, 0x10) // _SUN: Slot User Number > - Name (_ADR, 0x00100000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (S88) > - { > - Name (_SUN, 0x11) // _SUN: Slot User Number > - Name (_ADR, 0x00110000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (S90) > - { > - Name (_SUN, 0x12) // _SUN: Slot User Number > - Name (_ADR, 0x00120000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (S98) > - { > - Name (_SUN, 0x13) // _SUN: Slot User Number > - Name (_ADR, 0x00130000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (SA0) > - { > - Name (_SUN, 0x14) // _SUN: Slot User Number > - Name (_ADR, 0x00140000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (SA8) > - { > - Name (_SUN, 0x15) // _SUN: Slot User Number > - Name (_ADR, 0x00150000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (SB0) > - { > - Name (_SUN, 0x16) // _SUN: Slot User Number > - Name (_ADR, 0x00160000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (SB8) > - { > - Name (_SUN, 0x17) // _SUN: Slot User Number > - Name (_ADR, 0x00170000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (SC0) > - { > - Name (_SUN, 0x18) // _SUN: Slot User Number > - Name (_ADR, 0x00180000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (SC8) > - { > - Name (_SUN, 0x19) // _SUN: Slot User Number > - Name (_ADR, 0x00190000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (SD0) > - { > - Name (_SUN, 0x1A) // _SUN: Slot User Number > - Name (_ADR, 0x001A0000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (SD8) > - { > - Name (_SUN, 0x1B) // _SUN: Slot User Number > - Name (_ADR, 0x001B0000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (SE0) > - { > - Name (_SUN, 0x1C) // _SUN: Slot User Number > - Name (_ADR, 0x001C0000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (SE8) > - { > - Name (_SUN, 0x1D) // _SUN: Slot User Number > - Name (_ADR, 0x001D0000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (SF0) > - { > - Name (_SUN, 0x1E) // _SUN: Slot User Number > - Name (_ADR, 0x001E0000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Device (SF8) > - { > - Name (_SUN, 0x1F) // _SUN: Slot User Number > - Name (_ADR, 0x001F0000) // _ADR: Address > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > - { > - PCEJ (BSEL, _SUN) > - } > - } > - > - Method (DVNT, 2, NotSerialized) > - { > - If ((Arg0 & 0x10)) > - { > - Notify (S20, Arg1) > - } > - > - If ((Arg0 & 0x20)) > - { > - Notify (S28, Arg1) > - } > - > - If ((Arg0 & 0x40)) > - { > - Notify (S30, Arg1) > - } > - > - If ((Arg0 & 0x80)) > - { > - Notify (S38, Arg1) > - } > - > - If ((Arg0 & 0x0100)) > - { > - Notify (S40, Arg1) > - } > - > - If ((Arg0 & 0x0200)) > - { > - Notify (S48, Arg1) > - } > - > - If ((Arg0 & 0x0400)) > - { > - Notify (S50, Arg1) > - } > - > - If ((Arg0 & 0x0800)) > - { > - Notify (S58, Arg1) > - } > - > - If ((Arg0 & 0x1000)) > - { > - Notify (S60, Arg1) > - } > - > - If ((Arg0 & 0x2000)) > - { > - Notify (S68, Arg1) > - } > - > - If ((Arg0 & 0x4000)) > - { > - Notify (S70, Arg1) > - } > - > - If ((Arg0 & 0x8000)) > - { > - Notify (S78, Arg1) > - } > - > - If ((Arg0 & 0x00010000)) > - { > - Notify (S80, Arg1) > - } > - > - If ((Arg0 & 0x00020000)) > - { > - Notify (S88, Arg1) > - } > - > - If ((Arg0 & 0x00040000)) > - { > - Notify (S90, Arg1) > - } > - > - If ((Arg0 & 0x00080000)) > - { > - Notify (S98, Arg1) > - } > - > - If ((Arg0 & 0x00100000)) > - { > - Notify (SA0, Arg1) > - } > - > - If ((Arg0 & 0x00200000)) > - { > - Notify (SA8, Arg1) > - } > - > - If ((Arg0 & 0x00400000)) > - { > - Notify (SB0, Arg1) > - } > - > - If ((Arg0 & 0x00800000)) > - { > - Notify (SB8, Arg1) > - } > - > - If ((Arg0 & 0x01000000)) > - { > - Notify (SC0, Arg1) > - } > - > - If ((Arg0 & 0x02000000)) > - { > - Notify (SC8, Arg1) > - } > - > - If ((Arg0 & 0x04000000)) > - { > - Notify (SD0, Arg1) > - } > - > - If ((Arg0 & 0x08000000)) > - { > - Notify (SD8, Arg1) > - } > - > - If ((Arg0 & 0x10000000)) > - { > - Notify (SE0, Arg1) > - } > - > - If ((Arg0 & 0x20000000)) > - { > - Notify (SE8, Arg1) > - } > - > - If ((Arg0 & 0x40000000)) > - { > - Notify (SF0, Arg1) > - } > - > - If ((Arg0 & 0x80000000)) > - { > - Notify (SF8, Arg1) > - } > - } > - > - Method (PCNT, 0, NotSerialized) > - { > - BNUM = Zero > - DVNT (PCIU, One) > - DVNT (PCID, 0x03) > - } > } > } > } >
On Tue, Sep 29, 2020 at 1:53 PM Ani Sinha <ani@anisinha.ca> wrote: > > On Tue, Sep 29, 2020 at 12:56 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote: > > > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote: > > > > > This change adds a new DSDT golden master table blob to test disabling > > > > > hotplug on both pci root bus and pci bridges. Also reverts the change > > > > > in file bios-tables-test-allowed-diff.h to make sure its now empty so that > > > > > future modifications to acpi tables can be caught. > > > > > > > > > > The following is the disassembled diff between DSDT.hpbridge and DSDT.hpbrroot: > > > > > > > > > > @@ -1,30 +1,30 @@ > > > > > /* > > > > > * Intel ACPI Component Architecture > > > > > * AML/ASL+ Disassembler version 20180105 (64-bit version) > > > > > * Copyright (c) 2000 - 2018 Intel Corporation > > > > > * > > > > > * Disassembling to symbolic ASL+ operators > > > > > * > > > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Wed Sep 16 09:45:56 2020 > > > > > + * Disassembly of /tmp/aml-ECV9Q0, Wed Sep 16 09:45:56 2020 > > > > > * > > > > > * Original Table Header: > > > > > * Signature "DSDT" > > > > > - * Length 0x0000131F (4895) > > > > > + * Length 0x00000B89 (2953) > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > > > - * Checksum 0xF9 > > > > > + * Checksum 0xA2 > > > > > * OEM ID "BOCHS " > > > > > * OEM Table ID "BXPCDSDT" > > > > > * OEM Revision 0x00000001 (1) > > > > > * Compiler ID "BXPC" > > > > > * Compiler Version 0x00000001 (1) > > > > > */ > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) > > > > > { > > > > > Scope (\) > > > > > { > > > > > OperationRegion (DBG, SystemIO, 0x0402, One) > > > > > Field (DBG, ByteAcc, NoLock, Preserve) > > > > > { > > > > > DBGB, 8 > > > > > } > > > > > > > > > > @@ -234,64 +234,32 @@ > > > > > { > > > > > Name (_HID, EisaId ("PNP0B00") /* AT Real-Time Clock */) // _HID: Hardware ID > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > > { > > > > > IO (Decode16, > > > > > 0x0070, // Range Minimum > > > > > 0x0070, // Range Maximum > > > > > 0x01, // Alignment > > > > > 0x08, // Length > > > > > ) > > > > > IRQNoFlags () > > > > > {8} > > > > > }) > > > > > } > > > > > } > > > > > > > > > > - Scope (_SB.PCI0) > > > > > - { > > > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > > > > - { > > > > > - PCIU, 32, > > > > > - PCID, 32 > > > > > - } > > > > > - > > > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > > > > - { > > > > > - B0EJ, 32 > > > > > - } > > > > > - > > > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > > > > - { > > > > > - BNUM, 32 > > > > > - } > > > > > - > > > > > - Mutex (BLCK, 0x00) > > > > > - Method (PCEJ, 2, NotSerialized) > > > > > - { > > > > > - Acquire (BLCK, 0xFFFF) > > > > > - BNUM = Arg0 > > > > > - B0EJ = (One << Arg1) > > > > > - Release (BLCK) > > > > > - Return (Zero) > > > > > - } > > > > > - } > > > > > - > > > > > Scope (_SB) > > > > > { > > > > > Scope (PCI0) > > > > > { > > > > > Method (_PRT, 0, NotSerialized) // _PRT: PCI Routing Table > > > > > { > > > > > Local0 = Package (0x80){} > > > > > Local1 = Zero > > > > > While ((Local1 < 0x80)) > > > > > { > > > > > Local2 = (Local1 >> 0x02) > > > > > Local3 = ((Local1 + Local2) & 0x03) > > > > > If ((Local3 == Zero)) > > > > > { > > > > > Local4 = Package (0x04) > > > > > { > > > > > @@ -690,38 +658,32 @@ > > > > > Method (_OST, 3, Serialized) // _OST: OSPM Status Indication > > > > > { > > > > > COST (Zero, Arg0, Arg1, Arg2) > > > > > } > > > > > } > > > > > } > > > > > } > > > > > > > > > > Method (\_GPE._E02, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > > > > { > > > > > \_SB.CPUS.CSCN () > > > > > } > > > > > > > > > > Scope (_GPE) > > > > > { > > > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > > > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > > > > - { > > > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > > > > - \_SB.PCI0.PCNT () > > > > > - Release (\_SB.PCI0.BLCK) > > > > > - } > > > > > } > > > > > > > > > > Scope (\_SB.PCI0) > > > > > { > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > > { > > > > > WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode, > > > > > 0x0000, // Granularity > > > > > 0x0000, // Range Minimum > > > > > 0x00FF, // Range Maximum > > > > > 0x0000, // Translation Offset > > > > > 0x0100, // Length > > > > > ,, ) > > > > > IO (Decode16, > > > > > 0x0CF8, // Range Minimum > > > > > 0x0CF8, // Range Maximum > > > > > @@ -766,48 +728,32 @@ > > > > > }) > > > > > Device (GPE0) > > > > > { > > > > > Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > > > > Name (_UID, "GPE0 resources") // _UID: Unique ID > > > > > Name (_STA, 0x0B) // _STA: Status > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > > { > > > > > IO (Decode16, > > > > > 0xAFE0, // Range Minimum > > > > > 0xAFE0, // Range Maximum > > > > > 0x01, // Alignment > > > > > 0x04, // Length > > > > > ) > > > > > }) > > > > > } > > > > > - > > > > > - Device (PHPR) > > > > > - { > > > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > > > > - Name (_STA, 0x0B) // _STA: Status > > > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > > - { > > > > > - IO (Decode16, > > > > > - 0xAE00, // Range Minimum > > > > > - 0xAE00, // Range Maximum > > > > > - 0x01, // Alignment > > > > > - 0x14, // Length > > > > > - ) > > > > > - }) > > > > > - } > > > > > } > > > > > > > > > > Scope (\) > > > > > { > > > > > Name (_S3, Package (0x04) // _S3_: S3 System State > > > > > { > > > > > One, > > > > > One, > > > > > Zero, > > > > > Zero > > > > > }) > > > > > Name (_S4, Package (0x04) // _S4_: S4 System State > > > > > { > > > > > 0x02, > > > > > 0x02, > > > > > Zero, > > > > > @@ -831,479 +777,48 @@ > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > > { > > > > > IO (Decode16, > > > > > 0x0510, // Range Minimum > > > > > 0x0510, // Range Maximum > > > > > 0x01, // Alignment > > > > > 0x0C, // Length > > > > > ) > > > > > }) > > > > > } > > > > > } > > > > > > > > > > Scope (\_SB) > > > > > { > > > > > Scope (PCI0) > > > > > { > > > > > - Name (BSEL, Zero) > > > > > Device (S00) > > > > > { > > > > > Name (_ADR, Zero) // _ADR: Address > > > > > } > > > > > > > > > > Device (S10) > > > > > { > > > > > Name (_ADR, 0x00020000) // _ADR: Address > > > > > Method (_S1D, 0, NotSerialized) // _S1D: S1 Device State > > > > > { > > > > > Return (Zero) > > > > > } > > > > > > > > > > Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State > > > > > { > > > > > Return (Zero) > > > > > } > > > > > > > > > > Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State > > > > > { > > > > > Return (Zero) > > > > > } > > > > > } > > > > > > > > > > Device (S18) > > > > > { > > > > > Name (_ADR, 0x00030000) // _ADR: Address > > > > > } > > > > > - > > > > > - Device (S20) > > > > > - { > > > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00040000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S28) > > > > > - { > > > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00050000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S30) > > > > > - { > > > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00060000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S38) > > > > > - { > > > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00070000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S40) > > > > > - { > > > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00080000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S48) > > > > > - { > > > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00090000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S50) > > > > > - { > > > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S58) > > > > > - { > > > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S60) > > > > > - { > > > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S68) > > > > > - { > > > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S70) > > > > > - { > > > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S78) > > > > > - { > > > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S80) > > > > > - { > > > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00100000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S88) > > > > > - { > > > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00110000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S90) > > > > > - { > > > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00120000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S98) > > > > > - { > > > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00130000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SA0) > > > > > - { > > > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00140000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SA8) > > > > > - { > > > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00150000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SB0) > > > > > - { > > > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00160000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SB8) > > > > > - { > > > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00170000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SC0) > > > > > - { > > > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00180000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SC8) > > > > > - { > > > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00190000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SD0) > > > > > - { > > > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SD8) > > > > > - { > > > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SE0) > > > > > - { > > > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SE8) > > > > > - { > > > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SF0) > > > > > - { > > > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SF8) > > > > > - { > > > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Method (DVNT, 2, NotSerialized) > > > > > - { > > > > > - If ((Arg0 & 0x10)) > > > > > - { > > > > > - Notify (S20, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x20)) > > > > > - { > > > > > - Notify (S28, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x40)) > > > > > - { > > > > > - Notify (S30, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x80)) > > > > > - { > > > > > - Notify (S38, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x0100)) > > > > > - { > > > > > - Notify (S40, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x0200)) > > > > > - { > > > > > - Notify (S48, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x0400)) > > > > > - { > > > > > - Notify (S50, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x0800)) > > > > > - { > > > > > - Notify (S58, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x1000)) > > > > > - { > > > > > - Notify (S60, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x2000)) > > > > > - { > > > > > - Notify (S68, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x4000)) > > > > > - { > > > > > - Notify (S70, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x8000)) > > > > > - { > > > > > - Notify (S78, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x00010000)) > > > > > - { > > > > > - Notify (S80, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x00020000)) > > > > > - { > > > > > - Notify (S88, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x00040000)) > > > > > - { > > > > > - Notify (S90, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x00080000)) > > > > > - { > > > > > - Notify (S98, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x00100000)) > > > > > - { > > > > > - Notify (SA0, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x00200000)) > > > > > - { > > > > > - Notify (SA8, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x00400000)) > > > > > - { > > > > > - Notify (SB0, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x00800000)) > > > > > - { > > > > > - Notify (SB8, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x01000000)) > > > > > - { > > > > > - Notify (SC0, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x02000000)) > > > > > - { > > > > > - Notify (SC8, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x04000000)) > > > > > - { > > > > > - Notify (SD0, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x08000000)) > > > > > - { > > > > > - Notify (SD8, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x10000000)) > > > > > - { > > > > > - Notify (SE0, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x20000000)) > > > > > - { > > > > > - Notify (SE8, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x40000000)) > > > > > - { > > > > > - Notify (SF0, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x80000000)) > > > > > - { > > > > > - Notify (SF8, Arg1) > > > > > - } > > > > > - } > > > > > - > > > > > - Method (PCNT, 0, NotSerialized) > > > > > - { > > > > > - BNUM = Zero > > > > > - DVNT (PCIU, One) > > > > > - DVNT (PCID, 0x03) > > > > > - } > > > > > } > > > > > } > > > > > } > > > > > > > > This is not the only diff I see if I apply this patchset on > > > > top of master. > > > > Dropped this and the previous patch. > > > > Please check what is going on and repost as appropriate. > > > > > > Which two ACPI DSDT files are you diffing? What diff are you getting? > > > > > > diff -rup ./tests/data/acpi/pc/DSDT.hpbridge.dsl ./tests/data/acpi/pc/DSDT.hpbrroot.dsl > > I re-based my patchset on top of the latest qemu master and did a make > && make check-qtest-x86_64 V=1. > They pass. I am seeing this diff: > https://pastebin.ubuntu.com/p/BXy9GFfB2R/ > > and it looks good to me. > > Not sure why your diff looks different. Maybe you can regenerate the blob? I did a full make check and it passed. I compared the diff again and it's the same. I checked my tree and it looks clean. These are the patches I have: $ git log --oneline 20d1323e10 (HEAD -> master) qom: code hardening - have bound checking while looping with integer value 0f69dae0e2 Add a comment in bios-tables-test.c to clarify the reason behind approach dd9a8c3cd3 tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug 5b93474fe9 tests/acpi: unit test exercising global pci hotplug off for i440fx 54c33e334a tests/acpi: update golden master DSDT binary table blobs for q35 2279f61f30 piix4: don't reserve hw resources when hotplug is off globally 1f61c524a0 Add ACPI DSDT tables for q35 that are being updated by the next patch bdd823611b tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag 8c80f8fba9 tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag e0a3142df9 tests/acpi: list added acpi table binary file for pci bridge hotplug test 0ba08317a8 i440fx/acpi: do not add hotplug related amls for cold plugged bridges 73b191ade6 Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus ef0e526cc2 tests/acpi: add a new ACPI table in order to test root pci hotplug on/off c6d13264f8 tests/acpi: add new unit test to test hotplug off/on feature on the root pci bus 6901bada65 tests/acpi: mark addition of table DSDT.roothp for unit testing root pci hotplug 74504514b1 (origin/master, origin/HEAD) Merge remote-tracking branch 'remotes/alistair/tags/pull-register-20200927' into staging > > > > > > > > > --- ./tests/data/acpi/pc/DSDT.hpbridge.dsl 2020-09-29 02:44:43.874622404 -0400 > > +++ ./tests/data/acpi/pc/DSDT.hpbrroot.dsl 2020-09-29 02:44:43.876622403 -0400 > > @@ -5,13 +5,13 @@ > > * > > * Disassembling to symbolic ASL+ operators > > * > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 02:44:43 2020 > > + * Disassembly of tests/data/acpi/pc/DSDT.hpbrroot, Tue Sep 29 02:44:43 2020 > > * > > * Original Table Header: > > * Signature "DSDT" > > - * Length 0x0000139D (5021) > > + * Length 0x00000B89 (2953) > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > - * Checksum 0x05 > > + * Checksum 0xA2 > > * OEM ID "BOCHS " > > * OEM Table ID "BXPCDSDT" > > * OEM Revision 0x00000001 (1) > > @@ -247,38 +247,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > } > > } > > > > - Scope (_SB.PCI0) > > - { > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > - { > > - PCIU, 32, > > - PCID, 32 > > - } > > - > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > - { > > - B0EJ, 32 > > - } > > - > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > - { > > - BNUM, 32 > > - } > > - > > - Mutex (BLCK, 0x00) > > - Method (PCEJ, 2, NotSerialized) > > - { > > - Acquire (BLCK, 0xFFFF) > > - BNUM = Arg0 > > - B0EJ = (One << Arg1) > > - Release (BLCK) > > - Return (Zero) > > - } > > - } > > - > > Scope (_SB) > > { > > Scope (PCI0) > > @@ -643,56 +611,22 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > Method (CSCN, 0, Serialized) > > { > > Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF) > > - Name (CNEW, Package (0xFF){}) > > - Local3 = Zero > > - Local4 = One > > - While ((Local4 == One)) > > + Local0 = One > > + While ((Local0 == One)) > > { > > - Local4 = Zero > > - Local0 = One > > - Local1 = Zero > > - While (((Local0 == One) && (Local3 < One))) > > + Local0 = Zero > > + \_SB.PCI0.PRES.CCMD = Zero > > + If ((\_SB.PCI0.PRES.CINS == One)) > > { > > - Local0 = Zero > > - \_SB.PCI0.PRES.CSEL = Local3 > > - \_SB.PCI0.PRES.CCMD = Zero > > - If ((\_SB.PCI0.PRES.CDAT < Local3)) > > - { > > - Break > > - } > > - > > - If ((Local1 == 0xFF)) > > - { > > - Local4 = One > > - Break > > - } > > - > > - Local3 = \_SB.PCI0.PRES.CDAT > > - If ((\_SB.PCI0.PRES.CINS == One)) > > - { > > - CNEW [Local1] = Local3 > > - Local1++ > > - Local0 = One > > - } > > - ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > > - { > > - CTFY (Local3, 0x03) > > - \_SB.PCI0.PRES.CRMV = One > > - Local0 = One > > - } > > - > > - Local3++ > > + CTFY (\_SB.PCI0.PRES.CDAT, One) > > + \_SB.PCI0.PRES.CINS = One > > + Local0 = One > > } > > - > > - Local2 = Zero > > - While ((Local2 < Local1)) > > + ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > > { > > - Local3 = DerefOf (CNEW [Local2]) > > - CTFY (Local3, One) > > - Debug = Local3 > > - \_SB.PCI0.PRES.CSEL = Local3 > > - \_SB.PCI0.PRES.CINS = One > > - Local2++ > > + CTFY (\_SB.PCI0.PRES.CDAT, 0x03) > > + \_SB.PCI0.PRES.CRMV = One > > + Local0 = One > > } > > } > > > > @@ -737,12 +671,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > Scope (_GPE) > > { > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE, xx=0x00-0xFF > > - { > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > - \_SB.PCI0.PCNT () > > - Release (\_SB.PCI0.BLCK) > > - } > > } > > > > Scope (\_SB.PCI0) > > @@ -813,22 +741,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > ) > > }) > > } > > - > > - Device (PHPR) > > - { > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > - Name (_STA, 0x0B) // _STA: Status > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > - { > > - IO (Decode16, > > - 0xAE00, // Range Minimum > > - 0xAE00, // Range Maximum > > - 0x01, // Alignment > > - 0x14, // Length > > - ) > > - }) > > - } > > } > > > > Scope (\) > > @@ -878,7 +790,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > { > > Scope (PCI0) > > { > > - Name (BSEL, Zero) > > Device (S00) > > { > > Name (_ADR, Zero) // _ADR: Address > > @@ -907,436 +818,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > { > > Name (_ADR, 0x00030000) // _ADR: Address > > } > > - > > - Device (S20) > > - { > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > - Name (_ADR, 0x00040000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S28) > > - { > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > - Name (_ADR, 0x00050000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S30) > > - { > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > - Name (_ADR, 0x00060000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S38) > > - { > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > - Name (_ADR, 0x00070000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S40) > > - { > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > - Name (_ADR, 0x00080000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S48) > > - { > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > - Name (_ADR, 0x00090000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S50) > > - { > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > - Name (_ADR, 0x000A0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S58) > > - { > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > - Name (_ADR, 0x000B0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S60) > > - { > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > - Name (_ADR, 0x000C0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S68) > > - { > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > - Name (_ADR, 0x000D0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S70) > > - { > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > - Name (_ADR, 0x000E0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S78) > > - { > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > - Name (_ADR, 0x000F0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S80) > > - { > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > - Name (_ADR, 0x00100000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S88) > > - { > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > - Name (_ADR, 0x00110000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S90) > > - { > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > - Name (_ADR, 0x00120000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (S98) > > - { > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > - Name (_ADR, 0x00130000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SA0) > > - { > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > - Name (_ADR, 0x00140000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SA8) > > - { > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > - Name (_ADR, 0x00150000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SB0) > > - { > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > - Name (_ADR, 0x00160000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SB8) > > - { > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > - Name (_ADR, 0x00170000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SC0) > > - { > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > - Name (_ADR, 0x00180000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SC8) > > - { > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > - Name (_ADR, 0x00190000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SD0) > > - { > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > - Name (_ADR, 0x001A0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SD8) > > - { > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > - Name (_ADR, 0x001B0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SE0) > > - { > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > - Name (_ADR, 0x001C0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SE8) > > - { > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > - Name (_ADR, 0x001D0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SF0) > > - { > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > - Name (_ADR, 0x001E0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Device (SF8) > > - { > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > - Name (_ADR, 0x001F0000) // _ADR: Address > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > - { > > - PCEJ (BSEL, _SUN) > > - } > > - } > > - > > - Method (DVNT, 2, NotSerialized) > > - { > > - If ((Arg0 & 0x10)) > > - { > > - Notify (S20, Arg1) > > - } > > - > > - If ((Arg0 & 0x20)) > > - { > > - Notify (S28, Arg1) > > - } > > - > > - If ((Arg0 & 0x40)) > > - { > > - Notify (S30, Arg1) > > - } > > - > > - If ((Arg0 & 0x80)) > > - { > > - Notify (S38, Arg1) > > - } > > - > > - If ((Arg0 & 0x0100)) > > - { > > - Notify (S40, Arg1) > > - } > > - > > - If ((Arg0 & 0x0200)) > > - { > > - Notify (S48, Arg1) > > - } > > - > > - If ((Arg0 & 0x0400)) > > - { > > - Notify (S50, Arg1) > > - } > > - > > - If ((Arg0 & 0x0800)) > > - { > > - Notify (S58, Arg1) > > - } > > - > > - If ((Arg0 & 0x1000)) > > - { > > - Notify (S60, Arg1) > > - } > > - > > - If ((Arg0 & 0x2000)) > > - { > > - Notify (S68, Arg1) > > - } > > - > > - If ((Arg0 & 0x4000)) > > - { > > - Notify (S70, Arg1) > > - } > > - > > - If ((Arg0 & 0x8000)) > > - { > > - Notify (S78, Arg1) > > - } > > - > > - If ((Arg0 & 0x00010000)) > > - { > > - Notify (S80, Arg1) > > - } > > - > > - If ((Arg0 & 0x00020000)) > > - { > > - Notify (S88, Arg1) > > - } > > - > > - If ((Arg0 & 0x00040000)) > > - { > > - Notify (S90, Arg1) > > - } > > - > > - If ((Arg0 & 0x00080000)) > > - { > > - Notify (S98, Arg1) > > - } > > - > > - If ((Arg0 & 0x00100000)) > > - { > > - Notify (SA0, Arg1) > > - } > > - > > - If ((Arg0 & 0x00200000)) > > - { > > - Notify (SA8, Arg1) > > - } > > - > > - If ((Arg0 & 0x00400000)) > > - { > > - Notify (SB0, Arg1) > > - } > > - > > - If ((Arg0 & 0x00800000)) > > - { > > - Notify (SB8, Arg1) > > - } > > - > > - If ((Arg0 & 0x01000000)) > > - { > > - Notify (SC0, Arg1) > > - } > > - > > - If ((Arg0 & 0x02000000)) > > - { > > - Notify (SC8, Arg1) > > - } > > - > > - If ((Arg0 & 0x04000000)) > > - { > > - Notify (SD0, Arg1) > > - } > > - > > - If ((Arg0 & 0x08000000)) > > - { > > - Notify (SD8, Arg1) > > - } > > - > > - If ((Arg0 & 0x10000000)) > > - { > > - Notify (SE0, Arg1) > > - } > > - > > - If ((Arg0 & 0x20000000)) > > - { > > - Notify (SE8, Arg1) > > - } > > - > > - If ((Arg0 & 0x40000000)) > > - { > > - Notify (SF0, Arg1) > > - } > > - > > - If ((Arg0 & 0x80000000)) > > - { > > - Notify (SF8, Arg1) > > - } > > - } > > - > > - Method (PCNT, 0, NotSerialized) > > - { > > - BNUM = Zero > > - DVNT (PCIU, One) > > - DVNT (PCID, 0x03) > > - } > > } > > } > > } > >
Maybe you can give me access to your workspace aane I can take a look. On Tue, Sep 29, 2020 at 2:21 PM Ani Sinha <ani@anisinha.ca> wrote: > On Tue, Sep 29, 2020 at 1:53 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > On Tue, Sep 29, 2020 at 12:56 PM Michael S. Tsirkin <mst@redhat.com> > wrote: > > > > > > > > On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote: > > > > > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin <mst@redhat.com> > wrote: > > > > > > > > > > > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote: > > > > > > > This change adds a new DSDT golden master table blob to test > disabling > > > > > > > hotplug on both pci root bus and pci bridges. Also reverts the > change > > > > > > > in file bios-tables-test-allowed-diff.h to make sure its now > empty so that > > > > > > > future modifications to acpi tables can be caught. > > > > > > > > > > > > > > The following is the disassembled diff between DSDT.hpbridge and > DSDT.hpbrroot: > > > > > > > > > > > > > > @@ -1,30 +1,30 @@ > > > > > > > /* > > > > > > > * Intel ACPI Component Architecture > > > > > > > * AML/ASL+ Disassembler version 20180105 (64-bit version) > > > > > > > * Copyright (c) 2000 - 2018 Intel Corporation > > > > > > > * > > > > > > > * Disassembling to symbolic ASL+ operators > > > > > > > * > > > > > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Wed Sep 16 > 09:45:56 2020 > > > > > > > + * Disassembly of /tmp/aml-ECV9Q0, Wed Sep 16 09:45:56 2020 > > > > > > > * > > > > > > > * Original Table Header: > > > > > > > * Signature "DSDT" > > > > > > > - * Length 0x0000131F (4895) > > > > > > > + * Length 0x00000B89 (2953) > > > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit > math support > > > > > > > - * Checksum 0xF9 > > > > > > > + * Checksum 0xA2 > > > > > > > * OEM ID "BOCHS " > > > > > > > * OEM Table ID "BXPCDSDT" > > > > > > > * OEM Revision 0x00000001 (1) > > > > > > > * Compiler ID "BXPC" > > > > > > > * Compiler Version 0x00000001 (1) > > > > > > > */ > > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", > 0x00000001) > > > > > > > { > > > > > > > Scope (\) > > > > > > > { > > > > > > > OperationRegion (DBG, SystemIO, 0x0402, One) > > > > > > > Field (DBG, ByteAcc, NoLock, Preserve) > > > > > > > { > > > > > > > DBGB, 8 > > > > > > > } > > > > > > > > > > > > > > @@ -234,64 +234,32 @@ > > > > > > > { > > > > > > > Name (_HID, EisaId ("PNP0B00") /* AT Real-Time > Clock */) // _HID: Hardware ID > > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current > Resource Settings > > > > > > > { > > > > > > > IO (Decode16, > > > > > > > 0x0070, // Range Minimum > > > > > > > 0x0070, // Range Maximum > > > > > > > 0x01, // Alignment > > > > > > > 0x08, // Length > > > > > > > ) > > > > > > > IRQNoFlags () > > > > > > > {8} > > > > > > > }) > > > > > > > } > > > > > > > } > > > > > > > > > > > > > > - Scope (_SB.PCI0) > > > > > > > - { > > > > > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > > > > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > > > > > > - { > > > > > > > - PCIU, 32, > > > > > > > - PCID, 32 > > > > > > > - } > > > > > > > - > > > > > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > > > > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > > > > > > - { > > > > > > > - B0EJ, 32 > > > > > > > - } > > > > > > > - > > > > > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > > > > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > > > > > > - { > > > > > > > - BNUM, 32 > > > > > > > - } > > > > > > > - > > > > > > > - Mutex (BLCK, 0x00) > > > > > > > - Method (PCEJ, 2, NotSerialized) > > > > > > > - { > > > > > > > - Acquire (BLCK, 0xFFFF) > > > > > > > - BNUM = Arg0 > > > > > > > - B0EJ = (One << Arg1) > > > > > > > - Release (BLCK) > > > > > > > - Return (Zero) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > Scope (_SB) > > > > > > > { > > > > > > > Scope (PCI0) > > > > > > > { > > > > > > > Method (_PRT, 0, NotSerialized) // _PRT: PCI > Routing Table > > > > > > > { > > > > > > > Local0 = Package (0x80){} > > > > > > > Local1 = Zero > > > > > > > While ((Local1 < 0x80)) > > > > > > > { > > > > > > > Local2 = (Local1 >> 0x02) > > > > > > > Local3 = ((Local1 + Local2) & 0x03) > > > > > > > If ((Local3 == Zero)) > > > > > > > { > > > > > > > Local4 = Package (0x04) > > > > > > > { > > > > > > > @@ -690,38 +658,32 @@ > > > > > > > Method (_OST, 3, Serialized) // _OST: OSPM > Status Indication > > > > > > > { > > > > > > > COST (Zero, Arg0, Arg1, Arg2) > > > > > > > } > > > > > > > } > > > > > > > } > > > > > > > } > > > > > > > > > > > > > > Method (\_GPE._E02, 0, NotSerialized) // _Exx: > Edge-Triggered GPE > > > > > > > { > > > > > > > \_SB.CPUS.CSCN () > > > > > > > } > > > > > > > > > > > > > > Scope (_GPE) > > > > > > > { > > > > > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // > _HID: Hardware ID > > > > > > > - Method (_E01, 0, NotSerialized) // _Exx: > Edge-Triggered GPE > > > > > > > - { > > > > > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > > > > > > - \_SB.PCI0.PCNT () > > > > > > > - Release (\_SB.PCI0.BLCK) > > > > > > > - } > > > > > > > } > > > > > > > > > > > > > > Scope (\_SB.PCI0) > > > > > > > { > > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current > Resource Settings > > > > > > > { > > > > > > > WordBusNumber (ResourceProducer, MinFixed, > MaxFixed, PosDecode, > > > > > > > 0x0000, // Granularity > > > > > > > 0x0000, // Range Minimum > > > > > > > 0x00FF, // Range Maximum > > > > > > > 0x0000, // Translation Offset > > > > > > > 0x0100, // Length > > > > > > > ,, ) > > > > > > > IO (Decode16, > > > > > > > 0x0CF8, // Range Minimum > > > > > > > 0x0CF8, // Range Maximum > > > > > > > @@ -766,48 +728,32 @@ > > > > > > > }) > > > > > > > Device (GPE0) > > > > > > > { > > > > > > > Name (_HID, "PNP0A06" /* Generic Container Device > */) // _HID: Hardware ID > > > > > > > Name (_UID, "GPE0 resources") // _UID: Unique ID > > > > > > > Name (_STA, 0x0B) // _STA: Status > > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current > Resource Settings > > > > > > > { > > > > > > > IO (Decode16, > > > > > > > 0xAFE0, // Range Minimum > > > > > > > 0xAFE0, // Range Maximum > > > > > > > 0x01, // Alignment > > > > > > > 0x04, // Length > > > > > > > ) > > > > > > > }) > > > > > > > } > > > > > > > - > > > > > > > - Device (PHPR) > > > > > > > - { > > > > > > > - Name (_HID, "PNP0A06" /* Generic Container Device > */) // _HID: Hardware ID > > > > > > > - Name (_UID, "PCI Hotplug resources") // _UID: > Unique ID > > > > > > > - Name (_STA, 0x0B) // _STA: Status > > > > > > > - Name (_CRS, ResourceTemplate () // _CRS: Current > Resource Settings > > > > > > > - { > > > > > > > - IO (Decode16, > > > > > > > - 0xAE00, // Range Minimum > > > > > > > - 0xAE00, // Range Maximum > > > > > > > - 0x01, // Alignment > > > > > > > - 0x14, // Length > > > > > > > - ) > > > > > > > - }) > > > > > > > - } > > > > > > > } > > > > > > > > > > > > > > Scope (\) > > > > > > > { > > > > > > > Name (_S3, Package (0x04) // _S3_: S3 System State > > > > > > > { > > > > > > > One, > > > > > > > One, > > > > > > > Zero, > > > > > > > Zero > > > > > > > }) > > > > > > > Name (_S4, Package (0x04) // _S4_: S4 System State > > > > > > > { > > > > > > > 0x02, > > > > > > > 0x02, > > > > > > > Zero, > > > > > > > @@ -831,479 +777,48 @@ > > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current > Resource Settings > > > > > > > { > > > > > > > IO (Decode16, > > > > > > > 0x0510, // Range Minimum > > > > > > > 0x0510, // Range Maximum > > > > > > > 0x01, // Alignment > > > > > > > 0x0C, // Length > > > > > > > ) > > > > > > > }) > > > > > > > } > > > > > > > } > > > > > > > > > > > > > > Scope (\_SB) > > > > > > > { > > > > > > > Scope (PCI0) > > > > > > > { > > > > > > > - Name (BSEL, Zero) > > > > > > > Device (S00) > > > > > > > { > > > > > > > Name (_ADR, Zero) // _ADR: Address > > > > > > > } > > > > > > > > > > > > > > Device (S10) > > > > > > > { > > > > > > > Name (_ADR, 0x00020000) // _ADR: Address > > > > > > > Method (_S1D, 0, NotSerialized) // _S1D: S1 > Device State > > > > > > > { > > > > > > > Return (Zero) > > > > > > > } > > > > > > > > > > > > > > Method (_S2D, 0, NotSerialized) // _S2D: S2 > Device State > > > > > > > { > > > > > > > Return (Zero) > > > > > > > } > > > > > > > > > > > > > > Method (_S3D, 0, NotSerialized) // _S3D: S3 > Device State > > > > > > > { > > > > > > > Return (Zero) > > > > > > > } > > > > > > > } > > > > > > > > > > > > > > Device (S18) > > > > > > > { > > > > > > > Name (_ADR, 0x00030000) // _ADR: Address > > > > > > > } > > > > > > > - > > > > > > > - Device (S20) > > > > > > > - { > > > > > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x00040000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (S28) > > > > > > > - { > > > > > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x00050000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (S30) > > > > > > > - { > > > > > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x00060000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (S38) > > > > > > > - { > > > > > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x00070000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (S40) > > > > > > > - { > > > > > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x00080000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (S48) > > > > > > > - { > > > > > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x00090000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (S50) > > > > > > > - { > > > > > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (S58) > > > > > > > - { > > > > > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (S60) > > > > > > > - { > > > > > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (S68) > > > > > > > - { > > > > > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (S70) > > > > > > > - { > > > > > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (S78) > > > > > > > - { > > > > > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (S80) > > > > > > > - { > > > > > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x00100000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (S88) > > > > > > > - { > > > > > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x00110000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (S90) > > > > > > > - { > > > > > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x00120000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (S98) > > > > > > > - { > > > > > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x00130000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (SA0) > > > > > > > - { > > > > > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x00140000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (SA8) > > > > > > > - { > > > > > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x00150000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (SB0) > > > > > > > - { > > > > > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x00160000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (SB8) > > > > > > > - { > > > > > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x00170000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (SC0) > > > > > > > - { > > > > > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x00180000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (SC8) > > > > > > > - { > > > > > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x00190000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (SD0) > > > > > > > - { > > > > > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (SD8) > > > > > > > - { > > > > > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (SE0) > > > > > > > - { > > > > > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (SE8) > > > > > > > - { > > > > > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (SF0) > > > > > > > - { > > > > > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Device (SF8) > > > > > > > - { > > > > > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > > > > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device > > > > > > > - { > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Method (DVNT, 2, NotSerialized) > > > > > > > - { > > > > > > > - If ((Arg0 & 0x10)) > > > > > > > - { > > > > > > > - Notify (S20, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x20)) > > > > > > > - { > > > > > > > - Notify (S28, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x40)) > > > > > > > - { > > > > > > > - Notify (S30, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x80)) > > > > > > > - { > > > > > > > - Notify (S38, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x0100)) > > > > > > > - { > > > > > > > - Notify (S40, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x0200)) > > > > > > > - { > > > > > > > - Notify (S48, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x0400)) > > > > > > > - { > > > > > > > - Notify (S50, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x0800)) > > > > > > > - { > > > > > > > - Notify (S58, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x1000)) > > > > > > > - { > > > > > > > - Notify (S60, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x2000)) > > > > > > > - { > > > > > > > - Notify (S68, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x4000)) > > > > > > > - { > > > > > > > - Notify (S70, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x8000)) > > > > > > > - { > > > > > > > - Notify (S78, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x00010000)) > > > > > > > - { > > > > > > > - Notify (S80, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x00020000)) > > > > > > > - { > > > > > > > - Notify (S88, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x00040000)) > > > > > > > - { > > > > > > > - Notify (S90, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x00080000)) > > > > > > > - { > > > > > > > - Notify (S98, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x00100000)) > > > > > > > - { > > > > > > > - Notify (SA0, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x00200000)) > > > > > > > - { > > > > > > > - Notify (SA8, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x00400000)) > > > > > > > - { > > > > > > > - Notify (SB0, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x00800000)) > > > > > > > - { > > > > > > > - Notify (SB8, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x01000000)) > > > > > > > - { > > > > > > > - Notify (SC0, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x02000000)) > > > > > > > - { > > > > > > > - Notify (SC8, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x04000000)) > > > > > > > - { > > > > > > > - Notify (SD0, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x08000000)) > > > > > > > - { > > > > > > > - Notify (SD8, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x10000000)) > > > > > > > - { > > > > > > > - Notify (SE0, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x20000000)) > > > > > > > - { > > > > > > > - Notify (SE8, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x40000000)) > > > > > > > - { > > > > > > > - Notify (SF0, Arg1) > > > > > > > - } > > > > > > > - > > > > > > > - If ((Arg0 & 0x80000000)) > > > > > > > - { > > > > > > > - Notify (SF8, Arg1) > > > > > > > - } > > > > > > > - } > > > > > > > - > > > > > > > - Method (PCNT, 0, NotSerialized) > > > > > > > - { > > > > > > > - BNUM = Zero > > > > > > > - DVNT (PCIU, One) > > > > > > > - DVNT (PCID, 0x03) > > > > > > > - } > > > > > > > } > > > > > > > } > > > > > > > } > > > > > > > > > > > > This is not the only diff I see if I apply this patchset on > > > > > > top of master. > > > > > > Dropped this and the previous patch. > > > > > > Please check what is going on and repost as appropriate. > > > > > > > > > > Which two ACPI DSDT files are you diffing? What diff are you getting? > > > > > > > > > > > > diff -rup ./tests/data/acpi/pc/DSDT.hpbridge.dsl > ./tests/data/acpi/pc/DSDT.hpbrroot.dsl > > > > > > I re-based my patchset on top of the latest qemu master and did a make > > > && make check-qtest-x86_64 V=1. > > > They pass. I am seeing this diff: > > > https://pastebin.ubuntu.com/p/BXy9GFfB2R/ > > > > > > and it looks good to me. > > > > > > Not sure why your diff looks different. Maybe you can regenerate the > blob? > > > > I did a full make check and it passed. I compared the diff again and > > it's the same. I checked my tree and it looks clean. These are the > > patches I have: > > > > $ git log --oneline > > 20d1323e10 (HEAD -> master) qom: code hardening - have bound checking > > while looping with integer value > > 0f69dae0e2 Add a comment in bios-tables-test.c to clarify the reason > > behind approach > > dd9a8c3cd3 tests/acpi: add DSDT.hpbrroot DSDT table blob to test > > global i440fx hotplug > > 5b93474fe9 tests/acpi: unit test exercising global pci hotplug off for > i440fx > > 54c33e334a tests/acpi: update golden master DSDT binary table blobs for q35 > > 2279f61f30 piix4: don't reserve hw resources when hotplug is off globally > > 1f61c524a0 Add ACPI DSDT tables for q35 that are being updated by the next > patch > > bdd823611b tests/acpi: add newly added acpi DSDT table blob for pci > > bridge hotplug flag > > 8c80f8fba9 tests/acpi: unit test for > > 'acpi-pci-hotplug-with-bridge-support' bridge flag > > e0a3142df9 tests/acpi: list added acpi table binary file for pci > > bridge hotplug test > > 0ba08317a8 i440fx/acpi: do not add hotplug related amls for cold plugged > bridges > > 73b191ade6 Fix a gap where acpi_pcihp_find_hotplug_bus() returns a > > non-hotpluggable bus > > ef0e526cc2 tests/acpi: add a new ACPI table in order to test root pci > > hotplug on/off > > c6d13264f8 tests/acpi: add new unit test to test hotplug off/on > > feature on the root pci bus > > 6901bada65 tests/acpi: mark addition of table DSDT.roothp for unit > > testing root pci hotplug > > 74504514b1 (origin/master, origin/HEAD) Merge remote-tracking branch > > 'remotes/alistair/tags/pull-register-20200927' into staging > > > > > > > > > > > > > > > > > > > > > > > --- ./tests/data/acpi/pc/DSDT.hpbridge.dsl 2020-09-29 > 02:44:43.874622404 -0400 > > > > +++ ./tests/data/acpi/pc/DSDT.hpbrroot.dsl 2020-09-29 > 02:44:43.876622403 -0400 > > > > @@ -5,13 +5,13 @@ > > > > * > > > > * Disassembling to symbolic ASL+ operators > > > > * > > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 > 02:44:43 2020 > > > > + * Disassembly of tests/data/acpi/pc/DSDT.hpbrroot, Tue Sep 29 > 02:44:43 2020 > > > > * > > > > * Original Table Header: > > > > * Signature "DSDT" > > > > - * Length 0x0000139D (5021) > > > > + * Length 0x00000B89 (2953) > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math > support > > > > - * Checksum 0x05 > > > > + * Checksum 0xA2 > > > > * OEM ID "BOCHS " > > > > * OEM Table ID "BXPCDSDT" > > > > * OEM Revision 0x00000001 (1) > > > > @@ -247,38 +247,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > } > > > > } > > > > > > > > - Scope (_SB.PCI0) > > > > - { > > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > > > - { > > > > - PCIU, 32, > > > > - PCID, 32 > > > > - } > > > > - > > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > > > - { > > > > - B0EJ, 32 > > > > - } > > > > - > > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > > > - { > > > > - BNUM, 32 > > > > - } > > > > - > > > > - Mutex (BLCK, 0x00) > > > > - Method (PCEJ, 2, NotSerialized) > > > > - { > > > > - Acquire (BLCK, 0xFFFF) > > > > - BNUM = Arg0 > > > > - B0EJ = (One << Arg1) > > > > - Release (BLCK) > > > > - Return (Zero) > > > > - } > > > > - } > > > > - > > > > Scope (_SB) > > > > { > > > > Scope (PCI0) > > > > @@ -643,56 +611,22 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > Method (CSCN, 0, Serialized) > > > > { > > > > Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF) > > > > - Name (CNEW, Package (0xFF){}) > > > > - Local3 = Zero > > > > - Local4 = One > > > > - While ((Local4 == One)) > > > > + Local0 = One > > > > + While ((Local0 == One)) > > > > { > > > > - Local4 = Zero > > > > - Local0 = One > > > > - Local1 = Zero > > > > - While (((Local0 == One) && (Local3 < One))) > > > > + Local0 = Zero > > > > + \_SB.PCI0.PRES.CCMD = Zero > > > > + If ((\_SB.PCI0.PRES.CINS == One)) > > > > { > > > > - Local0 = Zero > > > > - \_SB.PCI0.PRES.CSEL = Local3 > > > > - \_SB.PCI0.PRES.CCMD = Zero > > > > - If ((\_SB.PCI0.PRES.CDAT < Local3)) > > > > - { > > > > - Break > > > > - } > > > > - > > > > - If ((Local1 == 0xFF)) > > > > - { > > > > - Local4 = One > > > > - Break > > > > - } > > > > - > > > > - Local3 = \_SB.PCI0.PRES.CDAT > > > > - If ((\_SB.PCI0.PRES.CINS == One)) > > > > - { > > > > - CNEW [Local1] = Local3 > > > > - Local1++ > > > > - Local0 = One > > > > - } > > > > - ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > > > > - { > > > > - CTFY (Local3, 0x03) > > > > - \_SB.PCI0.PRES.CRMV = One > > > > - Local0 = One > > > > - } > > > > - > > > > - Local3++ > > > > + CTFY (\_SB.PCI0.PRES.CDAT, One) > > > > + \_SB.PCI0.PRES.CINS = One > > > > + Local0 = One > > > > } > > > > - > > > > - Local2 = Zero > > > > - While ((Local2 < Local1)) > > > > + ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > > > > { > > > > - Local3 = DerefOf (CNEW [Local2]) > > > > - CTFY (Local3, One) > > > > - Debug = Local3 > > > > - \_SB.PCI0.PRES.CSEL = Local3 > > > > - \_SB.PCI0.PRES.CINS = One > > > > - Local2++ > > > > + CTFY (\_SB.PCI0.PRES.CDAT, 0x03) > > > > + \_SB.PCI0.PRES.CRMV = One > > > > + Local0 = One > > > > } > > > > } > > > > > > > > @@ -737,12 +671,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > Scope (_GPE) > > > > { > > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: > Hardware ID > > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE, > xx=0x00-0xFF > > > > - { > > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > > > - \_SB.PCI0.PCNT () > > > > - Release (\_SB.PCI0.BLCK) > > > > - } > > > > } > > > > > > > > Scope (\_SB.PCI0) > > > > @@ -813,22 +741,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > ) > > > > }) > > > > } > > > > - > > > > - Device (PHPR) > > > > - { > > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // > _HID: Hardware ID > > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > > > - Name (_STA, 0x0B) // _STA: Status > > > > - Name (_CRS, ResourceTemplate () // _CRS: Current > Resource Settings > > > > - { > > > > - IO (Decode16, > > > > - 0xAE00, // Range Minimum > > > > - 0xAE00, // Range Maximum > > > > - 0x01, // Alignment > > > > - 0x14, // Length > > > > - ) > > > > - }) > > > > - } > > > > } > > > > > > > > Scope (\) > > > > @@ -878,7 +790,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > { > > > > Scope (PCI0) > > > > { > > > > - Name (BSEL, Zero) > > > > Device (S00) > > > > { > > > > Name (_ADR, Zero) // _ADR: Address > > > > @@ -907,436 +818,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > { > > > > Name (_ADR, 0x00030000) // _ADR: Address > > > > } > > > > - > > > > - Device (S20) > > > > - { > > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00040000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S28) > > > > - { > > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00050000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S30) > > > > - { > > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00060000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S38) > > > > - { > > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00070000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S40) > > > > - { > > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00080000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S48) > > > > - { > > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00090000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S50) > > > > - { > > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S58) > > > > - { > > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S60) > > > > - { > > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S68) > > > > - { > > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S70) > > > > - { > > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S78) > > > > - { > > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S80) > > > > - { > > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00100000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S88) > > > > - { > > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00110000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S90) > > > > - { > > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00120000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (S98) > > > > - { > > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00130000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SA0) > > > > - { > > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00140000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SA8) > > > > - { > > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00150000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SB0) > > > > - { > > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00160000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SB8) > > > > - { > > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00170000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SC0) > > > > - { > > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00180000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SC8) > > > > - { > > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > > > - Name (_ADR, 0x00190000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SD0) > > > > - { > > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SD8) > > > > - { > > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SE0) > > > > - { > > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SE8) > > > > - { > > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SF0) > > > > - { > > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Device (SF8) > > > > - { > > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > - { > > > > - PCEJ (BSEL, _SUN) > > > > - } > > > > - } > > > > - > > > > - Method (DVNT, 2, NotSerialized) > > > > - { > > > > - If ((Arg0 & 0x10)) > > > > - { > > > > - Notify (S20, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x20)) > > > > - { > > > > - Notify (S28, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x40)) > > > > - { > > > > - Notify (S30, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x80)) > > > > - { > > > > - Notify (S38, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x0100)) > > > > - { > > > > - Notify (S40, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x0200)) > > > > - { > > > > - Notify (S48, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x0400)) > > > > - { > > > > - Notify (S50, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x0800)) > > > > - { > > > > - Notify (S58, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x1000)) > > > > - { > > > > - Notify (S60, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x2000)) > > > > - { > > > > - Notify (S68, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x4000)) > > > > - { > > > > - Notify (S70, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x8000)) > > > > - { > > > > - Notify (S78, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x00010000)) > > > > - { > > > > - Notify (S80, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x00020000)) > > > > - { > > > > - Notify (S88, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x00040000)) > > > > - { > > > > - Notify (S90, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x00080000)) > > > > - { > > > > - Notify (S98, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x00100000)) > > > > - { > > > > - Notify (SA0, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x00200000)) > > > > - { > > > > - Notify (SA8, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x00400000)) > > > > - { > > > > - Notify (SB0, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x00800000)) > > > > - { > > > > - Notify (SB8, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x01000000)) > > > > - { > > > > - Notify (SC0, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x02000000)) > > > > - { > > > > - Notify (SC8, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x04000000)) > > > > - { > > > > - Notify (SD0, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x08000000)) > > > > - { > > > > - Notify (SD8, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x10000000)) > > > > - { > > > > - Notify (SE0, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x20000000)) > > > > - { > > > > - Notify (SE8, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x40000000)) > > > > - { > > > > - Notify (SF0, Arg1) > > > > - } > > > > - > > > > - If ((Arg0 & 0x80000000)) > > > > - { > > > > - Notify (SF8, Arg1) > > > > - } > > > > - } > > > > - > > > > - Method (PCNT, 0, NotSerialized) > > > > - { > > > > - BNUM = Zero > > > > - DVNT (PCIU, One) > > > > - DVNT (PCID, 0x03) > > > > - } > > > > } > > > > } > > > > } > > > > > > <div dir="auto">Maybe you can give me access to your workspace aane I can take a look.</div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Sep 29, 2020 at 2:21 PM Ani Sinha <<a href="mailto:ani@anisinha.ca">ani@anisinha.ca</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">On Tue, Sep 29, 2020 at 1:53 PM Ani Sinha <<a href="mailto:ani@anisinha.ca" target="_blank">ani@anisinha.ca</a>> wrote:<br><br>><br><br>> On Tue, Sep 29, 2020 at 12:56 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>> wrote:<br><br>> ><br><br>> > On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote:<br><br>> > > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>> wrote:<br><br>> > > ><br><br>> > > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote:<br><br>> > > > > This change adds a new DSDT golden master table blob to test disabling<br><br>> > > > > hotplug on both pci root bus and pci bridges. Also reverts the change<br><br>> > > > > in file bios-tables-test-allowed-diff.h to make sure its now empty so that<br><br>> > > > > future modifications to acpi tables can be caught.<br><br>> > > > ><br><br>> > > > > The following is the disassembled diff between DSDT.hpbridge and DSDT.hpbrroot:<br><br>> > > > ><br><br>> > > > > @@ -1,30 +1,30 @@<br><br>> > > > > /*<br><br>> > > > > * Intel ACPI Component Architecture<br><br>> > > > > * AML/ASL+ Disassembler version 20180105 (64-bit version)<br><br>> > > > > * Copyright (c) 2000 - 2018 Intel Corporation<br><br>> > > > > *<br><br>> > > > > * Disassembling to symbolic ASL+ operators<br><br>> > > > > *<br><br>> > > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Wed Sep 16 09:45:56 2020<br><br>> > > > > + * Disassembly of /tmp/aml-ECV9Q0, Wed Sep 16 09:45:56 2020<br><br>> > > > > *<br><br>> > > > > * Original Table Header:<br><br>> > > > > * Signature "DSDT"<br><br>> > > > > - * Length 0x0000131F (4895)<br><br>> > > > > + * Length 0x00000B89 (2953)<br><br>> > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support<br><br>> > > > > - * Checksum 0xF9<br><br>> > > > > + * Checksum 0xA2<br><br>> > > > > * OEM ID "BOCHS "<br><br>> > > > > * OEM Table ID "BXPCDSDT"<br><br>> > > > > * OEM Revision 0x00000001 (1)<br><br>> > > > > * Compiler ID "BXPC"<br><br>> > > > > * Compiler Version 0x00000001 (1)<br><br>> > > > > */<br><br>> > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001)<br><br>> > > > > {<br><br>> > > > > Scope (\)<br><br>> > > > > {<br><br>> > > > > OperationRegion (DBG, SystemIO, 0x0402, One)<br><br>> > > > > Field (DBG, ByteAcc, NoLock, Preserve)<br><br>> > > > > {<br><br>> > > > > DBGB, 8<br><br>> > > > > }<br><br>> > > > ><br><br>> > > > > @@ -234,64 +234,32 @@<br><br>> > > > > {<br><br>> > > > > Name (_HID, EisaId ("PNP0B00") /* AT Real-Time Clock */) // _HID: Hardware ID<br><br>> > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings<br><br>> > > > > {<br><br>> > > > > IO (Decode16,<br><br>> > > > > 0x0070, // Range Minimum<br><br>> > > > > 0x0070, // Range Maximum<br><br>> > > > > 0x01, // Alignment<br><br>> > > > > 0x08, // Length<br><br>> > > > > )<br><br>> > > > > IRQNoFlags ()<br><br>> > > > > {8}<br><br>> > > > > })<br><br>> > > > > }<br><br>> > > > > }<br><br>> > > > ><br><br>> > > > > - Scope (_SB.PCI0)<br><br>> > > > > - {<br><br>> > > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08)<br><br>> > > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros)<br><br>> > > > > - {<br><br>> > > > > - PCIU, 32,<br><br>> > > > > - PCID, 32<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04)<br><br>> > > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros)<br><br>> > > > > - {<br><br>> > > > > - B0EJ, 32<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04)<br><br>> > > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros)<br><br>> > > > > - {<br><br>> > > > > - BNUM, 32<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Mutex (BLCK, 0x00)<br><br>> > > > > - Method (PCEJ, 2, NotSerialized)<br><br>> > > > > - {<br><br>> > > > > - Acquire (BLCK, 0xFFFF)<br><br>> > > > > - BNUM = Arg0<br><br>> > > > > - B0EJ = (One << Arg1)<br><br>> > > > > - Release (BLCK)<br><br>> > > > > - Return (Zero)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > Scope (_SB)<br><br>> > > > > {<br><br>> > > > > Scope (PCI0)<br><br>> > > > > {<br><br>> > > > > Method (_PRT, 0, NotSerialized) // _PRT: PCI Routing Table<br><br>> > > > > {<br><br>> > > > > Local0 = Package (0x80){}<br><br>> > > > > Local1 = Zero<br><br>> > > > > While ((Local1 < 0x80))<br><br>> > > > > {<br><br>> > > > > Local2 = (Local1 >> 0x02)<br><br>> > > > > Local3 = ((Local1 + Local2) & 0x03)<br><br>> > > > > If ((Local3 == Zero))<br><br>> > > > > {<br><br>> > > > > Local4 = Package (0x04)<br><br>> > > > > {<br><br>> > > > > @@ -690,38 +658,32 @@<br><br>> > > > > Method (_OST, 3, Serialized) // _OST: OSPM Status Indication<br><br>> > > > > {<br><br>> > > > > COST (Zero, Arg0, Arg1, Arg2)<br><br>> > > > > }<br><br>> > > > > }<br><br>> > > > > }<br><br>> > > > > }<br><br>> > > > ><br><br>> > > > > Method (\_GPE._E02, 0, NotSerialized) // _Exx: Edge-Triggered GPE<br><br>> > > > > {<br><br>> > > > > \_SB.CPUS.CSCN ()<br><br>> > > > > }<br><br>> > > > ><br><br>> > > > > Scope (_GPE)<br><br>> > > > > {<br><br>> > > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID<br><br>> > > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE<br><br>> > > > > - {<br><br>> > > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF)<br><br>> > > > > - \_SB.PCI0.PCNT ()<br><br>> > > > > - Release (\_SB.PCI0.BLCK)<br><br>> > > > > - }<br><br>> > > > > }<br><br>> > > > ><br><br>> > > > > Scope (\_SB.PCI0)<br><br>> > > > > {<br><br>> > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings<br><br>> > > > > {<br><br>> > > > > WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,<br><br>> > > > > 0x0000, // Granularity<br><br>> > > > > 0x0000, // Range Minimum<br><br>> > > > > 0x00FF, // Range Maximum<br><br>> > > > > 0x0000, // Translation Offset<br><br>> > > > > 0x0100, // Length<br><br>> > > > > ,, )<br><br>> > > > > IO (Decode16,<br><br>> > > > > 0x0CF8, // Range Minimum<br><br>> > > > > 0x0CF8, // Range Maximum<br><br>> > > > > @@ -766,48 +728,32 @@<br><br>> > > > > })<br><br>> > > > > Device (GPE0)<br><br>> > > > > {<br><br>> > > > > Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID<br><br>> > > > > Name (_UID, "GPE0 resources") // _UID: Unique ID<br><br>> > > > > Name (_STA, 0x0B) // _STA: Status<br><br>> > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings<br><br>> > > > > {<br><br>> > > > > IO (Decode16,<br><br>> > > > > 0xAFE0, // Range Minimum<br><br>> > > > > 0xAFE0, // Range Maximum<br><br>> > > > > 0x01, // Alignment<br><br>> > > > > 0x04, // Length<br><br>> > > > > )<br><br>> > > > > })<br><br>> > > > > }<br><br>> > > > > -<br><br>> > > > > - Device (PHPR)<br><br>> > > > > - {<br><br>> > > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID<br><br>> > > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID<br><br>> > > > > - Name (_STA, 0x0B) // _STA: Status<br><br>> > > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings<br><br>> > > > > - {<br><br>> > > > > - IO (Decode16,<br><br>> > > > > - 0xAE00, // Range Minimum<br><br>> > > > > - 0xAE00, // Range Maximum<br><br>> > > > > - 0x01, // Alignment<br><br>> > > > > - 0x14, // Length<br><br>> > > > > - )<br><br>> > > > > - })<br><br>> > > > > - }<br><br>> > > > > }<br><br>> > > > ><br><br>> > > > > Scope (\)<br><br>> > > > > {<br><br>> > > > > Name (_S3, Package (0x04) // _S3_: S3 System State<br><br>> > > > > {<br><br>> > > > > One,<br><br>> > > > > One,<br><br>> > > > > Zero,<br><br>> > > > > Zero<br><br>> > > > > })<br><br>> > > > > Name (_S4, Package (0x04) // _S4_: S4 System State<br><br>> > > > > {<br><br>> > > > > 0x02,<br><br>> > > > > 0x02,<br><br>> > > > > Zero,<br><br>> > > > > @@ -831,479 +777,48 @@<br><br>> > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings<br><br>> > > > > {<br><br>> > > > > IO (Decode16,<br><br>> > > > > 0x0510, // Range Minimum<br><br>> > > > > 0x0510, // Range Maximum<br><br>> > > > > 0x01, // Alignment<br><br>> > > > > 0x0C, // Length<br><br>> > > > > )<br><br>> > > > > })<br><br>> > > > > }<br><br>> > > > > }<br><br>> > > > ><br><br>> > > > > Scope (\_SB)<br><br>> > > > > {<br><br>> > > > > Scope (PCI0)<br><br>> > > > > {<br><br>> > > > > - Name (BSEL, Zero)<br><br>> > > > > Device (S00)<br><br>> > > > > {<br><br>> > > > > Name (_ADR, Zero) // _ADR: Address<br><br>> > > > > }<br><br>> > > > ><br><br>> > > > > Device (S10)<br><br>> > > > > {<br><br>> > > > > Name (_ADR, 0x00020000) // _ADR: Address<br><br>> > > > > Method (_S1D, 0, NotSerialized) // _S1D: S1 Device State<br><br>> > > > > {<br><br>> > > > > Return (Zero)<br><br>> > > > > }<br><br>> > > > ><br><br>> > > > > Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State<br><br>> > > > > {<br><br>> > > > > Return (Zero)<br><br>> > > > > }<br><br>> > > > ><br><br>> > > > > Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State<br><br>> > > > > {<br><br>> > > > > Return (Zero)<br><br>> > > > > }<br><br>> > > > > }<br><br>> > > > ><br><br>> > > > > Device (S18)<br><br>> > > > > {<br><br>> > > > > Name (_ADR, 0x00030000) // _ADR: Address<br><br>> > > > > }<br><br>> > > > > -<br><br>> > > > > - Device (S20)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x04) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x00040000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (S28)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x05) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x00050000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (S30)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x06) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x00060000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (S38)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x07) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x00070000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (S40)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x08) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x00080000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (S48)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x09) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x00090000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (S50)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x000A0000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (S58)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x000B0000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (S60)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x000C0000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (S68)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x000D0000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (S70)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x000E0000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (S78)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x000F0000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (S80)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x10) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x00100000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (S88)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x11) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x00110000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (S90)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x12) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x00120000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (S98)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x13) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x00130000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (SA0)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x14) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x00140000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (SA8)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x15) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x00150000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (SB0)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x16) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x00160000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (SB8)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x17) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x00170000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (SC0)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x18) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x00180000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (SC8)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x19) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x00190000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (SD0)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x001A0000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (SD8)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x001B0000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (SE0)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x001C0000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (SE8)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x001D0000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (SF0)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x001E0000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Device (SF8)<br><br>> > > > > - {<br><br>> > > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number<br><br>> > > > > - Name (_ADR, 0x001F0000) // _ADR: Address<br><br>> > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > - {<br><br>> > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Method (DVNT, 2, NotSerialized)<br><br>> > > > > - {<br><br>> > > > > - If ((Arg0 & 0x10))<br><br>> > > > > - {<br><br>> > > > > - Notify (S20, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x20))<br><br>> > > > > - {<br><br>> > > > > - Notify (S28, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x40))<br><br>> > > > > - {<br><br>> > > > > - Notify (S30, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x80))<br><br>> > > > > - {<br><br>> > > > > - Notify (S38, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x0100))<br><br>> > > > > - {<br><br>> > > > > - Notify (S40, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x0200))<br><br>> > > > > - {<br><br>> > > > > - Notify (S48, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x0400))<br><br>> > > > > - {<br><br>> > > > > - Notify (S50, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x0800))<br><br>> > > > > - {<br><br>> > > > > - Notify (S58, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x1000))<br><br>> > > > > - {<br><br>> > > > > - Notify (S60, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x2000))<br><br>> > > > > - {<br><br>> > > > > - Notify (S68, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x4000))<br><br>> > > > > - {<br><br>> > > > > - Notify (S70, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x8000))<br><br>> > > > > - {<br><br>> > > > > - Notify (S78, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x00010000))<br><br>> > > > > - {<br><br>> > > > > - Notify (S80, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x00020000))<br><br>> > > > > - {<br><br>> > > > > - Notify (S88, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x00040000))<br><br>> > > > > - {<br><br>> > > > > - Notify (S90, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x00080000))<br><br>> > > > > - {<br><br>> > > > > - Notify (S98, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x00100000))<br><br>> > > > > - {<br><br>> > > > > - Notify (SA0, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x00200000))<br><br>> > > > > - {<br><br>> > > > > - Notify (SA8, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x00400000))<br><br>> > > > > - {<br><br>> > > > > - Notify (SB0, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x00800000))<br><br>> > > > > - {<br><br>> > > > > - Notify (SB8, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x01000000))<br><br>> > > > > - {<br><br>> > > > > - Notify (SC0, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x02000000))<br><br>> > > > > - {<br><br>> > > > > - Notify (SC8, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x04000000))<br><br>> > > > > - {<br><br>> > > > > - Notify (SD0, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x08000000))<br><br>> > > > > - {<br><br>> > > > > - Notify (SD8, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x10000000))<br><br>> > > > > - {<br><br>> > > > > - Notify (SE0, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x20000000))<br><br>> > > > > - {<br><br>> > > > > - Notify (SE8, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x40000000))<br><br>> > > > > - {<br><br>> > > > > - Notify (SF0, Arg1)<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - If ((Arg0 & 0x80000000))<br><br>> > > > > - {<br><br>> > > > > - Notify (SF8, Arg1)<br><br>> > > > > - }<br><br>> > > > > - }<br><br>> > > > > -<br><br>> > > > > - Method (PCNT, 0, NotSerialized)<br><br>> > > > > - {<br><br>> > > > > - BNUM = Zero<br><br>> > > > > - DVNT (PCIU, One)<br><br>> > > > > - DVNT (PCID, 0x03)<br><br>> > > > > - }<br><br>> > > > > }<br><br>> > > > > }<br><br>> > > > > }<br><br>> > > ><br><br>> > > > This is not the only diff I see if I apply this patchset on<br><br>> > > > top of master.<br><br>> > > > Dropped this and the previous patch.<br><br>> > > > Please check what is going on and repost as appropriate.<br><br>> > ><br><br>> > > Which two ACPI DSDT files are you diffing? What diff are you getting?<br><br>> ><br><br>> ><br><br>> > diff -rup ./tests/data/acpi/pc/DSDT.hpbridge.dsl ./tests/data/acpi/pc/DSDT.hpbrroot.dsl<br><br>><br><br>> I re-based my patchset on top of the latest qemu master and did a make<br><br>> && make check-qtest-x86_64 V=1.<br><br>> They pass. I am seeing this diff:<br><br>> <a href="https://pastebin.ubuntu.com/p/BXy9GFfB2R/" rel="noreferrer" target="_blank">https://pastebin.ubuntu.com/p/BXy9GFfB2R/</a><br><br>><br><br>> and it looks good to me.<br><br>><br><br>> Not sure why your diff looks different. Maybe you can regenerate the blob?<br><br><br><br>I did a full make check and it passed. I compared the diff again and<br><br>it's the same. I checked my tree and it looks clean. These are the<br><br>patches I have:<br><br><br><br>$ git log --oneline<br><br>20d1323e10 (HEAD -> master) qom: code hardening - have bound checking<br><br>while looping with integer value<br><br>0f69dae0e2 Add a comment in bios-tables-test.c to clarify the reason<br><br>behind approach<br><br>dd9a8c3cd3 tests/acpi: add DSDT.hpbrroot DSDT table blob to test<br><br>global i440fx hotplug<br><br>5b93474fe9 tests/acpi: unit test exercising global pci hotplug off for i440fx<br><br>54c33e334a tests/acpi: update golden master DSDT binary table blobs for q35<br><br>2279f61f30 piix4: don't reserve hw resources when hotplug is off globally<br><br>1f61c524a0 Add ACPI DSDT tables for q35 that are being updated by the next patch<br><br>bdd823611b tests/acpi: add newly added acpi DSDT table blob for pci<br><br>bridge hotplug flag<br><br>8c80f8fba9 tests/acpi: unit test for<br><br>'acpi-pci-hotplug-with-bridge-support' bridge flag<br><br>e0a3142df9 tests/acpi: list added acpi table binary file for pci<br><br>bridge hotplug test<br><br>0ba08317a8 i440fx/acpi: do not add hotplug related amls for cold plugged bridges<br><br>73b191ade6 Fix a gap where acpi_pcihp_find_hotplug_bus() returns a<br><br>non-hotpluggable bus<br><br>ef0e526cc2 tests/acpi: add a new ACPI table in order to test root pci<br><br>hotplug on/off<br><br>c6d13264f8 tests/acpi: add new unit test to test hotplug off/on<br><br>feature on the root pci bus<br><br>6901bada65 tests/acpi: mark addition of table DSDT.roothp for unit<br><br>testing root pci hotplug<br><br>74504514b1 (origin/master, origin/HEAD) Merge remote-tracking branch<br><br>'remotes/alistair/tags/pull-register-20200927' into staging<br><br><br><br><br><br>><br><br>> ><br><br>> ><br><br>> ><br><br>> > --- ./tests/data/acpi/pc/DSDT.hpbridge.dsl 2020-09-29 02:44:43.874622404 -0400<br><br>> > +++ ./tests/data/acpi/pc/DSDT.hpbrroot.dsl 2020-09-29 02:44:43.876622403 -0400<br><br>> > @@ -5,13 +5,13 @@<br><br>> > *<br><br>> > * Disassembling to symbolic ASL+ operators<br><br>> > *<br><br>> > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 02:44:43 2020<br><br>> > + * Disassembly of tests/data/acpi/pc/DSDT.hpbrroot, Tue Sep 29 02:44:43 2020<br><br>> > *<br><br>> > * Original Table Header:<br><br>> > * Signature "DSDT"<br><br>> > - * Length 0x0000139D (5021)<br><br>> > + * Length 0x00000B89 (2953)<br><br>> > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support<br><br>> > - * Checksum 0x05<br><br>> > + * Checksum 0xA2<br><br>> > * OEM ID "BOCHS "<br><br>> > * OEM Table ID "BXPCDSDT"<br><br>> > * OEM Revision 0x00000001 (1)<br><br>> > @@ -247,38 +247,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "<br><br>> > }<br><br>> > }<br><br>> ><br><br>> > - Scope (_SB.PCI0)<br><br>> > - {<br><br>> > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08)<br><br>> > - Field (PCST, DWordAcc, NoLock, WriteAsZeros)<br><br>> > - {<br><br>> > - PCIU, 32,<br><br>> > - PCID, 32<br><br>> > - }<br><br>> > -<br><br>> > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04)<br><br>> > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros)<br><br>> > - {<br><br>> > - B0EJ, 32<br><br>> > - }<br><br>> > -<br><br>> > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04)<br><br>> > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros)<br><br>> > - {<br><br>> > - BNUM, 32<br><br>> > - }<br><br>> > -<br><br>> > - Mutex (BLCK, 0x00)<br><br>> > - Method (PCEJ, 2, NotSerialized)<br><br>> > - {<br><br>> > - Acquire (BLCK, 0xFFFF)<br><br>> > - BNUM = Arg0<br><br>> > - B0EJ = (One << Arg1)<br><br>> > - Release (BLCK)<br><br>> > - Return (Zero)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > Scope (_SB)<br><br>> > {<br><br>> > Scope (PCI0)<br><br>> > @@ -643,56 +611,22 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "<br><br>> > Method (CSCN, 0, Serialized)<br><br>> > {<br><br>> > Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF)<br><br>> > - Name (CNEW, Package (0xFF){})<br><br>> > - Local3 = Zero<br><br>> > - Local4 = One<br><br>> > - While ((Local4 == One))<br><br>> > + Local0 = One<br><br>> > + While ((Local0 == One))<br><br>> > {<br><br>> > - Local4 = Zero<br><br>> > - Local0 = One<br><br>> > - Local1 = Zero<br><br>> > - While (((Local0 == One) && (Local3 < One)))<br><br>> > + Local0 = Zero<br><br>> > + \_SB.PCI0.PRES.CCMD = Zero<br><br>> > + If ((\_SB.PCI0.PRES.CINS == One))<br><br>> > {<br><br>> > - Local0 = Zero<br><br>> > - \_SB.PCI0.PRES.CSEL = Local3<br><br>> > - \_SB.PCI0.PRES.CCMD = Zero<br><br>> > - If ((\_SB.PCI0.PRES.CDAT < Local3))<br><br>> > - {<br><br>> > - Break<br><br>> > - }<br><br>> > -<br><br>> > - If ((Local1 == 0xFF))<br><br>> > - {<br><br>> > - Local4 = One<br><br>> > - Break<br><br>> > - }<br><br>> > -<br><br>> > - Local3 = \_SB.PCI0.PRES.CDAT<br><br>> > - If ((\_SB.PCI0.PRES.CINS == One))<br><br>> > - {<br><br>> > - CNEW [Local1] = Local3<br><br>> > - Local1++<br><br>> > - Local0 = One<br><br>> > - }<br><br>> > - ElseIf ((\_SB.PCI0.PRES.CRMV == One))<br><br>> > - {<br><br>> > - CTFY (Local3, 0x03)<br><br>> > - \_SB.PCI0.PRES.CRMV = One<br><br>> > - Local0 = One<br><br>> > - }<br><br>> > -<br><br>> > - Local3++<br><br>> > + CTFY (\_SB.PCI0.PRES.CDAT, One)<br><br>> > + \_SB.PCI0.PRES.CINS = One<br><br>> > + Local0 = One<br><br>> > }<br><br>> > -<br><br>> > - Local2 = Zero<br><br>> > - While ((Local2 < Local1))<br><br>> > + ElseIf ((\_SB.PCI0.PRES.CRMV == One))<br><br>> > {<br><br>> > - Local3 = DerefOf (CNEW [Local2])<br><br>> > - CTFY (Local3, One)<br><br>> > - Debug = Local3<br><br>> > - \_SB.PCI0.PRES.CSEL = Local3<br><br>> > - \_SB.PCI0.PRES.CINS = One<br><br>> > - Local2++<br><br>> > + CTFY (\_SB.PCI0.PRES.CDAT, 0x03)<br><br>> > + \_SB.PCI0.PRES.CRMV = One<br><br>> > + Local0 = One<br><br>> > }<br><br>> > }<br><br>> ><br><br>> > @@ -737,12 +671,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "<br><br>> > Scope (_GPE)<br><br>> > {<br><br>> > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID<br><br>> > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE, xx=0x00-0xFF<br><br>> > - {<br><br>> > - Acquire (\_SB.PCI0.BLCK, 0xFFFF)<br><br>> > - \_SB.PCI0.PCNT ()<br><br>> > - Release (\_SB.PCI0.BLCK)<br><br>> > - }<br><br>> > }<br><br>> ><br><br>> > Scope (\_SB.PCI0)<br><br>> > @@ -813,22 +741,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "<br><br>> > )<br><br>> > })<br><br>> > }<br><br>> > -<br><br>> > - Device (PHPR)<br><br>> > - {<br><br>> > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID<br><br>> > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID<br><br>> > - Name (_STA, 0x0B) // _STA: Status<br><br>> > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings<br><br>> > - {<br><br>> > - IO (Decode16,<br><br>> > - 0xAE00, // Range Minimum<br><br>> > - 0xAE00, // Range Maximum<br><br>> > - 0x01, // Alignment<br><br>> > - 0x14, // Length<br><br>> > - )<br><br>> > - })<br><br>> > - }<br><br>> > }<br><br>> ><br><br>> > Scope (\)<br><br>> > @@ -878,7 +790,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "<br><br>> > {<br><br>> > Scope (PCI0)<br><br>> > {<br><br>> > - Name (BSEL, Zero)<br><br>> > Device (S00)<br><br>> > {<br><br>> > Name (_ADR, Zero) // _ADR: Address<br><br>> > @@ -907,436 +818,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "<br><br>> > {<br><br>> > Name (_ADR, 0x00030000) // _ADR: Address<br><br>> > }<br><br>> > -<br><br>> > - Device (S20)<br><br>> > - {<br><br>> > - Name (_SUN, 0x04) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x00040000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (S28)<br><br>> > - {<br><br>> > - Name (_SUN, 0x05) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x00050000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (S30)<br><br>> > - {<br><br>> > - Name (_SUN, 0x06) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x00060000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (S38)<br><br>> > - {<br><br>> > - Name (_SUN, 0x07) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x00070000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (S40)<br><br>> > - {<br><br>> > - Name (_SUN, 0x08) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x00080000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (S48)<br><br>> > - {<br><br>> > - Name (_SUN, 0x09) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x00090000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (S50)<br><br>> > - {<br><br>> > - Name (_SUN, 0x0A) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x000A0000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (S58)<br><br>> > - {<br><br>> > - Name (_SUN, 0x0B) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x000B0000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (S60)<br><br>> > - {<br><br>> > - Name (_SUN, 0x0C) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x000C0000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (S68)<br><br>> > - {<br><br>> > - Name (_SUN, 0x0D) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x000D0000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (S70)<br><br>> > - {<br><br>> > - Name (_SUN, 0x0E) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x000E0000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (S78)<br><br>> > - {<br><br>> > - Name (_SUN, 0x0F) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x000F0000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (S80)<br><br>> > - {<br><br>> > - Name (_SUN, 0x10) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x00100000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (S88)<br><br>> > - {<br><br>> > - Name (_SUN, 0x11) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x00110000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (S90)<br><br>> > - {<br><br>> > - Name (_SUN, 0x12) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x00120000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (S98)<br><br>> > - {<br><br>> > - Name (_SUN, 0x13) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x00130000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (SA0)<br><br>> > - {<br><br>> > - Name (_SUN, 0x14) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x00140000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (SA8)<br><br>> > - {<br><br>> > - Name (_SUN, 0x15) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x00150000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (SB0)<br><br>> > - {<br><br>> > - Name (_SUN, 0x16) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x00160000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (SB8)<br><br>> > - {<br><br>> > - Name (_SUN, 0x17) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x00170000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (SC0)<br><br>> > - {<br><br>> > - Name (_SUN, 0x18) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x00180000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (SC8)<br><br>> > - {<br><br>> > - Name (_SUN, 0x19) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x00190000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (SD0)<br><br>> > - {<br><br>> > - Name (_SUN, 0x1A) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x001A0000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (SD8)<br><br>> > - {<br><br>> > - Name (_SUN, 0x1B) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x001B0000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (SE0)<br><br>> > - {<br><br>> > - Name (_SUN, 0x1C) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x001C0000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (SE8)<br><br>> > - {<br><br>> > - Name (_SUN, 0x1D) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x001D0000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (SF0)<br><br>> > - {<br><br>> > - Name (_SUN, 0x1E) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x001E0000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Device (SF8)<br><br>> > - {<br><br>> > - Name (_SUN, 0x1F) // _SUN: Slot User Number<br><br>> > - Name (_ADR, 0x001F0000) // _ADR: Address<br><br>> > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > - {<br><br>> > - PCEJ (BSEL, _SUN)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Method (DVNT, 2, NotSerialized)<br><br>> > - {<br><br>> > - If ((Arg0 & 0x10))<br><br>> > - {<br><br>> > - Notify (S20, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x20))<br><br>> > - {<br><br>> > - Notify (S28, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x40))<br><br>> > - {<br><br>> > - Notify (S30, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x80))<br><br>> > - {<br><br>> > - Notify (S38, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x0100))<br><br>> > - {<br><br>> > - Notify (S40, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x0200))<br><br>> > - {<br><br>> > - Notify (S48, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x0400))<br><br>> > - {<br><br>> > - Notify (S50, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x0800))<br><br>> > - {<br><br>> > - Notify (S58, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x1000))<br><br>> > - {<br><br>> > - Notify (S60, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x2000))<br><br>> > - {<br><br>> > - Notify (S68, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x4000))<br><br>> > - {<br><br>> > - Notify (S70, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x8000))<br><br>> > - {<br><br>> > - Notify (S78, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x00010000))<br><br>> > - {<br><br>> > - Notify (S80, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x00020000))<br><br>> > - {<br><br>> > - Notify (S88, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x00040000))<br><br>> > - {<br><br>> > - Notify (S90, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x00080000))<br><br>> > - {<br><br>> > - Notify (S98, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x00100000))<br><br>> > - {<br><br>> > - Notify (SA0, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x00200000))<br><br>> > - {<br><br>> > - Notify (SA8, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x00400000))<br><br>> > - {<br><br>> > - Notify (SB0, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x00800000))<br><br>> > - {<br><br>> > - Notify (SB8, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x01000000))<br><br>> > - {<br><br>> > - Notify (SC0, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x02000000))<br><br>> > - {<br><br>> > - Notify (SC8, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x04000000))<br><br>> > - {<br><br>> > - Notify (SD0, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x08000000))<br><br>> > - {<br><br>> > - Notify (SD8, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x10000000))<br><br>> > - {<br><br>> > - Notify (SE0, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x20000000))<br><br>> > - {<br><br>> > - Notify (SE8, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x40000000))<br><br>> > - {<br><br>> > - Notify (SF0, Arg1)<br><br>> > - }<br><br>> > -<br><br>> > - If ((Arg0 & 0x80000000))<br><br>> > - {<br><br>> > - Notify (SF8, Arg1)<br><br>> > - }<br><br>> > - }<br><br>> > -<br><br>> > - Method (PCNT, 0, NotSerialized)<br><br>> > - {<br><br>> > - BNUM = Zero<br><br>> > - DVNT (PCIU, One)<br><br>> > - DVNT (PCID, 0x03)<br><br>> > - }<br><br>> > }<br><br>> > }<br><br>> > }<br><br>> ><br><br></blockquote></div></div>
On Tue, Sep 29, 2020 at 02:21:06PM +0530, Ani Sinha wrote: > On Tue, Sep 29, 2020 at 1:53 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > On Tue, Sep 29, 2020 at 12:56 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote: > > > > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > > > > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote: > > > > > > This change adds a new DSDT golden master table blob to test disabling > > > > > > hotplug on both pci root bus and pci bridges. Also reverts the change > > > > > > in file bios-tables-test-allowed-diff.h to make sure its now empty so that > > > > > > future modifications to acpi tables can be caught. > > > > > > > > > > > > The following is the disassembled diff between DSDT.hpbridge and DSDT.hpbrroot: > > > > > > > > > > > > @@ -1,30 +1,30 @@ > > > > > > /* > > > > > > * Intel ACPI Component Architecture > > > > > > * AML/ASL+ Disassembler version 20180105 (64-bit version) > > > > > > * Copyright (c) 2000 - 2018 Intel Corporation > > > > > > * > > > > > > * Disassembling to symbolic ASL+ operators > > > > > > * > > > > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Wed Sep 16 09:45:56 2020 > > > > > > + * Disassembly of /tmp/aml-ECV9Q0, Wed Sep 16 09:45:56 2020 > > > > > > * > > > > > > * Original Table Header: > > > > > > * Signature "DSDT" > > > > > > - * Length 0x0000131F (4895) > > > > > > + * Length 0x00000B89 (2953) > > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > > > > - * Checksum 0xF9 > > > > > > + * Checksum 0xA2 > > > > > > * OEM ID "BOCHS " > > > > > > * OEM Table ID "BXPCDSDT" > > > > > > * OEM Revision 0x00000001 (1) > > > > > > * Compiler ID "BXPC" > > > > > > * Compiler Version 0x00000001 (1) > > > > > > */ > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) > > > > > > { > > > > > > Scope (\) > > > > > > { > > > > > > OperationRegion (DBG, SystemIO, 0x0402, One) > > > > > > Field (DBG, ByteAcc, NoLock, Preserve) > > > > > > { > > > > > > DBGB, 8 > > > > > > } > > > > > > > > > > > > @@ -234,64 +234,32 @@ > > > > > > { > > > > > > Name (_HID, EisaId ("PNP0B00") /* AT Real-Time Clock */) // _HID: Hardware ID > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > > > { > > > > > > IO (Decode16, > > > > > > 0x0070, // Range Minimum > > > > > > 0x0070, // Range Maximum > > > > > > 0x01, // Alignment > > > > > > 0x08, // Length > > > > > > ) > > > > > > IRQNoFlags () > > > > > > {8} > > > > > > }) > > > > > > } > > > > > > } > > > > > > > > > > > > - Scope (_SB.PCI0) > > > > > > - { > > > > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > > > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > > > > > - { > > > > > > - PCIU, 32, > > > > > > - PCID, 32 > > > > > > - } > > > > > > - > > > > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > > > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > > > > > - { > > > > > > - B0EJ, 32 > > > > > > - } > > > > > > - > > > > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > > > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > > > > > - { > > > > > > - BNUM, 32 > > > > > > - } > > > > > > - > > > > > > - Mutex (BLCK, 0x00) > > > > > > - Method (PCEJ, 2, NotSerialized) > > > > > > - { > > > > > > - Acquire (BLCK, 0xFFFF) > > > > > > - BNUM = Arg0 > > > > > > - B0EJ = (One << Arg1) > > > > > > - Release (BLCK) > > > > > > - Return (Zero) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > Scope (_SB) > > > > > > { > > > > > > Scope (PCI0) > > > > > > { > > > > > > Method (_PRT, 0, NotSerialized) // _PRT: PCI Routing Table > > > > > > { > > > > > > Local0 = Package (0x80){} > > > > > > Local1 = Zero > > > > > > While ((Local1 < 0x80)) > > > > > > { > > > > > > Local2 = (Local1 >> 0x02) > > > > > > Local3 = ((Local1 + Local2) & 0x03) > > > > > > If ((Local3 == Zero)) > > > > > > { > > > > > > Local4 = Package (0x04) > > > > > > { > > > > > > @@ -690,38 +658,32 @@ > > > > > > Method (_OST, 3, Serialized) // _OST: OSPM Status Indication > > > > > > { > > > > > > COST (Zero, Arg0, Arg1, Arg2) > > > > > > } > > > > > > } > > > > > > } > > > > > > } > > > > > > > > > > > > Method (\_GPE._E02, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > > > > > { > > > > > > \_SB.CPUS.CSCN () > > > > > > } > > > > > > > > > > > > Scope (_GPE) > > > > > > { > > > > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > > > > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > > > > > - { > > > > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > > > > > - \_SB.PCI0.PCNT () > > > > > > - Release (\_SB.PCI0.BLCK) > > > > > > - } > > > > > > } > > > > > > > > > > > > Scope (\_SB.PCI0) > > > > > > { > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > > > { > > > > > > WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode, > > > > > > 0x0000, // Granularity > > > > > > 0x0000, // Range Minimum > > > > > > 0x00FF, // Range Maximum > > > > > > 0x0000, // Translation Offset > > > > > > 0x0100, // Length > > > > > > ,, ) > > > > > > IO (Decode16, > > > > > > 0x0CF8, // Range Minimum > > > > > > 0x0CF8, // Range Maximum > > > > > > @@ -766,48 +728,32 @@ > > > > > > }) > > > > > > Device (GPE0) > > > > > > { > > > > > > Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > > > > > Name (_UID, "GPE0 resources") // _UID: Unique ID > > > > > > Name (_STA, 0x0B) // _STA: Status > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > > > { > > > > > > IO (Decode16, > > > > > > 0xAFE0, // Range Minimum > > > > > > 0xAFE0, // Range Maximum > > > > > > 0x01, // Alignment > > > > > > 0x04, // Length > > > > > > ) > > > > > > }) > > > > > > } > > > > > > - > > > > > > - Device (PHPR) > > > > > > - { > > > > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > > > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > > > > > - Name (_STA, 0x0B) // _STA: Status > > > > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > > > - { > > > > > > - IO (Decode16, > > > > > > - 0xAE00, // Range Minimum > > > > > > - 0xAE00, // Range Maximum > > > > > > - 0x01, // Alignment > > > > > > - 0x14, // Length > > > > > > - ) > > > > > > - }) > > > > > > - } > > > > > > } > > > > > > > > > > > > Scope (\) > > > > > > { > > > > > > Name (_S3, Package (0x04) // _S3_: S3 System State > > > > > > { > > > > > > One, > > > > > > One, > > > > > > Zero, > > > > > > Zero > > > > > > }) > > > > > > Name (_S4, Package (0x04) // _S4_: S4 System State > > > > > > { > > > > > > 0x02, > > > > > > 0x02, > > > > > > Zero, > > > > > > @@ -831,479 +777,48 @@ > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > > > { > > > > > > IO (Decode16, > > > > > > 0x0510, // Range Minimum > > > > > > 0x0510, // Range Maximum > > > > > > 0x01, // Alignment > > > > > > 0x0C, // Length > > > > > > ) > > > > > > }) > > > > > > } > > > > > > } > > > > > > > > > > > > Scope (\_SB) > > > > > > { > > > > > > Scope (PCI0) > > > > > > { > > > > > > - Name (BSEL, Zero) > > > > > > Device (S00) > > > > > > { > > > > > > Name (_ADR, Zero) // _ADR: Address > > > > > > } > > > > > > > > > > > > Device (S10) > > > > > > { > > > > > > Name (_ADR, 0x00020000) // _ADR: Address > > > > > > Method (_S1D, 0, NotSerialized) // _S1D: S1 Device State > > > > > > { > > > > > > Return (Zero) > > > > > > } > > > > > > > > > > > > Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State > > > > > > { > > > > > > Return (Zero) > > > > > > } > > > > > > > > > > > > Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State > > > > > > { > > > > > > Return (Zero) > > > > > > } > > > > > > } > > > > > > > > > > > > Device (S18) > > > > > > { > > > > > > Name (_ADR, 0x00030000) // _ADR: Address > > > > > > } > > > > > > - > > > > > > - Device (S20) > > > > > > - { > > > > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x00040000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (S28) > > > > > > - { > > > > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x00050000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (S30) > > > > > > - { > > > > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x00060000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (S38) > > > > > > - { > > > > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x00070000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (S40) > > > > > > - { > > > > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x00080000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (S48) > > > > > > - { > > > > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x00090000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (S50) > > > > > > - { > > > > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (S58) > > > > > > - { > > > > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (S60) > > > > > > - { > > > > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (S68) > > > > > > - { > > > > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (S70) > > > > > > - { > > > > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (S78) > > > > > > - { > > > > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (S80) > > > > > > - { > > > > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x00100000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (S88) > > > > > > - { > > > > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x00110000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (S90) > > > > > > - { > > > > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x00120000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (S98) > > > > > > - { > > > > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x00130000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (SA0) > > > > > > - { > > > > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x00140000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (SA8) > > > > > > - { > > > > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x00150000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (SB0) > > > > > > - { > > > > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x00160000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (SB8) > > > > > > - { > > > > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x00170000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (SC0) > > > > > > - { > > > > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x00180000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (SC8) > > > > > > - { > > > > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x00190000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (SD0) > > > > > > - { > > > > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (SD8) > > > > > > - { > > > > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (SE0) > > > > > > - { > > > > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (SE8) > > > > > > - { > > > > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (SF0) > > > > > > - { > > > > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Device (SF8) > > > > > > - { > > > > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > > > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > > > - { > > > > > > - PCEJ (BSEL, _SUN) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Method (DVNT, 2, NotSerialized) > > > > > > - { > > > > > > - If ((Arg0 & 0x10)) > > > > > > - { > > > > > > - Notify (S20, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x20)) > > > > > > - { > > > > > > - Notify (S28, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x40)) > > > > > > - { > > > > > > - Notify (S30, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x80)) > > > > > > - { > > > > > > - Notify (S38, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x0100)) > > > > > > - { > > > > > > - Notify (S40, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x0200)) > > > > > > - { > > > > > > - Notify (S48, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x0400)) > > > > > > - { > > > > > > - Notify (S50, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x0800)) > > > > > > - { > > > > > > - Notify (S58, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x1000)) > > > > > > - { > > > > > > - Notify (S60, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x2000)) > > > > > > - { > > > > > > - Notify (S68, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x4000)) > > > > > > - { > > > > > > - Notify (S70, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x8000)) > > > > > > - { > > > > > > - Notify (S78, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x00010000)) > > > > > > - { > > > > > > - Notify (S80, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x00020000)) > > > > > > - { > > > > > > - Notify (S88, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x00040000)) > > > > > > - { > > > > > > - Notify (S90, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x00080000)) > > > > > > - { > > > > > > - Notify (S98, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x00100000)) > > > > > > - { > > > > > > - Notify (SA0, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x00200000)) > > > > > > - { > > > > > > - Notify (SA8, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x00400000)) > > > > > > - { > > > > > > - Notify (SB0, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x00800000)) > > > > > > - { > > > > > > - Notify (SB8, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x01000000)) > > > > > > - { > > > > > > - Notify (SC0, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x02000000)) > > > > > > - { > > > > > > - Notify (SC8, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x04000000)) > > > > > > - { > > > > > > - Notify (SD0, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x08000000)) > > > > > > - { > > > > > > - Notify (SD8, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x10000000)) > > > > > > - { > > > > > > - Notify (SE0, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x20000000)) > > > > > > - { > > > > > > - Notify (SE8, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x40000000)) > > > > > > - { > > > > > > - Notify (SF0, Arg1) > > > > > > - } > > > > > > - > > > > > > - If ((Arg0 & 0x80000000)) > > > > > > - { > > > > > > - Notify (SF8, Arg1) > > > > > > - } > > > > > > - } > > > > > > - > > > > > > - Method (PCNT, 0, NotSerialized) > > > > > > - { > > > > > > - BNUM = Zero > > > > > > - DVNT (PCIU, One) > > > > > > - DVNT (PCID, 0x03) > > > > > > - } > > > > > > } > > > > > > } > > > > > > } > > > > > > > > > > This is not the only diff I see if I apply this patchset on > > > > > top of master. > > > > > Dropped this and the previous patch. > > > > > Please check what is going on and repost as appropriate. > > > > > > > > Which two ACPI DSDT files are you diffing? What diff are you getting? > > > > > > > > > diff -rup ./tests/data/acpi/pc/DSDT.hpbridge.dsl ./tests/data/acpi/pc/DSDT.hpbrroot.dsl > > > > I re-based my patchset on top of the latest qemu master and did a make > > && make check-qtest-x86_64 V=1. > > They pass. I am seeing this diff: > > https://pastebin.ubuntu.com/p/BXy9GFfB2R/ > > > > and it looks good to me. > > > > Not sure why your diff looks different. Maybe you can regenerate the blob? > > I did a full make check and it passed. I compared the diff again and > it's the same. I checked my tree and it looks clean. These are the > patches I have: > > $ git log --oneline > 20d1323e10 (HEAD -> master) qom: code hardening - have bound checking > while looping with integer value > 0f69dae0e2 Add a comment in bios-tables-test.c to clarify the reason > behind approach > dd9a8c3cd3 tests/acpi: add DSDT.hpbrroot DSDT table blob to test > global i440fx hotplug > 5b93474fe9 tests/acpi: unit test exercising global pci hotplug off for i440fx > 54c33e334a tests/acpi: update golden master DSDT binary table blobs for q35 > 2279f61f30 piix4: don't reserve hw resources when hotplug is off globally > 1f61c524a0 Add ACPI DSDT tables for q35 that are being updated by the next patch > bdd823611b tests/acpi: add newly added acpi DSDT table blob for pci > bridge hotplug flag > 8c80f8fba9 tests/acpi: unit test for > 'acpi-pci-hotplug-with-bridge-support' bridge flag > e0a3142df9 tests/acpi: list added acpi table binary file for pci > bridge hotplug test > 0ba08317a8 i440fx/acpi: do not add hotplug related amls for cold plugged bridges > 73b191ade6 Fix a gap where acpi_pcihp_find_hotplug_bus() returns a > non-hotpluggable bus > ef0e526cc2 tests/acpi: add a new ACPI table in order to test root pci > hotplug on/off > c6d13264f8 tests/acpi: add new unit test to test hotplug off/on > feature on the root pci bus > 6901bada65 tests/acpi: mark addition of table DSDT.roothp for unit > testing root pci hotplug > 74504514b1 (origin/master, origin/HEAD) Merge remote-tracking branch > 'remotes/alistair/tags/pull-register-20200927' into staging Try applying on top of latest pull request? > > > > > > > > > > > > > > > --- ./tests/data/acpi/pc/DSDT.hpbridge.dsl 2020-09-29 02:44:43.874622404 -0400 > > > +++ ./tests/data/acpi/pc/DSDT.hpbrroot.dsl 2020-09-29 02:44:43.876622403 -0400 > > > @@ -5,13 +5,13 @@ > > > * > > > * Disassembling to symbolic ASL+ operators > > > * > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 02:44:43 2020 > > > + * Disassembly of tests/data/acpi/pc/DSDT.hpbrroot, Tue Sep 29 02:44:43 2020 > > > * > > > * Original Table Header: > > > * Signature "DSDT" > > > - * Length 0x0000139D (5021) > > > + * Length 0x00000B89 (2953) > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > - * Checksum 0x05 > > > + * Checksum 0xA2 > > > * OEM ID "BOCHS " > > > * OEM Table ID "BXPCDSDT" > > > * OEM Revision 0x00000001 (1) > > > @@ -247,38 +247,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > } > > > } > > > > > > - Scope (_SB.PCI0) > > > - { > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > > - { > > > - PCIU, 32, > > > - PCID, 32 > > > - } > > > - > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > > - { > > > - B0EJ, 32 > > > - } > > > - > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > > - { > > > - BNUM, 32 > > > - } > > > - > > > - Mutex (BLCK, 0x00) > > > - Method (PCEJ, 2, NotSerialized) > > > - { > > > - Acquire (BLCK, 0xFFFF) > > > - BNUM = Arg0 > > > - B0EJ = (One << Arg1) > > > - Release (BLCK) > > > - Return (Zero) > > > - } > > > - } > > > - > > > Scope (_SB) > > > { > > > Scope (PCI0) > > > @@ -643,56 +611,22 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > Method (CSCN, 0, Serialized) > > > { > > > Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF) > > > - Name (CNEW, Package (0xFF){}) > > > - Local3 = Zero > > > - Local4 = One > > > - While ((Local4 == One)) > > > + Local0 = One > > > + While ((Local0 == One)) > > > { > > > - Local4 = Zero > > > - Local0 = One > > > - Local1 = Zero > > > - While (((Local0 == One) && (Local3 < One))) > > > + Local0 = Zero > > > + \_SB.PCI0.PRES.CCMD = Zero > > > + If ((\_SB.PCI0.PRES.CINS == One)) > > > { > > > - Local0 = Zero > > > - \_SB.PCI0.PRES.CSEL = Local3 > > > - \_SB.PCI0.PRES.CCMD = Zero > > > - If ((\_SB.PCI0.PRES.CDAT < Local3)) > > > - { > > > - Break > > > - } > > > - > > > - If ((Local1 == 0xFF)) > > > - { > > > - Local4 = One > > > - Break > > > - } > > > - > > > - Local3 = \_SB.PCI0.PRES.CDAT > > > - If ((\_SB.PCI0.PRES.CINS == One)) > > > - { > > > - CNEW [Local1] = Local3 > > > - Local1++ > > > - Local0 = One > > > - } > > > - ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > > > - { > > > - CTFY (Local3, 0x03) > > > - \_SB.PCI0.PRES.CRMV = One > > > - Local0 = One > > > - } > > > - > > > - Local3++ > > > + CTFY (\_SB.PCI0.PRES.CDAT, One) > > > + \_SB.PCI0.PRES.CINS = One > > > + Local0 = One > > > } > > > - > > > - Local2 = Zero > > > - While ((Local2 < Local1)) > > > + ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > > > { > > > - Local3 = DerefOf (CNEW [Local2]) > > > - CTFY (Local3, One) > > > - Debug = Local3 > > > - \_SB.PCI0.PRES.CSEL = Local3 > > > - \_SB.PCI0.PRES.CINS = One > > > - Local2++ > > > + CTFY (\_SB.PCI0.PRES.CDAT, 0x03) > > > + \_SB.PCI0.PRES.CRMV = One > > > + Local0 = One > > > } > > > } > > > > > > @@ -737,12 +671,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > Scope (_GPE) > > > { > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE, xx=0x00-0xFF > > > - { > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > > - \_SB.PCI0.PCNT () > > > - Release (\_SB.PCI0.BLCK) > > > - } > > > } > > > > > > Scope (\_SB.PCI0) > > > @@ -813,22 +741,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > ) > > > }) > > > } > > > - > > > - Device (PHPR) > > > - { > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > > - Name (_STA, 0x0B) // _STA: Status > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > - { > > > - IO (Decode16, > > > - 0xAE00, // Range Minimum > > > - 0xAE00, // Range Maximum > > > - 0x01, // Alignment > > > - 0x14, // Length > > > - ) > > > - }) > > > - } > > > } > > > > > > Scope (\) > > > @@ -878,7 +790,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > { > > > Scope (PCI0) > > > { > > > - Name (BSEL, Zero) > > > Device (S00) > > > { > > > Name (_ADR, Zero) // _ADR: Address > > > @@ -907,436 +818,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > { > > > Name (_ADR, 0x00030000) // _ADR: Address > > > } > > > - > > > - Device (S20) > > > - { > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > > - Name (_ADR, 0x00040000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S28) > > > - { > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > > - Name (_ADR, 0x00050000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S30) > > > - { > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > > - Name (_ADR, 0x00060000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S38) > > > - { > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > > - Name (_ADR, 0x00070000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S40) > > > - { > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > > - Name (_ADR, 0x00080000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S48) > > > - { > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > > - Name (_ADR, 0x00090000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S50) > > > - { > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S58) > > > - { > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S60) > > > - { > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S68) > > > - { > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S70) > > > - { > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S78) > > > - { > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S80) > > > - { > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > > - Name (_ADR, 0x00100000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S88) > > > - { > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > > - Name (_ADR, 0x00110000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S90) > > > - { > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > > - Name (_ADR, 0x00120000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (S98) > > > - { > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > > - Name (_ADR, 0x00130000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SA0) > > > - { > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > > - Name (_ADR, 0x00140000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SA8) > > > - { > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > > - Name (_ADR, 0x00150000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SB0) > > > - { > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > > - Name (_ADR, 0x00160000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SB8) > > > - { > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > > - Name (_ADR, 0x00170000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SC0) > > > - { > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > > - Name (_ADR, 0x00180000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SC8) > > > - { > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > > - Name (_ADR, 0x00190000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SD0) > > > - { > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SD8) > > > - { > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SE0) > > > - { > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SE8) > > > - { > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SF0) > > > - { > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Device (SF8) > > > - { > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > - { > > > - PCEJ (BSEL, _SUN) > > > - } > > > - } > > > - > > > - Method (DVNT, 2, NotSerialized) > > > - { > > > - If ((Arg0 & 0x10)) > > > - { > > > - Notify (S20, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x20)) > > > - { > > > - Notify (S28, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x40)) > > > - { > > > - Notify (S30, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x80)) > > > - { > > > - Notify (S38, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x0100)) > > > - { > > > - Notify (S40, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x0200)) > > > - { > > > - Notify (S48, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x0400)) > > > - { > > > - Notify (S50, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x0800)) > > > - { > > > - Notify (S58, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x1000)) > > > - { > > > - Notify (S60, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x2000)) > > > - { > > > - Notify (S68, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x4000)) > > > - { > > > - Notify (S70, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x8000)) > > > - { > > > - Notify (S78, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x00010000)) > > > - { > > > - Notify (S80, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x00020000)) > > > - { > > > - Notify (S88, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x00040000)) > > > - { > > > - Notify (S90, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x00080000)) > > > - { > > > - Notify (S98, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x00100000)) > > > - { > > > - Notify (SA0, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x00200000)) > > > - { > > > - Notify (SA8, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x00400000)) > > > - { > > > - Notify (SB0, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x00800000)) > > > - { > > > - Notify (SB8, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x01000000)) > > > - { > > > - Notify (SC0, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x02000000)) > > > - { > > > - Notify (SC8, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x04000000)) > > > - { > > > - Notify (SD0, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x08000000)) > > > - { > > > - Notify (SD8, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x10000000)) > > > - { > > > - Notify (SE0, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x20000000)) > > > - { > > > - Notify (SE8, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x40000000)) > > > - { > > > - Notify (SF0, Arg1) > > > - } > > > - > > > - If ((Arg0 & 0x80000000)) > > > - { > > > - Notify (SF8, Arg1) > > > - } > > > - } > > > - > > > - Method (PCNT, 0, NotSerialized) > > > - { > > > - BNUM = Zero > > > - DVNT (PCIU, One) > > > - DVNT (PCID, 0x03) > > > - } > > > } > > > } > > > } > > >
On Tue, Sep 29, 2020 at 3:12 PM Michael S. Tsirkin <mst@redhat.com> wrote: > On Tue, Sep 29, 2020 at 02:21:06PM +0530, Ani Sinha wrote: > > > On Tue, Sep 29, 2020 at 1:53 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > > > On Tue, Sep 29, 2020 at 12:56 PM Michael S. Tsirkin <mst@redhat.com> > wrote: > > > > > > > > > > On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote: > > > > > > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin < > mst@redhat.com> wrote: > > > > > > > > > > > > > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote: > > > > > > > > This change adds a new DSDT golden master table blob to test > disabling > > > > > > > > hotplug on both pci root bus and pci bridges. Also reverts the > change > > > > > > > > in file bios-tables-test-allowed-diff.h to make sure its now > empty so that > > > > > > > > future modifications to acpi tables can be caught. > > > > > > > > > > > > > > > > The following is the disassembled diff between DSDT.hpbridge > and DSDT.hpbrroot: > > > > > > > > > > > > > > > > @@ -1,30 +1,30 @@ > > > > > > > > /* > > > > > > > > * Intel ACPI Component Architecture > > > > > > > > * AML/ASL+ Disassembler version 20180105 (64-bit version) > > > > > > > > * Copyright (c) 2000 - 2018 Intel Corporation > > > > > > > > * > > > > > > > > * Disassembling to symbolic ASL+ operators > > > > > > > > * > > > > > > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Wed Sep > 16 09:45:56 2020 > > > > > > > > + * Disassembly of /tmp/aml-ECV9Q0, Wed Sep 16 09:45:56 2020 > > > > > > > > * > > > > > > > > * Original Table Header: > > > > > > > > * Signature "DSDT" > > > > > > > > - * Length 0x0000131F (4895) > > > > > > > > + * Length 0x00000B89 (2953) > > > > > > > > * Revision 0x01 **** 32-bit table (V1), no > 64-bit math support > > > > > > > > - * Checksum 0xF9 > > > > > > > > + * Checksum 0xA2 > > > > > > > > * OEM ID "BOCHS " > > > > > > > > * OEM Table ID "BXPCDSDT" > > > > > > > > * OEM Revision 0x00000001 (1) > > > > > > > > * Compiler ID "BXPC" > > > > > > > > * Compiler Version 0x00000001 (1) > > > > > > > > */ > > > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", > 0x00000001) > > > > > > > > { > > > > > > > > Scope (\) > > > > > > > > { > > > > > > > > OperationRegion (DBG, SystemIO, 0x0402, One) > > > > > > > > Field (DBG, ByteAcc, NoLock, Preserve) > > > > > > > > { > > > > > > > > DBGB, 8 > > > > > > > > } > > > > > > > > > > > > > > > > @@ -234,64 +234,32 @@ > > > > > > > > { > > > > > > > > Name (_HID, EisaId ("PNP0B00") /* AT Real-Time > Clock */) // _HID: Hardware ID > > > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current > Resource Settings > > > > > > > > { > > > > > > > > IO (Decode16, > > > > > > > > 0x0070, // Range Minimum > > > > > > > > 0x0070, // Range Maximum > > > > > > > > 0x01, // Alignment > > > > > > > > 0x08, // Length > > > > > > > > ) > > > > > > > > IRQNoFlags () > > > > > > > > {8} > > > > > > > > }) > > > > > > > > } > > > > > > > > } > > > > > > > > > > > > > > > > - Scope (_SB.PCI0) > > > > > > > > - { > > > > > > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > > > > > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > > > > > > > - { > > > > > > > > - PCIU, 32, > > > > > > > > - PCID, 32 > > > > > > > > - } > > > > > > > > - > > > > > > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > > > > > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > > > > > > > - { > > > > > > > > - B0EJ, 32 > > > > > > > > - } > > > > > > > > - > > > > > > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > > > > > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > > > > > > > - { > > > > > > > > - BNUM, 32 > > > > > > > > - } > > > > > > > > - > > > > > > > > - Mutex (BLCK, 0x00) > > > > > > > > - Method (PCEJ, 2, NotSerialized) > > > > > > > > - { > > > > > > > > - Acquire (BLCK, 0xFFFF) > > > > > > > > - BNUM = Arg0 > > > > > > > > - B0EJ = (One << Arg1) > > > > > > > > - Release (BLCK) > > > > > > > > - Return (Zero) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > Scope (_SB) > > > > > > > > { > > > > > > > > Scope (PCI0) > > > > > > > > { > > > > > > > > Method (_PRT, 0, NotSerialized) // _PRT: PCI > Routing Table > > > > > > > > { > > > > > > > > Local0 = Package (0x80){} > > > > > > > > Local1 = Zero > > > > > > > > While ((Local1 < 0x80)) > > > > > > > > { > > > > > > > > Local2 = (Local1 >> 0x02) > > > > > > > > Local3 = ((Local1 + Local2) & 0x03) > > > > > > > > If ((Local3 == Zero)) > > > > > > > > { > > > > > > > > Local4 = Package (0x04) > > > > > > > > { > > > > > > > > @@ -690,38 +658,32 @@ > > > > > > > > Method (_OST, 3, Serialized) // _OST: OSPM > Status Indication > > > > > > > > { > > > > > > > > COST (Zero, Arg0, Arg1, Arg2) > > > > > > > > } > > > > > > > > } > > > > > > > > } > > > > > > > > } > > > > > > > > > > > > > > > > Method (\_GPE._E02, 0, NotSerialized) // _Exx: > Edge-Triggered GPE > > > > > > > > { > > > > > > > > \_SB.CPUS.CSCN () > > > > > > > > } > > > > > > > > > > > > > > > > Scope (_GPE) > > > > > > > > { > > > > > > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // > _HID: Hardware ID > > > > > > > > - Method (_E01, 0, NotSerialized) // _Exx: > Edge-Triggered GPE > > > > > > > > - { > > > > > > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > > > > > > > - \_SB.PCI0.PCNT () > > > > > > > > - Release (\_SB.PCI0.BLCK) > > > > > > > > - } > > > > > > > > } > > > > > > > > > > > > > > > > Scope (\_SB.PCI0) > > > > > > > > { > > > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current > Resource Settings > > > > > > > > { > > > > > > > > WordBusNumber (ResourceProducer, MinFixed, > MaxFixed, PosDecode, > > > > > > > > 0x0000, // Granularity > > > > > > > > 0x0000, // Range Minimum > > > > > > > > 0x00FF, // Range Maximum > > > > > > > > 0x0000, // Translation Offset > > > > > > > > 0x0100, // Length > > > > > > > > ,, ) > > > > > > > > IO (Decode16, > > > > > > > > 0x0CF8, // Range Minimum > > > > > > > > 0x0CF8, // Range Maximum > > > > > > > > @@ -766,48 +728,32 @@ > > > > > > > > }) > > > > > > > > Device (GPE0) > > > > > > > > { > > > > > > > > Name (_HID, "PNP0A06" /* Generic Container Device > */) // _HID: Hardware ID > > > > > > > > Name (_UID, "GPE0 resources") // _UID: Unique ID > > > > > > > > Name (_STA, 0x0B) // _STA: Status > > > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current > Resource Settings > > > > > > > > { > > > > > > > > IO (Decode16, > > > > > > > > 0xAFE0, // Range Minimum > > > > > > > > 0xAFE0, // Range Maximum > > > > > > > > 0x01, // Alignment > > > > > > > > 0x04, // Length > > > > > > > > ) > > > > > > > > }) > > > > > > > > } > > > > > > > > - > > > > > > > > - Device (PHPR) > > > > > > > > - { > > > > > > > > - Name (_HID, "PNP0A06" /* Generic Container Device > */) // _HID: Hardware ID > > > > > > > > - Name (_UID, "PCI Hotplug resources") // _UID: > Unique ID > > > > > > > > - Name (_STA, 0x0B) // _STA: Status > > > > > > > > - Name (_CRS, ResourceTemplate () // _CRS: Current > Resource Settings > > > > > > > > - { > > > > > > > > - IO (Decode16, > > > > > > > > - 0xAE00, // Range Minimum > > > > > > > > - 0xAE00, // Range Maximum > > > > > > > > - 0x01, // Alignment > > > > > > > > - 0x14, // Length > > > > > > > > - ) > > > > > > > > - }) > > > > > > > > - } > > > > > > > > } > > > > > > > > > > > > > > > > Scope (\) > > > > > > > > { > > > > > > > > Name (_S3, Package (0x04) // _S3_: S3 System State > > > > > > > > { > > > > > > > > One, > > > > > > > > One, > > > > > > > > Zero, > > > > > > > > Zero > > > > > > > > }) > > > > > > > > Name (_S4, Package (0x04) // _S4_: S4 System State > > > > > > > > { > > > > > > > > 0x02, > > > > > > > > 0x02, > > > > > > > > Zero, > > > > > > > > @@ -831,479 +777,48 @@ > > > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current > Resource Settings > > > > > > > > { > > > > > > > > IO (Decode16, > > > > > > > > 0x0510, // Range Minimum > > > > > > > > 0x0510, // Range Maximum > > > > > > > > 0x01, // Alignment > > > > > > > > 0x0C, // Length > > > > > > > > ) > > > > > > > > }) > > > > > > > > } > > > > > > > > } > > > > > > > > > > > > > > > > Scope (\_SB) > > > > > > > > { > > > > > > > > Scope (PCI0) > > > > > > > > { > > > > > > > > - Name (BSEL, Zero) > > > > > > > > Device (S00) > > > > > > > > { > > > > > > > > Name (_ADR, Zero) // _ADR: Address > > > > > > > > } > > > > > > > > > > > > > > > > Device (S10) > > > > > > > > { > > > > > > > > Name (_ADR, 0x00020000) // _ADR: Address > > > > > > > > Method (_S1D, 0, NotSerialized) // _S1D: S1 > Device State > > > > > > > > { > > > > > > > > Return (Zero) > > > > > > > > } > > > > > > > > > > > > > > > > Method (_S2D, 0, NotSerialized) // _S2D: S2 > Device State > > > > > > > > { > > > > > > > > Return (Zero) > > > > > > > > } > > > > > > > > > > > > > > > > Method (_S3D, 0, NotSerialized) // _S3D: S3 > Device State > > > > > > > > { > > > > > > > > Return (Zero) > > > > > > > > } > > > > > > > > } > > > > > > > > > > > > > > > > Device (S18) > > > > > > > > { > > > > > > > > Name (_ADR, 0x00030000) // _ADR: Address > > > > > > > > } > > > > > > > > - > > > > > > > > - Device (S20) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x00040000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (S28) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x00050000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (S30) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x00060000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (S38) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x00070000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (S40) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x00080000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (S48) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x00090000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (S50) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (S58) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (S60) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (S68) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (S70) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (S78) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (S80) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x00100000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (S88) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x00110000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (S90) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x00120000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (S98) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x00130000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (SA0) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x00140000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (SA8) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x00150000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (SB0) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x00160000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (SB8) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x00170000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (SC0) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x00180000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (SC8) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x00190000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (SD0) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (SD8) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (SE0) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (SE8) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (SF0) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Device (SF8) > > > > > > > > - { > > > > > > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > > > > > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: > Eject Device > > > > > > > > - { > > > > > > > > - PCEJ (BSEL, _SUN) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Method (DVNT, 2, NotSerialized) > > > > > > > > - { > > > > > > > > - If ((Arg0 & 0x10)) > > > > > > > > - { > > > > > > > > - Notify (S20, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x20)) > > > > > > > > - { > > > > > > > > - Notify (S28, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x40)) > > > > > > > > - { > > > > > > > > - Notify (S30, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x80)) > > > > > > > > - { > > > > > > > > - Notify (S38, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x0100)) > > > > > > > > - { > > > > > > > > - Notify (S40, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x0200)) > > > > > > > > - { > > > > > > > > - Notify (S48, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x0400)) > > > > > > > > - { > > > > > > > > - Notify (S50, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x0800)) > > > > > > > > - { > > > > > > > > - Notify (S58, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x1000)) > > > > > > > > - { > > > > > > > > - Notify (S60, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x2000)) > > > > > > > > - { > > > > > > > > - Notify (S68, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x4000)) > > > > > > > > - { > > > > > > > > - Notify (S70, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x8000)) > > > > > > > > - { > > > > > > > > - Notify (S78, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x00010000)) > > > > > > > > - { > > > > > > > > - Notify (S80, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x00020000)) > > > > > > > > - { > > > > > > > > - Notify (S88, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x00040000)) > > > > > > > > - { > > > > > > > > - Notify (S90, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x00080000)) > > > > > > > > - { > > > > > > > > - Notify (S98, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x00100000)) > > > > > > > > - { > > > > > > > > - Notify (SA0, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x00200000)) > > > > > > > > - { > > > > > > > > - Notify (SA8, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x00400000)) > > > > > > > > - { > > > > > > > > - Notify (SB0, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x00800000)) > > > > > > > > - { > > > > > > > > - Notify (SB8, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x01000000)) > > > > > > > > - { > > > > > > > > - Notify (SC0, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x02000000)) > > > > > > > > - { > > > > > > > > - Notify (SC8, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x04000000)) > > > > > > > > - { > > > > > > > > - Notify (SD0, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x08000000)) > > > > > > > > - { > > > > > > > > - Notify (SD8, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x10000000)) > > > > > > > > - { > > > > > > > > - Notify (SE0, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x20000000)) > > > > > > > > - { > > > > > > > > - Notify (SE8, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x40000000)) > > > > > > > > - { > > > > > > > > - Notify (SF0, Arg1) > > > > > > > > - } > > > > > > > > - > > > > > > > > - If ((Arg0 & 0x80000000)) > > > > > > > > - { > > > > > > > > - Notify (SF8, Arg1) > > > > > > > > - } > > > > > > > > - } > > > > > > > > - > > > > > > > > - Method (PCNT, 0, NotSerialized) > > > > > > > > - { > > > > > > > > - BNUM = Zero > > > > > > > > - DVNT (PCIU, One) > > > > > > > > - DVNT (PCID, 0x03) > > > > > > > > - } > > > > > > > > } > > > > > > > > } > > > > > > > > } > > > > > > > > > > > > > > This is not the only diff I see if I apply this patchset on > > > > > > > top of master. > > > > > > > Dropped this and the previous patch. > > > > > > > Please check what is going on and repost as appropriate. > > > > > > > > > > > > Which two ACPI DSDT files are you diffing? What diff are you > getting? > > > > > > > > > > > > > > > diff -rup ./tests/data/acpi/pc/DSDT.hpbridge.dsl > ./tests/data/acpi/pc/DSDT.hpbrroot.dsl > > > > > > > > I re-based my patchset on top of the latest qemu master and did a make > > > > && make check-qtest-x86_64 V=1. > > > > They pass. I am seeing this diff: > > > > https://pastebin.ubuntu.com/p/BXy9GFfB2R/ > > > > > > > > and it looks good to me. > > > > > > > > Not sure why your diff looks different. Maybe you can regenerate the > blob? > > > > > > I did a full make check and it passed. I compared the diff again and > > > it's the same. I checked my tree and it looks clean. These are the > > > patches I have: > > > > > > $ git log --oneline > > > 20d1323e10 (HEAD -> master) qom: code hardening - have bound checking > > > while looping with integer value > > > 0f69dae0e2 Add a comment in bios-tables-test.c to clarify the reason > > > behind approach > > > dd9a8c3cd3 tests/acpi: add DSDT.hpbrroot DSDT table blob to test > > > global i440fx hotplug > > > 5b93474fe9 tests/acpi: unit test exercising global pci hotplug off for > i440fx > > > 54c33e334a tests/acpi: update golden master DSDT binary table blobs for > q35 > > > 2279f61f30 piix4: don't reserve hw resources when hotplug is off globally > > > 1f61c524a0 Add ACPI DSDT tables for q35 that are being updated by the > next patch > > > bdd823611b tests/acpi: add newly added acpi DSDT table blob for pci > > > bridge hotplug flag > > > 8c80f8fba9 tests/acpi: unit test for > > > 'acpi-pci-hotplug-with-bridge-support' bridge flag > > > e0a3142df9 tests/acpi: list added acpi table binary file for pci > > > bridge hotplug test > > > 0ba08317a8 i440fx/acpi: do not add hotplug related amls for cold plugged > bridges > > > 73b191ade6 Fix a gap where acpi_pcihp_find_hotplug_bus() returns a > > > non-hotpluggable bus > > > ef0e526cc2 tests/acpi: add a new ACPI table in order to test root pci > > > hotplug on/off > > > c6d13264f8 tests/acpi: add new unit test to test hotplug off/on > > > feature on the root pci bus > > > 6901bada65 tests/acpi: mark addition of table DSDT.roothp for unit > > > testing root pci hotplug > > > 74504514b1 (origin/master, origin/HEAD) Merge remote-tracking branch > > > 'remotes/alistair/tags/pull-register-20200927' into staging > > > > Try applying on top of latest pull request? Maybe I'm missing something but can you point me to the latest pull request? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --- ./tests/data/acpi/pc/DSDT.hpbridge.dsl 2020-09-29 > 02:44:43.874622404 -0400 > > > > > +++ ./tests/data/acpi/pc/DSDT.hpbrroot.dsl 2020-09-29 > 02:44:43.876622403 -0400 > > > > > @@ -5,13 +5,13 @@ > > > > > * > > > > > * Disassembling to symbolic ASL+ operators > > > > > * > > > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 > 02:44:43 2020 > > > > > + * Disassembly of tests/data/acpi/pc/DSDT.hpbrroot, Tue Sep 29 > 02:44:43 2020 > > > > > * > > > > > * Original Table Header: > > > > > * Signature "DSDT" > > > > > - * Length 0x0000139D (5021) > > > > > + * Length 0x00000B89 (2953) > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math > support > > > > > - * Checksum 0x05 > > > > > + * Checksum 0xA2 > > > > > * OEM ID "BOCHS " > > > > > * OEM Table ID "BXPCDSDT" > > > > > * OEM Revision 0x00000001 (1) > > > > > @@ -247,38 +247,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > > } > > > > > } > > > > > > > > > > - Scope (_SB.PCI0) > > > > > - { > > > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > > > > - { > > > > > - PCIU, 32, > > > > > - PCID, 32 > > > > > - } > > > > > - > > > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > > > > - { > > > > > - B0EJ, 32 > > > > > - } > > > > > - > > > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > > > > - { > > > > > - BNUM, 32 > > > > > - } > > > > > - > > > > > - Mutex (BLCK, 0x00) > > > > > - Method (PCEJ, 2, NotSerialized) > > > > > - { > > > > > - Acquire (BLCK, 0xFFFF) > > > > > - BNUM = Arg0 > > > > > - B0EJ = (One << Arg1) > > > > > - Release (BLCK) > > > > > - Return (Zero) > > > > > - } > > > > > - } > > > > > - > > > > > Scope (_SB) > > > > > { > > > > > Scope (PCI0) > > > > > @@ -643,56 +611,22 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > > Method (CSCN, 0, Serialized) > > > > > { > > > > > Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF) > > > > > - Name (CNEW, Package (0xFF){}) > > > > > - Local3 = Zero > > > > > - Local4 = One > > > > > - While ((Local4 == One)) > > > > > + Local0 = One > > > > > + While ((Local0 == One)) > > > > > { > > > > > - Local4 = Zero > > > > > - Local0 = One > > > > > - Local1 = Zero > > > > > - While (((Local0 == One) && (Local3 < One))) > > > > > + Local0 = Zero > > > > > + \_SB.PCI0.PRES.CCMD = Zero > > > > > + If ((\_SB.PCI0.PRES.CINS == One)) > > > > > { > > > > > - Local0 = Zero > > > > > - \_SB.PCI0.PRES.CSEL = Local3 > > > > > - \_SB.PCI0.PRES.CCMD = Zero > > > > > - If ((\_SB.PCI0.PRES.CDAT < Local3)) > > > > > - { > > > > > - Break > > > > > - } > > > > > - > > > > > - If ((Local1 == 0xFF)) > > > > > - { > > > > > - Local4 = One > > > > > - Break > > > > > - } > > > > > - > > > > > - Local3 = \_SB.PCI0.PRES.CDAT > > > > > - If ((\_SB.PCI0.PRES.CINS == One)) > > > > > - { > > > > > - CNEW [Local1] = Local3 > > > > > - Local1++ > > > > > - Local0 = One > > > > > - } > > > > > - ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > > > > > - { > > > > > - CTFY (Local3, 0x03) > > > > > - \_SB.PCI0.PRES.CRMV = One > > > > > - Local0 = One > > > > > - } > > > > > - > > > > > - Local3++ > > > > > + CTFY (\_SB.PCI0.PRES.CDAT, One) > > > > > + \_SB.PCI0.PRES.CINS = One > > > > > + Local0 = One > > > > > } > > > > > - > > > > > - Local2 = Zero > > > > > - While ((Local2 < Local1)) > > > > > + ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > > > > > { > > > > > - Local3 = DerefOf (CNEW [Local2]) > > > > > - CTFY (Local3, One) > > > > > - Debug = Local3 > > > > > - \_SB.PCI0.PRES.CSEL = Local3 > > > > > - \_SB.PCI0.PRES.CINS = One > > > > > - Local2++ > > > > > + CTFY (\_SB.PCI0.PRES.CDAT, 0x03) > > > > > + \_SB.PCI0.PRES.CRMV = One > > > > > + Local0 = One > > > > > } > > > > > } > > > > > > > > > > @@ -737,12 +671,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > > Scope (_GPE) > > > > > { > > > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: > Hardware ID > > > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered > GPE, xx=0x00-0xFF > > > > > - { > > > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > > > > - \_SB.PCI0.PCNT () > > > > > - Release (\_SB.PCI0.BLCK) > > > > > - } > > > > > } > > > > > > > > > > Scope (\_SB.PCI0) > > > > > @@ -813,22 +741,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > > ) > > > > > }) > > > > > } > > > > > - > > > > > - Device (PHPR) > > > > > - { > > > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) > // _HID: Hardware ID > > > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > > > > - Name (_STA, 0x0B) // _STA: Status > > > > > - Name (_CRS, ResourceTemplate () // _CRS: Current > Resource Settings > > > > > - { > > > > > - IO (Decode16, > > > > > - 0xAE00, // Range Minimum > > > > > - 0xAE00, // Range Maximum > > > > > - 0x01, // Alignment > > > > > - 0x14, // Length > > > > > - ) > > > > > - }) > > > > > - } > > > > > } > > > > > > > > > > Scope (\) > > > > > @@ -878,7 +790,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > > { > > > > > Scope (PCI0) > > > > > { > > > > > - Name (BSEL, Zero) > > > > > Device (S00) > > > > > { > > > > > Name (_ADR, Zero) // _ADR: Address > > > > > @@ -907,436 +818,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > > { > > > > > Name (_ADR, 0x00030000) // _ADR: Address > > > > > } > > > > > - > > > > > - Device (S20) > > > > > - { > > > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00040000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S28) > > > > > - { > > > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00050000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S30) > > > > > - { > > > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00060000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S38) > > > > > - { > > > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00070000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S40) > > > > > - { > > > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00080000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S48) > > > > > - { > > > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00090000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S50) > > > > > - { > > > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S58) > > > > > - { > > > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S60) > > > > > - { > > > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S68) > > > > > - { > > > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S70) > > > > > - { > > > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S78) > > > > > - { > > > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S80) > > > > > - { > > > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00100000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S88) > > > > > - { > > > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00110000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S90) > > > > > - { > > > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00120000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (S98) > > > > > - { > > > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00130000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SA0) > > > > > - { > > > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00140000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SA8) > > > > > - { > > > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00150000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SB0) > > > > > - { > > > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00160000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SB8) > > > > > - { > > > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00170000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SC0) > > > > > - { > > > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00180000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SC8) > > > > > - { > > > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x00190000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SD0) > > > > > - { > > > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SD8) > > > > > - { > > > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SE0) > > > > > - { > > > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SE8) > > > > > - { > > > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SF0) > > > > > - { > > > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Device (SF8) > > > > > - { > > > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject > Device, x=0-9 > > > > > - { > > > > > - PCEJ (BSEL, _SUN) > > > > > - } > > > > > - } > > > > > - > > > > > - Method (DVNT, 2, NotSerialized) > > > > > - { > > > > > - If ((Arg0 & 0x10)) > > > > > - { > > > > > - Notify (S20, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x20)) > > > > > - { > > > > > - Notify (S28, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x40)) > > > > > - { > > > > > - Notify (S30, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x80)) > > > > > - { > > > > > - Notify (S38, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x0100)) > > > > > - { > > > > > - Notify (S40, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x0200)) > > > > > - { > > > > > - Notify (S48, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x0400)) > > > > > - { > > > > > - Notify (S50, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x0800)) > > > > > - { > > > > > - Notify (S58, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x1000)) > > > > > - { > > > > > - Notify (S60, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x2000)) > > > > > - { > > > > > - Notify (S68, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x4000)) > > > > > - { > > > > > - Notify (S70, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x8000)) > > > > > - { > > > > > - Notify (S78, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x00010000)) > > > > > - { > > > > > - Notify (S80, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x00020000)) > > > > > - { > > > > > - Notify (S88, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x00040000)) > > > > > - { > > > > > - Notify (S90, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x00080000)) > > > > > - { > > > > > - Notify (S98, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x00100000)) > > > > > - { > > > > > - Notify (SA0, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x00200000)) > > > > > - { > > > > > - Notify (SA8, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x00400000)) > > > > > - { > > > > > - Notify (SB0, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x00800000)) > > > > > - { > > > > > - Notify (SB8, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x01000000)) > > > > > - { > > > > > - Notify (SC0, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x02000000)) > > > > > - { > > > > > - Notify (SC8, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x04000000)) > > > > > - { > > > > > - Notify (SD0, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x08000000)) > > > > > - { > > > > > - Notify (SD8, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x10000000)) > > > > > - { > > > > > - Notify (SE0, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x20000000)) > > > > > - { > > > > > - Notify (SE8, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x40000000)) > > > > > - { > > > > > - Notify (SF0, Arg1) > > > > > - } > > > > > - > > > > > - If ((Arg0 & 0x80000000)) > > > > > - { > > > > > - Notify (SF8, Arg1) > > > > > - } > > > > > - } > > > > > - > > > > > - Method (PCNT, 0, NotSerialized) > > > > > - { > > > > > - BNUM = Zero > > > > > - DVNT (PCIU, One) > > > > > - DVNT (PCID, 0x03) > > > > > - } > > > > > } > > > > > } > > > > > } > > > > > > > > > <div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Sep 29, 2020 at 3:12 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com">mst@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">On Tue, Sep 29, 2020 at 02:21:06PM +0530, Ani Sinha wrote:<br><br>> On Tue, Sep 29, 2020 at 1:53 PM Ani Sinha <<a href="mailto:ani@anisinha.ca" target="_blank">ani@anisinha.ca</a>> wrote:<br><br>> ><br><br>> > On Tue, Sep 29, 2020 at 12:56 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>> wrote:<br><br>> > ><br><br>> > > On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote:<br><br>> > > > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>> wrote:<br><br>> > > > ><br><br>> > > > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote:<br><br>> > > > > > This change adds a new DSDT golden master table blob to test disabling<br><br>> > > > > > hotplug on both pci root bus and pci bridges. Also reverts the change<br><br>> > > > > > in file bios-tables-test-allowed-diff.h to make sure its now empty so that<br><br>> > > > > > future modifications to acpi tables can be caught.<br><br>> > > > > ><br><br>> > > > > > The following is the disassembled diff between DSDT.hpbridge and DSDT.hpbrroot:<br><br>> > > > > ><br><br>> > > > > > @@ -1,30 +1,30 @@<br><br>> > > > > > /*<br><br>> > > > > > * Intel ACPI Component Architecture<br><br>> > > > > > * AML/ASL+ Disassembler version 20180105 (64-bit version)<br><br>> > > > > > * Copyright (c) 2000 - 2018 Intel Corporation<br><br>> > > > > > *<br><br>> > > > > > * Disassembling to symbolic ASL+ operators<br><br>> > > > > > *<br><br>> > > > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Wed Sep 16 09:45:56 2020<br><br>> > > > > > + * Disassembly of /tmp/aml-ECV9Q0, Wed Sep 16 09:45:56 2020<br><br>> > > > > > *<br><br>> > > > > > * Original Table Header:<br><br>> > > > > > * Signature "DSDT"<br><br>> > > > > > - * Length 0x0000131F (4895)<br><br>> > > > > > + * Length 0x00000B89 (2953)<br><br>> > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support<br><br>> > > > > > - * Checksum 0xF9<br><br>> > > > > > + * Checksum 0xA2<br><br>> > > > > > * OEM ID "BOCHS "<br><br>> > > > > > * OEM Table ID "BXPCDSDT"<br><br>> > > > > > * OEM Revision 0x00000001 (1)<br><br>> > > > > > * Compiler ID "BXPC"<br><br>> > > > > > * Compiler Version 0x00000001 (1)<br><br>> > > > > > */<br><br>> > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001)<br><br>> > > > > > {<br><br>> > > > > > Scope (\)<br><br>> > > > > > {<br><br>> > > > > > OperationRegion (DBG, SystemIO, 0x0402, One)<br><br>> > > > > > Field (DBG, ByteAcc, NoLock, Preserve)<br><br>> > > > > > {<br><br>> > > > > > DBGB, 8<br><br>> > > > > > }<br><br>> > > > > ><br><br>> > > > > > @@ -234,64 +234,32 @@<br><br>> > > > > > {<br><br>> > > > > > Name (_HID, EisaId ("PNP0B00") /* AT Real-Time Clock */) // _HID: Hardware ID<br><br>> > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings<br><br>> > > > > > {<br><br>> > > > > > IO (Decode16,<br><br>> > > > > > 0x0070, // Range Minimum<br><br>> > > > > > 0x0070, // Range Maximum<br><br>> > > > > > 0x01, // Alignment<br><br>> > > > > > 0x08, // Length<br><br>> > > > > > )<br><br>> > > > > > IRQNoFlags ()<br><br>> > > > > > {8}<br><br>> > > > > > })<br><br>> > > > > > }<br><br>> > > > > > }<br><br>> > > > > ><br><br>> > > > > > - Scope (_SB.PCI0)<br><br>> > > > > > - {<br><br>> > > > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08)<br><br>> > > > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros)<br><br>> > > > > > - {<br><br>> > > > > > - PCIU, 32,<br><br>> > > > > > - PCID, 32<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04)<br><br>> > > > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros)<br><br>> > > > > > - {<br><br>> > > > > > - B0EJ, 32<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04)<br><br>> > > > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros)<br><br>> > > > > > - {<br><br>> > > > > > - BNUM, 32<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Mutex (BLCK, 0x00)<br><br>> > > > > > - Method (PCEJ, 2, NotSerialized)<br><br>> > > > > > - {<br><br>> > > > > > - Acquire (BLCK, 0xFFFF)<br><br>> > > > > > - BNUM = Arg0<br><br>> > > > > > - B0EJ = (One << Arg1)<br><br>> > > > > > - Release (BLCK)<br><br>> > > > > > - Return (Zero)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > Scope (_SB)<br><br>> > > > > > {<br><br>> > > > > > Scope (PCI0)<br><br>> > > > > > {<br><br>> > > > > > Method (_PRT, 0, NotSerialized) // _PRT: PCI Routing Table<br><br>> > > > > > {<br><br>> > > > > > Local0 = Package (0x80){}<br><br>> > > > > > Local1 = Zero<br><br>> > > > > > While ((Local1 < 0x80))<br><br>> > > > > > {<br><br>> > > > > > Local2 = (Local1 >> 0x02)<br><br>> > > > > > Local3 = ((Local1 + Local2) & 0x03)<br><br>> > > > > > If ((Local3 == Zero))<br><br>> > > > > > {<br><br>> > > > > > Local4 = Package (0x04)<br><br>> > > > > > {<br><br>> > > > > > @@ -690,38 +658,32 @@<br><br>> > > > > > Method (_OST, 3, Serialized) // _OST: OSPM Status Indication<br><br>> > > > > > {<br><br>> > > > > > COST (Zero, Arg0, Arg1, Arg2)<br><br>> > > > > > }<br><br>> > > > > > }<br><br>> > > > > > }<br><br>> > > > > > }<br><br>> > > > > ><br><br>> > > > > > Method (\_GPE._E02, 0, NotSerialized) // _Exx: Edge-Triggered GPE<br><br>> > > > > > {<br><br>> > > > > > \_SB.CPUS.CSCN ()<br><br>> > > > > > }<br><br>> > > > > ><br><br>> > > > > > Scope (_GPE)<br><br>> > > > > > {<br><br>> > > > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID<br><br>> > > > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE<br><br>> > > > > > - {<br><br>> > > > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF)<br><br>> > > > > > - \_SB.PCI0.PCNT ()<br><br>> > > > > > - Release (\_SB.PCI0.BLCK)<br><br>> > > > > > - }<br><br>> > > > > > }<br><br>> > > > > ><br><br>> > > > > > Scope (\_SB.PCI0)<br><br>> > > > > > {<br><br>> > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings<br><br>> > > > > > {<br><br>> > > > > > WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,<br><br>> > > > > > 0x0000, // Granularity<br><br>> > > > > > 0x0000, // Range Minimum<br><br>> > > > > > 0x00FF, // Range Maximum<br><br>> > > > > > 0x0000, // Translation Offset<br><br>> > > > > > 0x0100, // Length<br><br>> > > > > > ,, )<br><br>> > > > > > IO (Decode16,<br><br>> > > > > > 0x0CF8, // Range Minimum<br><br>> > > > > > 0x0CF8, // Range Maximum<br><br>> > > > > > @@ -766,48 +728,32 @@<br><br>> > > > > > })<br><br>> > > > > > Device (GPE0)<br><br>> > > > > > {<br><br>> > > > > > Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID<br><br>> > > > > > Name (_UID, "GPE0 resources") // _UID: Unique ID<br><br>> > > > > > Name (_STA, 0x0B) // _STA: Status<br><br>> > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings<br><br>> > > > > > {<br><br>> > > > > > IO (Decode16,<br><br>> > > > > > 0xAFE0, // Range Minimum<br><br>> > > > > > 0xAFE0, // Range Maximum<br><br>> > > > > > 0x01, // Alignment<br><br>> > > > > > 0x04, // Length<br><br>> > > > > > )<br><br>> > > > > > })<br><br>> > > > > > }<br><br>> > > > > > -<br><br>> > > > > > - Device (PHPR)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID<br><br>> > > > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID<br><br>> > > > > > - Name (_STA, 0x0B) // _STA: Status<br><br>> > > > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings<br><br>> > > > > > - {<br><br>> > > > > > - IO (Decode16,<br><br>> > > > > > - 0xAE00, // Range Minimum<br><br>> > > > > > - 0xAE00, // Range Maximum<br><br>> > > > > > - 0x01, // Alignment<br><br>> > > > > > - 0x14, // Length<br><br>> > > > > > - )<br><br>> > > > > > - })<br><br>> > > > > > - }<br><br>> > > > > > }<br><br>> > > > > ><br><br>> > > > > > Scope (\)<br><br>> > > > > > {<br><br>> > > > > > Name (_S3, Package (0x04) // _S3_: S3 System State<br><br>> > > > > > {<br><br>> > > > > > One,<br><br>> > > > > > One,<br><br>> > > > > > Zero,<br><br>> > > > > > Zero<br><br>> > > > > > })<br><br>> > > > > > Name (_S4, Package (0x04) // _S4_: S4 System State<br><br>> > > > > > {<br><br>> > > > > > 0x02,<br><br>> > > > > > 0x02,<br><br>> > > > > > Zero,<br><br>> > > > > > @@ -831,479 +777,48 @@<br><br>> > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings<br><br>> > > > > > {<br><br>> > > > > > IO (Decode16,<br><br>> > > > > > 0x0510, // Range Minimum<br><br>> > > > > > 0x0510, // Range Maximum<br><br>> > > > > > 0x01, // Alignment<br><br>> > > > > > 0x0C, // Length<br><br>> > > > > > )<br><br>> > > > > > })<br><br>> > > > > > }<br><br>> > > > > > }<br><br>> > > > > ><br><br>> > > > > > Scope (\_SB)<br><br>> > > > > > {<br><br>> > > > > > Scope (PCI0)<br><br>> > > > > > {<br><br>> > > > > > - Name (BSEL, Zero)<br><br>> > > > > > Device (S00)<br><br>> > > > > > {<br><br>> > > > > > Name (_ADR, Zero) // _ADR: Address<br><br>> > > > > > }<br><br>> > > > > ><br><br>> > > > > > Device (S10)<br><br>> > > > > > {<br><br>> > > > > > Name (_ADR, 0x00020000) // _ADR: Address<br><br>> > > > > > Method (_S1D, 0, NotSerialized) // _S1D: S1 Device State<br><br>> > > > > > {<br><br>> > > > > > Return (Zero)<br><br>> > > > > > }<br><br>> > > > > ><br><br>> > > > > > Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State<br><br>> > > > > > {<br><br>> > > > > > Return (Zero)<br><br>> > > > > > }<br><br>> > > > > ><br><br>> > > > > > Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State<br><br>> > > > > > {<br><br>> > > > > > Return (Zero)<br><br>> > > > > > }<br><br>> > > > > > }<br><br>> > > > > ><br><br>> > > > > > Device (S18)<br><br>> > > > > > {<br><br>> > > > > > Name (_ADR, 0x00030000) // _ADR: Address<br><br>> > > > > > }<br><br>> > > > > > -<br><br>> > > > > > - Device (S20)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x04) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x00040000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (S28)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x05) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x00050000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (S30)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x06) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x00060000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (S38)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x07) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x00070000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (S40)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x08) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x00080000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (S48)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x09) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x00090000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (S50)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x000A0000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (S58)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x000B0000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (S60)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x000C0000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (S68)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x000D0000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (S70)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x000E0000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (S78)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x000F0000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (S80)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x10) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x00100000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (S88)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x11) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x00110000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (S90)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x12) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x00120000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (S98)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x13) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x00130000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (SA0)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x14) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x00140000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (SA8)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x15) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x00150000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (SB0)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x16) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x00160000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (SB8)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x17) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x00170000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (SC0)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x18) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x00180000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (SC8)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x19) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x00190000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (SD0)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x001A0000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (SD8)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x001B0000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (SE0)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x001C0000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (SE8)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x001D0000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (SF0)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x001E0000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Device (SF8)<br><br>> > > > > > - {<br><br>> > > > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number<br><br>> > > > > > - Name (_ADR, 0x001F0000) // _ADR: Address<br><br>> > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device<br><br>> > > > > > - {<br><br>> > > > > > - PCEJ (BSEL, _SUN)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Method (DVNT, 2, NotSerialized)<br><br>> > > > > > - {<br><br>> > > > > > - If ((Arg0 & 0x10))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (S20, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x20))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (S28, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x40))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (S30, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x80))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (S38, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x0100))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (S40, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x0200))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (S48, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x0400))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (S50, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x0800))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (S58, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x1000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (S60, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x2000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (S68, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x4000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (S70, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x8000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (S78, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x00010000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (S80, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x00020000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (S88, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x00040000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (S90, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x00080000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (S98, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x00100000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (SA0, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x00200000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (SA8, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x00400000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (SB0, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x00800000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (SB8, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x01000000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (SC0, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x02000000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (SC8, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x04000000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (SD0, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x08000000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (SD8, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x10000000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (SE0, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x20000000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (SE8, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x40000000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (SF0, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - If ((Arg0 & 0x80000000))<br><br>> > > > > > - {<br><br>> > > > > > - Notify (SF8, Arg1)<br><br>> > > > > > - }<br><br>> > > > > > - }<br><br>> > > > > > -<br><br>> > > > > > - Method (PCNT, 0, NotSerialized)<br><br>> > > > > > - {<br><br>> > > > > > - BNUM = Zero<br><br>> > > > > > - DVNT (PCIU, One)<br><br>> > > > > > - DVNT (PCID, 0x03)<br><br>> > > > > > - }<br><br>> > > > > > }<br><br>> > > > > > }<br><br>> > > > > > }<br><br>> > > > ><br><br>> > > > > This is not the only diff I see if I apply this patchset on<br><br>> > > > > top of master.<br><br>> > > > > Dropped this and the previous patch.<br><br>> > > > > Please check what is going on and repost as appropriate.<br><br>> > > ><br><br>> > > > Which two ACPI DSDT files are you diffing? What diff are you getting?<br><br>> > ><br><br>> > ><br><br>> > > diff -rup ./tests/data/acpi/pc/DSDT.hpbridge.dsl ./tests/data/acpi/pc/DSDT.hpbrroot.dsl<br><br>> ><br><br>> > I re-based my patchset on top of the latest qemu master and did a make<br><br>> > && make check-qtest-x86_64 V=1.<br><br>> > They pass. I am seeing this diff:<br><br>> > <a href="https://pastebin.ubuntu.com/p/BXy9GFfB2R/" rel="noreferrer" target="_blank">https://pastebin.ubuntu.com/p/BXy9GFfB2R/</a><br><br>> ><br><br>> > and it looks good to me.<br><br>> ><br><br>> > Not sure why your diff looks different. Maybe you can regenerate the blob?<br><br>> <br><br>> I did a full make check and it passed. I compared the diff again and<br><br>> it's the same. I checked my tree and it looks clean. These are the<br><br>> patches I have:<br><br>> <br><br>> $ git log --oneline<br><br>> 20d1323e10 (HEAD -> master) qom: code hardening - have bound checking<br><br>> while looping with integer value<br><br>> 0f69dae0e2 Add a comment in bios-tables-test.c to clarify the reason<br><br>> behind approach<br><br>> dd9a8c3cd3 tests/acpi: add DSDT.hpbrroot DSDT table blob to test<br><br>> global i440fx hotplug<br><br>> 5b93474fe9 tests/acpi: unit test exercising global pci hotplug off for i440fx<br><br>> 54c33e334a tests/acpi: update golden master DSDT binary table blobs for q35<br><br>> 2279f61f30 piix4: don't reserve hw resources when hotplug is off globally<br><br>> 1f61c524a0 Add ACPI DSDT tables for q35 that are being updated by the next patch<br><br>> bdd823611b tests/acpi: add newly added acpi DSDT table blob for pci<br><br>> bridge hotplug flag<br><br>> 8c80f8fba9 tests/acpi: unit test for<br><br>> 'acpi-pci-hotplug-with-bridge-support' bridge flag<br><br>> e0a3142df9 tests/acpi: list added acpi table binary file for pci<br><br>> bridge hotplug test<br><br>> 0ba08317a8 i440fx/acpi: do not add hotplug related amls for cold plugged bridges<br><br>> 73b191ade6 Fix a gap where acpi_pcihp_find_hotplug_bus() returns a<br><br>> non-hotpluggable bus<br><br>> ef0e526cc2 tests/acpi: add a new ACPI table in order to test root pci<br><br>> hotplug on/off<br><br>> c6d13264f8 tests/acpi: add new unit test to test hotplug off/on<br><br>> feature on the root pci bus<br><br>> 6901bada65 tests/acpi: mark addition of table DSDT.roothp for unit<br><br>> testing root pci hotplug<br><br>> 74504514b1 (origin/master, origin/HEAD) Merge remote-tracking branch<br><br>> 'remotes/alistair/tags/pull-register-20200927' into staging<br><br><br><br>Try applying on top of latest pull request?</blockquote><div dir="auto"><br></div><div dir="auto">Maybe I'm missing something but can you point me to the latest pull request? </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)" dir="auto"><br><br><br><br><br><br>> <br><br>> ><br><br>> > ><br><br>> > ><br><br>> > ><br><br>> > > --- ./tests/data/acpi/pc/DSDT.hpbridge.dsl 2020-09-29 02:44:43.874622404 -0400<br><br>> > > +++ ./tests/data/acpi/pc/DSDT.hpbrroot.dsl 2020-09-29 02:44:43.876622403 -0400<br><br>> > > @@ -5,13 +5,13 @@<br><br>> > > *<br><br>> > > * Disassembling to symbolic ASL+ operators<br><br>> > > *<br><br>> > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 02:44:43 2020<br><br>> > > + * Disassembly of tests/data/acpi/pc/DSDT.hpbrroot, Tue Sep 29 02:44:43 2020<br><br>> > > *<br><br>> > > * Original Table Header:<br><br>> > > * Signature "DSDT"<br><br>> > > - * Length 0x0000139D (5021)<br><br>> > > + * Length 0x00000B89 (2953)<br><br>> > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support<br><br>> > > - * Checksum 0x05<br><br>> > > + * Checksum 0xA2<br><br>> > > * OEM ID "BOCHS "<br><br>> > > * OEM Table ID "BXPCDSDT"<br><br>> > > * OEM Revision 0x00000001 (1)<br><br>> > > @@ -247,38 +247,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "<br><br>> > > }<br><br>> > > }<br><br>> > ><br><br>> > > - Scope (_SB.PCI0)<br><br>> > > - {<br><br>> > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08)<br><br>> > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros)<br><br>> > > - {<br><br>> > > - PCIU, 32,<br><br>> > > - PCID, 32<br><br>> > > - }<br><br>> > > -<br><br>> > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04)<br><br>> > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros)<br><br>> > > - {<br><br>> > > - B0EJ, 32<br><br>> > > - }<br><br>> > > -<br><br>> > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04)<br><br>> > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros)<br><br>> > > - {<br><br>> > > - BNUM, 32<br><br>> > > - }<br><br>> > > -<br><br>> > > - Mutex (BLCK, 0x00)<br><br>> > > - Method (PCEJ, 2, NotSerialized)<br><br>> > > - {<br><br>> > > - Acquire (BLCK, 0xFFFF)<br><br>> > > - BNUM = Arg0<br><br>> > > - B0EJ = (One << Arg1)<br><br>> > > - Release (BLCK)<br><br>> > > - Return (Zero)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > Scope (_SB)<br><br>> > > {<br><br>> > > Scope (PCI0)<br><br>> > > @@ -643,56 +611,22 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "<br><br>> > > Method (CSCN, 0, Serialized)<br><br>> > > {<br><br>> > > Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF)<br><br>> > > - Name (CNEW, Package (0xFF){})<br><br>> > > - Local3 = Zero<br><br>> > > - Local4 = One<br><br>> > > - While ((Local4 == One))<br><br>> > > + Local0 = One<br><br>> > > + While ((Local0 == One))<br><br>> > > {<br><br>> > > - Local4 = Zero<br><br>> > > - Local0 = One<br><br>> > > - Local1 = Zero<br><br>> > > - While (((Local0 == One) && (Local3 < One)))<br><br>> > > + Local0 = Zero<br><br>> > > + \_SB.PCI0.PRES.CCMD = Zero<br><br>> > > + If ((\_SB.PCI0.PRES.CINS == One))<br><br>> > > {<br><br>> > > - Local0 = Zero<br><br>> > > - \_SB.PCI0.PRES.CSEL = Local3<br><br>> > > - \_SB.PCI0.PRES.CCMD = Zero<br><br>> > > - If ((\_SB.PCI0.PRES.CDAT < Local3))<br><br>> > > - {<br><br>> > > - Break<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Local1 == 0xFF))<br><br>> > > - {<br><br>> > > - Local4 = One<br><br>> > > - Break<br><br>> > > - }<br><br>> > > -<br><br>> > > - Local3 = \_SB.PCI0.PRES.CDAT<br><br>> > > - If ((\_SB.PCI0.PRES.CINS == One))<br><br>> > > - {<br><br>> > > - CNEW [Local1] = Local3<br><br>> > > - Local1++<br><br>> > > - Local0 = One<br><br>> > > - }<br><br>> > > - ElseIf ((\_SB.PCI0.PRES.CRMV == One))<br><br>> > > - {<br><br>> > > - CTFY (Local3, 0x03)<br><br>> > > - \_SB.PCI0.PRES.CRMV = One<br><br>> > > - Local0 = One<br><br>> > > - }<br><br>> > > -<br><br>> > > - Local3++<br><br>> > > + CTFY (\_SB.PCI0.PRES.CDAT, One)<br><br>> > > + \_SB.PCI0.PRES.CINS = One<br><br>> > > + Local0 = One<br><br>> > > }<br><br>> > > -<br><br>> > > - Local2 = Zero<br><br>> > > - While ((Local2 < Local1))<br><br>> > > + ElseIf ((\_SB.PCI0.PRES.CRMV == One))<br><br>> > > {<br><br>> > > - Local3 = DerefOf (CNEW [Local2])<br><br>> > > - CTFY (Local3, One)<br><br>> > > - Debug = Local3<br><br>> > > - \_SB.PCI0.PRES.CSEL = Local3<br><br>> > > - \_SB.PCI0.PRES.CINS = One<br><br>> > > - Local2++<br><br>> > > + CTFY (\_SB.PCI0.PRES.CDAT, 0x03)<br><br>> > > + \_SB.PCI0.PRES.CRMV = One<br><br>> > > + Local0 = One<br><br>> > > }<br><br>> > > }<br><br>> > ><br><br>> > > @@ -737,12 +671,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "<br><br>> > > Scope (_GPE)<br><br>> > > {<br><br>> > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID<br><br>> > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE, xx=0x00-0xFF<br><br>> > > - {<br><br>> > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF)<br><br>> > > - \_SB.PCI0.PCNT ()<br><br>> > > - Release (\_SB.PCI0.BLCK)<br><br>> > > - }<br><br>> > > }<br><br>> > ><br><br>> > > Scope (\_SB.PCI0)<br><br>> > > @@ -813,22 +741,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "<br><br>> > > )<br><br>> > > })<br><br>> > > }<br><br>> > > -<br><br>> > > - Device (PHPR)<br><br>> > > - {<br><br>> > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID<br><br>> > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID<br><br>> > > - Name (_STA, 0x0B) // _STA: Status<br><br>> > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings<br><br>> > > - {<br><br>> > > - IO (Decode16,<br><br>> > > - 0xAE00, // Range Minimum<br><br>> > > - 0xAE00, // Range Maximum<br><br>> > > - 0x01, // Alignment<br><br>> > > - 0x14, // Length<br><br>> > > - )<br><br>> > > - })<br><br>> > > - }<br><br>> > > }<br><br>> > ><br><br>> > > Scope (\)<br><br>> > > @@ -878,7 +790,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "<br><br>> > > {<br><br>> > > Scope (PCI0)<br><br>> > > {<br><br>> > > - Name (BSEL, Zero)<br><br>> > > Device (S00)<br><br>> > > {<br><br>> > > Name (_ADR, Zero) // _ADR: Address<br><br>> > > @@ -907,436 +818,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "<br><br>> > > {<br><br>> > > Name (_ADR, 0x00030000) // _ADR: Address<br><br>> > > }<br><br>> > > -<br><br>> > > - Device (S20)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x04) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x00040000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (S28)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x05) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x00050000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (S30)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x06) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x00060000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (S38)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x07) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x00070000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (S40)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x08) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x00080000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (S48)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x09) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x00090000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (S50)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x0A) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x000A0000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (S58)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x0B) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x000B0000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (S60)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x0C) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x000C0000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (S68)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x0D) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x000D0000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (S70)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x0E) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x000E0000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (S78)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x0F) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x000F0000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (S80)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x10) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x00100000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (S88)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x11) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x00110000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (S90)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x12) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x00120000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (S98)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x13) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x00130000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (SA0)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x14) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x00140000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (SA8)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x15) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x00150000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (SB0)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x16) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x00160000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (SB8)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x17) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x00170000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (SC0)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x18) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x00180000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (SC8)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x19) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x00190000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (SD0)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x1A) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x001A0000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (SD8)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x1B) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x001B0000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (SE0)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x1C) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x001C0000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (SE8)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x1D) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x001D0000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (SF0)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x1E) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x001E0000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Device (SF8)<br><br>> > > - {<br><br>> > > - Name (_SUN, 0x1F) // _SUN: Slot User Number<br><br>> > > - Name (_ADR, 0x001F0000) // _ADR: Address<br><br>> > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9<br><br>> > > - {<br><br>> > > - PCEJ (BSEL, _SUN)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Method (DVNT, 2, NotSerialized)<br><br>> > > - {<br><br>> > > - If ((Arg0 & 0x10))<br><br>> > > - {<br><br>> > > - Notify (S20, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x20))<br><br>> > > - {<br><br>> > > - Notify (S28, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x40))<br><br>> > > - {<br><br>> > > - Notify (S30, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x80))<br><br>> > > - {<br><br>> > > - Notify (S38, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x0100))<br><br>> > > - {<br><br>> > > - Notify (S40, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x0200))<br><br>> > > - {<br><br>> > > - Notify (S48, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x0400))<br><br>> > > - {<br><br>> > > - Notify (S50, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x0800))<br><br>> > > - {<br><br>> > > - Notify (S58, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x1000))<br><br>> > > - {<br><br>> > > - Notify (S60, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x2000))<br><br>> > > - {<br><br>> > > - Notify (S68, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x4000))<br><br>> > > - {<br><br>> > > - Notify (S70, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x8000))<br><br>> > > - {<br><br>> > > - Notify (S78, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x00010000))<br><br>> > > - {<br><br>> > > - Notify (S80, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x00020000))<br><br>> > > - {<br><br>> > > - Notify (S88, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x00040000))<br><br>> > > - {<br><br>> > > - Notify (S90, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x00080000))<br><br>> > > - {<br><br>> > > - Notify (S98, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x00100000))<br><br>> > > - {<br><br>> > > - Notify (SA0, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x00200000))<br><br>> > > - {<br><br>> > > - Notify (SA8, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x00400000))<br><br>> > > - {<br><br>> > > - Notify (SB0, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x00800000))<br><br>> > > - {<br><br>> > > - Notify (SB8, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x01000000))<br><br>> > > - {<br><br>> > > - Notify (SC0, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x02000000))<br><br>> > > - {<br><br>> > > - Notify (SC8, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x04000000))<br><br>> > > - {<br><br>> > > - Notify (SD0, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x08000000))<br><br>> > > - {<br><br>> > > - Notify (SD8, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x10000000))<br><br>> > > - {<br><br>> > > - Notify (SE0, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x20000000))<br><br>> > > - {<br><br>> > > - Notify (SE8, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x40000000))<br><br>> > > - {<br><br>> > > - Notify (SF0, Arg1)<br><br>> > > - }<br><br>> > > -<br><br>> > > - If ((Arg0 & 0x80000000))<br><br>> > > - {<br><br>> > > - Notify (SF8, Arg1)<br><br>> > > - }<br><br>> > > - }<br><br>> > > -<br><br>> > > - Method (PCNT, 0, NotSerialized)<br><br>> > > - {<br><br>> > > - BNUM = Zero<br><br>> > > - DVNT (PCIU, One)<br><br>> > > - DVNT (PCID, 0x03)<br><br>> > > - }<br><br>> > > }<br><br>> > > }<br><br>> > > }<br><br>> > ><br><br><br><br></blockquote></div></div>
In your pull request the following patch is completely screwed up:
commit cda2006eded0ed91974e1d9e7f9f288e65812a3e
Author: Ani Sinha <ani@anisinha.ca>
Date: Tue Sep 29 03:22:52 2020 -0400
tests/acpi: update golden master DSDT binary table blobs for q35
This is not my patch. It has all sorts of changes which does not
belong there. Can you please check?
On Tue, Sep 29, 2020 at 3:20 PM Ani Sinha <ani@anisinha.ca> wrote:
>
>
>
> On Tue, Sep 29, 2020 at 3:12 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>>
>> On Tue, Sep 29, 2020 at 02:21:06PM +0530, Ani Sinha wrote:
>>
>> > On Tue, Sep 29, 2020 at 1:53 PM Ani Sinha <ani@anisinha.ca> wrote:
>>
>> > >
>>
>> > > On Tue, Sep 29, 2020 at 12:56 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>>
>> > > >
>>
>> > > > On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote:
>>
>> > > > > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>>
>> > > > > >
>>
>> > > > > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote:
>>
>> > > > > > > This change adds a new DSDT golden master table blob to test disabling
>>
>> > > > > > > hotplug on both pci root bus and pci bridges. Also reverts the change
>>
>> > > > > > > in file bios-tables-test-allowed-diff.h to make sure its now empty so that
>>
>> > > > > > > future modifications to acpi tables can be caught.
>>
>> > > > > > >
>>
>> > > > > > > The following is the disassembled diff between DSDT.hpbridge and DSDT.hpbrroot:
>>
>> > > > > > >
>>
>> > > > > > > @@ -1,30 +1,30 @@
>>
>> > > > > > > /*
>>
>> > > > > > > * Intel ACPI Component Architecture
>>
>> > > > > > > * AML/ASL+ Disassembler version 20180105 (64-bit version)
>>
>> > > > > > > * Copyright (c) 2000 - 2018 Intel Corporation
>>
>> > > > > > > *
>>
>> > > > > > > * Disassembling to symbolic ASL+ operators
>>
>> > > > > > > *
>>
>> > > > > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Wed Sep 16 09:45:56 2020
>>
>> > > > > > > + * Disassembly of /tmp/aml-ECV9Q0, Wed Sep 16 09:45:56 2020
>>
>> > > > > > > *
>>
>> > > > > > > * Original Table Header:
>>
>> > > > > > > * Signature "DSDT"
>>
>> > > > > > > - * Length 0x0000131F (4895)
>>
>> > > > > > > + * Length 0x00000B89 (2953)
>>
>> > > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support
>>
>> > > > > > > - * Checksum 0xF9
>>
>> > > > > > > + * Checksum 0xA2
>>
>> > > > > > > * OEM ID "BOCHS "
>>
>> > > > > > > * OEM Table ID "BXPCDSDT"
>>
>> > > > > > > * OEM Revision 0x00000001 (1)
>>
>> > > > > > > * Compiler ID "BXPC"
>>
>> > > > > > > * Compiler Version 0x00000001 (1)
>>
>> > > > > > > */
>>
>> > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001)
>>
>> > > > > > > {
>>
>> > > > > > > Scope (\)
>>
>> > > > > > > {
>>
>> > > > > > > OperationRegion (DBG, SystemIO, 0x0402, One)
>>
>> > > > > > > Field (DBG, ByteAcc, NoLock, Preserve)
>>
>> > > > > > > {
>>
>> > > > > > > DBGB, 8
>>
>> > > > > > > }
>>
>> > > > > > >
>>
>> > > > > > > @@ -234,64 +234,32 @@
>>
>> > > > > > > {
>>
>> > > > > > > Name (_HID, EisaId ("PNP0B00") /* AT Real-Time Clock */) // _HID: Hardware ID
>>
>> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
>>
>> > > > > > > {
>>
>> > > > > > > IO (Decode16,
>>
>> > > > > > > 0x0070, // Range Minimum
>>
>> > > > > > > 0x0070, // Range Maximum
>>
>> > > > > > > 0x01, // Alignment
>>
>> > > > > > > 0x08, // Length
>>
>> > > > > > > )
>>
>> > > > > > > IRQNoFlags ()
>>
>> > > > > > > {8}
>>
>> > > > > > > })
>>
>> > > > > > > }
>>
>> > > > > > > }
>>
>> > > > > > >
>>
>> > > > > > > - Scope (_SB.PCI0)
>>
>> > > > > > > - {
>>
>> > > > > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08)
>>
>> > > > > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros)
>>
>> > > > > > > - {
>>
>> > > > > > > - PCIU, 32,
>>
>> > > > > > > - PCID, 32
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04)
>>
>> > > > > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros)
>>
>> > > > > > > - {
>>
>> > > > > > > - B0EJ, 32
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04)
>>
>> > > > > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros)
>>
>> > > > > > > - {
>>
>> > > > > > > - BNUM, 32
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Mutex (BLCK, 0x00)
>>
>> > > > > > > - Method (PCEJ, 2, NotSerialized)
>>
>> > > > > > > - {
>>
>> > > > > > > - Acquire (BLCK, 0xFFFF)
>>
>> > > > > > > - BNUM = Arg0
>>
>> > > > > > > - B0EJ = (One << Arg1)
>>
>> > > > > > > - Release (BLCK)
>>
>> > > > > > > - Return (Zero)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > Scope (_SB)
>>
>> > > > > > > {
>>
>> > > > > > > Scope (PCI0)
>>
>> > > > > > > {
>>
>> > > > > > > Method (_PRT, 0, NotSerialized) // _PRT: PCI Routing Table
>>
>> > > > > > > {
>>
>> > > > > > > Local0 = Package (0x80){}
>>
>> > > > > > > Local1 = Zero
>>
>> > > > > > > While ((Local1 < 0x80))
>>
>> > > > > > > {
>>
>> > > > > > > Local2 = (Local1 >> 0x02)
>>
>> > > > > > > Local3 = ((Local1 + Local2) & 0x03)
>>
>> > > > > > > If ((Local3 == Zero))
>>
>> > > > > > > {
>>
>> > > > > > > Local4 = Package (0x04)
>>
>> > > > > > > {
>>
>> > > > > > > @@ -690,38 +658,32 @@
>>
>> > > > > > > Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
>>
>> > > > > > > {
>>
>> > > > > > > COST (Zero, Arg0, Arg1, Arg2)
>>
>> > > > > > > }
>>
>> > > > > > > }
>>
>> > > > > > > }
>>
>> > > > > > > }
>>
>> > > > > > >
>>
>> > > > > > > Method (\_GPE._E02, 0, NotSerialized) // _Exx: Edge-Triggered GPE
>>
>> > > > > > > {
>>
>> > > > > > > \_SB.CPUS.CSCN ()
>>
>> > > > > > > }
>>
>> > > > > > >
>>
>> > > > > > > Scope (_GPE)
>>
>> > > > > > > {
>>
>> > > > > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID
>>
>> > > > > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE
>>
>> > > > > > > - {
>>
>> > > > > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF)
>>
>> > > > > > > - \_SB.PCI0.PCNT ()
>>
>> > > > > > > - Release (\_SB.PCI0.BLCK)
>>
>> > > > > > > - }
>>
>> > > > > > > }
>>
>> > > > > > >
>>
>> > > > > > > Scope (\_SB.PCI0)
>>
>> > > > > > > {
>>
>> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
>>
>> > > > > > > {
>>
>> > > > > > > WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode,
>>
>> > > > > > > 0x0000, // Granularity
>>
>> > > > > > > 0x0000, // Range Minimum
>>
>> > > > > > > 0x00FF, // Range Maximum
>>
>> > > > > > > 0x0000, // Translation Offset
>>
>> > > > > > > 0x0100, // Length
>>
>> > > > > > > ,, )
>>
>> > > > > > > IO (Decode16,
>>
>> > > > > > > 0x0CF8, // Range Minimum
>>
>> > > > > > > 0x0CF8, // Range Maximum
>>
>> > > > > > > @@ -766,48 +728,32 @@
>>
>> > > > > > > })
>>
>> > > > > > > Device (GPE0)
>>
>> > > > > > > {
>>
>> > > > > > > Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID
>>
>> > > > > > > Name (_UID, "GPE0 resources") // _UID: Unique ID
>>
>> > > > > > > Name (_STA, 0x0B) // _STA: Status
>>
>> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
>>
>> > > > > > > {
>>
>> > > > > > > IO (Decode16,
>>
>> > > > > > > 0xAFE0, // Range Minimum
>>
>> > > > > > > 0xAFE0, // Range Maximum
>>
>> > > > > > > 0x01, // Alignment
>>
>> > > > > > > 0x04, // Length
>>
>> > > > > > > )
>>
>> > > > > > > })
>>
>> > > > > > > }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (PHPR)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID
>>
>> > > > > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID
>>
>> > > > > > > - Name (_STA, 0x0B) // _STA: Status
>>
>> > > > > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
>>
>> > > > > > > - {
>>
>> > > > > > > - IO (Decode16,
>>
>> > > > > > > - 0xAE00, // Range Minimum
>>
>> > > > > > > - 0xAE00, // Range Maximum
>>
>> > > > > > > - 0x01, // Alignment
>>
>> > > > > > > - 0x14, // Length
>>
>> > > > > > > - )
>>
>> > > > > > > - })
>>
>> > > > > > > - }
>>
>> > > > > > > }
>>
>> > > > > > >
>>
>> > > > > > > Scope (\)
>>
>> > > > > > > {
>>
>> > > > > > > Name (_S3, Package (0x04) // _S3_: S3 System State
>>
>> > > > > > > {
>>
>> > > > > > > One,
>>
>> > > > > > > One,
>>
>> > > > > > > Zero,
>>
>> > > > > > > Zero
>>
>> > > > > > > })
>>
>> > > > > > > Name (_S4, Package (0x04) // _S4_: S4 System State
>>
>> > > > > > > {
>>
>> > > > > > > 0x02,
>>
>> > > > > > > 0x02,
>>
>> > > > > > > Zero,
>>
>> > > > > > > @@ -831,479 +777,48 @@
>>
>> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
>>
>> > > > > > > {
>>
>> > > > > > > IO (Decode16,
>>
>> > > > > > > 0x0510, // Range Minimum
>>
>> > > > > > > 0x0510, // Range Maximum
>>
>> > > > > > > 0x01, // Alignment
>>
>> > > > > > > 0x0C, // Length
>>
>> > > > > > > )
>>
>> > > > > > > })
>>
>> > > > > > > }
>>
>> > > > > > > }
>>
>> > > > > > >
>>
>> > > > > > > Scope (\_SB)
>>
>> > > > > > > {
>>
>> > > > > > > Scope (PCI0)
>>
>> > > > > > > {
>>
>> > > > > > > - Name (BSEL, Zero)
>>
>> > > > > > > Device (S00)
>>
>> > > > > > > {
>>
>> > > > > > > Name (_ADR, Zero) // _ADR: Address
>>
>> > > > > > > }
>>
>> > > > > > >
>>
>> > > > > > > Device (S10)
>>
>> > > > > > > {
>>
>> > > > > > > Name (_ADR, 0x00020000) // _ADR: Address
>>
>> > > > > > > Method (_S1D, 0, NotSerialized) // _S1D: S1 Device State
>>
>> > > > > > > {
>>
>> > > > > > > Return (Zero)
>>
>> > > > > > > }
>>
>> > > > > > >
>>
>> > > > > > > Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State
>>
>> > > > > > > {
>>
>> > > > > > > Return (Zero)
>>
>> > > > > > > }
>>
>> > > > > > >
>>
>> > > > > > > Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State
>>
>> > > > > > > {
>>
>> > > > > > > Return (Zero)
>>
>> > > > > > > }
>>
>> > > > > > > }
>>
>> > > > > > >
>>
>> > > > > > > Device (S18)
>>
>> > > > > > > {
>>
>> > > > > > > Name (_ADR, 0x00030000) // _ADR: Address
>>
>> > > > > > > }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (S20)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x04) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x00040000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (S28)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x05) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x00050000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (S30)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x06) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x00060000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (S38)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x07) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x00070000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (S40)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x08) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x00080000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (S48)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x09) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x00090000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (S50)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x000A0000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (S58)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x000B0000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (S60)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x000C0000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (S68)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x000D0000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (S70)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x000E0000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (S78)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x000F0000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (S80)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x10) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x00100000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (S88)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x11) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x00110000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (S90)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x12) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x00120000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (S98)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x13) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x00130000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (SA0)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x14) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x00140000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (SA8)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x15) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x00150000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (SB0)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x16) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x00160000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (SB8)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x17) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x00170000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (SC0)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x18) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x00180000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (SC8)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x19) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x00190000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (SD0)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x001A0000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (SD8)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x001B0000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (SE0)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x001C0000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (SE8)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x001D0000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (SF0)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x001E0000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Device (SF8)
>>
>> > > > > > > - {
>>
>> > > > > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number
>>
>> > > > > > > - Name (_ADR, 0x001F0000) // _ADR: Address
>>
>> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
>>
>> > > > > > > - {
>>
>> > > > > > > - PCEJ (BSEL, _SUN)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Method (DVNT, 2, NotSerialized)
>>
>> > > > > > > - {
>>
>> > > > > > > - If ((Arg0 & 0x10))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (S20, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x20))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (S28, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x40))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (S30, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x80))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (S38, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x0100))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (S40, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x0200))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (S48, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x0400))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (S50, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x0800))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (S58, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x1000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (S60, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x2000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (S68, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x4000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (S70, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x8000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (S78, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x00010000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (S80, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x00020000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (S88, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x00040000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (S90, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x00080000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (S98, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x00100000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (SA0, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x00200000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (SA8, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x00400000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (SB0, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x00800000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (SB8, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x01000000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (SC0, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x02000000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (SC8, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x04000000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (SD0, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x08000000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (SD8, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x10000000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (SE0, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x20000000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (SE8, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x40000000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (SF0, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - If ((Arg0 & 0x80000000))
>>
>> > > > > > > - {
>>
>> > > > > > > - Notify (SF8, Arg1)
>>
>> > > > > > > - }
>>
>> > > > > > > - }
>>
>> > > > > > > -
>>
>> > > > > > > - Method (PCNT, 0, NotSerialized)
>>
>> > > > > > > - {
>>
>> > > > > > > - BNUM = Zero
>>
>> > > > > > > - DVNT (PCIU, One)
>>
>> > > > > > > - DVNT (PCID, 0x03)
>>
>> > > > > > > - }
>>
>> > > > > > > }
>>
>> > > > > > > }
>>
>> > > > > > > }
>>
>> > > > > >
>>
>> > > > > > This is not the only diff I see if I apply this patchset on
>>
>> > > > > > top of master.
>>
>> > > > > > Dropped this and the previous patch.
>>
>> > > > > > Please check what is going on and repost as appropriate.
>>
>> > > > >
>>
>> > > > > Which two ACPI DSDT files are you diffing? What diff are you getting?
>>
>> > > >
>>
>> > > >
>>
>> > > > diff -rup ./tests/data/acpi/pc/DSDT.hpbridge.dsl ./tests/data/acpi/pc/DSDT.hpbrroot.dsl
>>
>> > >
>>
>> > > I re-based my patchset on top of the latest qemu master and did a make
>>
>> > > && make check-qtest-x86_64 V=1.
>>
>> > > They pass. I am seeing this diff:
>>
>> > > https://pastebin.ubuntu.com/p/BXy9GFfB2R/
>>
>> > >
>>
>> > > and it looks good to me.
>>
>> > >
>>
>> > > Not sure why your diff looks different. Maybe you can regenerate the blob?
>>
>> >
>>
>> > I did a full make check and it passed. I compared the diff again and
>>
>> > it's the same. I checked my tree and it looks clean. These are the
>>
>> > patches I have:
>>
>> >
>>
>> > $ git log --oneline
>>
>> > 20d1323e10 (HEAD -> master) qom: code hardening - have bound checking
>>
>> > while looping with integer value
>>
>> > 0f69dae0e2 Add a comment in bios-tables-test.c to clarify the reason
>>
>> > behind approach
>>
>> > dd9a8c3cd3 tests/acpi: add DSDT.hpbrroot DSDT table blob to test
>>
>> > global i440fx hotplug
>>
>> > 5b93474fe9 tests/acpi: unit test exercising global pci hotplug off for i440fx
>>
>> > 54c33e334a tests/acpi: update golden master DSDT binary table blobs for q35
>>
>> > 2279f61f30 piix4: don't reserve hw resources when hotplug is off globally
>>
>> > 1f61c524a0 Add ACPI DSDT tables for q35 that are being updated by the next patch
>>
>> > bdd823611b tests/acpi: add newly added acpi DSDT table blob for pci
>>
>> > bridge hotplug flag
>>
>> > 8c80f8fba9 tests/acpi: unit test for
>>
>> > 'acpi-pci-hotplug-with-bridge-support' bridge flag
>>
>> > e0a3142df9 tests/acpi: list added acpi table binary file for pci
>>
>> > bridge hotplug test
>>
>> > 0ba08317a8 i440fx/acpi: do not add hotplug related amls for cold plugged bridges
>>
>> > 73b191ade6 Fix a gap where acpi_pcihp_find_hotplug_bus() returns a
>>
>> > non-hotpluggable bus
>>
>> > ef0e526cc2 tests/acpi: add a new ACPI table in order to test root pci
>>
>> > hotplug on/off
>>
>> > c6d13264f8 tests/acpi: add new unit test to test hotplug off/on
>>
>> > feature on the root pci bus
>>
>> > 6901bada65 tests/acpi: mark addition of table DSDT.roothp for unit
>>
>> > testing root pci hotplug
>>
>> > 74504514b1 (origin/master, origin/HEAD) Merge remote-tracking branch
>>
>> > 'remotes/alistair/tags/pull-register-20200927' into staging
>>
>>
>>
>> Try applying on top of latest pull request?
>
>
> Maybe I'm missing something but can you point me to the latest pull request?
>>
>>
>>
>>
>>
>>
>>
>> >
>>
>> > >
>>
>> > > >
>>
>> > > >
>>
>> > > >
>>
>> > > > --- ./tests/data/acpi/pc/DSDT.hpbridge.dsl 2020-09-29 02:44:43.874622404 -0400
>>
>> > > > +++ ./tests/data/acpi/pc/DSDT.hpbrroot.dsl 2020-09-29 02:44:43.876622403 -0400
>>
>> > > > @@ -5,13 +5,13 @@
>>
>> > > > *
>>
>> > > > * Disassembling to symbolic ASL+ operators
>>
>> > > > *
>>
>> > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 02:44:43 2020
>>
>> > > > + * Disassembly of tests/data/acpi/pc/DSDT.hpbrroot, Tue Sep 29 02:44:43 2020
>>
>> > > > *
>>
>> > > > * Original Table Header:
>>
>> > > > * Signature "DSDT"
>>
>> > > > - * Length 0x0000139D (5021)
>>
>> > > > + * Length 0x00000B89 (2953)
>>
>> > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support
>>
>> > > > - * Checksum 0x05
>>
>> > > > + * Checksum 0xA2
>>
>> > > > * OEM ID "BOCHS "
>>
>> > > > * OEM Table ID "BXPCDSDT"
>>
>> > > > * OEM Revision 0x00000001 (1)
>>
>> > > > @@ -247,38 +247,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "
>>
>> > > > }
>>
>> > > > }
>>
>> > > >
>>
>> > > > - Scope (_SB.PCI0)
>>
>> > > > - {
>>
>> > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08)
>>
>> > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros)
>>
>> > > > - {
>>
>> > > > - PCIU, 32,
>>
>> > > > - PCID, 32
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04)
>>
>> > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros)
>>
>> > > > - {
>>
>> > > > - B0EJ, 32
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04)
>>
>> > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros)
>>
>> > > > - {
>>
>> > > > - BNUM, 32
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Mutex (BLCK, 0x00)
>>
>> > > > - Method (PCEJ, 2, NotSerialized)
>>
>> > > > - {
>>
>> > > > - Acquire (BLCK, 0xFFFF)
>>
>> > > > - BNUM = Arg0
>>
>> > > > - B0EJ = (One << Arg1)
>>
>> > > > - Release (BLCK)
>>
>> > > > - Return (Zero)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > Scope (_SB)
>>
>> > > > {
>>
>> > > > Scope (PCI0)
>>
>> > > > @@ -643,56 +611,22 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "
>>
>> > > > Method (CSCN, 0, Serialized)
>>
>> > > > {
>>
>> > > > Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF)
>>
>> > > > - Name (CNEW, Package (0xFF){})
>>
>> > > > - Local3 = Zero
>>
>> > > > - Local4 = One
>>
>> > > > - While ((Local4 == One))
>>
>> > > > + Local0 = One
>>
>> > > > + While ((Local0 == One))
>>
>> > > > {
>>
>> > > > - Local4 = Zero
>>
>> > > > - Local0 = One
>>
>> > > > - Local1 = Zero
>>
>> > > > - While (((Local0 == One) && (Local3 < One)))
>>
>> > > > + Local0 = Zero
>>
>> > > > + \_SB.PCI0.PRES.CCMD = Zero
>>
>> > > > + If ((\_SB.PCI0.PRES.CINS == One))
>>
>> > > > {
>>
>> > > > - Local0 = Zero
>>
>> > > > - \_SB.PCI0.PRES.CSEL = Local3
>>
>> > > > - \_SB.PCI0.PRES.CCMD = Zero
>>
>> > > > - If ((\_SB.PCI0.PRES.CDAT < Local3))
>>
>> > > > - {
>>
>> > > > - Break
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Local1 == 0xFF))
>>
>> > > > - {
>>
>> > > > - Local4 = One
>>
>> > > > - Break
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Local3 = \_SB.PCI0.PRES.CDAT
>>
>> > > > - If ((\_SB.PCI0.PRES.CINS == One))
>>
>> > > > - {
>>
>> > > > - CNEW [Local1] = Local3
>>
>> > > > - Local1++
>>
>> > > > - Local0 = One
>>
>> > > > - }
>>
>> > > > - ElseIf ((\_SB.PCI0.PRES.CRMV == One))
>>
>> > > > - {
>>
>> > > > - CTFY (Local3, 0x03)
>>
>> > > > - \_SB.PCI0.PRES.CRMV = One
>>
>> > > > - Local0 = One
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Local3++
>>
>> > > > + CTFY (\_SB.PCI0.PRES.CDAT, One)
>>
>> > > > + \_SB.PCI0.PRES.CINS = One
>>
>> > > > + Local0 = One
>>
>> > > > }
>>
>> > > > -
>>
>> > > > - Local2 = Zero
>>
>> > > > - While ((Local2 < Local1))
>>
>> > > > + ElseIf ((\_SB.PCI0.PRES.CRMV == One))
>>
>> > > > {
>>
>> > > > - Local3 = DerefOf (CNEW [Local2])
>>
>> > > > - CTFY (Local3, One)
>>
>> > > > - Debug = Local3
>>
>> > > > - \_SB.PCI0.PRES.CSEL = Local3
>>
>> > > > - \_SB.PCI0.PRES.CINS = One
>>
>> > > > - Local2++
>>
>> > > > + CTFY (\_SB.PCI0.PRES.CDAT, 0x03)
>>
>> > > > + \_SB.PCI0.PRES.CRMV = One
>>
>> > > > + Local0 = One
>>
>> > > > }
>>
>> > > > }
>>
>> > > >
>>
>> > > > @@ -737,12 +671,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "
>>
>> > > > Scope (_GPE)
>>
>> > > > {
>>
>> > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID
>>
>> > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE, xx=0x00-0xFF
>>
>> > > > - {
>>
>> > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF)
>>
>> > > > - \_SB.PCI0.PCNT ()
>>
>> > > > - Release (\_SB.PCI0.BLCK)
>>
>> > > > - }
>>
>> > > > }
>>
>> > > >
>>
>> > > > Scope (\_SB.PCI0)
>>
>> > > > @@ -813,22 +741,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "
>>
>> > > > )
>>
>> > > > })
>>
>> > > > }
>>
>> > > > -
>>
>> > > > - Device (PHPR)
>>
>> > > > - {
>>
>> > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID
>>
>> > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID
>>
>> > > > - Name (_STA, 0x0B) // _STA: Status
>>
>> > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
>>
>> > > > - {
>>
>> > > > - IO (Decode16,
>>
>> > > > - 0xAE00, // Range Minimum
>>
>> > > > - 0xAE00, // Range Maximum
>>
>> > > > - 0x01, // Alignment
>>
>> > > > - 0x14, // Length
>>
>> > > > - )
>>
>> > > > - })
>>
>> > > > - }
>>
>> > > > }
>>
>> > > >
>>
>> > > > Scope (\)
>>
>> > > > @@ -878,7 +790,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "
>>
>> > > > {
>>
>> > > > Scope (PCI0)
>>
>> > > > {
>>
>> > > > - Name (BSEL, Zero)
>>
>> > > > Device (S00)
>>
>> > > > {
>>
>> > > > Name (_ADR, Zero) // _ADR: Address
>>
>> > > > @@ -907,436 +818,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS "
>>
>> > > > {
>>
>> > > > Name (_ADR, 0x00030000) // _ADR: Address
>>
>> > > > }
>>
>> > > > -
>>
>> > > > - Device (S20)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x04) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x00040000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (S28)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x05) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x00050000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (S30)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x06) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x00060000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (S38)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x07) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x00070000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (S40)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x08) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x00080000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (S48)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x09) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x00090000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (S50)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x000A0000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (S58)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x000B0000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (S60)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x000C0000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (S68)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x000D0000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (S70)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x000E0000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (S78)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x000F0000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (S80)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x10) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x00100000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (S88)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x11) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x00110000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (S90)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x12) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x00120000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (S98)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x13) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x00130000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (SA0)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x14) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x00140000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (SA8)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x15) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x00150000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (SB0)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x16) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x00160000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (SB8)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x17) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x00170000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (SC0)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x18) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x00180000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (SC8)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x19) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x00190000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (SD0)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x001A0000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (SD8)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x001B0000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (SE0)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x001C0000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (SE8)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x001D0000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (SF0)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x001E0000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Device (SF8)
>>
>> > > > - {
>>
>> > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number
>>
>> > > > - Name (_ADR, 0x001F0000) // _ADR: Address
>>
>> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
>>
>> > > > - {
>>
>> > > > - PCEJ (BSEL, _SUN)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Method (DVNT, 2, NotSerialized)
>>
>> > > > - {
>>
>> > > > - If ((Arg0 & 0x10))
>>
>> > > > - {
>>
>> > > > - Notify (S20, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x20))
>>
>> > > > - {
>>
>> > > > - Notify (S28, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x40))
>>
>> > > > - {
>>
>> > > > - Notify (S30, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x80))
>>
>> > > > - {
>>
>> > > > - Notify (S38, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x0100))
>>
>> > > > - {
>>
>> > > > - Notify (S40, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x0200))
>>
>> > > > - {
>>
>> > > > - Notify (S48, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x0400))
>>
>> > > > - {
>>
>> > > > - Notify (S50, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x0800))
>>
>> > > > - {
>>
>> > > > - Notify (S58, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x1000))
>>
>> > > > - {
>>
>> > > > - Notify (S60, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x2000))
>>
>> > > > - {
>>
>> > > > - Notify (S68, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x4000))
>>
>> > > > - {
>>
>> > > > - Notify (S70, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x8000))
>>
>> > > > - {
>>
>> > > > - Notify (S78, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x00010000))
>>
>> > > > - {
>>
>> > > > - Notify (S80, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x00020000))
>>
>> > > > - {
>>
>> > > > - Notify (S88, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x00040000))
>>
>> > > > - {
>>
>> > > > - Notify (S90, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x00080000))
>>
>> > > > - {
>>
>> > > > - Notify (S98, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x00100000))
>>
>> > > > - {
>>
>> > > > - Notify (SA0, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x00200000))
>>
>> > > > - {
>>
>> > > > - Notify (SA8, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x00400000))
>>
>> > > > - {
>>
>> > > > - Notify (SB0, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x00800000))
>>
>> > > > - {
>>
>> > > > - Notify (SB8, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x01000000))
>>
>> > > > - {
>>
>> > > > - Notify (SC0, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x02000000))
>>
>> > > > - {
>>
>> > > > - Notify (SC8, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x04000000))
>>
>> > > > - {
>>
>> > > > - Notify (SD0, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x08000000))
>>
>> > > > - {
>>
>> > > > - Notify (SD8, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x10000000))
>>
>> > > > - {
>>
>> > > > - Notify (SE0, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x20000000))
>>
>> > > > - {
>>
>> > > > - Notify (SE8, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x40000000))
>>
>> > > > - {
>>
>> > > > - Notify (SF0, Arg1)
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - If ((Arg0 & 0x80000000))
>>
>> > > > - {
>>
>> > > > - Notify (SF8, Arg1)
>>
>> > > > - }
>>
>> > > > - }
>>
>> > > > -
>>
>> > > > - Method (PCNT, 0, NotSerialized)
>>
>> > > > - {
>>
>> > > > - BNUM = Zero
>>
>> > > > - DVNT (PCIU, One)
>>
>> > > > - DVNT (PCID, 0x03)
>>
>> > > > - }
>>
>> > > > }
>>
>> > > > }
>>
>> > > > }
>>
>> > > >
>>
>>
>>
On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <ani@anisinha.ca> wrote: > > In your pull request the following patch is completely screwed up: > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > Author: Ani Sinha <ani@anisinha.ca> > Date: Tue Sep 29 03:22:52 2020 -0400 > > tests/acpi: update golden master DSDT binary table blobs for q35 > > > This is not my patch. It has all sorts of changes which does not > belong there. Can you please check? See https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/ > > On Tue, Sep 29, 2020 at 3:20 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > > > On Tue, Sep 29, 2020 at 3:12 PM Michael S. Tsirkin <mst@redhat.com> wrote: > >> > >> On Tue, Sep 29, 2020 at 02:21:06PM +0530, Ani Sinha wrote: > >> > >> > On Tue, Sep 29, 2020 at 1:53 PM Ani Sinha <ani@anisinha.ca> wrote: > >> > >> > > > >> > >> > > On Tue, Sep 29, 2020 at 12:56 PM Michael S. Tsirkin <mst@redhat.com> wrote: > >> > >> > > > > >> > >> > > > On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote: > >> > >> > > > > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin <mst@redhat.com> wrote: > >> > >> > > > > > > >> > >> > > > > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote: > >> > >> > > > > > > This change adds a new DSDT golden master table blob to test disabling > >> > >> > > > > > > hotplug on both pci root bus and pci bridges. Also reverts the change > >> > >> > > > > > > in file bios-tables-test-allowed-diff.h to make sure its now empty so that > >> > >> > > > > > > future modifications to acpi tables can be caught. > >> > >> > > > > > > > >> > >> > > > > > > The following is the disassembled diff between DSDT.hpbridge and DSDT.hpbrroot: > >> > >> > > > > > > > >> > >> > > > > > > @@ -1,30 +1,30 @@ > >> > >> > > > > > > /* > >> > >> > > > > > > * Intel ACPI Component Architecture > >> > >> > > > > > > * AML/ASL+ Disassembler version 20180105 (64-bit version) > >> > >> > > > > > > * Copyright (c) 2000 - 2018 Intel Corporation > >> > >> > > > > > > * > >> > >> > > > > > > * Disassembling to symbolic ASL+ operators > >> > >> > > > > > > * > >> > >> > > > > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Wed Sep 16 09:45:56 2020 > >> > >> > > > > > > + * Disassembly of /tmp/aml-ECV9Q0, Wed Sep 16 09:45:56 2020 > >> > >> > > > > > > * > >> > >> > > > > > > * Original Table Header: > >> > >> > > > > > > * Signature "DSDT" > >> > >> > > > > > > - * Length 0x0000131F (4895) > >> > >> > > > > > > + * Length 0x00000B89 (2953) > >> > >> > > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > >> > >> > > > > > > - * Checksum 0xF9 > >> > >> > > > > > > + * Checksum 0xA2 > >> > >> > > > > > > * OEM ID "BOCHS " > >> > >> > > > > > > * OEM Table ID "BXPCDSDT" > >> > >> > > > > > > * OEM Revision 0x00000001 (1) > >> > >> > > > > > > * Compiler ID "BXPC" > >> > >> > > > > > > * Compiler Version 0x00000001 (1) > >> > >> > > > > > > */ > >> > >> > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) > >> > >> > > > > > > { > >> > >> > > > > > > Scope (\) > >> > >> > > > > > > { > >> > >> > > > > > > OperationRegion (DBG, SystemIO, 0x0402, One) > >> > >> > > > > > > Field (DBG, ByteAcc, NoLock, Preserve) > >> > >> > > > > > > { > >> > >> > > > > > > DBGB, 8 > >> > >> > > > > > > } > >> > >> > > > > > > > >> > >> > > > > > > @@ -234,64 +234,32 @@ > >> > >> > > > > > > { > >> > >> > > > > > > Name (_HID, EisaId ("PNP0B00") /* AT Real-Time Clock */) // _HID: Hardware ID > >> > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > >> > >> > > > > > > { > >> > >> > > > > > > IO (Decode16, > >> > >> > > > > > > 0x0070, // Range Minimum > >> > >> > > > > > > 0x0070, // Range Maximum > >> > >> > > > > > > 0x01, // Alignment > >> > >> > > > > > > 0x08, // Length > >> > >> > > > > > > ) > >> > >> > > > > > > IRQNoFlags () > >> > >> > > > > > > {8} > >> > >> > > > > > > }) > >> > >> > > > > > > } > >> > >> > > > > > > } > >> > >> > > > > > > > >> > >> > > > > > > - Scope (_SB.PCI0) > >> > >> > > > > > > - { > >> > >> > > > > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > >> > >> > > > > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > >> > >> > > > > > > - { > >> > >> > > > > > > - PCIU, 32, > >> > >> > > > > > > - PCID, 32 > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > >> > >> > > > > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > >> > >> > > > > > > - { > >> > >> > > > > > > - B0EJ, 32 > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > >> > >> > > > > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > >> > >> > > > > > > - { > >> > >> > > > > > > - BNUM, 32 > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Mutex (BLCK, 0x00) > >> > >> > > > > > > - Method (PCEJ, 2, NotSerialized) > >> > >> > > > > > > - { > >> > >> > > > > > > - Acquire (BLCK, 0xFFFF) > >> > >> > > > > > > - BNUM = Arg0 > >> > >> > > > > > > - B0EJ = (One << Arg1) > >> > >> > > > > > > - Release (BLCK) > >> > >> > > > > > > - Return (Zero) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > Scope (_SB) > >> > >> > > > > > > { > >> > >> > > > > > > Scope (PCI0) > >> > >> > > > > > > { > >> > >> > > > > > > Method (_PRT, 0, NotSerialized) // _PRT: PCI Routing Table > >> > >> > > > > > > { > >> > >> > > > > > > Local0 = Package (0x80){} > >> > >> > > > > > > Local1 = Zero > >> > >> > > > > > > While ((Local1 < 0x80)) > >> > >> > > > > > > { > >> > >> > > > > > > Local2 = (Local1 >> 0x02) > >> > >> > > > > > > Local3 = ((Local1 + Local2) & 0x03) > >> > >> > > > > > > If ((Local3 == Zero)) > >> > >> > > > > > > { > >> > >> > > > > > > Local4 = Package (0x04) > >> > >> > > > > > > { > >> > >> > > > > > > @@ -690,38 +658,32 @@ > >> > >> > > > > > > Method (_OST, 3, Serialized) // _OST: OSPM Status Indication > >> > >> > > > > > > { > >> > >> > > > > > > COST (Zero, Arg0, Arg1, Arg2) > >> > >> > > > > > > } > >> > >> > > > > > > } > >> > >> > > > > > > } > >> > >> > > > > > > } > >> > >> > > > > > > > >> > >> > > > > > > Method (\_GPE._E02, 0, NotSerialized) // _Exx: Edge-Triggered GPE > >> > >> > > > > > > { > >> > >> > > > > > > \_SB.CPUS.CSCN () > >> > >> > > > > > > } > >> > >> > > > > > > > >> > >> > > > > > > Scope (_GPE) > >> > >> > > > > > > { > >> > >> > > > > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > >> > >> > > > > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE > >> > >> > > > > > > - { > >> > >> > > > > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > >> > >> > > > > > > - \_SB.PCI0.PCNT () > >> > >> > > > > > > - Release (\_SB.PCI0.BLCK) > >> > >> > > > > > > - } > >> > >> > > > > > > } > >> > >> > > > > > > > >> > >> > > > > > > Scope (\_SB.PCI0) > >> > >> > > > > > > { > >> > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > >> > >> > > > > > > { > >> > >> > > > > > > WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode, > >> > >> > > > > > > 0x0000, // Granularity > >> > >> > > > > > > 0x0000, // Range Minimum > >> > >> > > > > > > 0x00FF, // Range Maximum > >> > >> > > > > > > 0x0000, // Translation Offset > >> > >> > > > > > > 0x0100, // Length > >> > >> > > > > > > ,, ) > >> > >> > > > > > > IO (Decode16, > >> > >> > > > > > > 0x0CF8, // Range Minimum > >> > >> > > > > > > 0x0CF8, // Range Maximum > >> > >> > > > > > > @@ -766,48 +728,32 @@ > >> > >> > > > > > > }) > >> > >> > > > > > > Device (GPE0) > >> > >> > > > > > > { > >> > >> > > > > > > Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > >> > >> > > > > > > Name (_UID, "GPE0 resources") // _UID: Unique ID > >> > >> > > > > > > Name (_STA, 0x0B) // _STA: Status > >> > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > >> > >> > > > > > > { > >> > >> > > > > > > IO (Decode16, > >> > >> > > > > > > 0xAFE0, // Range Minimum > >> > >> > > > > > > 0xAFE0, // Range Maximum > >> > >> > > > > > > 0x01, // Alignment > >> > >> > > > > > > 0x04, // Length > >> > >> > > > > > > ) > >> > >> > > > > > > }) > >> > >> > > > > > > } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (PHPR) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > >> > >> > > > > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > >> > >> > > > > > > - Name (_STA, 0x0B) // _STA: Status > >> > >> > > > > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > >> > >> > > > > > > - { > >> > >> > > > > > > - IO (Decode16, > >> > >> > > > > > > - 0xAE00, // Range Minimum > >> > >> > > > > > > - 0xAE00, // Range Maximum > >> > >> > > > > > > - 0x01, // Alignment > >> > >> > > > > > > - 0x14, // Length > >> > >> > > > > > > - ) > >> > >> > > > > > > - }) > >> > >> > > > > > > - } > >> > >> > > > > > > } > >> > >> > > > > > > > >> > >> > > > > > > Scope (\) > >> > >> > > > > > > { > >> > >> > > > > > > Name (_S3, Package (0x04) // _S3_: S3 System State > >> > >> > > > > > > { > >> > >> > > > > > > One, > >> > >> > > > > > > One, > >> > >> > > > > > > Zero, > >> > >> > > > > > > Zero > >> > >> > > > > > > }) > >> > >> > > > > > > Name (_S4, Package (0x04) // _S4_: S4 System State > >> > >> > > > > > > { > >> > >> > > > > > > 0x02, > >> > >> > > > > > > 0x02, > >> > >> > > > > > > Zero, > >> > >> > > > > > > @@ -831,479 +777,48 @@ > >> > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > >> > >> > > > > > > { > >> > >> > > > > > > IO (Decode16, > >> > >> > > > > > > 0x0510, // Range Minimum > >> > >> > > > > > > 0x0510, // Range Maximum > >> > >> > > > > > > 0x01, // Alignment > >> > >> > > > > > > 0x0C, // Length > >> > >> > > > > > > ) > >> > >> > > > > > > }) > >> > >> > > > > > > } > >> > >> > > > > > > } > >> > >> > > > > > > > >> > >> > > > > > > Scope (\_SB) > >> > >> > > > > > > { > >> > >> > > > > > > Scope (PCI0) > >> > >> > > > > > > { > >> > >> > > > > > > - Name (BSEL, Zero) > >> > >> > > > > > > Device (S00) > >> > >> > > > > > > { > >> > >> > > > > > > Name (_ADR, Zero) // _ADR: Address > >> > >> > > > > > > } > >> > >> > > > > > > > >> > >> > > > > > > Device (S10) > >> > >> > > > > > > { > >> > >> > > > > > > Name (_ADR, 0x00020000) // _ADR: Address > >> > >> > > > > > > Method (_S1D, 0, NotSerialized) // _S1D: S1 Device State > >> > >> > > > > > > { > >> > >> > > > > > > Return (Zero) > >> > >> > > > > > > } > >> > >> > > > > > > > >> > >> > > > > > > Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State > >> > >> > > > > > > { > >> > >> > > > > > > Return (Zero) > >> > >> > > > > > > } > >> > >> > > > > > > > >> > >> > > > > > > Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State > >> > >> > > > > > > { > >> > >> > > > > > > Return (Zero) > >> > >> > > > > > > } > >> > >> > > > > > > } > >> > >> > > > > > > > >> > >> > > > > > > Device (S18) > >> > >> > > > > > > { > >> > >> > > > > > > Name (_ADR, 0x00030000) // _ADR: Address > >> > >> > > > > > > } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (S20) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x00040000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (S28) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x00050000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (S30) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x00060000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (S38) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x00070000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (S40) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x00080000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (S48) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x00090000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (S50) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x000A0000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (S58) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x000B0000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (S60) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x000C0000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (S68) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x000D0000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (S70) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x000E0000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (S78) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x000F0000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (S80) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x00100000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (S88) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x00110000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (S90) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x00120000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (S98) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x00130000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (SA0) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x00140000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (SA8) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x00150000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (SB0) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x00160000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (SB8) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x00170000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (SC0) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x00180000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (SC8) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x00190000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (SD0) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x001A0000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (SD8) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x001B0000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (SE0) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x001C0000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (SE8) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x001D0000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (SF0) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x001E0000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Device (SF8) > >> > >> > > > > > > - { > >> > >> > > > > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > >> > >> > > > > > > - Name (_ADR, 0x001F0000) // _ADR: Address > >> > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > >> > >> > > > > > > - { > >> > >> > > > > > > - PCEJ (BSEL, _SUN) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Method (DVNT, 2, NotSerialized) > >> > >> > > > > > > - { > >> > >> > > > > > > - If ((Arg0 & 0x10)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (S20, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x20)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (S28, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x40)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (S30, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x80)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (S38, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x0100)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (S40, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x0200)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (S48, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x0400)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (S50, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x0800)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (S58, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x1000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (S60, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x2000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (S68, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x4000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (S70, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x8000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (S78, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x00010000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (S80, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x00020000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (S88, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x00040000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (S90, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x00080000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (S98, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x00100000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (SA0, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x00200000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (SA8, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x00400000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (SB0, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x00800000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (SB8, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x01000000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (SC0, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x02000000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (SC8, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x04000000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (SD0, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x08000000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (SD8, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x10000000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (SE0, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x20000000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (SE8, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x40000000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (SF0, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - If ((Arg0 & 0x80000000)) > >> > >> > > > > > > - { > >> > >> > > > > > > - Notify (SF8, Arg1) > >> > >> > > > > > > - } > >> > >> > > > > > > - } > >> > >> > > > > > > - > >> > >> > > > > > > - Method (PCNT, 0, NotSerialized) > >> > >> > > > > > > - { > >> > >> > > > > > > - BNUM = Zero > >> > >> > > > > > > - DVNT (PCIU, One) > >> > >> > > > > > > - DVNT (PCID, 0x03) > >> > >> > > > > > > - } > >> > >> > > > > > > } > >> > >> > > > > > > } > >> > >> > > > > > > } > >> > >> > > > > > > >> > >> > > > > > This is not the only diff I see if I apply this patchset on > >> > >> > > > > > top of master. > >> > >> > > > > > Dropped this and the previous patch. > >> > >> > > > > > Please check what is going on and repost as appropriate. > >> > >> > > > > > >> > >> > > > > Which two ACPI DSDT files are you diffing? What diff are you getting? > >> > >> > > > > >> > >> > > > > >> > >> > > > diff -rup ./tests/data/acpi/pc/DSDT.hpbridge.dsl ./tests/data/acpi/pc/DSDT.hpbrroot.dsl > >> > >> > > > >> > >> > > I re-based my patchset on top of the latest qemu master and did a make > >> > >> > > && make check-qtest-x86_64 V=1. > >> > >> > > They pass. I am seeing this diff: > >> > >> > > https://pastebin.ubuntu.com/p/BXy9GFfB2R/ > >> > >> > > > >> > >> > > and it looks good to me. > >> > >> > > > >> > >> > > Not sure why your diff looks different. Maybe you can regenerate the blob? > >> > >> > > >> > >> > I did a full make check and it passed. I compared the diff again and > >> > >> > it's the same. I checked my tree and it looks clean. These are the > >> > >> > patches I have: > >> > >> > > >> > >> > $ git log --oneline > >> > >> > 20d1323e10 (HEAD -> master) qom: code hardening - have bound checking > >> > >> > while looping with integer value > >> > >> > 0f69dae0e2 Add a comment in bios-tables-test.c to clarify the reason > >> > >> > behind approach > >> > >> > dd9a8c3cd3 tests/acpi: add DSDT.hpbrroot DSDT table blob to test > >> > >> > global i440fx hotplug > >> > >> > 5b93474fe9 tests/acpi: unit test exercising global pci hotplug off for i440fx > >> > >> > 54c33e334a tests/acpi: update golden master DSDT binary table blobs for q35 > >> > >> > 2279f61f30 piix4: don't reserve hw resources when hotplug is off globally > >> > >> > 1f61c524a0 Add ACPI DSDT tables for q35 that are being updated by the next patch > >> > >> > bdd823611b tests/acpi: add newly added acpi DSDT table blob for pci > >> > >> > bridge hotplug flag > >> > >> > 8c80f8fba9 tests/acpi: unit test for > >> > >> > 'acpi-pci-hotplug-with-bridge-support' bridge flag > >> > >> > e0a3142df9 tests/acpi: list added acpi table binary file for pci > >> > >> > bridge hotplug test > >> > >> > 0ba08317a8 i440fx/acpi: do not add hotplug related amls for cold plugged bridges > >> > >> > 73b191ade6 Fix a gap where acpi_pcihp_find_hotplug_bus() returns a > >> > >> > non-hotpluggable bus > >> > >> > ef0e526cc2 tests/acpi: add a new ACPI table in order to test root pci > >> > >> > hotplug on/off > >> > >> > c6d13264f8 tests/acpi: add new unit test to test hotplug off/on > >> > >> > feature on the root pci bus > >> > >> > 6901bada65 tests/acpi: mark addition of table DSDT.roothp for unit > >> > >> > testing root pci hotplug > >> > >> > 74504514b1 (origin/master, origin/HEAD) Merge remote-tracking branch > >> > >> > 'remotes/alistair/tags/pull-register-20200927' into staging > >> > >> > >> > >> Try applying on top of latest pull request? > > > > > > Maybe I'm missing something but can you point me to the latest pull request? > >> > >> > >> > >> > >> > >> > >> > >> > > >> > >> > > > >> > >> > > > > >> > >> > > > > >> > >> > > > > >> > >> > > > --- ./tests/data/acpi/pc/DSDT.hpbridge.dsl 2020-09-29 02:44:43.874622404 -0400 > >> > >> > > > +++ ./tests/data/acpi/pc/DSDT.hpbrroot.dsl 2020-09-29 02:44:43.876622403 -0400 > >> > >> > > > @@ -5,13 +5,13 @@ > >> > >> > > > * > >> > >> > > > * Disassembling to symbolic ASL+ operators > >> > >> > > > * > >> > >> > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 02:44:43 2020 > >> > >> > > > + * Disassembly of tests/data/acpi/pc/DSDT.hpbrroot, Tue Sep 29 02:44:43 2020 > >> > >> > > > * > >> > >> > > > * Original Table Header: > >> > >> > > > * Signature "DSDT" > >> > >> > > > - * Length 0x0000139D (5021) > >> > >> > > > + * Length 0x00000B89 (2953) > >> > >> > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > >> > >> > > > - * Checksum 0x05 > >> > >> > > > + * Checksum 0xA2 > >> > >> > > > * OEM ID "BOCHS " > >> > >> > > > * OEM Table ID "BXPCDSDT" > >> > >> > > > * OEM Revision 0x00000001 (1) > >> > >> > > > @@ -247,38 +247,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > >> > >> > > > } > >> > >> > > > } > >> > >> > > > > >> > >> > > > - Scope (_SB.PCI0) > >> > >> > > > - { > >> > >> > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > >> > >> > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > >> > >> > > > - { > >> > >> > > > - PCIU, 32, > >> > >> > > > - PCID, 32 > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > >> > >> > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > >> > >> > > > - { > >> > >> > > > - B0EJ, 32 > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > >> > >> > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > >> > >> > > > - { > >> > >> > > > - BNUM, 32 > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Mutex (BLCK, 0x00) > >> > >> > > > - Method (PCEJ, 2, NotSerialized) > >> > >> > > > - { > >> > >> > > > - Acquire (BLCK, 0xFFFF) > >> > >> > > > - BNUM = Arg0 > >> > >> > > > - B0EJ = (One << Arg1) > >> > >> > > > - Release (BLCK) > >> > >> > > > - Return (Zero) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > Scope (_SB) > >> > >> > > > { > >> > >> > > > Scope (PCI0) > >> > >> > > > @@ -643,56 +611,22 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > >> > >> > > > Method (CSCN, 0, Serialized) > >> > >> > > > { > >> > >> > > > Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF) > >> > >> > > > - Name (CNEW, Package (0xFF){}) > >> > >> > > > - Local3 = Zero > >> > >> > > > - Local4 = One > >> > >> > > > - While ((Local4 == One)) > >> > >> > > > + Local0 = One > >> > >> > > > + While ((Local0 == One)) > >> > >> > > > { > >> > >> > > > - Local4 = Zero > >> > >> > > > - Local0 = One > >> > >> > > > - Local1 = Zero > >> > >> > > > - While (((Local0 == One) && (Local3 < One))) > >> > >> > > > + Local0 = Zero > >> > >> > > > + \_SB.PCI0.PRES.CCMD = Zero > >> > >> > > > + If ((\_SB.PCI0.PRES.CINS == One)) > >> > >> > > > { > >> > >> > > > - Local0 = Zero > >> > >> > > > - \_SB.PCI0.PRES.CSEL = Local3 > >> > >> > > > - \_SB.PCI0.PRES.CCMD = Zero > >> > >> > > > - If ((\_SB.PCI0.PRES.CDAT < Local3)) > >> > >> > > > - { > >> > >> > > > - Break > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Local1 == 0xFF)) > >> > >> > > > - { > >> > >> > > > - Local4 = One > >> > >> > > > - Break > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Local3 = \_SB.PCI0.PRES.CDAT > >> > >> > > > - If ((\_SB.PCI0.PRES.CINS == One)) > >> > >> > > > - { > >> > >> > > > - CNEW [Local1] = Local3 > >> > >> > > > - Local1++ > >> > >> > > > - Local0 = One > >> > >> > > > - } > >> > >> > > > - ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > >> > >> > > > - { > >> > >> > > > - CTFY (Local3, 0x03) > >> > >> > > > - \_SB.PCI0.PRES.CRMV = One > >> > >> > > > - Local0 = One > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Local3++ > >> > >> > > > + CTFY (\_SB.PCI0.PRES.CDAT, One) > >> > >> > > > + \_SB.PCI0.PRES.CINS = One > >> > >> > > > + Local0 = One > >> > >> > > > } > >> > >> > > > - > >> > >> > > > - Local2 = Zero > >> > >> > > > - While ((Local2 < Local1)) > >> > >> > > > + ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > >> > >> > > > { > >> > >> > > > - Local3 = DerefOf (CNEW [Local2]) > >> > >> > > > - CTFY (Local3, One) > >> > >> > > > - Debug = Local3 > >> > >> > > > - \_SB.PCI0.PRES.CSEL = Local3 > >> > >> > > > - \_SB.PCI0.PRES.CINS = One > >> > >> > > > - Local2++ > >> > >> > > > + CTFY (\_SB.PCI0.PRES.CDAT, 0x03) > >> > >> > > > + \_SB.PCI0.PRES.CRMV = One > >> > >> > > > + Local0 = One > >> > >> > > > } > >> > >> > > > } > >> > >> > > > > >> > >> > > > @@ -737,12 +671,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > >> > >> > > > Scope (_GPE) > >> > >> > > > { > >> > >> > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > >> > >> > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE, xx=0x00-0xFF > >> > >> > > > - { > >> > >> > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > >> > >> > > > - \_SB.PCI0.PCNT () > >> > >> > > > - Release (\_SB.PCI0.BLCK) > >> > >> > > > - } > >> > >> > > > } > >> > >> > > > > >> > >> > > > Scope (\_SB.PCI0) > >> > >> > > > @@ -813,22 +741,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > >> > >> > > > ) > >> > >> > > > }) > >> > >> > > > } > >> > >> > > > - > >> > >> > > > - Device (PHPR) > >> > >> > > > - { > >> > >> > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > >> > >> > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > >> > >> > > > - Name (_STA, 0x0B) // _STA: Status > >> > >> > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > >> > >> > > > - { > >> > >> > > > - IO (Decode16, > >> > >> > > > - 0xAE00, // Range Minimum > >> > >> > > > - 0xAE00, // Range Maximum > >> > >> > > > - 0x01, // Alignment > >> > >> > > > - 0x14, // Length > >> > >> > > > - ) > >> > >> > > > - }) > >> > >> > > > - } > >> > >> > > > } > >> > >> > > > > >> > >> > > > Scope (\) > >> > >> > > > @@ -878,7 +790,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > >> > >> > > > { > >> > >> > > > Scope (PCI0) > >> > >> > > > { > >> > >> > > > - Name (BSEL, Zero) > >> > >> > > > Device (S00) > >> > >> > > > { > >> > >> > > > Name (_ADR, Zero) // _ADR: Address > >> > >> > > > @@ -907,436 +818,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > >> > >> > > > { > >> > >> > > > Name (_ADR, 0x00030000) // _ADR: Address > >> > >> > > > } > >> > >> > > > - > >> > >> > > > - Device (S20) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x00040000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (S28) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x00050000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (S30) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x00060000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (S38) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x00070000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (S40) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x00080000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (S48) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x00090000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (S50) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x000A0000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (S58) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x000B0000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (S60) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x000C0000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (S68) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x000D0000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (S70) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x000E0000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (S78) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x000F0000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (S80) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x00100000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (S88) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x00110000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (S90) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x00120000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (S98) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x00130000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (SA0) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x00140000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (SA8) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x00150000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (SB0) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x00160000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (SB8) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x00170000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (SC0) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x00180000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (SC8) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x00190000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (SD0) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x001A0000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (SD8) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x001B0000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (SE0) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x001C0000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (SE8) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x001D0000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (SF0) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x001E0000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Device (SF8) > >> > >> > > > - { > >> > >> > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > >> > >> > > > - Name (_ADR, 0x001F0000) // _ADR: Address > >> > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > >> > >> > > > - { > >> > >> > > > - PCEJ (BSEL, _SUN) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Method (DVNT, 2, NotSerialized) > >> > >> > > > - { > >> > >> > > > - If ((Arg0 & 0x10)) > >> > >> > > > - { > >> > >> > > > - Notify (S20, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x20)) > >> > >> > > > - { > >> > >> > > > - Notify (S28, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x40)) > >> > >> > > > - { > >> > >> > > > - Notify (S30, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x80)) > >> > >> > > > - { > >> > >> > > > - Notify (S38, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x0100)) > >> > >> > > > - { > >> > >> > > > - Notify (S40, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x0200)) > >> > >> > > > - { > >> > >> > > > - Notify (S48, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x0400)) > >> > >> > > > - { > >> > >> > > > - Notify (S50, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x0800)) > >> > >> > > > - { > >> > >> > > > - Notify (S58, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x1000)) > >> > >> > > > - { > >> > >> > > > - Notify (S60, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x2000)) > >> > >> > > > - { > >> > >> > > > - Notify (S68, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x4000)) > >> > >> > > > - { > >> > >> > > > - Notify (S70, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x8000)) > >> > >> > > > - { > >> > >> > > > - Notify (S78, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x00010000)) > >> > >> > > > - { > >> > >> > > > - Notify (S80, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x00020000)) > >> > >> > > > - { > >> > >> > > > - Notify (S88, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x00040000)) > >> > >> > > > - { > >> > >> > > > - Notify (S90, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x00080000)) > >> > >> > > > - { > >> > >> > > > - Notify (S98, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x00100000)) > >> > >> > > > - { > >> > >> > > > - Notify (SA0, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x00200000)) > >> > >> > > > - { > >> > >> > > > - Notify (SA8, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x00400000)) > >> > >> > > > - { > >> > >> > > > - Notify (SB0, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x00800000)) > >> > >> > > > - { > >> > >> > > > - Notify (SB8, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x01000000)) > >> > >> > > > - { > >> > >> > > > - Notify (SC0, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x02000000)) > >> > >> > > > - { > >> > >> > > > - Notify (SC8, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x04000000)) > >> > >> > > > - { > >> > >> > > > - Notify (SD0, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x08000000)) > >> > >> > > > - { > >> > >> > > > - Notify (SD8, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x10000000)) > >> > >> > > > - { > >> > >> > > > - Notify (SE0, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x20000000)) > >> > >> > > > - { > >> > >> > > > - Notify (SE8, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x40000000)) > >> > >> > > > - { > >> > >> > > > - Notify (SF0, Arg1) > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - If ((Arg0 & 0x80000000)) > >> > >> > > > - { > >> > >> > > > - Notify (SF8, Arg1) > >> > >> > > > - } > >> > >> > > > - } > >> > >> > > > - > >> > >> > > > - Method (PCNT, 0, NotSerialized) > >> > >> > > > - { > >> > >> > > > - BNUM = Zero > >> > >> > > > - DVNT (PCIU, One) > >> > >> > > > - DVNT (PCID, 0x03) > >> > >> > > > - } > >> > >> > > > } > >> > >> > > > } > >> > >> > > > } > >> > >> > > > > >> > >> > >>
On Tue, Sep 29, 2020 at 4:02 PM Ani Sinha <ani@anisinha.ca> wrote: > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > In your pull request the following patch is completely screwed up: > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > Author: Ani Sinha <ani@anisinha.ca> > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > tests/acpi: update golden master DSDT binary table blobs for q35 > > > > > > This is not my patch. It has all sorts of changes which does not > > belong there. Can you please check? > > See https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/ Also you have tons of dsl files which does not belong : ani@ani-ubuntu:~/workspace/qemu-patchew/tests/data/acpi/pc$ ls *.dsl APIC.acpihmat.dsl DSDT.acpihmat.dsl FACP.acpihmat.dsl FACS.acpihmat.dsl HMAT.acpihmat.dsl HPET.dsl SLIT.memhp.dsl WAET.acpihmat.dsl APIC.bridge.dsl DSDT.bridge.dsl FACP.bridge.dsl FACS.bridge.dsl HMAT.dsl HPET.ipmikcs.dsl SRAT.acpihmat.dsl WAET.bridge.dsl APIC.cphp.dsl DSDT.cphp.dsl FACP.cphp.dsl FACS.cphp.dsl hpbridge.dsl HPET.memhp.dsl SRAT.cphp.dsl WAET.cphp.dsl APIC.dimmpxm.dsl DSDT.dimmpxm.dsl FACP.dimmpxm.dsl FACS.dimmpxm.dsl hpbrroot.dsl HPET.numamem.dsl SRAT.dimmpxm.dsl WAET.dimmpxm.dsl APIC.dsl DSDT.dsl FACP.dsl FACS.dsl HPET.acpihmat.dsl NFIT.dimmpxm.dsl SRAT.dsl WAET.dsl APIC.ipmikcs.dsl DSDT.ipmikcs.dsl FACP.ipmikcs.dsl FACS.ipmikcs.dsl HPET.bridge.dsl NFIT.dsl SRAT.memhp.dsl WAET.ipmikcs.dsl APIC.memhp.dsl DSDT.memhp.dsl FACP.memhp.dsl FACS.memhp.dsl HPET.cphp.dsl SLIT.cphp.dsl SRAT.numamem.dsl WAET.memhp.dsl APIC.numamem.dsl DSDT.numamem.dsl FACP.numamem.dsl FACS.numamem.dsl HPET.dimmpxm.dsl SLIT.dsl SSDT.dsl WAET.numamem.dsl They are all introduced by that patch. So some screwup while rebase? > > > > > > On Tue, Sep 29, 2020 at 3:20 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > > > > > > > On Tue, Sep 29, 2020 at 3:12 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > >> > > >> On Tue, Sep 29, 2020 at 02:21:06PM +0530, Ani Sinha wrote: > > >> > > >> > On Tue, Sep 29, 2020 at 1:53 PM Ani Sinha <ani@anisinha.ca> wrote: > > >> > > >> > > > > >> > > >> > > On Tue, Sep 29, 2020 at 12:56 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > >> > > >> > > > > > >> > > >> > > > On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote: > > >> > > >> > > > > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > >> > > >> > > > > > > > >> > > >> > > > > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote: > > >> > > >> > > > > > > This change adds a new DSDT golden master table blob to test disabling > > >> > > >> > > > > > > hotplug on both pci root bus and pci bridges. Also reverts the change > > >> > > >> > > > > > > in file bios-tables-test-allowed-diff.h to make sure its now empty so that > > >> > > >> > > > > > > future modifications to acpi tables can be caught. > > >> > > >> > > > > > > > > >> > > >> > > > > > > The following is the disassembled diff between DSDT.hpbridge and DSDT.hpbrroot: > > >> > > >> > > > > > > > > >> > > >> > > > > > > @@ -1,30 +1,30 @@ > > >> > > >> > > > > > > /* > > >> > > >> > > > > > > * Intel ACPI Component Architecture > > >> > > >> > > > > > > * AML/ASL+ Disassembler version 20180105 (64-bit version) > > >> > > >> > > > > > > * Copyright (c) 2000 - 2018 Intel Corporation > > >> > > >> > > > > > > * > > >> > > >> > > > > > > * Disassembling to symbolic ASL+ operators > > >> > > >> > > > > > > * > > >> > > >> > > > > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Wed Sep 16 09:45:56 2020 > > >> > > >> > > > > > > + * Disassembly of /tmp/aml-ECV9Q0, Wed Sep 16 09:45:56 2020 > > >> > > >> > > > > > > * > > >> > > >> > > > > > > * Original Table Header: > > >> > > >> > > > > > > * Signature "DSDT" > > >> > > >> > > > > > > - * Length 0x0000131F (4895) > > >> > > >> > > > > > > + * Length 0x00000B89 (2953) > > >> > > >> > > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > >> > > >> > > > > > > - * Checksum 0xF9 > > >> > > >> > > > > > > + * Checksum 0xA2 > > >> > > >> > > > > > > * OEM ID "BOCHS " > > >> > > >> > > > > > > * OEM Table ID "BXPCDSDT" > > >> > > >> > > > > > > * OEM Revision 0x00000001 (1) > > >> > > >> > > > > > > * Compiler ID "BXPC" > > >> > > >> > > > > > > * Compiler Version 0x00000001 (1) > > >> > > >> > > > > > > */ > > >> > > >> > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Scope (\) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > OperationRegion (DBG, SystemIO, 0x0402, One) > > >> > > >> > > > > > > Field (DBG, ByteAcc, NoLock, Preserve) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > DBGB, 8 > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > @@ -234,64 +234,32 @@ > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Name (_HID, EisaId ("PNP0B00") /* AT Real-Time Clock */) // _HID: Hardware ID > > >> > > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > >> > > >> > > > > > > { > > >> > > >> > > > > > > IO (Decode16, > > >> > > >> > > > > > > 0x0070, // Range Minimum > > >> > > >> > > > > > > 0x0070, // Range Maximum > > >> > > >> > > > > > > 0x01, // Alignment > > >> > > >> > > > > > > 0x08, // Length > > >> > > >> > > > > > > ) > > >> > > >> > > > > > > IRQNoFlags () > > >> > > >> > > > > > > {8} > > >> > > >> > > > > > > }) > > >> > > >> > > > > > > } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > - Scope (_SB.PCI0) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > >> > > >> > > > > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCIU, 32, > > >> > > >> > > > > > > - PCID, 32 > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > >> > > >> > > > > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - B0EJ, 32 > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > >> > > >> > > > > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - BNUM, 32 > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Mutex (BLCK, 0x00) > > >> > > >> > > > > > > - Method (PCEJ, 2, NotSerialized) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Acquire (BLCK, 0xFFFF) > > >> > > >> > > > > > > - BNUM = Arg0 > > >> > > >> > > > > > > - B0EJ = (One << Arg1) > > >> > > >> > > > > > > - Release (BLCK) > > >> > > >> > > > > > > - Return (Zero) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > Scope (_SB) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Scope (PCI0) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Method (_PRT, 0, NotSerialized) // _PRT: PCI Routing Table > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Local0 = Package (0x80){} > > >> > > >> > > > > > > Local1 = Zero > > >> > > >> > > > > > > While ((Local1 < 0x80)) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Local2 = (Local1 >> 0x02) > > >> > > >> > > > > > > Local3 = ((Local1 + Local2) & 0x03) > > >> > > >> > > > > > > If ((Local3 == Zero)) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Local4 = Package (0x04) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > @@ -690,38 +658,32 @@ > > >> > > >> > > > > > > Method (_OST, 3, Serialized) // _OST: OSPM Status Indication > > >> > > >> > > > > > > { > > >> > > >> > > > > > > COST (Zero, Arg0, Arg1, Arg2) > > >> > > >> > > > > > > } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Method (\_GPE._E02, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > >> > > >> > > > > > > { > > >> > > >> > > > > > > \_SB.CPUS.CSCN () > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Scope (_GPE) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > > >> > > >> > > > > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > >> > > >> > > > > > > - \_SB.PCI0.PCNT () > > >> > > >> > > > > > > - Release (\_SB.PCI0.BLCK) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Scope (\_SB.PCI0) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > >> > > >> > > > > > > { > > >> > > >> > > > > > > WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode, > > >> > > >> > > > > > > 0x0000, // Granularity > > >> > > >> > > > > > > 0x0000, // Range Minimum > > >> > > >> > > > > > > 0x00FF, // Range Maximum > > >> > > >> > > > > > > 0x0000, // Translation Offset > > >> > > >> > > > > > > 0x0100, // Length > > >> > > >> > > > > > > ,, ) > > >> > > >> > > > > > > IO (Decode16, > > >> > > >> > > > > > > 0x0CF8, // Range Minimum > > >> > > >> > > > > > > 0x0CF8, // Range Maximum > > >> > > >> > > > > > > @@ -766,48 +728,32 @@ > > >> > > >> > > > > > > }) > > >> > > >> > > > > > > Device (GPE0) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > >> > > >> > > > > > > Name (_UID, "GPE0 resources") // _UID: Unique ID > > >> > > >> > > > > > > Name (_STA, 0x0B) // _STA: Status > > >> > > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > >> > > >> > > > > > > { > > >> > > >> > > > > > > IO (Decode16, > > >> > > >> > > > > > > 0xAFE0, // Range Minimum > > >> > > >> > > > > > > 0xAFE0, // Range Maximum > > >> > > >> > > > > > > 0x01, // Alignment > > >> > > >> > > > > > > 0x04, // Length > > >> > > >> > > > > > > ) > > >> > > >> > > > > > > }) > > >> > > >> > > > > > > } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (PHPR) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > >> > > >> > > > > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > >> > > >> > > > > > > - Name (_STA, 0x0B) // _STA: Status > > >> > > >> > > > > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - IO (Decode16, > > >> > > >> > > > > > > - 0xAE00, // Range Minimum > > >> > > >> > > > > > > - 0xAE00, // Range Maximum > > >> > > >> > > > > > > - 0x01, // Alignment > > >> > > >> > > > > > > - 0x14, // Length > > >> > > >> > > > > > > - ) > > >> > > >> > > > > > > - }) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Scope (\) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Name (_S3, Package (0x04) // _S3_: S3 System State > > >> > > >> > > > > > > { > > >> > > >> > > > > > > One, > > >> > > >> > > > > > > One, > > >> > > >> > > > > > > Zero, > > >> > > >> > > > > > > Zero > > >> > > >> > > > > > > }) > > >> > > >> > > > > > > Name (_S4, Package (0x04) // _S4_: S4 System State > > >> > > >> > > > > > > { > > >> > > >> > > > > > > 0x02, > > >> > > >> > > > > > > 0x02, > > >> > > >> > > > > > > Zero, > > >> > > >> > > > > > > @@ -831,479 +777,48 @@ > > >> > > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > >> > > >> > > > > > > { > > >> > > >> > > > > > > IO (Decode16, > > >> > > >> > > > > > > 0x0510, // Range Minimum > > >> > > >> > > > > > > 0x0510, // Range Maximum > > >> > > >> > > > > > > 0x01, // Alignment > > >> > > >> > > > > > > 0x0C, // Length > > >> > > >> > > > > > > ) > > >> > > >> > > > > > > }) > > >> > > >> > > > > > > } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Scope (\_SB) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Scope (PCI0) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > - Name (BSEL, Zero) > > >> > > >> > > > > > > Device (S00) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Name (_ADR, Zero) // _ADR: Address > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Device (S10) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Name (_ADR, 0x00020000) // _ADR: Address > > >> > > >> > > > > > > Method (_S1D, 0, NotSerialized) // _S1D: S1 Device State > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Return (Zero) > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Return (Zero) > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Return (Zero) > > >> > > >> > > > > > > } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Device (S18) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Name (_ADR, 0x00030000) // _ADR: Address > > >> > > >> > > > > > > } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S20) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00040000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S28) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00050000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S30) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00060000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S38) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00070000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S40) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00080000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S48) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00090000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S50) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S58) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S60) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S68) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S70) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S78) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S80) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00100000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S88) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00110000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S90) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00120000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S98) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00130000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SA0) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00140000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SA8) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00150000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SB0) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00160000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SB8) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00170000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SC0) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00180000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SC8) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00190000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SD0) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SD8) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SE0) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SE8) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SF0) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SF8) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Method (DVNT, 2, NotSerialized) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - If ((Arg0 & 0x10)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S20, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x20)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S28, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x40)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S30, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x80)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S38, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x0100)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S40, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x0200)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S48, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x0400)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S50, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x0800)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S58, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x1000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S60, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x2000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S68, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x4000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S70, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x8000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S78, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x00010000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S80, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x00020000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S88, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x00040000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S90, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x00080000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S98, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x00100000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SA0, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x00200000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SA8, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x00400000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SB0, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x00800000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SB8, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x01000000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SC0, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x02000000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SC8, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x04000000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SD0, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x08000000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SD8, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x10000000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SE0, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x20000000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SE8, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x40000000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SF0, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x80000000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SF8, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Method (PCNT, 0, NotSerialized) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - BNUM = Zero > > >> > > >> > > > > > > - DVNT (PCIU, One) > > >> > > >> > > > > > > - DVNT (PCID, 0x03) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > >> > > >> > > > > > This is not the only diff I see if I apply this patchset on > > >> > > >> > > > > > top of master. > > >> > > >> > > > > > Dropped this and the previous patch. > > >> > > >> > > > > > Please check what is going on and repost as appropriate. > > >> > > >> > > > > > > >> > > >> > > > > Which two ACPI DSDT files are you diffing? What diff are you getting? > > >> > > >> > > > > > >> > > >> > > > > > >> > > >> > > > diff -rup ./tests/data/acpi/pc/DSDT.hpbridge.dsl ./tests/data/acpi/pc/DSDT.hpbrroot.dsl > > >> > > >> > > > > >> > > >> > > I re-based my patchset on top of the latest qemu master and did a make > > >> > > >> > > && make check-qtest-x86_64 V=1. > > >> > > >> > > They pass. I am seeing this diff: > > >> > > >> > > https://pastebin.ubuntu.com/p/BXy9GFfB2R/ > > >> > > >> > > > > >> > > >> > > and it looks good to me. > > >> > > >> > > > > >> > > >> > > Not sure why your diff looks different. Maybe you can regenerate the blob? > > >> > > >> > > > >> > > >> > I did a full make check and it passed. I compared the diff again and > > >> > > >> > it's the same. I checked my tree and it looks clean. These are the > > >> > > >> > patches I have: > > >> > > >> > > > >> > > >> > $ git log --oneline > > >> > > >> > 20d1323e10 (HEAD -> master) qom: code hardening - have bound checking > > >> > > >> > while looping with integer value > > >> > > >> > 0f69dae0e2 Add a comment in bios-tables-test.c to clarify the reason > > >> > > >> > behind approach > > >> > > >> > dd9a8c3cd3 tests/acpi: add DSDT.hpbrroot DSDT table blob to test > > >> > > >> > global i440fx hotplug > > >> > > >> > 5b93474fe9 tests/acpi: unit test exercising global pci hotplug off for i440fx > > >> > > >> > 54c33e334a tests/acpi: update golden master DSDT binary table blobs for q35 > > >> > > >> > 2279f61f30 piix4: don't reserve hw resources when hotplug is off globally > > >> > > >> > 1f61c524a0 Add ACPI DSDT tables for q35 that are being updated by the next patch > > >> > > >> > bdd823611b tests/acpi: add newly added acpi DSDT table blob for pci > > >> > > >> > bridge hotplug flag > > >> > > >> > 8c80f8fba9 tests/acpi: unit test for > > >> > > >> > 'acpi-pci-hotplug-with-bridge-support' bridge flag > > >> > > >> > e0a3142df9 tests/acpi: list added acpi table binary file for pci > > >> > > >> > bridge hotplug test > > >> > > >> > 0ba08317a8 i440fx/acpi: do not add hotplug related amls for cold plugged bridges > > >> > > >> > 73b191ade6 Fix a gap where acpi_pcihp_find_hotplug_bus() returns a > > >> > > >> > non-hotpluggable bus > > >> > > >> > ef0e526cc2 tests/acpi: add a new ACPI table in order to test root pci > > >> > > >> > hotplug on/off > > >> > > >> > c6d13264f8 tests/acpi: add new unit test to test hotplug off/on > > >> > > >> > feature on the root pci bus > > >> > > >> > 6901bada65 tests/acpi: mark addition of table DSDT.roothp for unit > > >> > > >> > testing root pci hotplug > > >> > > >> > 74504514b1 (origin/master, origin/HEAD) Merge remote-tracking branch > > >> > > >> > 'remotes/alistair/tags/pull-register-20200927' into staging > > >> > > >> > > >> > > >> Try applying on top of latest pull request? > > > > > > > > > Maybe I'm missing something but can you point me to the latest pull request? > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > > >> > > >> > > > > >> > > >> > > > > > >> > > >> > > > > > >> > > >> > > > > > >> > > >> > > > --- ./tests/data/acpi/pc/DSDT.hpbridge.dsl 2020-09-29 02:44:43.874622404 -0400 > > >> > > >> > > > +++ ./tests/data/acpi/pc/DSDT.hpbrroot.dsl 2020-09-29 02:44:43.876622403 -0400 > > >> > > >> > > > @@ -5,13 +5,13 @@ > > >> > > >> > > > * > > >> > > >> > > > * Disassembling to symbolic ASL+ operators > > >> > > >> > > > * > > >> > > >> > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 02:44:43 2020 > > >> > > >> > > > + * Disassembly of tests/data/acpi/pc/DSDT.hpbrroot, Tue Sep 29 02:44:43 2020 > > >> > > >> > > > * > > >> > > >> > > > * Original Table Header: > > >> > > >> > > > * Signature "DSDT" > > >> > > >> > > > - * Length 0x0000139D (5021) > > >> > > >> > > > + * Length 0x00000B89 (2953) > > >> > > >> > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > >> > > >> > > > - * Checksum 0x05 > > >> > > >> > > > + * Checksum 0xA2 > > >> > > >> > > > * OEM ID "BOCHS " > > >> > > >> > > > * OEM Table ID "BXPCDSDT" > > >> > > >> > > > * OEM Revision 0x00000001 (1) > > >> > > >> > > > @@ -247,38 +247,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > >> > > >> > > > } > > >> > > >> > > > } > > >> > > >> > > > > > >> > > >> > > > - Scope (_SB.PCI0) > > >> > > >> > > > - { > > >> > > >> > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > >> > > >> > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > >> > > >> > > > - { > > >> > > >> > > > - PCIU, 32, > > >> > > >> > > > - PCID, 32 > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > >> > > >> > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > >> > > >> > > > - { > > >> > > >> > > > - B0EJ, 32 > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > >> > > >> > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > >> > > >> > > > - { > > >> > > >> > > > - BNUM, 32 > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Mutex (BLCK, 0x00) > > >> > > >> > > > - Method (PCEJ, 2, NotSerialized) > > >> > > >> > > > - { > > >> > > >> > > > - Acquire (BLCK, 0xFFFF) > > >> > > >> > > > - BNUM = Arg0 > > >> > > >> > > > - B0EJ = (One << Arg1) > > >> > > >> > > > - Release (BLCK) > > >> > > >> > > > - Return (Zero) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > Scope (_SB) > > >> > > >> > > > { > > >> > > >> > > > Scope (PCI0) > > >> > > >> > > > @@ -643,56 +611,22 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > >> > > >> > > > Method (CSCN, 0, Serialized) > > >> > > >> > > > { > > >> > > >> > > > Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF) > > >> > > >> > > > - Name (CNEW, Package (0xFF){}) > > >> > > >> > > > - Local3 = Zero > > >> > > >> > > > - Local4 = One > > >> > > >> > > > - While ((Local4 == One)) > > >> > > >> > > > + Local0 = One > > >> > > >> > > > + While ((Local0 == One)) > > >> > > >> > > > { > > >> > > >> > > > - Local4 = Zero > > >> > > >> > > > - Local0 = One > > >> > > >> > > > - Local1 = Zero > > >> > > >> > > > - While (((Local0 == One) && (Local3 < One))) > > >> > > >> > > > + Local0 = Zero > > >> > > >> > > > + \_SB.PCI0.PRES.CCMD = Zero > > >> > > >> > > > + If ((\_SB.PCI0.PRES.CINS == One)) > > >> > > >> > > > { > > >> > > >> > > > - Local0 = Zero > > >> > > >> > > > - \_SB.PCI0.PRES.CSEL = Local3 > > >> > > >> > > > - \_SB.PCI0.PRES.CCMD = Zero > > >> > > >> > > > - If ((\_SB.PCI0.PRES.CDAT < Local3)) > > >> > > >> > > > - { > > >> > > >> > > > - Break > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Local1 == 0xFF)) > > >> > > >> > > > - { > > >> > > >> > > > - Local4 = One > > >> > > >> > > > - Break > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Local3 = \_SB.PCI0.PRES.CDAT > > >> > > >> > > > - If ((\_SB.PCI0.PRES.CINS == One)) > > >> > > >> > > > - { > > >> > > >> > > > - CNEW [Local1] = Local3 > > >> > > >> > > > - Local1++ > > >> > > >> > > > - Local0 = One > > >> > > >> > > > - } > > >> > > >> > > > - ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > > >> > > >> > > > - { > > >> > > >> > > > - CTFY (Local3, 0x03) > > >> > > >> > > > - \_SB.PCI0.PRES.CRMV = One > > >> > > >> > > > - Local0 = One > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Local3++ > > >> > > >> > > > + CTFY (\_SB.PCI0.PRES.CDAT, One) > > >> > > >> > > > + \_SB.PCI0.PRES.CINS = One > > >> > > >> > > > + Local0 = One > > >> > > >> > > > } > > >> > > >> > > > - > > >> > > >> > > > - Local2 = Zero > > >> > > >> > > > - While ((Local2 < Local1)) > > >> > > >> > > > + ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > > >> > > >> > > > { > > >> > > >> > > > - Local3 = DerefOf (CNEW [Local2]) > > >> > > >> > > > - CTFY (Local3, One) > > >> > > >> > > > - Debug = Local3 > > >> > > >> > > > - \_SB.PCI0.PRES.CSEL = Local3 > > >> > > >> > > > - \_SB.PCI0.PRES.CINS = One > > >> > > >> > > > - Local2++ > > >> > > >> > > > + CTFY (\_SB.PCI0.PRES.CDAT, 0x03) > > >> > > >> > > > + \_SB.PCI0.PRES.CRMV = One > > >> > > >> > > > + Local0 = One > > >> > > >> > > > } > > >> > > >> > > > } > > >> > > >> > > > > > >> > > >> > > > @@ -737,12 +671,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > >> > > >> > > > Scope (_GPE) > > >> > > >> > > > { > > >> > > >> > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > > >> > > >> > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE, xx=0x00-0xFF > > >> > > >> > > > - { > > >> > > >> > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > >> > > >> > > > - \_SB.PCI0.PCNT () > > >> > > >> > > > - Release (\_SB.PCI0.BLCK) > > >> > > >> > > > - } > > >> > > >> > > > } > > >> > > >> > > > > > >> > > >> > > > Scope (\_SB.PCI0) > > >> > > >> > > > @@ -813,22 +741,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > >> > > >> > > > ) > > >> > > >> > > > }) > > >> > > >> > > > } > > >> > > >> > > > - > > >> > > >> > > > - Device (PHPR) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > >> > > >> > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > >> > > >> > > > - Name (_STA, 0x0B) // _STA: Status > > >> > > >> > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > >> > > >> > > > - { > > >> > > >> > > > - IO (Decode16, > > >> > > >> > > > - 0xAE00, // Range Minimum > > >> > > >> > > > - 0xAE00, // Range Maximum > > >> > > >> > > > - 0x01, // Alignment > > >> > > >> > > > - 0x14, // Length > > >> > > >> > > > - ) > > >> > > >> > > > - }) > > >> > > >> > > > - } > > >> > > >> > > > } > > >> > > >> > > > > > >> > > >> > > > Scope (\) > > >> > > >> > > > @@ -878,7 +790,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > >> > > >> > > > { > > >> > > >> > > > Scope (PCI0) > > >> > > >> > > > { > > >> > > >> > > > - Name (BSEL, Zero) > > >> > > >> > > > Device (S00) > > >> > > >> > > > { > > >> > > >> > > > Name (_ADR, Zero) // _ADR: Address > > >> > > >> > > > @@ -907,436 +818,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > >> > > >> > > > { > > >> > > >> > > > Name (_ADR, 0x00030000) // _ADR: Address > > >> > > >> > > > } > > >> > > >> > > > - > > >> > > >> > > > - Device (S20) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00040000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S28) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00050000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S30) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00060000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S38) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00070000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S40) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00080000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S48) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00090000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S50) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S58) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S60) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S68) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S70) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S78) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S80) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00100000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S88) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00110000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S90) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00120000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S98) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00130000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SA0) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00140000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SA8) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00150000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SB0) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00160000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SB8) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00170000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SC0) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00180000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SC8) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00190000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SD0) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SD8) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SE0) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SE8) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SF0) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SF8) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Method (DVNT, 2, NotSerialized) > > >> > > >> > > > - { > > >> > > >> > > > - If ((Arg0 & 0x10)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S20, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x20)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S28, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x40)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S30, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x80)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S38, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x0100)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S40, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x0200)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S48, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x0400)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S50, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x0800)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S58, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x1000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S60, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x2000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S68, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x4000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S70, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x8000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S78, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x00010000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S80, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x00020000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S88, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x00040000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S90, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x00080000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S98, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x00100000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SA0, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x00200000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SA8, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x00400000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SB0, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x00800000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SB8, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x01000000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SC0, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x02000000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SC8, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x04000000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SD0, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x08000000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SD8, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x10000000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SE0, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x20000000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SE8, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x40000000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SF0, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x80000000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SF8, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Method (PCNT, 0, NotSerialized) > > >> > > >> > > > - { > > >> > > >> > > > - BNUM = Zero > > >> > > >> > > > - DVNT (PCIU, One) > > >> > > >> > > > - DVNT (PCID, 0x03) > > >> > > >> > > > - } > > >> > > >> > > > } > > >> > > >> > > > } > > >> > > >> > > > } > > >> > > >> > > > > > >> > > >> > > >>
On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote: > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > In your pull request the following patch is completely screwed up: > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > Author: Ani Sinha <ani@anisinha.ca> > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > tests/acpi: update golden master DSDT binary table blobs for q35 > > > > > > This is not my patch. It has all sorts of changes which does not > > belong there. Can you please check? > > See https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/ I had to regenerate the binary, yes. That's par for the course. But it looks like I added disasssembled files. Will fix up and drop, thanks for noticing this. > > > > > On Tue, Sep 29, 2020 at 3:20 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > > > > > > > On Tue, Sep 29, 2020 at 3:12 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > >> > > >> On Tue, Sep 29, 2020 at 02:21:06PM +0530, Ani Sinha wrote: > > >> > > >> > On Tue, Sep 29, 2020 at 1:53 PM Ani Sinha <ani@anisinha.ca> wrote: > > >> > > >> > > > > >> > > >> > > On Tue, Sep 29, 2020 at 12:56 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > >> > > >> > > > > > >> > > >> > > > On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote: > > >> > > >> > > > > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > >> > > >> > > > > > > > >> > > >> > > > > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote: > > >> > > >> > > > > > > This change adds a new DSDT golden master table blob to test disabling > > >> > > >> > > > > > > hotplug on both pci root bus and pci bridges. Also reverts the change > > >> > > >> > > > > > > in file bios-tables-test-allowed-diff.h to make sure its now empty so that > > >> > > >> > > > > > > future modifications to acpi tables can be caught. > > >> > > >> > > > > > > > > >> > > >> > > > > > > The following is the disassembled diff between DSDT.hpbridge and DSDT.hpbrroot: > > >> > > >> > > > > > > > > >> > > >> > > > > > > @@ -1,30 +1,30 @@ > > >> > > >> > > > > > > /* > > >> > > >> > > > > > > * Intel ACPI Component Architecture > > >> > > >> > > > > > > * AML/ASL+ Disassembler version 20180105 (64-bit version) > > >> > > >> > > > > > > * Copyright (c) 2000 - 2018 Intel Corporation > > >> > > >> > > > > > > * > > >> > > >> > > > > > > * Disassembling to symbolic ASL+ operators > > >> > > >> > > > > > > * > > >> > > >> > > > > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Wed Sep 16 09:45:56 2020 > > >> > > >> > > > > > > + * Disassembly of /tmp/aml-ECV9Q0, Wed Sep 16 09:45:56 2020 > > >> > > >> > > > > > > * > > >> > > >> > > > > > > * Original Table Header: > > >> > > >> > > > > > > * Signature "DSDT" > > >> > > >> > > > > > > - * Length 0x0000131F (4895) > > >> > > >> > > > > > > + * Length 0x00000B89 (2953) > > >> > > >> > > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > >> > > >> > > > > > > - * Checksum 0xF9 > > >> > > >> > > > > > > + * Checksum 0xA2 > > >> > > >> > > > > > > * OEM ID "BOCHS " > > >> > > >> > > > > > > * OEM Table ID "BXPCDSDT" > > >> > > >> > > > > > > * OEM Revision 0x00000001 (1) > > >> > > >> > > > > > > * Compiler ID "BXPC" > > >> > > >> > > > > > > * Compiler Version 0x00000001 (1) > > >> > > >> > > > > > > */ > > >> > > >> > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Scope (\) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > OperationRegion (DBG, SystemIO, 0x0402, One) > > >> > > >> > > > > > > Field (DBG, ByteAcc, NoLock, Preserve) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > DBGB, 8 > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > @@ -234,64 +234,32 @@ > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Name (_HID, EisaId ("PNP0B00") /* AT Real-Time Clock */) // _HID: Hardware ID > > >> > > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > >> > > >> > > > > > > { > > >> > > >> > > > > > > IO (Decode16, > > >> > > >> > > > > > > 0x0070, // Range Minimum > > >> > > >> > > > > > > 0x0070, // Range Maximum > > >> > > >> > > > > > > 0x01, // Alignment > > >> > > >> > > > > > > 0x08, // Length > > >> > > >> > > > > > > ) > > >> > > >> > > > > > > IRQNoFlags () > > >> > > >> > > > > > > {8} > > >> > > >> > > > > > > }) > > >> > > >> > > > > > > } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > - Scope (_SB.PCI0) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > >> > > >> > > > > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCIU, 32, > > >> > > >> > > > > > > - PCID, 32 > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > >> > > >> > > > > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - B0EJ, 32 > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > >> > > >> > > > > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - BNUM, 32 > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Mutex (BLCK, 0x00) > > >> > > >> > > > > > > - Method (PCEJ, 2, NotSerialized) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Acquire (BLCK, 0xFFFF) > > >> > > >> > > > > > > - BNUM = Arg0 > > >> > > >> > > > > > > - B0EJ = (One << Arg1) > > >> > > >> > > > > > > - Release (BLCK) > > >> > > >> > > > > > > - Return (Zero) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > Scope (_SB) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Scope (PCI0) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Method (_PRT, 0, NotSerialized) // _PRT: PCI Routing Table > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Local0 = Package (0x80){} > > >> > > >> > > > > > > Local1 = Zero > > >> > > >> > > > > > > While ((Local1 < 0x80)) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Local2 = (Local1 >> 0x02) > > >> > > >> > > > > > > Local3 = ((Local1 + Local2) & 0x03) > > >> > > >> > > > > > > If ((Local3 == Zero)) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Local4 = Package (0x04) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > @@ -690,38 +658,32 @@ > > >> > > >> > > > > > > Method (_OST, 3, Serialized) // _OST: OSPM Status Indication > > >> > > >> > > > > > > { > > >> > > >> > > > > > > COST (Zero, Arg0, Arg1, Arg2) > > >> > > >> > > > > > > } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Method (\_GPE._E02, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > >> > > >> > > > > > > { > > >> > > >> > > > > > > \_SB.CPUS.CSCN () > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Scope (_GPE) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > > >> > > >> > > > > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > >> > > >> > > > > > > - \_SB.PCI0.PCNT () > > >> > > >> > > > > > > - Release (\_SB.PCI0.BLCK) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Scope (\_SB.PCI0) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > >> > > >> > > > > > > { > > >> > > >> > > > > > > WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode, > > >> > > >> > > > > > > 0x0000, // Granularity > > >> > > >> > > > > > > 0x0000, // Range Minimum > > >> > > >> > > > > > > 0x00FF, // Range Maximum > > >> > > >> > > > > > > 0x0000, // Translation Offset > > >> > > >> > > > > > > 0x0100, // Length > > >> > > >> > > > > > > ,, ) > > >> > > >> > > > > > > IO (Decode16, > > >> > > >> > > > > > > 0x0CF8, // Range Minimum > > >> > > >> > > > > > > 0x0CF8, // Range Maximum > > >> > > >> > > > > > > @@ -766,48 +728,32 @@ > > >> > > >> > > > > > > }) > > >> > > >> > > > > > > Device (GPE0) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > >> > > >> > > > > > > Name (_UID, "GPE0 resources") // _UID: Unique ID > > >> > > >> > > > > > > Name (_STA, 0x0B) // _STA: Status > > >> > > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > >> > > >> > > > > > > { > > >> > > >> > > > > > > IO (Decode16, > > >> > > >> > > > > > > 0xAFE0, // Range Minimum > > >> > > >> > > > > > > 0xAFE0, // Range Maximum > > >> > > >> > > > > > > 0x01, // Alignment > > >> > > >> > > > > > > 0x04, // Length > > >> > > >> > > > > > > ) > > >> > > >> > > > > > > }) > > >> > > >> > > > > > > } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (PHPR) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > >> > > >> > > > > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > >> > > >> > > > > > > - Name (_STA, 0x0B) // _STA: Status > > >> > > >> > > > > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - IO (Decode16, > > >> > > >> > > > > > > - 0xAE00, // Range Minimum > > >> > > >> > > > > > > - 0xAE00, // Range Maximum > > >> > > >> > > > > > > - 0x01, // Alignment > > >> > > >> > > > > > > - 0x14, // Length > > >> > > >> > > > > > > - ) > > >> > > >> > > > > > > - }) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Scope (\) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Name (_S3, Package (0x04) // _S3_: S3 System State > > >> > > >> > > > > > > { > > >> > > >> > > > > > > One, > > >> > > >> > > > > > > One, > > >> > > >> > > > > > > Zero, > > >> > > >> > > > > > > Zero > > >> > > >> > > > > > > }) > > >> > > >> > > > > > > Name (_S4, Package (0x04) // _S4_: S4 System State > > >> > > >> > > > > > > { > > >> > > >> > > > > > > 0x02, > > >> > > >> > > > > > > 0x02, > > >> > > >> > > > > > > Zero, > > >> > > >> > > > > > > @@ -831,479 +777,48 @@ > > >> > > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > >> > > >> > > > > > > { > > >> > > >> > > > > > > IO (Decode16, > > >> > > >> > > > > > > 0x0510, // Range Minimum > > >> > > >> > > > > > > 0x0510, // Range Maximum > > >> > > >> > > > > > > 0x01, // Alignment > > >> > > >> > > > > > > 0x0C, // Length > > >> > > >> > > > > > > ) > > >> > > >> > > > > > > }) > > >> > > >> > > > > > > } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Scope (\_SB) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Scope (PCI0) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > - Name (BSEL, Zero) > > >> > > >> > > > > > > Device (S00) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Name (_ADR, Zero) // _ADR: Address > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Device (S10) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Name (_ADR, 0x00020000) // _ADR: Address > > >> > > >> > > > > > > Method (_S1D, 0, NotSerialized) // _S1D: S1 Device State > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Return (Zero) > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Return (Zero) > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Return (Zero) > > >> > > >> > > > > > > } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > > >> > > >> > > > > > > Device (S18) > > >> > > >> > > > > > > { > > >> > > >> > > > > > > Name (_ADR, 0x00030000) // _ADR: Address > > >> > > >> > > > > > > } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S20) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00040000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S28) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00050000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S30) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00060000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S38) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00070000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S40) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00080000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S48) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00090000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S50) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S58) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S60) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S68) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S70) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S78) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S80) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00100000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S88) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00110000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S90) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00120000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (S98) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00130000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SA0) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00140000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SA8) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00150000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SB0) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00160000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SB8) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00170000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SC0) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00180000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SC8) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x00190000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SD0) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SD8) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SE0) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SE8) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SF0) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Device (SF8) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > >> > > >> > > > > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > >> > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Method (DVNT, 2, NotSerialized) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - If ((Arg0 & 0x10)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S20, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x20)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S28, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x40)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S30, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x80)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S38, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x0100)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S40, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x0200)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S48, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x0400)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S50, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x0800)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S58, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x1000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S60, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x2000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S68, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x4000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S70, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x8000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S78, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x00010000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S80, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x00020000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S88, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x00040000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S90, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x00080000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (S98, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x00100000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SA0, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x00200000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SA8, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x00400000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SB0, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x00800000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SB8, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x01000000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SC0, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x02000000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SC8, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x04000000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SD0, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x08000000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SD8, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x10000000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SE0, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x20000000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SE8, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x40000000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SF0, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - If ((Arg0 & 0x80000000)) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - Notify (SF8, Arg1) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > - > > >> > > >> > > > > > > - Method (PCNT, 0, NotSerialized) > > >> > > >> > > > > > > - { > > >> > > >> > > > > > > - BNUM = Zero > > >> > > >> > > > > > > - DVNT (PCIU, One) > > >> > > >> > > > > > > - DVNT (PCID, 0x03) > > >> > > >> > > > > > > - } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > } > > >> > > >> > > > > > > > >> > > >> > > > > > This is not the only diff I see if I apply this patchset on > > >> > > >> > > > > > top of master. > > >> > > >> > > > > > Dropped this and the previous patch. > > >> > > >> > > > > > Please check what is going on and repost as appropriate. > > >> > > >> > > > > > > >> > > >> > > > > Which two ACPI DSDT files are you diffing? What diff are you getting? > > >> > > >> > > > > > >> > > >> > > > > > >> > > >> > > > diff -rup ./tests/data/acpi/pc/DSDT.hpbridge.dsl ./tests/data/acpi/pc/DSDT.hpbrroot.dsl > > >> > > >> > > > > >> > > >> > > I re-based my patchset on top of the latest qemu master and did a make > > >> > > >> > > && make check-qtest-x86_64 V=1. > > >> > > >> > > They pass. I am seeing this diff: > > >> > > >> > > https://pastebin.ubuntu.com/p/BXy9GFfB2R/ > > >> > > >> > > > > >> > > >> > > and it looks good to me. > > >> > > >> > > > > >> > > >> > > Not sure why your diff looks different. Maybe you can regenerate the blob? > > >> > > >> > > > >> > > >> > I did a full make check and it passed. I compared the diff again and > > >> > > >> > it's the same. I checked my tree and it looks clean. These are the > > >> > > >> > patches I have: > > >> > > >> > > > >> > > >> > $ git log --oneline > > >> > > >> > 20d1323e10 (HEAD -> master) qom: code hardening - have bound checking > > >> > > >> > while looping with integer value > > >> > > >> > 0f69dae0e2 Add a comment in bios-tables-test.c to clarify the reason > > >> > > >> > behind approach > > >> > > >> > dd9a8c3cd3 tests/acpi: add DSDT.hpbrroot DSDT table blob to test > > >> > > >> > global i440fx hotplug > > >> > > >> > 5b93474fe9 tests/acpi: unit test exercising global pci hotplug off for i440fx > > >> > > >> > 54c33e334a tests/acpi: update golden master DSDT binary table blobs for q35 > > >> > > >> > 2279f61f30 piix4: don't reserve hw resources when hotplug is off globally > > >> > > >> > 1f61c524a0 Add ACPI DSDT tables for q35 that are being updated by the next patch > > >> > > >> > bdd823611b tests/acpi: add newly added acpi DSDT table blob for pci > > >> > > >> > bridge hotplug flag > > >> > > >> > 8c80f8fba9 tests/acpi: unit test for > > >> > > >> > 'acpi-pci-hotplug-with-bridge-support' bridge flag > > >> > > >> > e0a3142df9 tests/acpi: list added acpi table binary file for pci > > >> > > >> > bridge hotplug test > > >> > > >> > 0ba08317a8 i440fx/acpi: do not add hotplug related amls for cold plugged bridges > > >> > > >> > 73b191ade6 Fix a gap where acpi_pcihp_find_hotplug_bus() returns a > > >> > > >> > non-hotpluggable bus > > >> > > >> > ef0e526cc2 tests/acpi: add a new ACPI table in order to test root pci > > >> > > >> > hotplug on/off > > >> > > >> > c6d13264f8 tests/acpi: add new unit test to test hotplug off/on > > >> > > >> > feature on the root pci bus > > >> > > >> > 6901bada65 tests/acpi: mark addition of table DSDT.roothp for unit > > >> > > >> > testing root pci hotplug > > >> > > >> > 74504514b1 (origin/master, origin/HEAD) Merge remote-tracking branch > > >> > > >> > 'remotes/alistair/tags/pull-register-20200927' into staging > > >> > > >> > > >> > > >> Try applying on top of latest pull request? > > > > > > > > > Maybe I'm missing something but can you point me to the latest pull request? > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > > >> > > >> > > > > >> > > >> > > > > > >> > > >> > > > > > >> > > >> > > > > > >> > > >> > > > --- ./tests/data/acpi/pc/DSDT.hpbridge.dsl 2020-09-29 02:44:43.874622404 -0400 > > >> > > >> > > > +++ ./tests/data/acpi/pc/DSDT.hpbrroot.dsl 2020-09-29 02:44:43.876622403 -0400 > > >> > > >> > > > @@ -5,13 +5,13 @@ > > >> > > >> > > > * > > >> > > >> > > > * Disassembling to symbolic ASL+ operators > > >> > > >> > > > * > > >> > > >> > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 02:44:43 2020 > > >> > > >> > > > + * Disassembly of tests/data/acpi/pc/DSDT.hpbrroot, Tue Sep 29 02:44:43 2020 > > >> > > >> > > > * > > >> > > >> > > > * Original Table Header: > > >> > > >> > > > * Signature "DSDT" > > >> > > >> > > > - * Length 0x0000139D (5021) > > >> > > >> > > > + * Length 0x00000B89 (2953) > > >> > > >> > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > >> > > >> > > > - * Checksum 0x05 > > >> > > >> > > > + * Checksum 0xA2 > > >> > > >> > > > * OEM ID "BOCHS " > > >> > > >> > > > * OEM Table ID "BXPCDSDT" > > >> > > >> > > > * OEM Revision 0x00000001 (1) > > >> > > >> > > > @@ -247,38 +247,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > >> > > >> > > > } > > >> > > >> > > > } > > >> > > >> > > > > > >> > > >> > > > - Scope (_SB.PCI0) > > >> > > >> > > > - { > > >> > > >> > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > >> > > >> > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > >> > > >> > > > - { > > >> > > >> > > > - PCIU, 32, > > >> > > >> > > > - PCID, 32 > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > >> > > >> > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > >> > > >> > > > - { > > >> > > >> > > > - B0EJ, 32 > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > >> > > >> > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > >> > > >> > > > - { > > >> > > >> > > > - BNUM, 32 > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Mutex (BLCK, 0x00) > > >> > > >> > > > - Method (PCEJ, 2, NotSerialized) > > >> > > >> > > > - { > > >> > > >> > > > - Acquire (BLCK, 0xFFFF) > > >> > > >> > > > - BNUM = Arg0 > > >> > > >> > > > - B0EJ = (One << Arg1) > > >> > > >> > > > - Release (BLCK) > > >> > > >> > > > - Return (Zero) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > Scope (_SB) > > >> > > >> > > > { > > >> > > >> > > > Scope (PCI0) > > >> > > >> > > > @@ -643,56 +611,22 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > >> > > >> > > > Method (CSCN, 0, Serialized) > > >> > > >> > > > { > > >> > > >> > > > Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF) > > >> > > >> > > > - Name (CNEW, Package (0xFF){}) > > >> > > >> > > > - Local3 = Zero > > >> > > >> > > > - Local4 = One > > >> > > >> > > > - While ((Local4 == One)) > > >> > > >> > > > + Local0 = One > > >> > > >> > > > + While ((Local0 == One)) > > >> > > >> > > > { > > >> > > >> > > > - Local4 = Zero > > >> > > >> > > > - Local0 = One > > >> > > >> > > > - Local1 = Zero > > >> > > >> > > > - While (((Local0 == One) && (Local3 < One))) > > >> > > >> > > > + Local0 = Zero > > >> > > >> > > > + \_SB.PCI0.PRES.CCMD = Zero > > >> > > >> > > > + If ((\_SB.PCI0.PRES.CINS == One)) > > >> > > >> > > > { > > >> > > >> > > > - Local0 = Zero > > >> > > >> > > > - \_SB.PCI0.PRES.CSEL = Local3 > > >> > > >> > > > - \_SB.PCI0.PRES.CCMD = Zero > > >> > > >> > > > - If ((\_SB.PCI0.PRES.CDAT < Local3)) > > >> > > >> > > > - { > > >> > > >> > > > - Break > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Local1 == 0xFF)) > > >> > > >> > > > - { > > >> > > >> > > > - Local4 = One > > >> > > >> > > > - Break > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Local3 = \_SB.PCI0.PRES.CDAT > > >> > > >> > > > - If ((\_SB.PCI0.PRES.CINS == One)) > > >> > > >> > > > - { > > >> > > >> > > > - CNEW [Local1] = Local3 > > >> > > >> > > > - Local1++ > > >> > > >> > > > - Local0 = One > > >> > > >> > > > - } > > >> > > >> > > > - ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > > >> > > >> > > > - { > > >> > > >> > > > - CTFY (Local3, 0x03) > > >> > > >> > > > - \_SB.PCI0.PRES.CRMV = One > > >> > > >> > > > - Local0 = One > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Local3++ > > >> > > >> > > > + CTFY (\_SB.PCI0.PRES.CDAT, One) > > >> > > >> > > > + \_SB.PCI0.PRES.CINS = One > > >> > > >> > > > + Local0 = One > > >> > > >> > > > } > > >> > > >> > > > - > > >> > > >> > > > - Local2 = Zero > > >> > > >> > > > - While ((Local2 < Local1)) > > >> > > >> > > > + ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > > >> > > >> > > > { > > >> > > >> > > > - Local3 = DerefOf (CNEW [Local2]) > > >> > > >> > > > - CTFY (Local3, One) > > >> > > >> > > > - Debug = Local3 > > >> > > >> > > > - \_SB.PCI0.PRES.CSEL = Local3 > > >> > > >> > > > - \_SB.PCI0.PRES.CINS = One > > >> > > >> > > > - Local2++ > > >> > > >> > > > + CTFY (\_SB.PCI0.PRES.CDAT, 0x03) > > >> > > >> > > > + \_SB.PCI0.PRES.CRMV = One > > >> > > >> > > > + Local0 = One > > >> > > >> > > > } > > >> > > >> > > > } > > >> > > >> > > > > > >> > > >> > > > @@ -737,12 +671,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > >> > > >> > > > Scope (_GPE) > > >> > > >> > > > { > > >> > > >> > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > > >> > > >> > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE, xx=0x00-0xFF > > >> > > >> > > > - { > > >> > > >> > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > >> > > >> > > > - \_SB.PCI0.PCNT () > > >> > > >> > > > - Release (\_SB.PCI0.BLCK) > > >> > > >> > > > - } > > >> > > >> > > > } > > >> > > >> > > > > > >> > > >> > > > Scope (\_SB.PCI0) > > >> > > >> > > > @@ -813,22 +741,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > >> > > >> > > > ) > > >> > > >> > > > }) > > >> > > >> > > > } > > >> > > >> > > > - > > >> > > >> > > > - Device (PHPR) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > >> > > >> > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > >> > > >> > > > - Name (_STA, 0x0B) // _STA: Status > > >> > > >> > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > >> > > >> > > > - { > > >> > > >> > > > - IO (Decode16, > > >> > > >> > > > - 0xAE00, // Range Minimum > > >> > > >> > > > - 0xAE00, // Range Maximum > > >> > > >> > > > - 0x01, // Alignment > > >> > > >> > > > - 0x14, // Length > > >> > > >> > > > - ) > > >> > > >> > > > - }) > > >> > > >> > > > - } > > >> > > >> > > > } > > >> > > >> > > > > > >> > > >> > > > Scope (\) > > >> > > >> > > > @@ -878,7 +790,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > >> > > >> > > > { > > >> > > >> > > > Scope (PCI0) > > >> > > >> > > > { > > >> > > >> > > > - Name (BSEL, Zero) > > >> > > >> > > > Device (S00) > > >> > > >> > > > { > > >> > > >> > > > Name (_ADR, Zero) // _ADR: Address > > >> > > >> > > > @@ -907,436 +818,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > >> > > >> > > > { > > >> > > >> > > > Name (_ADR, 0x00030000) // _ADR: Address > > >> > > >> > > > } > > >> > > >> > > > - > > >> > > >> > > > - Device (S20) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00040000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S28) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00050000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S30) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00060000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S38) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00070000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S40) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00080000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S48) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00090000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S50) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S58) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S60) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S68) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S70) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S78) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S80) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00100000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S88) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00110000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S90) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00120000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (S98) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00130000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SA0) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00140000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SA8) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00150000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SB0) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00160000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SB8) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00170000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SC0) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00180000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SC8) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x00190000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SD0) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SD8) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SE0) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SE8) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SF0) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Device (SF8) > > >> > > >> > > > - { > > >> > > >> > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > >> > > >> > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > >> > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > >> > > >> > > > - { > > >> > > >> > > > - PCEJ (BSEL, _SUN) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Method (DVNT, 2, NotSerialized) > > >> > > >> > > > - { > > >> > > >> > > > - If ((Arg0 & 0x10)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S20, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x20)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S28, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x40)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S30, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x80)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S38, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x0100)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S40, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x0200)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S48, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x0400)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S50, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x0800)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S58, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x1000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S60, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x2000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S68, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x4000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S70, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x8000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S78, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x00010000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S80, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x00020000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S88, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x00040000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S90, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x00080000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (S98, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x00100000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SA0, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x00200000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SA8, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x00400000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SB0, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x00800000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SB8, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x01000000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SC0, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x02000000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SC8, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x04000000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SD0, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x08000000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SD8, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x10000000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SE0, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x20000000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SE8, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x40000000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SF0, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - If ((Arg0 & 0x80000000)) > > >> > > >> > > > - { > > >> > > >> > > > - Notify (SF8, Arg1) > > >> > > >> > > > - } > > >> > > >> > > > - } > > >> > > >> > > > - > > >> > > >> > > > - Method (PCNT, 0, NotSerialized) > > >> > > >> > > > - { > > >> > > >> > > > - BNUM = Zero > > >> > > >> > > > - DVNT (PCIU, One) > > >> > > >> > > > - DVNT (PCID, 0x03) > > >> > > >> > > > - } > > >> > > >> > > > } > > >> > > >> > > > } > > >> > > >> > > > } > > >> > > >> > > > > > >> > > >> > > >>
On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote: > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > In your pull request the following patch is completely screwed up: > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > Author: Ani Sinha <ani@anisinha.ca> > > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > > > tests/acpi: update golden master DSDT binary table blobs for q35 > > > > > > > > > This is not my patch. It has all sorts of changes which does not > > > belong there. Can you please check? > > > > See https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/ > > > I had to regenerate the binary, yes. That's par for the course. > But it looks like I added disasssembled files. Will fix up and drop, > thanks for noticing this. I think DSDT.hbridge is wrong. The checksum looks weird: + * Length 0x00000B89 (2953) * Revision 0x01 **** 32-bit table (V1), no 64-bit math support - * Checksum 0x05 This file should be introduced just by one patch. my patch. > > > > > > > > > > On Tue, Sep 29, 2020 at 3:20 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 3:12 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > >> > > > >> On Tue, Sep 29, 2020 at 02:21:06PM +0530, Ani Sinha wrote: > > > >> > > > >> > On Tue, Sep 29, 2020 at 1:53 PM Ani Sinha <ani@anisinha.ca> wrote: > > > >> > > > >> > > > > > >> > > > >> > > On Tue, Sep 29, 2020 at 12:56 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > >> > > > >> > > > > > > >> > > > >> > > > On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote: > > > >> > > > >> > > > > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > >> > > > >> > > > > > > > > >> > > > >> > > > > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote: > > > >> > > > >> > > > > > > This change adds a new DSDT golden master table blob to test disabling > > > >> > > > >> > > > > > > hotplug on both pci root bus and pci bridges. Also reverts the change > > > >> > > > >> > > > > > > in file bios-tables-test-allowed-diff.h to make sure its now empty so that > > > >> > > > >> > > > > > > future modifications to acpi tables can be caught. > > > >> > > > >> > > > > > > > > > >> > > > >> > > > > > > The following is the disassembled diff between DSDT.hpbridge and DSDT.hpbrroot: > > > >> > > > >> > > > > > > > > > >> > > > >> > > > > > > @@ -1,30 +1,30 @@ > > > >> > > > >> > > > > > > /* > > > >> > > > >> > > > > > > * Intel ACPI Component Architecture > > > >> > > > >> > > > > > > * AML/ASL+ Disassembler version 20180105 (64-bit version) > > > >> > > > >> > > > > > > * Copyright (c) 2000 - 2018 Intel Corporation > > > >> > > > >> > > > > > > * > > > >> > > > >> > > > > > > * Disassembling to symbolic ASL+ operators > > > >> > > > >> > > > > > > * > > > >> > > > >> > > > > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Wed Sep 16 09:45:56 2020 > > > >> > > > >> > > > > > > + * Disassembly of /tmp/aml-ECV9Q0, Wed Sep 16 09:45:56 2020 > > > >> > > > >> > > > > > > * > > > >> > > > >> > > > > > > * Original Table Header: > > > >> > > > >> > > > > > > * Signature "DSDT" > > > >> > > > >> > > > > > > - * Length 0x0000131F (4895) > > > >> > > > >> > > > > > > + * Length 0x00000B89 (2953) > > > >> > > > >> > > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > >> > > > >> > > > > > > - * Checksum 0xF9 > > > >> > > > >> > > > > > > + * Checksum 0xA2 > > > >> > > > >> > > > > > > * OEM ID "BOCHS " > > > >> > > > >> > > > > > > * OEM Table ID "BXPCDSDT" > > > >> > > > >> > > > > > > * OEM Revision 0x00000001 (1) > > > >> > > > >> > > > > > > * Compiler ID "BXPC" > > > >> > > > >> > > > > > > * Compiler Version 0x00000001 (1) > > > >> > > > >> > > > > > > */ > > > >> > > > >> > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Scope (\) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > OperationRegion (DBG, SystemIO, 0x0402, One) > > > >> > > > >> > > > > > > Field (DBG, ByteAcc, NoLock, Preserve) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > DBGB, 8 > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > > > > >> > > > >> > > > > > > @@ -234,64 +234,32 @@ > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Name (_HID, EisaId ("PNP0B00") /* AT Real-Time Clock */) // _HID: Hardware ID > > > >> > > > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > IO (Decode16, > > > >> > > > >> > > > > > > 0x0070, // Range Minimum > > > >> > > > >> > > > > > > 0x0070, // Range Maximum > > > >> > > > >> > > > > > > 0x01, // Alignment > > > >> > > > >> > > > > > > 0x08, // Length > > > >> > > > >> > > > > > > ) > > > >> > > > >> > > > > > > IRQNoFlags () > > > >> > > > >> > > > > > > {8} > > > >> > > > >> > > > > > > }) > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > > > > >> > > > >> > > > > > > - Scope (_SB.PCI0) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > > >> > > > >> > > > > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCIU, 32, > > > >> > > > >> > > > > > > - PCID, 32 > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > > >> > > > >> > > > > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - B0EJ, 32 > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > > >> > > > >> > > > > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - BNUM, 32 > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Mutex (BLCK, 0x00) > > > >> > > > >> > > > > > > - Method (PCEJ, 2, NotSerialized) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Acquire (BLCK, 0xFFFF) > > > >> > > > >> > > > > > > - BNUM = Arg0 > > > >> > > > >> > > > > > > - B0EJ = (One << Arg1) > > > >> > > > >> > > > > > > - Release (BLCK) > > > >> > > > >> > > > > > > - Return (Zero) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > Scope (_SB) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Scope (PCI0) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Method (_PRT, 0, NotSerialized) // _PRT: PCI Routing Table > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Local0 = Package (0x80){} > > > >> > > > >> > > > > > > Local1 = Zero > > > >> > > > >> > > > > > > While ((Local1 < 0x80)) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Local2 = (Local1 >> 0x02) > > > >> > > > >> > > > > > > Local3 = ((Local1 + Local2) & 0x03) > > > >> > > > >> > > > > > > If ((Local3 == Zero)) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Local4 = Package (0x04) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > @@ -690,38 +658,32 @@ > > > >> > > > >> > > > > > > Method (_OST, 3, Serialized) // _OST: OSPM Status Indication > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > COST (Zero, Arg0, Arg1, Arg2) > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > > > > >> > > > >> > > > > > > Method (\_GPE._E02, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > \_SB.CPUS.CSCN () > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > > > > >> > > > >> > > > > > > Scope (_GPE) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > > > >> > > > >> > > > > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > > >> > > > >> > > > > > > - \_SB.PCI0.PCNT () > > > >> > > > >> > > > > > > - Release (\_SB.PCI0.BLCK) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > > > > >> > > > >> > > > > > > Scope (\_SB.PCI0) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode, > > > >> > > > >> > > > > > > 0x0000, // Granularity > > > >> > > > >> > > > > > > 0x0000, // Range Minimum > > > >> > > > >> > > > > > > 0x00FF, // Range Maximum > > > >> > > > >> > > > > > > 0x0000, // Translation Offset > > > >> > > > >> > > > > > > 0x0100, // Length > > > >> > > > >> > > > > > > ,, ) > > > >> > > > >> > > > > > > IO (Decode16, > > > >> > > > >> > > > > > > 0x0CF8, // Range Minimum > > > >> > > > >> > > > > > > 0x0CF8, // Range Maximum > > > >> > > > >> > > > > > > @@ -766,48 +728,32 @@ > > > >> > > > >> > > > > > > }) > > > >> > > > >> > > > > > > Device (GPE0) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > > >> > > > >> > > > > > > Name (_UID, "GPE0 resources") // _UID: Unique ID > > > >> > > > >> > > > > > > Name (_STA, 0x0B) // _STA: Status > > > >> > > > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > IO (Decode16, > > > >> > > > >> > > > > > > 0xAFE0, // Range Minimum > > > >> > > > >> > > > > > > 0xAFE0, // Range Maximum > > > >> > > > >> > > > > > > 0x01, // Alignment > > > >> > > > >> > > > > > > 0x04, // Length > > > >> > > > >> > > > > > > ) > > > >> > > > >> > > > > > > }) > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (PHPR) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > > >> > > > >> > > > > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > > >> > > > >> > > > > > > - Name (_STA, 0x0B) // _STA: Status > > > >> > > > >> > > > > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - IO (Decode16, > > > >> > > > >> > > > > > > - 0xAE00, // Range Minimum > > > >> > > > >> > > > > > > - 0xAE00, // Range Maximum > > > >> > > > >> > > > > > > - 0x01, // Alignment > > > >> > > > >> > > > > > > - 0x14, // Length > > > >> > > > >> > > > > > > - ) > > > >> > > > >> > > > > > > - }) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > > > > >> > > > >> > > > > > > Scope (\) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Name (_S3, Package (0x04) // _S3_: S3 System State > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > One, > > > >> > > > >> > > > > > > One, > > > >> > > > >> > > > > > > Zero, > > > >> > > > >> > > > > > > Zero > > > >> > > > >> > > > > > > }) > > > >> > > > >> > > > > > > Name (_S4, Package (0x04) // _S4_: S4 System State > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > 0x02, > > > >> > > > >> > > > > > > 0x02, > > > >> > > > >> > > > > > > Zero, > > > >> > > > >> > > > > > > @@ -831,479 +777,48 @@ > > > >> > > > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > IO (Decode16, > > > >> > > > >> > > > > > > 0x0510, // Range Minimum > > > >> > > > >> > > > > > > 0x0510, // Range Maximum > > > >> > > > >> > > > > > > 0x01, // Alignment > > > >> > > > >> > > > > > > 0x0C, // Length > > > >> > > > >> > > > > > > ) > > > >> > > > >> > > > > > > }) > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > > > > >> > > > >> > > > > > > Scope (\_SB) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Scope (PCI0) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > - Name (BSEL, Zero) > > > >> > > > >> > > > > > > Device (S00) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Name (_ADR, Zero) // _ADR: Address > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > > > > >> > > > >> > > > > > > Device (S10) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Name (_ADR, 0x00020000) // _ADR: Address > > > >> > > > >> > > > > > > Method (_S1D, 0, NotSerialized) // _S1D: S1 Device State > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Return (Zero) > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > > > > >> > > > >> > > > > > > Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Return (Zero) > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > > > > >> > > > >> > > > > > > Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Return (Zero) > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > > > > >> > > > >> > > > > > > Device (S18) > > > >> > > > >> > > > > > > { > > > >> > > > >> > > > > > > Name (_ADR, 0x00030000) // _ADR: Address > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (S20) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x00040000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (S28) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x00050000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (S30) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x00060000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (S38) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x00070000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (S40) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x00080000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (S48) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x00090000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (S50) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (S58) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (S60) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (S68) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (S70) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (S78) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (S80) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x00100000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (S88) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x00110000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (S90) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x00120000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (S98) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x00130000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (SA0) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x00140000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (SA8) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x00150000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (SB0) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x00160000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (SB8) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x00170000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (SC0) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x00180000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (SC8) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x00190000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (SD0) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (SD8) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (SE0) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (SE8) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (SF0) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Device (SF8) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > > >> > > > >> > > > > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > > >> > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Method (DVNT, 2, NotSerialized) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - If ((Arg0 & 0x10)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (S20, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x20)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (S28, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x40)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (S30, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x80)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (S38, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x0100)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (S40, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x0200)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (S48, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x0400)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (S50, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x0800)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (S58, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x1000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (S60, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x2000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (S68, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x4000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (S70, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x8000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (S78, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x00010000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (S80, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x00020000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (S88, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x00040000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (S90, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x00080000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (S98, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x00100000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (SA0, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x00200000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (SA8, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x00400000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (SB0, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x00800000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (SB8, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x01000000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (SC0, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x02000000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (SC8, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x04000000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (SD0, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x08000000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (SD8, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x10000000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (SE0, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x20000000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (SE8, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x40000000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (SF0, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - If ((Arg0 & 0x80000000)) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - Notify (SF8, Arg1) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > - > > > >> > > > >> > > > > > > - Method (PCNT, 0, NotSerialized) > > > >> > > > >> > > > > > > - { > > > >> > > > >> > > > > > > - BNUM = Zero > > > >> > > > >> > > > > > > - DVNT (PCIU, One) > > > >> > > > >> > > > > > > - DVNT (PCID, 0x03) > > > >> > > > >> > > > > > > - } > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > } > > > >> > > > >> > > > > > > > > >> > > > >> > > > > > This is not the only diff I see if I apply this patchset on > > > >> > > > >> > > > > > top of master. > > > >> > > > >> > > > > > Dropped this and the previous patch. > > > >> > > > >> > > > > > Please check what is going on and repost as appropriate. > > > >> > > > >> > > > > > > > >> > > > >> > > > > Which two ACPI DSDT files are you diffing? What diff are you getting? > > > >> > > > >> > > > > > > >> > > > >> > > > > > > >> > > > >> > > > diff -rup ./tests/data/acpi/pc/DSDT.hpbridge.dsl ./tests/data/acpi/pc/DSDT.hpbrroot.dsl > > > >> > > > >> > > > > > >> > > > >> > > I re-based my patchset on top of the latest qemu master and did a make > > > >> > > > >> > > && make check-qtest-x86_64 V=1. > > > >> > > > >> > > They pass. I am seeing this diff: > > > >> > > > >> > > https://pastebin.ubuntu.com/p/BXy9GFfB2R/ > > > >> > > > >> > > > > > >> > > > >> > > and it looks good to me. > > > >> > > > >> > > > > > >> > > > >> > > Not sure why your diff looks different. Maybe you can regenerate the blob? > > > >> > > > >> > > > > >> > > > >> > I did a full make check and it passed. I compared the diff again and > > > >> > > > >> > it's the same. I checked my tree and it looks clean. These are the > > > >> > > > >> > patches I have: > > > >> > > > >> > > > > >> > > > >> > $ git log --oneline > > > >> > > > >> > 20d1323e10 (HEAD -> master) qom: code hardening - have bound checking > > > >> > > > >> > while looping with integer value > > > >> > > > >> > 0f69dae0e2 Add a comment in bios-tables-test.c to clarify the reason > > > >> > > > >> > behind approach > > > >> > > > >> > dd9a8c3cd3 tests/acpi: add DSDT.hpbrroot DSDT table blob to test > > > >> > > > >> > global i440fx hotplug > > > >> > > > >> > 5b93474fe9 tests/acpi: unit test exercising global pci hotplug off for i440fx > > > >> > > > >> > 54c33e334a tests/acpi: update golden master DSDT binary table blobs for q35 > > > >> > > > >> > 2279f61f30 piix4: don't reserve hw resources when hotplug is off globally > > > >> > > > >> > 1f61c524a0 Add ACPI DSDT tables for q35 that are being updated by the next patch > > > >> > > > >> > bdd823611b tests/acpi: add newly added acpi DSDT table blob for pci > > > >> > > > >> > bridge hotplug flag > > > >> > > > >> > 8c80f8fba9 tests/acpi: unit test for > > > >> > > > >> > 'acpi-pci-hotplug-with-bridge-support' bridge flag > > > >> > > > >> > e0a3142df9 tests/acpi: list added acpi table binary file for pci > > > >> > > > >> > bridge hotplug test > > > >> > > > >> > 0ba08317a8 i440fx/acpi: do not add hotplug related amls for cold plugged bridges > > > >> > > > >> > 73b191ade6 Fix a gap where acpi_pcihp_find_hotplug_bus() returns a > > > >> > > > >> > non-hotpluggable bus > > > >> > > > >> > ef0e526cc2 tests/acpi: add a new ACPI table in order to test root pci > > > >> > > > >> > hotplug on/off > > > >> > > > >> > c6d13264f8 tests/acpi: add new unit test to test hotplug off/on > > > >> > > > >> > feature on the root pci bus > > > >> > > > >> > 6901bada65 tests/acpi: mark addition of table DSDT.roothp for unit > > > >> > > > >> > testing root pci hotplug > > > >> > > > >> > 74504514b1 (origin/master, origin/HEAD) Merge remote-tracking branch > > > >> > > > >> > 'remotes/alistair/tags/pull-register-20200927' into staging > > > >> > > > >> > > > >> > > > >> Try applying on top of latest pull request? > > > > > > > > > > > > Maybe I'm missing something but can you point me to the latest pull request? > > > >> > > > >> > > > >> > > > >> > > > >> > > > >> > > > >> > > > >> > > > > >> > > > >> > > > > > >> > > > >> > > > > > > >> > > > >> > > > > > > >> > > > >> > > > > > > >> > > > >> > > > --- ./tests/data/acpi/pc/DSDT.hpbridge.dsl 2020-09-29 02:44:43.874622404 -0400 > > > >> > > > >> > > > +++ ./tests/data/acpi/pc/DSDT.hpbrroot.dsl 2020-09-29 02:44:43.876622403 -0400 > > > >> > > > >> > > > @@ -5,13 +5,13 @@ > > > >> > > > >> > > > * > > > >> > > > >> > > > * Disassembling to symbolic ASL+ operators > > > >> > > > >> > > > * > > > >> > > > >> > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 02:44:43 2020 > > > >> > > > >> > > > + * Disassembly of tests/data/acpi/pc/DSDT.hpbrroot, Tue Sep 29 02:44:43 2020 > > > >> > > > >> > > > * > > > >> > > > >> > > > * Original Table Header: > > > >> > > > >> > > > * Signature "DSDT" > > > >> > > > >> > > > - * Length 0x0000139D (5021) > > > >> > > > >> > > > + * Length 0x00000B89 (2953) > > > >> > > > >> > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > >> > > > >> > > > - * Checksum 0x05 > > > >> > > > >> > > > + * Checksum 0xA2 > > > >> > > > >> > > > * OEM ID "BOCHS " > > > >> > > > >> > > > * OEM Table ID "BXPCDSDT" > > > >> > > > >> > > > * OEM Revision 0x00000001 (1) > > > >> > > > >> > > > @@ -247,38 +247,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > >> > > > >> > > > } > > > >> > > > >> > > > } > > > >> > > > >> > > > > > > >> > > > >> > > > - Scope (_SB.PCI0) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > > >> > > > >> > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCIU, 32, > > > >> > > > >> > > > - PCID, 32 > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > > >> > > > >> > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - B0EJ, 32 > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > > >> > > > >> > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - BNUM, 32 > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Mutex (BLCK, 0x00) > > > >> > > > >> > > > - Method (PCEJ, 2, NotSerialized) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Acquire (BLCK, 0xFFFF) > > > >> > > > >> > > > - BNUM = Arg0 > > > >> > > > >> > > > - B0EJ = (One << Arg1) > > > >> > > > >> > > > - Release (BLCK) > > > >> > > > >> > > > - Return (Zero) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > Scope (_SB) > > > >> > > > >> > > > { > > > >> > > > >> > > > Scope (PCI0) > > > >> > > > >> > > > @@ -643,56 +611,22 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > >> > > > >> > > > Method (CSCN, 0, Serialized) > > > >> > > > >> > > > { > > > >> > > > >> > > > Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF) > > > >> > > > >> > > > - Name (CNEW, Package (0xFF){}) > > > >> > > > >> > > > - Local3 = Zero > > > >> > > > >> > > > - Local4 = One > > > >> > > > >> > > > - While ((Local4 == One)) > > > >> > > > >> > > > + Local0 = One > > > >> > > > >> > > > + While ((Local0 == One)) > > > >> > > > >> > > > { > > > >> > > > >> > > > - Local4 = Zero > > > >> > > > >> > > > - Local0 = One > > > >> > > > >> > > > - Local1 = Zero > > > >> > > > >> > > > - While (((Local0 == One) && (Local3 < One))) > > > >> > > > >> > > > + Local0 = Zero > > > >> > > > >> > > > + \_SB.PCI0.PRES.CCMD = Zero > > > >> > > > >> > > > + If ((\_SB.PCI0.PRES.CINS == One)) > > > >> > > > >> > > > { > > > >> > > > >> > > > - Local0 = Zero > > > >> > > > >> > > > - \_SB.PCI0.PRES.CSEL = Local3 > > > >> > > > >> > > > - \_SB.PCI0.PRES.CCMD = Zero > > > >> > > > >> > > > - If ((\_SB.PCI0.PRES.CDAT < Local3)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Break > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Local1 == 0xFF)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Local4 = One > > > >> > > > >> > > > - Break > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Local3 = \_SB.PCI0.PRES.CDAT > > > >> > > > >> > > > - If ((\_SB.PCI0.PRES.CINS == One)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - CNEW [Local1] = Local3 > > > >> > > > >> > > > - Local1++ > > > >> > > > >> > > > - Local0 = One > > > >> > > > >> > > > - } > > > >> > > > >> > > > - ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - CTFY (Local3, 0x03) > > > >> > > > >> > > > - \_SB.PCI0.PRES.CRMV = One > > > >> > > > >> > > > - Local0 = One > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Local3++ > > > >> > > > >> > > > + CTFY (\_SB.PCI0.PRES.CDAT, One) > > > >> > > > >> > > > + \_SB.PCI0.PRES.CINS = One > > > >> > > > >> > > > + Local0 = One > > > >> > > > >> > > > } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Local2 = Zero > > > >> > > > >> > > > - While ((Local2 < Local1)) > > > >> > > > >> > > > + ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > > > >> > > > >> > > > { > > > >> > > > >> > > > - Local3 = DerefOf (CNEW [Local2]) > > > >> > > > >> > > > - CTFY (Local3, One) > > > >> > > > >> > > > - Debug = Local3 > > > >> > > > >> > > > - \_SB.PCI0.PRES.CSEL = Local3 > > > >> > > > >> > > > - \_SB.PCI0.PRES.CINS = One > > > >> > > > >> > > > - Local2++ > > > >> > > > >> > > > + CTFY (\_SB.PCI0.PRES.CDAT, 0x03) > > > >> > > > >> > > > + \_SB.PCI0.PRES.CRMV = One > > > >> > > > >> > > > + Local0 = One > > > >> > > > >> > > > } > > > >> > > > >> > > > } > > > >> > > > >> > > > > > > >> > > > >> > > > @@ -737,12 +671,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > >> > > > >> > > > Scope (_GPE) > > > >> > > > >> > > > { > > > >> > > > >> > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > > > >> > > > >> > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE, xx=0x00-0xFF > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > > >> > > > >> > > > - \_SB.PCI0.PCNT () > > > >> > > > >> > > > - Release (\_SB.PCI0.BLCK) > > > >> > > > >> > > > - } > > > >> > > > >> > > > } > > > >> > > > >> > > > > > > >> > > > >> > > > Scope (\_SB.PCI0) > > > >> > > > >> > > > @@ -813,22 +741,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > >> > > > >> > > > ) > > > >> > > > >> > > > }) > > > >> > > > >> > > > } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (PHPR) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > > >> > > > >> > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > > >> > > > >> > > > - Name (_STA, 0x0B) // _STA: Status > > > >> > > > >> > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > >> > > > >> > > > - { > > > >> > > > >> > > > - IO (Decode16, > > > >> > > > >> > > > - 0xAE00, // Range Minimum > > > >> > > > >> > > > - 0xAE00, // Range Maximum > > > >> > > > >> > > > - 0x01, // Alignment > > > >> > > > >> > > > - 0x14, // Length > > > >> > > > >> > > > - ) > > > >> > > > >> > > > - }) > > > >> > > > >> > > > - } > > > >> > > > >> > > > } > > > >> > > > >> > > > > > > >> > > > >> > > > Scope (\) > > > >> > > > >> > > > @@ -878,7 +790,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > >> > > > >> > > > { > > > >> > > > >> > > > Scope (PCI0) > > > >> > > > >> > > > { > > > >> > > > >> > > > - Name (BSEL, Zero) > > > >> > > > >> > > > Device (S00) > > > >> > > > >> > > > { > > > >> > > > >> > > > Name (_ADR, Zero) // _ADR: Address > > > >> > > > >> > > > @@ -907,436 +818,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > >> > > > >> > > > { > > > >> > > > >> > > > Name (_ADR, 0x00030000) // _ADR: Address > > > >> > > > >> > > > } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (S20) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x00040000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (S28) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x00050000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (S30) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x00060000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (S38) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x00070000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (S40) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x00080000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (S48) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x00090000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (S50) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (S58) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (S60) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (S68) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (S70) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (S78) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (S80) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x00100000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (S88) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x00110000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (S90) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x00120000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (S98) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x00130000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (SA0) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x00140000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (SA8) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x00150000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (SB0) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x00160000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (SB8) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x00170000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (SC0) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x00180000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (SC8) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x00190000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (SD0) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (SD8) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (SE0) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (SE8) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (SF0) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Device (SF8) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > > >> > > > >> > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > > >> > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > >> > > > >> > > > - { > > > >> > > > >> > > > - PCEJ (BSEL, _SUN) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Method (DVNT, 2, NotSerialized) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - If ((Arg0 & 0x10)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (S20, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x20)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (S28, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x40)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (S30, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x80)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (S38, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x0100)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (S40, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x0200)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (S48, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x0400)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (S50, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x0800)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (S58, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x1000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (S60, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x2000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (S68, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x4000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (S70, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x8000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (S78, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x00010000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (S80, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x00020000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (S88, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x00040000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (S90, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x00080000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (S98, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x00100000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (SA0, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x00200000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (SA8, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x00400000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (SB0, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x00800000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (SB8, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x01000000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (SC0, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x02000000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (SC8, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x04000000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (SD0, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x08000000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (SD8, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x10000000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (SE0, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x20000000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (SE8, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x40000000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (SF0, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - If ((Arg0 & 0x80000000)) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - Notify (SF8, Arg1) > > > >> > > > >> > > > - } > > > >> > > > >> > > > - } > > > >> > > > >> > > > - > > > >> > > > >> > > > - Method (PCNT, 0, NotSerialized) > > > >> > > > >> > > > - { > > > >> > > > >> > > > - BNUM = Zero > > > >> > > > >> > > > - DVNT (PCIU, One) > > > >> > > > >> > > > - DVNT (PCID, 0x03) > > > >> > > > >> > > > - } > > > >> > > > >> > > > } > > > >> > > > >> > > > } > > > >> > > > >> > > > } > > > >> > > > >> > > > > > > >> > > > >> > > > >> >
as On Tue, Sep 29, 2020 at 4:11 PM Ani Sinha <ani@anisinha.ca> wrote: > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote: > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > > > In your pull request the following patch is completely screwed up: > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > > > > > tests/acpi: update golden master DSDT binary table blobs for q35 > > > > > > > > > > > > This is not my patch. It has all sorts of changes which does not > > > > belong there. Can you please check? > > > > > > See https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/ > > > > > > I had to regenerate the binary, yes. That's par for the course. > > But it looks like I added disasssembled files. Will fix up and drop, > > thanks for noticing this. It's probably worthwhile to regenerate DSDT.hpbrroot as well and then do the diff and compare. > > I think DSDT.hbridge is wrong. The checksum looks weird: > > > + * Length 0x00000B89 (2953) > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > - * Checksum 0x05 > > This file should be introduced just by one patch. my patch. > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 3:20 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 3:12 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > >> > > > > >> On Tue, Sep 29, 2020 at 02:21:06PM +0530, Ani Sinha wrote: > > > > >> > > > > >> > On Tue, Sep 29, 2020 at 1:53 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > >> > > > > >> > > > > > > >> > > > > >> > > On Tue, Sep 29, 2020 at 12:56 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > On Tue, Sep 29, 2020 at 12:53:17PM +0530, Ani Sinha wrote: > > > > >> > > > > >> > > > > On Tue, Sep 29, 2020 at 12:42 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > >> > > > > >> > > > > > > > > > >> > > > > >> > > > > > On Fri, Sep 18, 2020 at 02:11:11PM +0530, Ani Sinha wrote: > > > > >> > > > > >> > > > > > > This change adds a new DSDT golden master table blob to test disabling > > > > >> > > > > >> > > > > > > hotplug on both pci root bus and pci bridges. Also reverts the change > > > > >> > > > > >> > > > > > > in file bios-tables-test-allowed-diff.h to make sure its now empty so that > > > > >> > > > > >> > > > > > > future modifications to acpi tables can be caught. > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > > The following is the disassembled diff between DSDT.hpbridge and DSDT.hpbrroot: > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > > @@ -1,30 +1,30 @@ > > > > >> > > > > >> > > > > > > /* > > > > >> > > > > >> > > > > > > * Intel ACPI Component Architecture > > > > >> > > > > >> > > > > > > * AML/ASL+ Disassembler version 20180105 (64-bit version) > > > > >> > > > > >> > > > > > > * Copyright (c) 2000 - 2018 Intel Corporation > > > > >> > > > > >> > > > > > > * > > > > >> > > > > >> > > > > > > * Disassembling to symbolic ASL+ operators > > > > >> > > > > >> > > > > > > * > > > > >> > > > > >> > > > > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Wed Sep 16 09:45:56 2020 > > > > >> > > > > >> > > > > > > + * Disassembly of /tmp/aml-ECV9Q0, Wed Sep 16 09:45:56 2020 > > > > >> > > > > >> > > > > > > * > > > > >> > > > > >> > > > > > > * Original Table Header: > > > > >> > > > > >> > > > > > > * Signature "DSDT" > > > > >> > > > > >> > > > > > > - * Length 0x0000131F (4895) > > > > >> > > > > >> > > > > > > + * Length 0x00000B89 (2953) > > > > >> > > > > >> > > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > > >> > > > > >> > > > > > > - * Checksum 0xF9 > > > > >> > > > > >> > > > > > > + * Checksum 0xA2 > > > > >> > > > > >> > > > > > > * OEM ID "BOCHS " > > > > >> > > > > >> > > > > > > * OEM Table ID "BXPCDSDT" > > > > >> > > > > >> > > > > > > * OEM Revision 0x00000001 (1) > > > > >> > > > > >> > > > > > > * Compiler ID "BXPC" > > > > >> > > > > >> > > > > > > * Compiler Version 0x00000001 (1) > > > > >> > > > > >> > > > > > > */ > > > > >> > > > > >> > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Scope (\) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > OperationRegion (DBG, SystemIO, 0x0402, One) > > > > >> > > > > >> > > > > > > Field (DBG, ByteAcc, NoLock, Preserve) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > DBGB, 8 > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > > @@ -234,64 +234,32 @@ > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Name (_HID, EisaId ("PNP0B00") /* AT Real-Time Clock */) // _HID: Hardware ID > > > > >> > > > > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > IO (Decode16, > > > > >> > > > > >> > > > > > > 0x0070, // Range Minimum > > > > >> > > > > >> > > > > > > 0x0070, // Range Maximum > > > > >> > > > > >> > > > > > > 0x01, // Alignment > > > > >> > > > > >> > > > > > > 0x08, // Length > > > > >> > > > > >> > > > > > > ) > > > > >> > > > > >> > > > > > > IRQNoFlags () > > > > >> > > > > >> > > > > > > {8} > > > > >> > > > > >> > > > > > > }) > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > > - Scope (_SB.PCI0) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > > > >> > > > > >> > > > > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCIU, 32, > > > > >> > > > > >> > > > > > > - PCID, 32 > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > > > >> > > > > >> > > > > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - B0EJ, 32 > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > > > >> > > > > >> > > > > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - BNUM, 32 > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Mutex (BLCK, 0x00) > > > > >> > > > > >> > > > > > > - Method (PCEJ, 2, NotSerialized) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Acquire (BLCK, 0xFFFF) > > > > >> > > > > >> > > > > > > - BNUM = Arg0 > > > > >> > > > > >> > > > > > > - B0EJ = (One << Arg1) > > > > >> > > > > >> > > > > > > - Release (BLCK) > > > > >> > > > > >> > > > > > > - Return (Zero) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > Scope (_SB) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Scope (PCI0) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Method (_PRT, 0, NotSerialized) // _PRT: PCI Routing Table > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Local0 = Package (0x80){} > > > > >> > > > > >> > > > > > > Local1 = Zero > > > > >> > > > > >> > > > > > > While ((Local1 < 0x80)) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Local2 = (Local1 >> 0x02) > > > > >> > > > > >> > > > > > > Local3 = ((Local1 + Local2) & 0x03) > > > > >> > > > > >> > > > > > > If ((Local3 == Zero)) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Local4 = Package (0x04) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > @@ -690,38 +658,32 @@ > > > > >> > > > > >> > > > > > > Method (_OST, 3, Serialized) // _OST: OSPM Status Indication > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > COST (Zero, Arg0, Arg1, Arg2) > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > > Method (\_GPE._E02, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > \_SB.CPUS.CSCN () > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > > Scope (_GPE) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > > > > >> > > > > >> > > > > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > > > >> > > > > >> > > > > > > - \_SB.PCI0.PCNT () > > > > >> > > > > >> > > > > > > - Release (\_SB.PCI0.BLCK) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > > Scope (\_SB.PCI0) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > WordBusNumber (ResourceProducer, MinFixed, MaxFixed, PosDecode, > > > > >> > > > > >> > > > > > > 0x0000, // Granularity > > > > >> > > > > >> > > > > > > 0x0000, // Range Minimum > > > > >> > > > > >> > > > > > > 0x00FF, // Range Maximum > > > > >> > > > > >> > > > > > > 0x0000, // Translation Offset > > > > >> > > > > >> > > > > > > 0x0100, // Length > > > > >> > > > > >> > > > > > > ,, ) > > > > >> > > > > >> > > > > > > IO (Decode16, > > > > >> > > > > >> > > > > > > 0x0CF8, // Range Minimum > > > > >> > > > > >> > > > > > > 0x0CF8, // Range Maximum > > > > >> > > > > >> > > > > > > @@ -766,48 +728,32 @@ > > > > >> > > > > >> > > > > > > }) > > > > >> > > > > >> > > > > > > Device (GPE0) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > > > >> > > > > >> > > > > > > Name (_UID, "GPE0 resources") // _UID: Unique ID > > > > >> > > > > >> > > > > > > Name (_STA, 0x0B) // _STA: Status > > > > >> > > > > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > IO (Decode16, > > > > >> > > > > >> > > > > > > 0xAFE0, // Range Minimum > > > > >> > > > > >> > > > > > > 0xAFE0, // Range Maximum > > > > >> > > > > >> > > > > > > 0x01, // Alignment > > > > >> > > > > >> > > > > > > 0x04, // Length > > > > >> > > > > >> > > > > > > ) > > > > >> > > > > >> > > > > > > }) > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (PHPR) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > > > >> > > > > >> > > > > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > > > >> > > > > >> > > > > > > - Name (_STA, 0x0B) // _STA: Status > > > > >> > > > > >> > > > > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - IO (Decode16, > > > > >> > > > > >> > > > > > > - 0xAE00, // Range Minimum > > > > >> > > > > >> > > > > > > - 0xAE00, // Range Maximum > > > > >> > > > > >> > > > > > > - 0x01, // Alignment > > > > >> > > > > >> > > > > > > - 0x14, // Length > > > > >> > > > > >> > > > > > > - ) > > > > >> > > > > >> > > > > > > - }) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > > Scope (\) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Name (_S3, Package (0x04) // _S3_: S3 System State > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > One, > > > > >> > > > > >> > > > > > > One, > > > > >> > > > > >> > > > > > > Zero, > > > > >> > > > > >> > > > > > > Zero > > > > >> > > > > >> > > > > > > }) > > > > >> > > > > >> > > > > > > Name (_S4, Package (0x04) // _S4_: S4 System State > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > 0x02, > > > > >> > > > > >> > > > > > > 0x02, > > > > >> > > > > >> > > > > > > Zero, > > > > >> > > > > >> > > > > > > @@ -831,479 +777,48 @@ > > > > >> > > > > >> > > > > > > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > IO (Decode16, > > > > >> > > > > >> > > > > > > 0x0510, // Range Minimum > > > > >> > > > > >> > > > > > > 0x0510, // Range Maximum > > > > >> > > > > >> > > > > > > 0x01, // Alignment > > > > >> > > > > >> > > > > > > 0x0C, // Length > > > > >> > > > > >> > > > > > > ) > > > > >> > > > > >> > > > > > > }) > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > > Scope (\_SB) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Scope (PCI0) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > - Name (BSEL, Zero) > > > > >> > > > > >> > > > > > > Device (S00) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Name (_ADR, Zero) // _ADR: Address > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > > Device (S10) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Name (_ADR, 0x00020000) // _ADR: Address > > > > >> > > > > >> > > > > > > Method (_S1D, 0, NotSerialized) // _S1D: S1 Device State > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Return (Zero) > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > > Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Return (Zero) > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > > Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Return (Zero) > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > > > > > >> > > > > >> > > > > > > Device (S18) > > > > >> > > > > >> > > > > > > { > > > > >> > > > > >> > > > > > > Name (_ADR, 0x00030000) // _ADR: Address > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (S20) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x00040000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (S28) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x00050000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (S30) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x00060000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (S38) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x00070000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (S40) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x00080000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (S48) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x00090000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (S50) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (S58) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (S60) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (S68) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (S70) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (S78) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (S80) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x00100000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (S88) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x00110000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (S90) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x00120000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (S98) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x00130000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (SA0) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x00140000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (SA8) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x00150000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (SB0) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x00160000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (SB8) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x00170000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (SC0) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x00180000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (SC8) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x00190000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (SD0) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (SD8) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (SE0) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (SE8) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (SF0) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Device (SF8) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > > > >> > > > > >> > > > > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > > > >> > > > > >> > > > > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Method (DVNT, 2, NotSerialized) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x10)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (S20, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x20)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (S28, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x40)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (S30, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x80)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (S38, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x0100)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (S40, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x0200)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (S48, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x0400)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (S50, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x0800)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (S58, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x1000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (S60, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x2000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (S68, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x4000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (S70, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x8000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (S78, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x00010000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (S80, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x00020000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (S88, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x00040000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (S90, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x00080000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (S98, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x00100000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (SA0, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x00200000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (SA8, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x00400000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (SB0, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x00800000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (SB8, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x01000000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (SC0, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x02000000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (SC8, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x04000000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (SD0, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x08000000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (SD8, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x10000000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (SE0, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x20000000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (SE8, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x40000000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (SF0, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - If ((Arg0 & 0x80000000)) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - Notify (SF8, Arg1) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > - > > > > >> > > > > >> > > > > > > - Method (PCNT, 0, NotSerialized) > > > > >> > > > > >> > > > > > > - { > > > > >> > > > > >> > > > > > > - BNUM = Zero > > > > >> > > > > >> > > > > > > - DVNT (PCIU, One) > > > > >> > > > > >> > > > > > > - DVNT (PCID, 0x03) > > > > >> > > > > >> > > > > > > - } > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > } > > > > >> > > > > >> > > > > > > > > > >> > > > > >> > > > > > This is not the only diff I see if I apply this patchset on > > > > >> > > > > >> > > > > > top of master. > > > > >> > > > > >> > > > > > Dropped this and the previous patch. > > > > >> > > > > >> > > > > > Please check what is going on and repost as appropriate. > > > > >> > > > > >> > > > > > > > > >> > > > > >> > > > > Which two ACPI DSDT files are you diffing? What diff are you getting? > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > diff -rup ./tests/data/acpi/pc/DSDT.hpbridge.dsl ./tests/data/acpi/pc/DSDT.hpbrroot.dsl > > > > >> > > > > >> > > > > > > >> > > > > >> > > I re-based my patchset on top of the latest qemu master and did a make > > > > >> > > > > >> > > && make check-qtest-x86_64 V=1. > > > > >> > > > > >> > > They pass. I am seeing this diff: > > > > >> > > > > >> > > https://pastebin.ubuntu.com/p/BXy9GFfB2R/ > > > > >> > > > > >> > > > > > > >> > > > > >> > > and it looks good to me. > > > > >> > > > > >> > > > > > > >> > > > > >> > > Not sure why your diff looks different. Maybe you can regenerate the blob? > > > > >> > > > > >> > > > > > >> > > > > >> > I did a full make check and it passed. I compared the diff again and > > > > >> > > > > >> > it's the same. I checked my tree and it looks clean. These are the > > > > >> > > > > >> > patches I have: > > > > >> > > > > >> > > > > > >> > > > > >> > $ git log --oneline > > > > >> > > > > >> > 20d1323e10 (HEAD -> master) qom: code hardening - have bound checking > > > > >> > > > > >> > while looping with integer value > > > > >> > > > > >> > 0f69dae0e2 Add a comment in bios-tables-test.c to clarify the reason > > > > >> > > > > >> > behind approach > > > > >> > > > > >> > dd9a8c3cd3 tests/acpi: add DSDT.hpbrroot DSDT table blob to test > > > > >> > > > > >> > global i440fx hotplug > > > > >> > > > > >> > 5b93474fe9 tests/acpi: unit test exercising global pci hotplug off for i440fx > > > > >> > > > > >> > 54c33e334a tests/acpi: update golden master DSDT binary table blobs for q35 > > > > >> > > > > >> > 2279f61f30 piix4: don't reserve hw resources when hotplug is off globally > > > > >> > > > > >> > 1f61c524a0 Add ACPI DSDT tables for q35 that are being updated by the next patch > > > > >> > > > > >> > bdd823611b tests/acpi: add newly added acpi DSDT table blob for pci > > > > >> > > > > >> > bridge hotplug flag > > > > >> > > > > >> > 8c80f8fba9 tests/acpi: unit test for > > > > >> > > > > >> > 'acpi-pci-hotplug-with-bridge-support' bridge flag > > > > >> > > > > >> > e0a3142df9 tests/acpi: list added acpi table binary file for pci > > > > >> > > > > >> > bridge hotplug test > > > > >> > > > > >> > 0ba08317a8 i440fx/acpi: do not add hotplug related amls for cold plugged bridges > > > > >> > > > > >> > 73b191ade6 Fix a gap where acpi_pcihp_find_hotplug_bus() returns a > > > > >> > > > > >> > non-hotpluggable bus > > > > >> > > > > >> > ef0e526cc2 tests/acpi: add a new ACPI table in order to test root pci > > > > >> > > > > >> > hotplug on/off > > > > >> > > > > >> > c6d13264f8 tests/acpi: add new unit test to test hotplug off/on > > > > >> > > > > >> > feature on the root pci bus > > > > >> > > > > >> > 6901bada65 tests/acpi: mark addition of table DSDT.roothp for unit > > > > >> > > > > >> > testing root pci hotplug > > > > >> > > > > >> > 74504514b1 (origin/master, origin/HEAD) Merge remote-tracking branch > > > > >> > > > > >> > 'remotes/alistair/tags/pull-register-20200927' into staging > > > > >> > > > > >> > > > > >> > > > > >> Try applying on top of latest pull request? > > > > > > > > > > > > > > > Maybe I'm missing something but can you point me to the latest pull request? > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > > >> > > > > >> > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > --- ./tests/data/acpi/pc/DSDT.hpbridge.dsl 2020-09-29 02:44:43.874622404 -0400 > > > > >> > > > > >> > > > +++ ./tests/data/acpi/pc/DSDT.hpbrroot.dsl 2020-09-29 02:44:43.876622403 -0400 > > > > >> > > > > >> > > > @@ -5,13 +5,13 @@ > > > > >> > > > > >> > > > * > > > > >> > > > > >> > > > * Disassembling to symbolic ASL+ operators > > > > >> > > > > >> > > > * > > > > >> > > > > >> > > > - * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 02:44:43 2020 > > > > >> > > > > >> > > > + * Disassembly of tests/data/acpi/pc/DSDT.hpbrroot, Tue Sep 29 02:44:43 2020 > > > > >> > > > > >> > > > * > > > > >> > > > > >> > > > * Original Table Header: > > > > >> > > > > >> > > > * Signature "DSDT" > > > > >> > > > > >> > > > - * Length 0x0000139D (5021) > > > > >> > > > > >> > > > + * Length 0x00000B89 (2953) > > > > >> > > > > >> > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > > >> > > > > >> > > > - * Checksum 0x05 > > > > >> > > > > >> > > > + * Checksum 0xA2 > > > > >> > > > > >> > > > * OEM ID "BOCHS " > > > > >> > > > > >> > > > * OEM Table ID "BXPCDSDT" > > > > >> > > > > >> > > > * OEM Revision 0x00000001 (1) > > > > >> > > > > >> > > > @@ -247,38 +247,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > >> > > > > >> > > > } > > > > >> > > > > >> > > > } > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > - Scope (_SB.PCI0) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - OperationRegion (PCST, SystemIO, 0xAE00, 0x08) > > > > >> > > > > >> > > > - Field (PCST, DWordAcc, NoLock, WriteAsZeros) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCIU, 32, > > > > >> > > > > >> > > > - PCID, 32 > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - OperationRegion (SEJ, SystemIO, 0xAE08, 0x04) > > > > >> > > > > >> > > > - Field (SEJ, DWordAcc, NoLock, WriteAsZeros) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - B0EJ, 32 > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - OperationRegion (BNMR, SystemIO, 0xAE10, 0x04) > > > > >> > > > > >> > > > - Field (BNMR, DWordAcc, NoLock, WriteAsZeros) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - BNUM, 32 > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Mutex (BLCK, 0x00) > > > > >> > > > > >> > > > - Method (PCEJ, 2, NotSerialized) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Acquire (BLCK, 0xFFFF) > > > > >> > > > > >> > > > - BNUM = Arg0 > > > > >> > > > > >> > > > - B0EJ = (One << Arg1) > > > > >> > > > > >> > > > - Release (BLCK) > > > > >> > > > > >> > > > - Return (Zero) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > Scope (_SB) > > > > >> > > > > >> > > > { > > > > >> > > > > >> > > > Scope (PCI0) > > > > >> > > > > >> > > > @@ -643,56 +611,22 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > >> > > > > >> > > > Method (CSCN, 0, Serialized) > > > > >> > > > > >> > > > { > > > > >> > > > > >> > > > Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF) > > > > >> > > > > >> > > > - Name (CNEW, Package (0xFF){}) > > > > >> > > > > >> > > > - Local3 = Zero > > > > >> > > > > >> > > > - Local4 = One > > > > >> > > > > >> > > > - While ((Local4 == One)) > > > > >> > > > > >> > > > + Local0 = One > > > > >> > > > > >> > > > + While ((Local0 == One)) > > > > >> > > > > >> > > > { > > > > >> > > > > >> > > > - Local4 = Zero > > > > >> > > > > >> > > > - Local0 = One > > > > >> > > > > >> > > > - Local1 = Zero > > > > >> > > > > >> > > > - While (((Local0 == One) && (Local3 < One))) > > > > >> > > > > >> > > > + Local0 = Zero > > > > >> > > > > >> > > > + \_SB.PCI0.PRES.CCMD = Zero > > > > >> > > > > >> > > > + If ((\_SB.PCI0.PRES.CINS == One)) > > > > >> > > > > >> > > > { > > > > >> > > > > >> > > > - Local0 = Zero > > > > >> > > > > >> > > > - \_SB.PCI0.PRES.CSEL = Local3 > > > > >> > > > > >> > > > - \_SB.PCI0.PRES.CCMD = Zero > > > > >> > > > > >> > > > - If ((\_SB.PCI0.PRES.CDAT < Local3)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Break > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Local1 == 0xFF)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Local4 = One > > > > >> > > > > >> > > > - Break > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Local3 = \_SB.PCI0.PRES.CDAT > > > > >> > > > > >> > > > - If ((\_SB.PCI0.PRES.CINS == One)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - CNEW [Local1] = Local3 > > > > >> > > > > >> > > > - Local1++ > > > > >> > > > > >> > > > - Local0 = One > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - CTFY (Local3, 0x03) > > > > >> > > > > >> > > > - \_SB.PCI0.PRES.CRMV = One > > > > >> > > > > >> > > > - Local0 = One > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Local3++ > > > > >> > > > > >> > > > + CTFY (\_SB.PCI0.PRES.CDAT, One) > > > > >> > > > > >> > > > + \_SB.PCI0.PRES.CINS = One > > > > >> > > > > >> > > > + Local0 = One > > > > >> > > > > >> > > > } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Local2 = Zero > > > > >> > > > > >> > > > - While ((Local2 < Local1)) > > > > >> > > > > >> > > > + ElseIf ((\_SB.PCI0.PRES.CRMV == One)) > > > > >> > > > > >> > > > { > > > > >> > > > > >> > > > - Local3 = DerefOf (CNEW [Local2]) > > > > >> > > > > >> > > > - CTFY (Local3, One) > > > > >> > > > > >> > > > - Debug = Local3 > > > > >> > > > > >> > > > - \_SB.PCI0.PRES.CSEL = Local3 > > > > >> > > > > >> > > > - \_SB.PCI0.PRES.CINS = One > > > > >> > > > > >> > > > - Local2++ > > > > >> > > > > >> > > > + CTFY (\_SB.PCI0.PRES.CDAT, 0x03) > > > > >> > > > > >> > > > + \_SB.PCI0.PRES.CRMV = One > > > > >> > > > > >> > > > + Local0 = One > > > > >> > > > > >> > > > } > > > > >> > > > > >> > > > } > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > @@ -737,12 +671,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > >> > > > > >> > > > Scope (_GPE) > > > > >> > > > > >> > > > { > > > > >> > > > > >> > > > Name (_HID, "ACPI0006" /* GPE Block Device */) // _HID: Hardware ID > > > > >> > > > > >> > > > - Method (_E01, 0, NotSerialized) // _Exx: Edge-Triggered GPE, xx=0x00-0xFF > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Acquire (\_SB.PCI0.BLCK, 0xFFFF) > > > > >> > > > > >> > > > - \_SB.PCI0.PCNT () > > > > >> > > > > >> > > > - Release (\_SB.PCI0.BLCK) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > } > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > Scope (\_SB.PCI0) > > > > >> > > > > >> > > > @@ -813,22 +741,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > >> > > > > >> > > > ) > > > > >> > > > > >> > > > }) > > > > >> > > > > >> > > > } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (PHPR) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_HID, "PNP0A06" /* Generic Container Device */) // _HID: Hardware ID > > > > >> > > > > >> > > > - Name (_UID, "PCI Hotplug resources") // _UID: Unique ID > > > > >> > > > > >> > > > - Name (_STA, 0x0B) // _STA: Status > > > > >> > > > > >> > > > - Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - IO (Decode16, > > > > >> > > > > >> > > > - 0xAE00, // Range Minimum > > > > >> > > > > >> > > > - 0xAE00, // Range Maximum > > > > >> > > > > >> > > > - 0x01, // Alignment > > > > >> > > > > >> > > > - 0x14, // Length > > > > >> > > > > >> > > > - ) > > > > >> > > > > >> > > > - }) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > } > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > Scope (\) > > > > >> > > > > >> > > > @@ -878,7 +790,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > >> > > > > >> > > > { > > > > >> > > > > >> > > > Scope (PCI0) > > > > >> > > > > >> > > > { > > > > >> > > > > >> > > > - Name (BSEL, Zero) > > > > >> > > > > >> > > > Device (S00) > > > > >> > > > > >> > > > { > > > > >> > > > > >> > > > Name (_ADR, Zero) // _ADR: Address > > > > >> > > > > >> > > > @@ -907,436 +818,6 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS " > > > > >> > > > > >> > > > { > > > > >> > > > > >> > > > Name (_ADR, 0x00030000) // _ADR: Address > > > > >> > > > > >> > > > } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (S20) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x04) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x00040000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (S28) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x05) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x00050000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (S30) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x06) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x00060000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (S38) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x07) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x00070000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (S40) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x08) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x00080000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (S48) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x09) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x00090000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (S50) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x0A) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x000A0000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (S58) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x0B) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x000B0000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (S60) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x0C) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x000C0000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (S68) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x0D) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x000D0000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (S70) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x0E) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x000E0000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (S78) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x0F) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x000F0000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (S80) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x10) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x00100000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (S88) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x11) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x00110000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (S90) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x12) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x00120000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (S98) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x13) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x00130000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (SA0) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x14) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x00140000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (SA8) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x15) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x00150000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (SB0) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x16) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x00160000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (SB8) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x17) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x00170000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (SC0) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x18) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x00180000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (SC8) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x19) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x00190000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (SD0) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x1A) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x001A0000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (SD8) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x1B) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x001B0000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (SE0) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x1C) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x001C0000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (SE8) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x1D) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x001D0000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (SF0) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x1E) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x001E0000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Device (SF8) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Name (_SUN, 0x1F) // _SUN: Slot User Number > > > > >> > > > > >> > > > - Name (_ADR, 0x001F0000) // _ADR: Address > > > > >> > > > > >> > > > - Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9 > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - PCEJ (BSEL, _SUN) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Method (DVNT, 2, NotSerialized) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - If ((Arg0 & 0x10)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (S20, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x20)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (S28, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x40)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (S30, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x80)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (S38, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x0100)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (S40, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x0200)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (S48, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x0400)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (S50, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x0800)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (S58, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x1000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (S60, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x2000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (S68, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x4000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (S70, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x8000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (S78, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x00010000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (S80, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x00020000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (S88, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x00040000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (S90, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x00080000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (S98, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x00100000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (SA0, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x00200000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (SA8, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x00400000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (SB0, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x00800000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (SB8, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x01000000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (SC0, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x02000000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (SC8, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x04000000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (SD0, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x08000000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (SD8, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x10000000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (SE0, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x20000000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (SE8, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x40000000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (SF0, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - If ((Arg0 & 0x80000000)) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - Notify (SF8, Arg1) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > - > > > > >> > > > > >> > > > - Method (PCNT, 0, NotSerialized) > > > > >> > > > > >> > > > - { > > > > >> > > > > >> > > > - BNUM = Zero > > > > >> > > > > >> > > > - DVNT (PCIU, One) > > > > >> > > > > >> > > > - DVNT (PCID, 0x03) > > > > >> > > > > >> > > > - } > > > > >> > > > > >> > > > } > > > > >> > > > > >> > > > } > > > > >> > > > > >> > > > } > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > > >> > >
On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha wrote: > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote: > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > > > In your pull request the following patch is completely screwed up: > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > > > > > tests/acpi: update golden master DSDT binary table blobs for q35 > > > > > > > > > > > > This is not my patch. It has all sorts of changes which does not > > > > belong there. Can you please check? > > > > > > See https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/ > > > > > > I had to regenerate the binary, yes. That's par for the course. > > But it looks like I added disasssembled files. Will fix up and drop, > > thanks for noticing this. OK I pushed out a fixed variant. Pls take a look. > I think DSDT.hbridge is wrong. The checksum looks weird: > > > + * Length 0x00000B89 (2953) > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > - * Checksum 0x05 What is weird about it? > > This file should be introduced just by one patch. my patch. I just re-run rebuild-expected-aml, no changes. I have this: commit 5e3a486211f02d9ecb18939ca21087515ec81883 Author: Ani Sinha <ani@anisinha.ca> Date: Fri Sep 18 14:11:05 2020 +0530 tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag This change adds a new unit test for the global flag 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci bridges in i440fx. The flag can be used to turn off ACPI based hotplug support on all pci bridges. Here is the full DSDT header, attached: /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20190509 (64-bit version) * Copyright (c) 2000 - 2019 Intel Corporation * * Disassembling to symbolic ASL+ operators * * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 06:51:03 2020 * * Original Table Header: * Signature "DSDT" * Length 0x0000139D (5021) * Revision 0x01 **** 32-bit table (V1), no 64-bit math support * Checksum 0x05 * OEM ID "BOCHS " * OEM Table ID "BXPCDSDT" * OEM Revision 0x00000001 (1) * Compiler ID "BXPC" * Compiler Version 0x00000001 (1) */ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) -- MST
On Tue, Sep 29, 2020 at 04:20:15PM +0530, Ani Sinha wrote: > as > > On Tue, Sep 29, 2020 at 4:11 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote: > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > > > > > In your pull request the following patch is completely screwed up: > > > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > > > > > > > tests/acpi: update golden master DSDT binary table blobs for q35 > > > > > > > > > > > > > > > This is not my patch. It has all sorts of changes which does not > > > > > belong there. Can you please check? > > > > > > > > See https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/ > > > > > > > > > I had to regenerate the binary, yes. That's par for the course. > > > But it looks like I added disasssembled files. Will fix up and drop, > > > thanks for noticing this. > > It's probably worthwhile to regenerate DSDT.hpbrroot as well and then > do the diff and compare. They are all regenerated by tests/data/acpi/rebuild-expected-aml.sh What is important is to check the changes and not trust them blindly. Do you see anything unexpected? It is easy to run tests/data/acpi/disassemle-aml.sh -o <output directory> on multiple versions and see what is going on. Care to do this? -- MST
On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha wrote: > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote: > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > > > > > In your pull request the following patch is completely screwed up: > > > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > > > > > > > tests/acpi: update golden master DSDT binary table blobs for q35 > > > > > > > > > > > > > > > This is not my patch. It has all sorts of changes which does not > > > > > belong there. Can you please check? > > > > > > > > See https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/ > > > > > > > > > I had to regenerate the binary, yes. That's par for the course. > > > But it looks like I added disasssembled files. Will fix up and drop, > > > thanks for noticing this. > > OK I pushed out a fixed variant. Pls take a look. OK I am not used to this workflow. How am I supposed to get it? Which tag? > > > I think DSDT.hbridge is wrong. The checksum looks weird: > > > > > > + * Length 0x00000B89 (2953) > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > - * Checksum 0x05 > > What is weird about it? > > > > > This file should be introduced just by one patch. my patch. > > I just re-run rebuild-expected-aml, no changes. > > I have this: > commit 5e3a486211f02d9ecb18939ca21087515ec81883 > Author: Ani Sinha <ani@anisinha.ca> > Date: Fri Sep 18 14:11:05 2020 +0530 > > tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag > > This change adds a new unit test for the global flag > 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci > bridges in i440fx. The flag can be used to turn off ACPI based hotplug support > on all pci bridges. > > > Here is the full DSDT header, attached: > > /* > * Intel ACPI Component Architecture > * AML/ASL+ Disassembler version 20190509 (64-bit version) > * Copyright (c) 2000 - 2019 Intel Corporation > * > * Disassembling to symbolic ASL+ operators > * > * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 06:51:03 2020 > * > * Original Table Header: > * Signature "DSDT" > * Length 0x0000139D (5021) > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > * Checksum 0x05 > * OEM ID "BOCHS " > * OEM Table ID "BXPCDSDT" > * OEM Revision 0x00000001 (1) > * Compiler ID "BXPC" > * Compiler Version 0x00000001 (1) > */ > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) > > -- > MST >
On Tue, Sep 29, 2020 at 4:28 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > On Tue, Sep 29, 2020 at 04:20:15PM +0530, Ani Sinha wrote: > > as > > > > On Tue, Sep 29, 2020 at 4:11 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote: > > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > > > > > > > In your pull request the following patch is completely screwed up: > > > > > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > > > > > > > > > tests/acpi: update golden master DSDT binary table blobs for q35 > > > > > > > > > > > > > > > > > > This is not my patch. It has all sorts of changes which does not > > > > > > belong there. Can you please check? > > > > > > > > > > See https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/ > > > > > > > > > > > > I had to regenerate the binary, yes. That's par for the course. > > > > But it looks like I added disasssembled files. Will fix up and drop, > > > > thanks for noticing this. > > > > It's probably worthwhile to regenerate DSDT.hpbrroot as well and then > > do the diff and compare. > > They are all regenerated by tests/data/acpi/rebuild-expected-aml.sh > > What is important is to check the changes and not trust them blindly. Yes what I meant was if you are regenerating the source blob with which you are diff-ing, you should generate the destination blob as well so that we can compare apples to apples. > > Do you see anything unexpected? It is easy to run > > tests/data/acpi/disassemle-aml.sh -o <output directory> > > on multiple versions and see what is going on. > Care to do this? > > > -- > MST >
On Tue, Sep 29, 2020 at 04:35:50PM +0530, Ani Sinha wrote: > On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha wrote: > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote: > > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > > > > > > > In your pull request the following patch is completely screwed up: > > > > > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > > > > > > > > > tests/acpi: update golden master DSDT binary table blobs for q35 > > > > > > > > > > > > > > > > > > This is not my patch. It has all sorts of changes which does not > > > > > > belong there. Can you please check? > > > > > > > > > > See https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/ > > > > > > > > > > > > I had to regenerate the binary, yes. That's par for the course. > > > > But it looks like I added disasssembled files. Will fix up and drop, > > > > thanks for noticing this. > > > > OK I pushed out a fixed variant. Pls take a look. > > OK I am not used to this workflow. How am I supposed to get it? Which tag? New for_upstream tag - I just sent in a pull request. > > > > > > I think DSDT.hbridge is wrong. The checksum looks weird: > > > > > > > > > + * Length 0x00000B89 (2953) > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > - * Checksum 0x05 > > > > What is weird about it? > > > > > > > > This file should be introduced just by one patch. my patch. > > > > I just re-run rebuild-expected-aml, no changes. > > > > I have this: > > commit 5e3a486211f02d9ecb18939ca21087515ec81883 > > Author: Ani Sinha <ani@anisinha.ca> > > Date: Fri Sep 18 14:11:05 2020 +0530 > > > > tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag > > > > This change adds a new unit test for the global flag > > 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci > > bridges in i440fx. The flag can be used to turn off ACPI based hotplug support > > on all pci bridges. > > > > > > Here is the full DSDT header, attached: > > > > /* > > * Intel ACPI Component Architecture > > * AML/ASL+ Disassembler version 20190509 (64-bit version) > > * Copyright (c) 2000 - 2019 Intel Corporation > > * > > * Disassembling to symbolic ASL+ operators > > * > > * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 06:51:03 2020 > > * > > * Original Table Header: > > * Signature "DSDT" > > * Length 0x0000139D (5021) > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > * Checksum 0x05 > > * OEM ID "BOCHS " > > * OEM Table ID "BXPCDSDT" > > * OEM Revision 0x00000001 (1) > > * Compiler ID "BXPC" > > * Compiler Version 0x00000001 (1) > > */ > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) > > > > -- > > MST > >
On Tue, Sep 29, 2020 at 4:45 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > On Tue, Sep 29, 2020 at 04:35:50PM +0530, Ani Sinha wrote: > > On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha wrote: > > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote: > > > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > > > > > > > > > In your pull request the following patch is completely screwed up: > > > > > > > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > > > > > > > > > > > tests/acpi: update golden master DSDT binary table blobs for q35 > > > > > > > > > > > > > > > > > > > > > This is not my patch. It has all sorts of changes which does not > > > > > > > belong there. Can you please check? > > > > > > > > > > > > See https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/ > > > > > > > > > > > > > > > I had to regenerate the binary, yes. That's par for the course. > > > > > But it looks like I added disasssembled files. Will fix up and drop, > > > > > thanks for noticing this. > > > > > > OK I pushed out a fixed variant. Pls take a look. > > > > OK I am not used to this workflow. How am I supposed to get it? Which tag? > > New for_upstream tag - I just sent in a pull request. Can you please point me to your tree? > > > > > > > > > > I think DSDT.hbridge is wrong. The checksum looks weird: > > > > > > > > > > > > + * Length 0x00000B89 (2953) > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > > - * Checksum 0x05 > > > > > > What is weird about it? > > > > > > > > > > > This file should be introduced just by one patch. my patch. > > > > > > I just re-run rebuild-expected-aml, no changes. > > > > > > I have this: > > > commit 5e3a486211f02d9ecb18939ca21087515ec81883 > > > Author: Ani Sinha <ani@anisinha.ca> > > > Date: Fri Sep 18 14:11:05 2020 +0530 > > > > > > tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag > > > > > > This change adds a new unit test for the global flag > > > 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci > > > bridges in i440fx. The flag can be used to turn off ACPI based hotplug support > > > on all pci bridges. > > > > > > > > > Here is the full DSDT header, attached: > > > > > > /* > > > * Intel ACPI Component Architecture > > > * AML/ASL+ Disassembler version 20190509 (64-bit version) > > > * Copyright (c) 2000 - 2019 Intel Corporation > > > * > > > * Disassembling to symbolic ASL+ operators > > > * > > > * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 06:51:03 2020 > > > * > > > * Original Table Header: > > > * Signature "DSDT" > > > * Length 0x0000139D (5021) > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > * Checksum 0x05 > > > * OEM ID "BOCHS " > > > * OEM Table ID "BXPCDSDT" > > > * OEM Revision 0x00000001 (1) > > > * Compiler ID "BXPC" > > > * Compiler Version 0x00000001 (1) > > > */ > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) > > > > > > -- > > > MST > > > >
On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha wrote: > On Tue, Sep 29, 2020 at 4:45 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > On Tue, Sep 29, 2020 at 04:35:50PM +0530, Ani Sinha wrote: > > > On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > > > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha wrote: > > > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote: > > > > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > > > > > > > > > > > In your pull request the following patch is completely screwed up: > > > > > > > > > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > > > > > > > > > > > > > tests/acpi: update golden master DSDT binary table blobs for q35 > > > > > > > > > > > > > > > > > > > > > > > > This is not my patch. It has all sorts of changes which does not > > > > > > > > belong there. Can you please check? > > > > > > > > > > > > > > See https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/ > > > > > > > > > > > > > > > > > > I had to regenerate the binary, yes. That's par for the course. > > > > > > But it looks like I added disasssembled files. Will fix up and drop, > > > > > > thanks for noticing this. > > > > > > > > OK I pushed out a fixed variant. Pls take a look. > > > > > > OK I am not used to this workflow. How am I supposed to get it? Which tag? > > > > New for_upstream tag - I just sent in a pull request. > > Can you please point me to your tree? git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > > > > > > > > > > > > > I think DSDT.hbridge is wrong. The checksum looks weird: > > > > > > > > > > > > > > > + * Length 0x00000B89 (2953) > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > > > - * Checksum 0x05 > > > > > > > > What is weird about it? > > > > > > > > > > > > > > This file should be introduced just by one patch. my patch. > > > > > > > > I just re-run rebuild-expected-aml, no changes. > > > > > > > > I have this: > > > > commit 5e3a486211f02d9ecb18939ca21087515ec81883 > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > Date: Fri Sep 18 14:11:05 2020 +0530 > > > > > > > > tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag > > > > > > > > This change adds a new unit test for the global flag > > > > 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci > > > > bridges in i440fx. The flag can be used to turn off ACPI based hotplug support > > > > on all pci bridges. > > > > > > > > > > > > Here is the full DSDT header, attached: > > > > > > > > /* > > > > * Intel ACPI Component Architecture > > > > * AML/ASL+ Disassembler version 20190509 (64-bit version) > > > > * Copyright (c) 2000 - 2019 Intel Corporation > > > > * > > > > * Disassembling to symbolic ASL+ operators > > > > * > > > > * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 06:51:03 2020 > > > > * > > > > * Original Table Header: > > > > * Signature "DSDT" > > > > * Length 0x0000139D (5021) > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > > * Checksum 0x05 > > > > * OEM ID "BOCHS " > > > > * OEM Table ID "BXPCDSDT" > > > > * OEM Revision 0x00000001 (1) > > > > * Compiler ID "BXPC" > > > > * Compiler Version 0x00000001 (1) > > > > */ > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) > > > > > > > > -- > > > > MST > > > > > >
On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha wrote: > > On Tue, Sep 29, 2020 at 4:45 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > On Tue, Sep 29, 2020 at 04:35:50PM +0530, Ani Sinha wrote: > > > > On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > > > > > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha wrote: > > > > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote: > > > > > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > > > > > > > > > > > > > In your pull request the following patch is completely screwed up: > > > > > > > > > > > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > > > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > > > > > > > > > > > > > > > tests/acpi: update golden master DSDT binary table blobs for q35 > > > > > > > > > > > > > > > > > > > > > > > > > > > This is not my patch. It has all sorts of changes which does not > > > > > > > > > belong there. Can you please check? > > > > > > > > > > > > > > > > See https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/ > > > > > > > > > > > > > > > > > > > > > I had to regenerate the binary, yes. That's par for the course. > > > > > > > But it looks like I added disasssembled files. Will fix up and drop, > > > > > > > thanks for noticing this. > > > > > > > > > > OK I pushed out a fixed variant. Pls take a look. > > > > > > > > OK I am not used to this workflow. How am I supposed to get it? Which tag? > > > > > > New for_upstream tag - I just sent in a pull request. > > > > Can you please point me to your tree? > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream I have sent the updated patches based on your pull request tag. I just had to regenrated the blob for tests/data/acpi/pc/DSDT.hpbrroot. make && make check-qtest-x86_64 V=1 passes. The diff looks good. Can you please send a pull request with these two patches ASAP? > > > > > > > > > > > > > > > > > > > > > I think DSDT.hbridge is wrong. The checksum looks weird: > > > > > > > > > > > > > > > > > > + * Length 0x00000B89 (2953) > > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > > > > - * Checksum 0x05 > > > > > > > > > > What is weird about it? > > > > > > > > > > > > > > > > > This file should be introduced just by one patch. my patch. > > > > > > > > > > I just re-run rebuild-expected-aml, no changes. > > > > > > > > > > I have this: > > > > > commit 5e3a486211f02d9ecb18939ca21087515ec81883 > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > Date: Fri Sep 18 14:11:05 2020 +0530 > > > > > > > > > > tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag > > > > > > > > > > This change adds a new unit test for the global flag > > > > > 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci > > > > > bridges in i440fx. The flag can be used to turn off ACPI based hotplug support > > > > > on all pci bridges. > > > > > > > > > > > > > > > Here is the full DSDT header, attached: > > > > > > > > > > /* > > > > > * Intel ACPI Component Architecture > > > > > * AML/ASL+ Disassembler version 20190509 (64-bit version) > > > > > * Copyright (c) 2000 - 2019 Intel Corporation > > > > > * > > > > > * Disassembling to symbolic ASL+ operators > > > > > * > > > > > * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 06:51:03 2020 > > > > > * > > > > > * Original Table Header: > > > > > * Signature "DSDT" > > > > > * Length 0x0000139D (5021) > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > > > * Checksum 0x05 > > > > > * OEM ID "BOCHS " > > > > > * OEM Table ID "BXPCDSDT" > > > > > * OEM Revision 0x00000001 (1) > > > > > * Compiler ID "BXPC" > > > > > * Compiler Version 0x00000001 (1) > > > > > */ > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) > > > > > > > > > > -- > > > > > MST > > > > > > > > >
On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote: > On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha wrote: > > > On Tue, Sep 29, 2020 at 4:45 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > > > On Tue, Sep 29, 2020 at 04:35:50PM +0530, Ani Sinha wrote: > > > > > On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha wrote: > > > > > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote: > > > > > > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <ani@anisinha.ca> wrote: > > > > > > > > > > > > > > > > > > > > In your pull request the following patch is completely screwed up: > > > > > > > > > > > > > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > > > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > > > > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > > > > > > > > > > > > > > > > > tests/acpi: update golden master DSDT binary table blobs for q35 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This is not my patch. It has all sorts of changes which does not > > > > > > > > > > belong there. Can you please check? > > > > > > > > > > > > > > > > > > See https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/ > > > > > > > > > > > > > > > > > > > > > > > > I had to regenerate the binary, yes. That's par for the course. > > > > > > > > But it looks like I added disasssembled files. Will fix up and drop, > > > > > > > > thanks for noticing this. > > > > > > > > > > > > OK I pushed out a fixed variant. Pls take a look. > > > > > > > > > > OK I am not used to this workflow. How am I supposed to get it? Which tag? > > > > > > > > New for_upstream tag - I just sent in a pull request. > > > > > > Can you please point me to your tree? > > > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > I have sent the updated patches based on your pull request tag. I just > had to regenrated the blob for tests/data/acpi/pc/DSDT.hpbrroot. > > make && make check-qtest-x86_64 V=1 passes. > > The diff looks good. > > Can you please send a pull request with these two patches ASAP? Thanks, I will queue them and merge in the next pull request. > > > > > > > > > > > > > > > > > > > > > > > > > > > > I think DSDT.hbridge is wrong. The checksum looks weird: > > > > > > > > > > > > > > > > > > > > > + * Length 0x00000B89 (2953) > > > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > > > > > - * Checksum 0x05 > > > > > > > > > > > > What is weird about it? > > > > > > > > > > > > > > > > > > > > This file should be introduced just by one patch. my patch. > > > > > > > > > > > > I just re-run rebuild-expected-aml, no changes. > > > > > > > > > > > > I have this: > > > > > > commit 5e3a486211f02d9ecb18939ca21087515ec81883 > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > Date: Fri Sep 18 14:11:05 2020 +0530 > > > > > > > > > > > > tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag > > > > > > > > > > > > This change adds a new unit test for the global flag > > > > > > 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci > > > > > > bridges in i440fx. The flag can be used to turn off ACPI based hotplug support > > > > > > on all pci bridges. > > > > > > > > > > > > > > > > > > Here is the full DSDT header, attached: > > > > > > > > > > > > /* > > > > > > * Intel ACPI Component Architecture > > > > > > * AML/ASL+ Disassembler version 20190509 (64-bit version) > > > > > > * Copyright (c) 2000 - 2019 Intel Corporation > > > > > > * > > > > > > * Disassembling to symbolic ASL+ operators > > > > > > * > > > > > > * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 06:51:03 2020 > > > > > > * > > > > > > * Original Table Header: > > > > > > * Signature "DSDT" > > > > > > * Length 0x0000139D (5021) > > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support > > > > > > * Checksum 0x05 > > > > > > * OEM ID "BOCHS " > > > > > > * OEM Table ID "BXPCDSDT" > > > > > > * OEM Revision 0x00000001 (1) > > > > > > * Compiler ID "BXPC" > > > > > > * Compiler Version 0x00000001 (1) > > > > > > */ > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001) > > > > > > > > > > > > -- > > > > > > MST > > > > > > > > > > > >
On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin <mst@redhat.com> wrote: > On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote: > > > On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin <mst@redhat.com> > wrote: > > > > > > > > On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha wrote: > > > > > On Tue, Sep 29, 2020 at 4:45 PM Michael S. Tsirkin <mst@redhat.com> > wrote: > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:35:50PM +0530, Ani Sinha wrote: > > > > > > > On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin < > mst@redhat.com> wrote: > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha wrote: > > > > > > > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin < > mst@redhat.com> wrote: > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote: > > > > > > > > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha < > ani@anisinha.ca> wrote: > > > > > > > > > > > > > > > > > > > > > > > > In your pull request the following patch is completely > screwed up: > > > > > > > > > > > > > > > > > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > > > > > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > > > > > > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > > > > > > > > > > > > > > > > > > > > > tests/acpi: update golden master DSDT binary table > blobs for q35 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This is not my patch. It has all sorts of changes > which does not > > > > > > > > > > > > belong there. Can you please check? > > > > > > > > > > > > > > > > > > > > > > See > https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I had to regenerate the binary, yes. That's par for the > course. > > > > > > > > > > But it looks like I added disasssembled files. Will fix up > and drop, > > > > > > > > > > thanks for noticing this. > > > > > > > > > > > > > > > > OK I pushed out a fixed variant. Pls take a look. > > > > > > > > > > > > > > OK I am not used to this workflow. How am I supposed to get it? > Which tag? > > > > > > > > > > > > New for_upstream tag - I just sent in a pull request. > > > > > > > > > > Can you please point me to your tree? > > > > > > > > > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > > > > > I have sent the updated patches based on your pull request tag. I just > > > had to regenrated the blob for tests/data/acpi/pc/DSDT.hpbrroot. > > > > > > make && make check-qtest-x86_64 V=1 passes. > > > > > > The diff looks good. > > > > > > Can you please send a pull request with these two patches ASAP? > > > > > > Thanks, I will queue them and merge in the next pull request. I'm willing to get down on my knees begging you to just do one another pull request for these two patches. Were so close with my entire work merged. Please let's not wait another week or so. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I think DSDT.hbridge is wrong. The checksum looks weird: > > > > > > > > > > > > > > > > > > > > > > > > > > > + * Length 0x00000B89 (2953) > > > > > > > > > * Revision 0x01 **** 32-bit table (V1), no > 64-bit math support > > > > > > > > > - * Checksum 0x05 > > > > > > > > > > > > > > > > What is weird about it? > > > > > > > > > > > > > > > > > > > > > > > > > > This file should be introduced just by one patch. my patch. > > > > > > > > > > > > > > > > I just re-run rebuild-expected-aml, no changes. > > > > > > > > > > > > > > > > I have this: > > > > > > > > commit 5e3a486211f02d9ecb18939ca21087515ec81883 > > > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > > > Date: Fri Sep 18 14:11:05 2020 +0530 > > > > > > > > > > > > > > > > tests/acpi: unit test for > 'acpi-pci-hotplug-with-bridge-support' bridge flag > > > > > > > > > > > > > > > > This change adds a new unit test for the global flag > > > > > > > > 'acpi-pci-hotplug-with-bridge-support' which is available > for cold plugged pci > > > > > > > > bridges in i440fx. The flag can be used to turn off ACPI > based hotplug support > > > > > > > > on all pci bridges. > > > > > > > > > > > > > > > > > > > > > > > > Here is the full DSDT header, attached: > > > > > > > > > > > > > > > > /* > > > > > > > > * Intel ACPI Component Architecture > > > > > > > > * AML/ASL+ Disassembler version 20190509 (64-bit version) > > > > > > > > * Copyright (c) 2000 - 2019 Intel Corporation > > > > > > > > * > > > > > > > > * Disassembling to symbolic ASL+ operators > > > > > > > > * > > > > > > > > * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 > 06:51:03 2020 > > > > > > > > * > > > > > > > > * Original Table Header: > > > > > > > > * Signature "DSDT" > > > > > > > > * Length 0x0000139D (5021) > > > > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit > math support > > > > > > > > * Checksum 0x05 > > > > > > > > * OEM ID "BOCHS " > > > > > > > > * OEM Table ID "BXPCDSDT" > > > > > > > > * OEM Revision 0x00000001 (1) > > > > > > > > * Compiler ID "BXPC" > > > > > > > > * Compiler Version 0x00000001 (1) > > > > > > > > */ > > > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", > 0x00000001) > > > > > > > > > > > > > > > > -- > > > > > > > > MST > > > > > > > > > > > > > > > > > > > > > > <div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com">mst@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote:<br><br>> On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>> wrote:<br><br>> ><br><br>> > On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha wrote:<br><br>> > > On Tue, Sep 29, 2020 at 4:45 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>> wrote:<br><br>> > > ><br><br>> > > > On Tue, Sep 29, 2020 at 04:35:50PM +0530, Ani Sinha wrote:<br><br>> > > > > On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>> wrote:<br><br>> > > > > ><br><br>> > > > > > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha wrote:<br><br>> > > > > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>> wrote:<br><br>> > > > > > > ><br><br>> > > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote:<br><br>> > > > > > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <<a href="mailto:ani@anisinha.ca" target="_blank">ani@anisinha.ca</a>> wrote:<br><br>> > > > > > > > > ><br><br>> > > > > > > > > > In your pull request the following patch is completely screwed up:<br><br>> > > > > > > > > ><br><br>> > > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e<br><br>> > > > > > > > > > Author: Ani Sinha <<a href="mailto:ani@anisinha.ca" target="_blank">ani@anisinha.ca</a>><br><br>> > > > > > > > > > Date: Tue Sep 29 03:22:52 2020 -0400<br><br>> > > > > > > > > ><br><br>> > > > > > > > > > tests/acpi: update golden master DSDT binary table blobs for q35<br><br>> > > > > > > > > ><br><br>> > > > > > > > > ><br><br>> > > > > > > > > > This is not my patch. It has all sorts of changes which does not<br><br>> > > > > > > > > > belong there. Can you please check?<br><br>> > > > > > > > ><br><br>> > > > > > > > > See <a href="https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/" rel="noreferrer" target="_blank">https://patchew.org/QEMU/20200929071948.281157-1-mst@redhat.com/20200929071948.281157-46-mst@redhat.com/</a><br><br>> > > > > > > ><br><br>> > > > > > > ><br><br>> > > > > > > > I had to regenerate the binary, yes. That's par for the course.<br><br>> > > > > > > > But it looks like I added disasssembled files. Will fix up and drop,<br><br>> > > > > > > > thanks for noticing this.<br><br>> > > > > ><br><br>> > > > > > OK I pushed out a fixed variant. Pls take a look.<br><br>> > > > ><br><br>> > > > > OK I am not used to this workflow. How am I supposed to get it? Which tag?<br><br>> > > ><br><br>> > > > New for_upstream tag - I just sent in a pull request.<br><br>> > ><br><br>> > > Can you please point me to your tree?<br><br>> ><br><br>> ><br><br>> > git://<a href="http://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git" rel="noreferrer" target="_blank">git.kernel.org/pub/scm/virt/kvm/mst/qemu.git</a> tags/for_upstream<br><br>> <br><br>> I have sent the updated patches based on your pull request tag. I just<br><br>> had to regenrated the blob for tests/data/acpi/pc/DSDT.hpbrroot.<br><br>> <br><br>> make && make check-qtest-x86_64 V=1 passes.<br><br>> <br><br>> The diff looks good.<br><br>> <br><br>> Can you please send a pull request with these two patches ASAP?<br><br><br><br><br><br>Thanks, I will queue them and merge in the next pull request.</blockquote><div dir="auto"><br></div><div dir="auto">I'm willing to get down on my knees begging you to just do one another pull request for these two patches. Were so close with my entire work merged.</div><div dir="auto"><br></div><div dir="auto">Please let's not wait another week or so. </div><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)" dir="auto"><br><br><br><br>> ><br><br>> ><br><br>> ><br><br>> > > ><br><br>> > > > ><br><br>> > > > > ><br><br>> > > > > > > I think DSDT.hbridge is wrong. The checksum looks weird:<br><br>> > > > > > ><br><br>> > > > > > ><br><br>> > > > > > > + * Length 0x00000B89 (2953)<br><br>> > > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support<br><br>> > > > > > > - * Checksum 0x05<br><br>> > > > > ><br><br>> > > > > > What is weird about it?<br><br>> > > > > ><br><br>> > > > > > ><br><br>> > > > > > > This file should be introduced just by one patch. my patch.<br><br>> > > > > ><br><br>> > > > > > I just re-run rebuild-expected-aml, no changes.<br><br>> > > > > ><br><br>> > > > > > I have this:<br><br>> > > > > > commit 5e3a486211f02d9ecb18939ca21087515ec81883<br><br>> > > > > > Author: Ani Sinha <<a href="mailto:ani@anisinha.ca" target="_blank">ani@anisinha.ca</a>><br><br>> > > > > > Date: Fri Sep 18 14:11:05 2020 +0530<br><br>> > > > > ><br><br>> > > > > > tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag<br><br>> > > > > ><br><br>> > > > > > This change adds a new unit test for the global flag<br><br>> > > > > > 'acpi-pci-hotplug-with-bridge-support' which is available for cold plugged pci<br><br>> > > > > > bridges in i440fx. The flag can be used to turn off ACPI based hotplug support<br><br>> > > > > > on all pci bridges.<br><br>> > > > > ><br><br>> > > > > ><br><br>> > > > > > Here is the full DSDT header, attached:<br><br>> > > > > ><br><br>> > > > > > /*<br><br>> > > > > > * Intel ACPI Component Architecture<br><br>> > > > > > * AML/ASL+ Disassembler version 20190509 (64-bit version)<br><br>> > > > > > * Copyright (c) 2000 - 2019 Intel Corporation<br><br>> > > > > > *<br><br>> > > > > > * Disassembling to symbolic ASL+ operators<br><br>> > > > > > *<br><br>> > > > > > * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 06:51:03 2020<br><br>> > > > > > *<br><br>> > > > > > * Original Table Header:<br><br>> > > > > > * Signature "DSDT"<br><br>> > > > > > * Length 0x0000139D (5021)<br><br>> > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit math support<br><br>> > > > > > * Checksum 0x05<br><br>> > > > > > * OEM ID "BOCHS "<br><br>> > > > > > * OEM Table ID "BXPCDSDT"<br><br>> > > > > > * OEM Revision 0x00000001 (1)<br><br>> > > > > > * Compiler ID "BXPC"<br><br>> > > > > > * Compiler Version 0x00000001 (1)<br><br>> > > > > > */<br><br>> > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001)<br><br>> > > > > ><br><br>> > > > > > --<br><br>> > > > > > MST<br><br>> > > > > ><br><br>> > > ><br><br>> ><br><br><br><br></blockquote></div></div>
On Wed, Sep 30, 2020 at 01:09:09PM +0530, Ani Sinha wrote: > > > On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote: > > > On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin <mst@redhat.com> > wrote: > > > > > > > > On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha wrote: > > > > > On Tue, Sep 29, 2020 at 4:45 PM Michael S. Tsirkin <mst@redhat.com> > wrote: > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:35:50PM +0530, Ani Sinha wrote: > > > > > > > On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin < > mst@redhat.com> wrote: > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha wrote: > > > > > > > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin < > mst@redhat.com> wrote: > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote: > > > > > > > > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha < > ani@anisinha.ca> wrote: > > > > > > > > > > > > > > > > > > > > > > > > In your pull request the following patch is completely > screwed up: > > > > > > > > > > > > > > > > > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > > > > > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > > > > > > > Date:  Tue Sep 29 03:22:52 2020 -0400 > > > > > > > > > > > > > > > > > > > > > > > >   tests/acpi: update golden master DSDT binary table > blobs for q35 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This is not my patch. It has all sorts of changes which > does not > > > > > > > > > > > > belong there. Can you please check? > > > > > > > > > > > > > > > > > > > > > > See https://patchew.org/QEMU/ > 20200929071948.281157-1-mst@redhat.com/ > 20200929071948.281157-46-mst@redhat.com/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I had to regenerate the binary, yes. That's par for the > course. > > > > > > > > > > But it looks like I added disasssembled files. Will fix up > and drop, > > > > > > > > > > thanks for noticing this. > > > > > > > > > > > > > > > > OK I pushed out a fixed variant. Pls take a look. > > > > > > > > > > > > > > OK I am not used to this workflow. How am I supposed to get it? > Which tag? > > > > > > > > > > > > New for_upstream tag - I just sent in a pull request. > > > > > > > > > > Can you please point me to your tree? > > > > > > > > > > > >  git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream > > > > > > I have sent the updated patches based on your pull request tag. I just > > > had to regenrated the blob for tests/data/acpi/pc/DSDT.hpbrroot. > > > > > > make && make check-qtest-x86_64 V=1 passes. > > > > > > The diff looks good. > > > > > > Can you please send a pull request with these two patches ASAP? > > > > > > Thanks, I will queue them and merge in the next pull request. > > > I'm willing to get down on my knees begging you to just do one another pull > request for these two patches. Were so close with my entire work merged. > > Please let's not wait another week or so. OK it's not too much work but ... could you please add justification about why adding this one unit test is needed so urgently? That motivation would be quite helpful for the pull request. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I think DSDT.hbridge is wrong. The checksum looks weird: > > > > > > > > > > > > > > > > > > > > > > > > > > > + *   Length      0x00000B89 (2953) > > > > > > > > >  *   Revision     0x01 **** 32-bit table (V1), no > 64-bit math support > > > > > > > > > - *   Checksum     0x05 > > > > > > > > > > > > > > > > What is weird about it? > > > > > > > > > > > > > > > > > > > > > > > > > > This file should be introduced just by one patch. my patch. > > > > > > > > > > > > > > > > I just re-run rebuild-expected-aml, no changes. > > > > > > > > > > > > > > > > I have this: > > > > > > > > commit 5e3a486211f02d9ecb18939ca21087515ec81883 > > > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > > > Date:  Fri Sep 18 14:11:05 2020 +0530 > > > > > > > > > > > > > > > >   tests/acpi: unit test for > 'acpi-pci-hotplug-with-bridge-support' bridge flag > > > > > > > > > > > > > > > >   This change adds a new unit test for the global flag > > > > > > > >   'acpi-pci-hotplug-with-bridge-support' which is available > for cold plugged pci > > > > > > > >   bridges in i440fx. The flag can be used to turn off ACPI > based hotplug support > > > > > > > >   on all pci bridges. > > > > > > > > > > > > > > > > > > > > > > > > Here is the full DSDT header, attached: > > > > > > > > > > > > > > > > /* > > > > > > > > * Intel ACPI Component Architecture > > > > > > > > * AML/ASL+ Disassembler version 20190509 (64-bit version) > > > > > > > > * Copyright (c) 2000 - 2019 Intel Corporation > > > > > > > > * > > > > > > > > * Disassembling to symbolic ASL+ operators > > > > > > > > * > > > > > > > > * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29 > 06:51:03 2020 > > > > > > > > * > > > > > > > > * Original Table Header: > > > > > > > > *   Signature    "DSDT" > > > > > > > > *   Length      0x0000139D (5021) > > > > > > > > *   Revision     0x01 **** 32-bit table (V1), no 64-bit > math support > > > > > > > > *   Checksum     0x05 > > > > > > > > *   OEM ID      "BOCHS " > > > > > > > > *   OEM Table ID   "BXPCDSDT" > > > > > > > > *   OEM Revision   0x00000001 (1) > > > > > > > > *   Compiler ID   "BXPC" > > > > > > > > *   Compiler Version 0x00000001 (1) > > > > > > > > */ > > > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", > 0x00000001) > > > > > > > > > > > > > > > > -- > > > > > > > > MST > > > > > > > > > > > > > > > > > > > > > >
On Wed, Sep 30, 2020 at 1:14 PM Michael S. Tsirkin <mst@redhat.com> wrote: > On Wed, Sep 30, 2020 at 01:09:09PM +0530, Ani Sinha wrote: > > > > > > > > > On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin <mst@redhat.com> > wrote: > > > > > > On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote: > > > > > > > On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin <mst@redhat.com > > > > > wrote: > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha wrote: > > > > > > > > > On Tue, Sep 29, 2020 at 4:45 PM Michael S. Tsirkin < > mst@redhat.com> > > > wrote: > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:35:50PM +0530, Ani Sinha wrote: > > > > > > > > > > > On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin < > > > mst@redhat.com> wrote: > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha > wrote: > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin < > > > mst@redhat.com> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha > wrote: > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha < > > > ani@anisinha.ca> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > In your pull request the following patch is > completely > > > screwed up: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > > > > > > > > > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > > > > > > > > > > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > tests/acpi: update golden master DSDT binary > table > > > blobs for q35 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This is not my patch. It has all sorts of > changes which > > > does not > > > > > > > > > > > > > > > > belong there. Can you please check? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > See https://patchew.org/QEMU/ > > > 20200929071948.281157-1-mst@redhat.com/ > > > 20200929071948.281157-46-mst@redhat.com/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I had to regenerate the binary, yes. That's par for > the > > > course. > > > > > > > > > > > > > > But it looks like I added disasssembled files. Will > fix up > > > and drop, > > > > > > > > > > > > > > thanks for noticing this. > > > > > > > > > > > > > > > > > > > > > > > > OK I pushed out a fixed variant. Pls take a look. > > > > > > > > > > > > > > > > > > > > > > OK I am not used to this workflow. How am I supposed to > get it? > > > Which tag? > > > > > > > > > > > > > > > > > > > > New for_upstream tag - I just sent in a pull request. > > > > > > > > > > > > > > > > > > Can you please point me to your tree? > > > > > > > > > > > > > > > > > > > > > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git > tags/for_upstream > > > > > > > > > > > > > > I have sent the updated patches based on your pull request tag. I > just > > > > > > > had to regenrated the blob for tests/data/acpi/pc/DSDT.hpbrroot. > > > > > > > > > > > > > > make && make check-qtest-x86_64 V=1 passes. > > > > > > > > > > > > > > The diff looks good. > > > > > > > > > > > > > > Can you please send a pull request with these two patches ASAP? > > > > > > > > > > > > > > > > > > Thanks, I will queue them and merge in the next pull request. > > > > > > > > > I'm willing to get down on my knees begging you to just do one another > pull > > > request for these two patches. Were so close with my entire work merged. > > > > > > Please let's not wait another week or so. > > > > > > OK it's not too much work but ... could you please add justification > > about why adding this one unit test is needed so urgently? > > That motivation would be quite helpful for the pull request. A patch without unit test doesn't complete the patch work. A unit test makes sure that the change would not get broken by other changes that come in later. Typically all code changes are accompanied by unit test in the same patch. Hence since the main work has already been merged, the unit test should merge ASAP so that no breakage can happen in between. Plus this completes an entire series of work which I've been working for a while. I really would love to see it all merged cleanly and fully completed. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I think DSDT.hbridge is wrong. The checksum looks > weird: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > + * Length 0x00000B89 (2953) > > > > > > > > > > > > > * Revision 0x01 **** 32-bit table (V1), > no > > > 64-bit math support > > > > > > > > > > > > > - * Checksum 0x05 > > > > > > > > > > > > > > > > > > > > > > > > What is weird about it? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This file should be introduced just by one patch. my > patch. > > > > > > > > > > > > > > > > > > > > > > > > I just re-run rebuild-expected-aml, no changes. > > > > > > > > > > > > > > > > > > > > > > > > I have this: > > > > > > > > > > > > commit 5e3a486211f02d9ecb18939ca21087515ec81883 > > > > > > > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > > > > > > > Date: Fri Sep 18 14:11:05 2020 +0530 > > > > > > > > > > > > > > > > > > > > > > > > tests/acpi: unit test for > > > 'acpi-pci-hotplug-with-bridge-support' bridge flag > > > > > > > > > > > > > > > > > > > > > > > > This change adds a new unit test for the global flag > > > > > > > > > > > > 'acpi-pci-hotplug-with-bridge-support' which is > available > > > for cold plugged pci > > > > > > > > > > > > bridges in i440fx. The flag can be used to turn off > ACPI > > > based hotplug support > > > > > > > > > > > > on all pci bridges. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Here is the full DSDT header, attached: > > > > > > > > > > > > > > > > > > > > > > > > /* > > > > > > > > > > > > * Intel ACPI Component Architecture > > > > > > > > > > > > * AML/ASL+ Disassembler version 20190509 (64-bit > version) > > > > > > > > > > > > * Copyright (c) 2000 - 2019 Intel Corporation > > > > > > > > > > > > * > > > > > > > > > > > > * Disassembling to symbolic ASL+ operators > > > > > > > > > > > > * > > > > > > > > > > > > * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue > Sep 29 > > > 06:51:03 2020 > > > > > > > > > > > > * > > > > > > > > > > > > * Original Table Header: > > > > > > > > > > > > * Signature "DSDT" > > > > > > > > > > > > * Length 0x0000139D (5021) > > > > > > > > > > > > * Revision 0x01 **** 32-bit table (V1), no > 64-bit > > > math support > > > > > > > > > > > > * Checksum 0x05 > > > > > > > > > > > > * OEM ID "BOCHS " > > > > > > > > > > > > * OEM Table ID "BXPCDSDT" > > > > > > > > > > > > * OEM Revision 0x00000001 (1) > > > > > > > > > > > > * Compiler ID "BXPC" > > > > > > > > > > > > * Compiler Version 0x00000001 (1) > > > > > > > > > > > > */ > > > > > > > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", > > > 0x00000001) > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > MST > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > <div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Sep 30, 2020 at 1:14 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com">mst@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">On Wed, Sep 30, 2020 at 01:09:09PM +0530, Ani Sinha wrote:<br><br>> <br><br>> <br><br>> On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>> wrote:<br><br>> <br><br>> On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote:<br><br>> <br><br>> > On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>><br><br>> wrote:<br><br>> <br><br>> > ><br><br>> <br><br>> > > On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha wrote:<br><br>> <br><br>> > > > On Tue, Sep 29, 2020 at 4:45 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>><br><br>> wrote:<br><br>> <br><br>> > > > ><br><br>> <br><br>> > > > > On Tue, Sep 29, 2020 at 04:35:50PM +0530, Ani Sinha wrote:<br><br>> <br><br>> > > > > > On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin <<br><br>> <a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>> wrote:<br><br>> <br><br>> > > > > > ><br><br>> <br><br>> > > > > > > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha wrote:<br><br>> <br><br>> > > > > > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin <<br><br>> <a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>> wrote:<br><br>> <br><br>> > > > > > > > ><br><br>> <br><br>> > > > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha wrote:<br><br>> <br><br>> > > > > > > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <<br><br>> <a href="mailto:ani@anisinha.ca" target="_blank">ani@anisinha.ca</a>> wrote:<br><br>> <br><br>> > > > > > > > > > ><br><br>> <br><br>> > > > > > > > > > > In your pull request the following patch is completely<br><br>> screwed up:<br><br>> <br><br>> > > > > > > > > > ><br><br>> <br><br>> > > > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e<br><br>> <br><br>> > > > > > > > > > > Author: Ani Sinha <<a href="mailto:ani@anisinha.ca" target="_blank">ani@anisinha.ca</a>><br><br>> <br><br>> > > > > > > > > > > Date: Tue Sep 29 03:22:52 2020 -0400<br><br>> <br><br>> > > > > > > > > > ><br><br>> <br><br>> > > > > > > > > > > tests/acpi: update golden master DSDT binary table<br><br>> blobs for q35<br><br>> <br><br>> > > > > > > > > > ><br><br>> <br><br>> > > > > > > > > > ><br><br>> <br><br>> > > > > > > > > > > This is not my patch. It has all sorts of changes which<br><br>> does not<br><br>> <br><br>> > > > > > > > > > > belong there. Can you please check?<br><br>> <br><br>> > > > > > > > > ><br><br>> <br><br>> > > > > > > > > > See <a href="https://patchew.org/QEMU/" rel="noreferrer" target="_blank">https://patchew.org/QEMU/</a><br><br>> <a href="http://20200929071948.281157-1-mst@redhat.com/" rel="noreferrer" target="_blank">20200929071948.281157-1-mst@redhat.com/</a><br><br>> <a href="http://20200929071948.281157-46-mst@redhat.com/" rel="noreferrer" target="_blank">20200929071948.281157-46-mst@redhat.com/</a><br><br>> <br><br>> > > > > > > > ><br><br>> <br><br>> > > > > > > > ><br><br>> <br><br>> > > > > > > > > I had to regenerate the binary, yes. That's par for the<br><br>> course.<br><br>> <br><br>> > > > > > > > > But it looks like I added disasssembled files. Will fix up<br><br>> and drop,<br><br>> <br><br>> > > > > > > > > thanks for noticing this.<br><br>> <br><br>> > > > > > ><br><br>> <br><br>> > > > > > > OK I pushed out a fixed variant. Pls take a look.<br><br>> <br><br>> > > > > ><br><br>> <br><br>> > > > > > OK I am not used to this workflow. How am I supposed to get it?<br><br>> Which tag?<br><br>> <br><br>> > > > ><br><br>> <br><br>> > > > > New for_upstream tag - I just sent in a pull request.<br><br>> <br><br>> > > ><br><br>> <br><br>> > > > Can you please point me to your tree?<br><br>> <br><br>> > ><br><br>> <br><br>> > ><br><br>> <br><br>> > > git://<a href="http://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git" rel="noreferrer" target="_blank">git.kernel.org/pub/scm/virt/kvm/mst/qemu.git</a> tags/for_upstream<br><br>> <br><br>> ><br><br>> <br><br>> > I have sent the updated patches based on your pull request tag. I just<br><br>> <br><br>> > had to regenrated the blob for tests/data/acpi/pc/DSDT.hpbrroot.<br><br>> <br><br>> ><br><br>> <br><br>> > make && make check-qtest-x86_64 V=1 passes.<br><br>> <br><br>> ><br><br>> <br><br>> > The diff looks good.<br><br>> <br><br>> ><br><br>> <br><br>> > Can you please send a pull request with these two patches ASAP?<br><br>> <br><br>> <br><br>> <br><br>> <br><br>> <br><br>> Thanks, I will queue them and merge in the next pull request.<br><br>> <br><br>> <br><br>> I'm willing to get down on my knees begging you to just do one another pull<br><br>> request for these two patches. Were so close with my entire work merged.<br><br>> <br><br>> Please let's not wait another week or so. <br><br><br><br><br><br>OK it's not too much work but ... could you please add justification<br><br>about why adding this one unit test is needed so urgently?<br><br>That motivation would be quite helpful for the pull request.</blockquote><div dir="auto"><br></div><div dir="auto">A patch without unit test doesn't complete the patch work. A unit test makes sure that the change would not get broken by other changes that come in later. Typically all code changes are accompanied by unit test in the same patch. Hence since the main work has already been merged, the unit test should merge ASAP so that no breakage can happen in between.</div><div dir="auto"><br></div><div dir="auto">Plus this completes an entire series of work which I've been working for a while. I really would love to see it all merged cleanly and fully completed.</div><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)" dir="auto"><br><br><br><br><br><br>> <br><br>> <br><br>> <br><br>> <br><br>> <br><br>> > ><br><br>> <br><br>> > ><br><br>> <br><br>> > ><br><br>> <br><br>> > > > ><br><br>> <br><br>> > > > > ><br><br>> <br><br>> > > > > > ><br><br>> <br><br>> > > > > > > > I think DSDT.hbridge is wrong. The checksum looks weird:<br><br>> <br><br>> > > > > > > ><br><br>> <br><br>> > > > > > > ><br><br>> <br><br>> > > > > > > > + * Length 0x00000B89 (2953)<br><br>> <br><br>> > > > > > > > * Revision 0x01 **** 32-bit table (V1), no<br><br>> 64-bit math support<br><br>> <br><br>> > > > > > > > - * Checksum 0x05<br><br>> <br><br>> > > > > > ><br><br>> <br><br>> > > > > > > What is weird about it?<br><br>> <br><br>> > > > > > ><br><br>> <br><br>> > > > > > > ><br><br>> <br><br>> > > > > > > > This file should be introduced just by one patch. my patch.<br><br>> <br><br>> > > > > > ><br><br>> <br><br>> > > > > > > I just re-run rebuild-expected-aml, no changes.<br><br>> <br><br>> > > > > > ><br><br>> <br><br>> > > > > > > I have this:<br><br>> <br><br>> > > > > > > commit 5e3a486211f02d9ecb18939ca21087515ec81883<br><br>> <br><br>> > > > > > > Author: Ani Sinha <<a href="mailto:ani@anisinha.ca" target="_blank">ani@anisinha.ca</a>><br><br>> <br><br>> > > > > > > Date: Fri Sep 18 14:11:05 2020 +0530<br><br>> <br><br>> > > > > > ><br><br>> <br><br>> > > > > > > tests/acpi: unit test for<br><br>> 'acpi-pci-hotplug-with-bridge-support' bridge flag<br><br>> <br><br>> > > > > > ><br><br>> <br><br>> > > > > > > This change adds a new unit test for the global flag<br><br>> <br><br>> > > > > > > 'acpi-pci-hotplug-with-bridge-support' which is available<br><br>> for cold plugged pci<br><br>> <br><br>> > > > > > > bridges in i440fx. The flag can be used to turn off ACPI<br><br>> based hotplug support<br><br>> <br><br>> > > > > > > on all pci bridges.<br><br>> <br><br>> > > > > > ><br><br>> <br><br>> > > > > > ><br><br>> <br><br>> > > > > > > Here is the full DSDT header, attached:<br><br>> <br><br>> > > > > > ><br><br>> <br><br>> > > > > > > /*<br><br>> <br><br>> > > > > > > * Intel ACPI Component Architecture<br><br>> <br><br>> > > > > > > * AML/ASL+ Disassembler version 20190509 (64-bit version)<br><br>> <br><br>> > > > > > > * Copyright (c) 2000 - 2019 Intel Corporation<br><br>> <br><br>> > > > > > > *<br><br>> <br><br>> > > > > > > * Disassembling to symbolic ASL+ operators<br><br>> <br><br>> > > > > > > *<br><br>> <br><br>> > > > > > > * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue Sep 29<br><br>> 06:51:03 2020<br><br>> <br><br>> > > > > > > *<br><br>> <br><br>> > > > > > > * Original Table Header:<br><br>> <br><br>> > > > > > > * Signature "DSDT"<br><br>> <br><br>> > > > > > > * Length 0x0000139D (5021)<br><br>> <br><br>> > > > > > > * Revision 0x01 **** 32-bit table (V1), no 64-bit<br><br>> math support<br><br>> <br><br>> > > > > > > * Checksum 0x05<br><br>> <br><br>> > > > > > > * OEM ID "BOCHS "<br><br>> <br><br>> > > > > > > * OEM Table ID "BXPCDSDT"<br><br>> <br><br>> > > > > > > * OEM Revision 0x00000001 (1)<br><br>> <br><br>> > > > > > > * Compiler ID "BXPC"<br><br>> <br><br>> > > > > > > * Compiler Version 0x00000001 (1)<br><br>> <br><br>> > > > > > > */<br><br>> <br><br>> > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT",<br><br>> 0x00000001)<br><br>> <br><br>> > > > > > ><br><br>> <br><br>> > > > > > > --<br><br>> <br><br>> > > > > > > MST<br><br>> <br><br>> > > > > > ><br><br>> <br><br>> > > > ><br><br>> <br><br>> > ><br><br>> <br><br>> <br><br>> <br><br>> <br><br><br><br></blockquote></div></div>
On Wed, Sep 30, 2020 at 01:17:53PM +0530, Ani Sinha wrote: > > > On Wed, Sep 30, 2020 at 1:14 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > On Wed, Sep 30, 2020 at 01:09:09PM +0530, Ani Sinha wrote: > > > > > > > > > On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin <mst@redhat.com> > wrote: > > > > > >   On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote: > > > > > >   > On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin <mst@redhat.com> > > >   wrote: > > > > > >   > > > > > > > >   > > On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha wrote: > > > > > >   > > > On Tue, Sep 29, 2020 at 4:45 PM Michael S. Tsirkin < > mst@redhat.com> > > >   wrote: > > > > > >   > > > > > > > > > >   > > > > On Tue, Sep 29, 2020 at 04:35:50PM +0530, Ani Sinha wrote: > > > > > >   > > > > > On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin < > > >   mst@redhat.com> wrote: > > > > > >   > > > > > > > > > > > >   > > > > > > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha > wrote: > > > > > >   > > > > > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin < > > >   mst@redhat.com> wrote: > > > > > >   > > > > > > > > > > > > > >   > > > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha > wrote: > > > > > >   > > > > > > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha < > > >   ani@anisinha.ca> wrote: > > > > > >   > > > > > > > > > > > > > > > >   > > > > > > > > > > In your pull request the following patch is > completely > > >   screwed up: > > > > > >   > > > > > > > > > > > > > > > >   > > > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > > > >   > > > > > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > >   > > > > > > > > > > Date:  Tue Sep 29 03:22:52 2020 -0400 > > > > > >   > > > > > > > > > > > > > > > >   > > > > > > > > > >   tests/acpi: update golden master DSDT binary > table > > >   blobs for q35 > > > > > >   > > > > > > > > > > > > > > > >   > > > > > > > > > > > > > > > >   > > > > > > > > > > This is not my patch. It has all sorts of changes > which > > >   does not > > > > > >   > > > > > > > > > > belong there. Can you please check? > > > > > >   > > > > > > > > > > > > > > >   > > > > > > > > > See https://patchew.org/QEMU/ > > >   20200929071948.281157-1-mst@redhat.com/ > > >   20200929071948.281157-46-mst@redhat.com/ > > > > > >   > > > > > > > > > > > > > >   > > > > > > > > > > > > > >   > > > > > > > > I had to regenerate the binary, yes. That's par for > the > > >   course. > > > > > >   > > > > > > > > But it looks like I added disasssembled files. Will > fix up > > >   and drop, > > > > > >   > > > > > > > > thanks for noticing this. > > > > > >   > > > > > > > > > > > >   > > > > > > OK I pushed out a fixed variant. Pls take a look. > > > > > >   > > > > > > > > > > >   > > > > > OK I am not used to this workflow. How am I supposed to get > it? > > >   Which tag? > > > > > >   > > > > > > > > > >   > > > > New for_upstream tag - I just sent in a pull request. > > > > > >   > > > > > > > > >   > > > Can you please point me to your tree? > > > > > >   > > > > > > > >   > > > > > > > >   > >  git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/ > for_upstream > > > > > >   > > > > > > >   > I have sent the updated patches based on your pull request tag. I > just > > > > > >   > had to regenrated the blob for tests/data/acpi/pc/DSDT.hpbrroot. > > > > > >   > > > > > > >   > make && make check-qtest-x86_64 V=1 passes. > > > > > >   > > > > > > >   > The diff looks good. > > > > > >   > > > > > > >   > Can you please send a pull request with these two patches ASAP? > > > > > > > > > > > > > > > > > >   Thanks, I will queue them and merge in the next pull request. > > > > > > > > > I'm willing to get down on my knees begging you to just do one another > pull > > > request for these two patches. Were so close with my entire work merged. > > > > > > Please let's not wait another week or so. > > > > > > OK it's not too much work but ... could you please add justification > > about why adding this one unit test is needed so urgently? > > That motivation would be quite helpful for the pull request. > > > A patch without unit test doesn't complete the patch work. A unit test makes > sure that the change would not get broken by other changes that come in later. > Typically all code changes are accompanied by unit test in the same patch. > Hence since the main work has already been merged, the unit test should merge > ASAP so that no breakage can happen in between. > > Plus this completes an entire series of work which I've been working for a > while. I really would love to see it all merged cleanly and fully completed. > Absolutely, thanks for the great work! I am not sure that's a good justification to rushing a pull request though ... are you waiting to get paid and it hinges on the test, or are under a deadline, or something like this? It's okay to say so if so. > > > > > > > > > > > > > > > > > > > > > > >   > > > > > > > >   > > > > > > > >   > > > > > > > >   > > > > > > > > > >   > > > > > > > > > > >   > > > > > > > > > > > >   > > > > > > > I think DSDT.hbridge is wrong. The checksum looks > weird: > > > > > >   > > > > > > > > > > > > >   > > > > > > > > > > > > >   > > > > > > > + *   Length      0x00000B89 (2953) > > > > > >   > > > > > > >  *   Revision     0x01 **** 32-bit table (V1), > no > > >   64-bit math support > > > > > >   > > > > > > > - *   Checksum     0x05 > > > > > >   > > > > > > > > > > > >   > > > > > > What is weird about it? > > > > > >   > > > > > > > > > > > >   > > > > > > > > > > > > >   > > > > > > > This file should be introduced just by one patch. my > patch. > > > > > >   > > > > > > > > > > > >   > > > > > > I just re-run rebuild-expected-aml, no changes. > > > > > >   > > > > > > > > > > > >   > > > > > > I have this: > > > > > >   > > > > > > commit 5e3a486211f02d9ecb18939ca21087515ec81883 > > > > > >   > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > >   > > > > > > Date:  Fri Sep 18 14:11:05 2020 +0530 > > > > > >   > > > > > > > > > > > >   > > > > > >   tests/acpi: unit test for > > >   'acpi-pci-hotplug-with-bridge-support' bridge flag > > > > > >   > > > > > > > > > > > >   > > > > > >   This change adds a new unit test for the global flag > > > > > >   > > > > > >   'acpi-pci-hotplug-with-bridge-support' which is > available > > >   for cold plugged pci > > > > > >   > > > > > >   bridges in i440fx. The flag can be used to turn off > ACPI > > >   based hotplug support > > > > > >   > > > > > >   on all pci bridges. > > > > > >   > > > > > > > > > > > >   > > > > > > > > > > > >   > > > > > > Here is the full DSDT header, attached: > > > > > >   > > > > > > > > > > > >   > > > > > > /* > > > > > >   > > > > > > * Intel ACPI Component Architecture > > > > > >   > > > > > > * AML/ASL+ Disassembler version 20190509 (64-bit > version) > > > > > >   > > > > > > * Copyright (c) 2000 - 2019 Intel Corporation > > > > > >   > > > > > > * > > > > > >   > > > > > > * Disassembling to symbolic ASL+ operators > > > > > >   > > > > > > * > > > > > >   > > > > > > * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue > Sep 29 > > >   06:51:03 2020 > > > > > >   > > > > > > * > > > > > >   > > > > > > * Original Table Header: > > > > > >   > > > > > > *   Signature    "DSDT" > > > > > >   > > > > > > *   Length      0x0000139D (5021) > > > > > >   > > > > > > *   Revision     0x01 **** 32-bit table (V1), no > 64-bit > > >   math support > > > > > >   > > > > > > *   Checksum     0x05 > > > > > >   > > > > > > *   OEM ID      "BOCHS " > > > > > >   > > > > > > *   OEM Table ID   "BXPCDSDT" > > > > > >   > > > > > > *   OEM Revision   0x00000001 (1) > > > > > >   > > > > > > *   Compiler ID   "BXPC" > > > > > >   > > > > > > *   Compiler Version 0x00000001 (1) > > > > > >   > > > > > > */ > > > > > >   > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", > > >   0x00000001) > > > > > >   > > > > > > > > > > > >   > > > > > > -- > > > > > >   > > > > > > MST > > > > > >   > > > > > > > > > > > >   > > > > > > > > > >   > > > > > > > > > > > > > > > > > >
On Wed, Sep 30, 2020 at 1:34 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > On Wed, Sep 30, 2020 at 01:17:53PM +0530, Ani Sinha wrote: > > > > > > On Wed, Sep 30, 2020 at 1:14 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > On Wed, Sep 30, 2020 at 01:09:09PM +0530, Ani Sinha wrote: > > > > > > > > > > > > > > > On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin <mst@redhat.com> > > wrote: > > > > > > > > > > On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote: > > > > > > > > > > > On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin <mst@redhat.com> > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha wrote: > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 4:45 PM Michael S. Tsirkin < > > mst@redhat.com> > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:35:50PM +0530, Ani Sinha wrote: > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin < > > > > > mst@redhat.com> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha > > wrote: > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin < > > > > > mst@redhat.com> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha > > wrote: > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha < > > > > > ani@anisinha.ca> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > In your pull request the following patch is > > completely > > > > > screwed up: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > > > > > > > > > > > > > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > > > > > > > > > > > > > > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > tests/acpi: update golden master DSDT binary > > table > > > > > blobs for q35 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This is not my patch. It has all sorts of changes > > which > > > > > does not > > > > > > > > > > > > > > > > > > > > belong there. Can you please check? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > See https://patchew.org/QEMU/ > > > > > 20200929071948.281157-1-mst@redhat.com/ > > > > > 20200929071948.281157-46-mst@redhat.com/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I had to regenerate the binary, yes. That's par for > > the > > > > > course. > > > > > > > > > > > > > > > > > > But it looks like I added disasssembled files. Will > > fix up > > > > > and drop, > > > > > > > > > > > > > > > > > > thanks for noticing this. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > OK I pushed out a fixed variant. Pls take a look. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > OK I am not used to this workflow. How am I supposed to get > > it? > > > > > Which tag? > > > > > > > > > > > > > > > > > > > > > > > > > > > > New for_upstream tag - I just sent in a pull request. > > > > > > > > > > > > > > > > > > > > > > > > > > Can you please point me to your tree? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/ > > for_upstream > > > > > > > > > > > > > > > > > > > > > > I have sent the updated patches based on your pull request tag. I > > just > > > > > > > > > > > had to regenrated the blob for tests/data/acpi/pc/DSDT.hpbrroot. > > > > > > > > > > > > > > > > > > > > > > make && make check-qtest-x86_64 V=1 passes. > > > > > > > > > > > > > > > > > > > > > > The diff looks good. > > > > > > > > > > > > > > > > > > > > > > Can you please send a pull request with these two patches ASAP? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks, I will queue them and merge in the next pull request. > > > > > > > > > > > > > > > I'm willing to get down on my knees begging you to just do one another > > pull > > > > > request for these two patches. Were so close with my entire work merged. > > > > > > > > > > Please let's not wait another week or so. > > > > > > > > > > > > OK it's not too much work but ... could you please add justification > > > > about why adding this one unit test is needed so urgently? > > > > That motivation would be quite helpful for the pull request. > > > > > > A patch without unit test doesn't complete the patch work. A unit test makes > > sure that the change would not get broken by other changes that come in later. > > Typically all code changes are accompanied by unit test in the same patch. > > Hence since the main work has already been merged, the unit test should merge > > ASAP so that no breakage can happen in between. > > > > Plus this completes an entire series of work which I've been working for a > > while. I really would love to see it all merged cleanly and fully completed. > > > > Absolutely, thanks for the great work! > I am not sure that's a good justification to rushing a pull request > though ... are you waiting to get paid and it hinges on the test, or are > under a deadline, or something like this? It's okay to say so if so. Yes I am under a deadline too. Unfortunately can't disclose more details. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I think DSDT.hbridge is wrong. The checksum looks > > weird: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > + * Length 0x00000B89 (2953) > > > > > > > > > > > > > > > > > * Revision 0x01 **** 32-bit table (V1), > > no > > > > > 64-bit math support > > > > > > > > > > > > > > > > > - * Checksum 0x05 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > What is weird about it? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This file should be introduced just by one patch. my > > patch. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I just re-run rebuild-expected-aml, no changes. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I have this: > > > > > > > > > > > > > > > > commit 5e3a486211f02d9ecb18939ca21087515ec81883 > > > > > > > > > > > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > > > > > > > > > > > Date: Fri Sep 18 14:11:05 2020 +0530 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > tests/acpi: unit test for > > > > > 'acpi-pci-hotplug-with-bridge-support' bridge flag > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This change adds a new unit test for the global flag > > > > > > > > > > > > > > > > 'acpi-pci-hotplug-with-bridge-support' which is > > available > > > > > for cold plugged pci > > > > > > > > > > > > > > > > bridges in i440fx. The flag can be used to turn off > > ACPI > > > > > based hotplug support > > > > > > > > > > > > > > > > on all pci bridges. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Here is the full DSDT header, attached: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > /* > > > > > > > > > > > > > > > > * Intel ACPI Component Architecture > > > > > > > > > > > > > > > > * AML/ASL+ Disassembler version 20190509 (64-bit > > version) > > > > > > > > > > > > > > > > * Copyright (c) 2000 - 2019 Intel Corporation > > > > > > > > > > > > > > > > * > > > > > > > > > > > > > > > > * Disassembling to symbolic ASL+ operators > > > > > > > > > > > > > > > > * > > > > > > > > > > > > > > > > * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue > > Sep 29 > > > > > 06:51:03 2020 > > > > > > > > > > > > > > > > * > > > > > > > > > > > > > > > > * Original Table Header: > > > > > > > > > > > > > > > > * Signature "DSDT" > > > > > > > > > > > > > > > > * Length 0x0000139D (5021) > > > > > > > > > > > > > > > > * Revision 0x01 **** 32-bit table (V1), no > > 64-bit > > > > > math support > > > > > > > > > > > > > > > > * Checksum 0x05 > > > > > > > > > > > > > > > > * OEM ID "BOCHS " > > > > > > > > > > > > > > > > * OEM Table ID "BXPCDSDT" > > > > > > > > > > > > > > > > * OEM Revision 0x00000001 (1) > > > > > > > > > > > > > > > > * Compiler ID "BXPC" > > > > > > > > > > > > > > > > * Compiler Version 0x00000001 (1) > > > > > > > > > > > > > > > > */ > > > > > > > > > > > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", > > > > > 0x00000001) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > MST > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
On Wed, Sep 30, 2020 at 1:37 PM Ani Sinha <ani@anisinha.ca> wrote: > On Wed, Sep 30, 2020 at 1:34 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > > > > > On Wed, Sep 30, 2020 at 01:17:53PM +0530, Ani Sinha wrote: > > > > > > > > > > > > On Wed, Sep 30, 2020 at 1:14 PM Michael S. Tsirkin <mst@redhat.com> > wrote: > > > > > > > > On Wed, Sep 30, 2020 at 01:09:09PM +0530, Ani Sinha wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin < > mst@redhat.com> > > > > wrote: > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote: > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin < > mst@redhat.com> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha > wrote: > > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 4:45 PM Michael S. Tsirkin < > > > > mst@redhat.com> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:35:50PM +0530, Ani Sinha > wrote: > > > > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin > < > > > > > > > > > mst@redhat.com> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani > Sinha > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. > Tsirkin < > > > > > > > > > mst@redhat.com> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, > Ani Sinha > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha < > > > > > > > > > ani@anisinha.ca> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > In your pull request the following patch > is > > > > completely > > > > > > > > > screwed up: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > commit > cda2006eded0ed91974e1d9e7f9f288e65812a3e > > > > > > > > > > > > > > > > > > > > > > > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Tue Sep 29 03:22:52 2020 -0400 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > tests/acpi: update golden master > DSDT binary > > > > table > > > > > > > > > blobs for q35 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This is not my patch. It has all sorts > of changes > > > > which > > > > > > > > > does not > > > > > > > > > > > > > > > > > > > > > > > > > > > > belong there. Can you please check? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > See https://patchew.org/QEMU/ > > > > > > > > > 20200929071948.281157-1-mst@redhat.com/ > > > > > > > > > 20200929071948.281157-46-mst@redhat.com/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I had to regenerate the binary, yes. That's > par for > > > > the > > > > > > > > > course. > > > > > > > > > > > > > > > > > > > > > > > > > > But it looks like I added disasssembled > files. Will > > > > fix up > > > > > > > > > and drop, > > > > > > > > > > > > > > > > > > > > > > > > > > thanks for noticing this. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > OK I pushed out a fixed variant. Pls take a look. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > OK I am not used to this workflow. How am I > supposed to get > > > > it? > > > > > > > > > Which tag? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > New for_upstream tag - I just sent in a pull request. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Can you please point me to your tree? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git > tags/ > > > > for_upstream > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I have sent the updated patches based on your pull request > tag. I > > > > just > > > > > > > > > > > > > > > > > > > had to regenrated the blob for > tests/data/acpi/pc/DSDT.hpbrroot. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > make && make check-qtest-x86_64 V=1 passes. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The diff looks good. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Can you please send a pull request with these two patches > ASAP? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks, I will queue them and merge in the next pull request. > > > > > > > > > > > > > > > > > > > > > > > > > > > I'm willing to get down on my knees begging you to just do one > another > > > > pull > > > > > > > > > request for these two patches. Were so close with my entire work > merged. > > > > > > > > > > > > > > > > > > Please let's not wait another week or so. > > > > > > > > > > > > > > > > > > > > > > > > OK it's not too much work but ... could you please add > justification > > > > > > > > about why adding this one unit test is needed so urgently? > > > > > > > > That motivation would be quite helpful for the pull request. > > > > > > > > > > > > A patch without unit test doesn't complete the patch work. A unit test > makes > > > > sure that the change would not get broken by other changes that come > in later. > > > > Typically all code changes are accompanied by unit test in the same > patch. > > > > Hence since the main work has already been merged, the unit test > should merge > > > > ASAP so that no breakage can happen in between. > > > > > > > > Plus this completes an entire series of work which I've been working > for a > > > > while. I really would love to see it all merged cleanly and fully > completed. > > > > > > > > > > Absolutely, thanks for the great work! > > > I am not sure that's a good justification to rushing a pull request > > > though ... are you waiting to get paid and it hinges on the test, or are > > > under a deadline, or something like this? It's okay to say so if so. > > > > Yes I am under a deadline too. Unfortunately can't disclose more details. Thanks Michael. Very much appreciate your help here. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I think DSDT.hbridge is wrong. The checksum > looks > > > > weird: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > + * Length 0x00000B89 (2953) > > > > > > > > > > > > > > > > > > > > > > > > > * Revision 0x01 **** 32-bit > table (V1), > > > > no > > > > > > > > > 64-bit math support > > > > > > > > > > > > > > > > > > > > > > > > > - * Checksum 0x05 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > What is weird about it? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This file should be introduced just by one > patch. my > > > > patch. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I just re-run rebuild-expected-aml, no changes. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I have this: > > > > > > > > > > > > > > > > > > > > > > > > commit 5e3a486211f02d9ecb18939ca21087515ec81883 > > > > > > > > > > > > > > > > > > > > > > > > Author: Ani Sinha <ani@anisinha.ca> > > > > > > > > > > > > > > > > > > > > > > > > Date: Fri Sep 18 14:11:05 2020 +0530 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > tests/acpi: unit test for > > > > > > > > > 'acpi-pci-hotplug-with-bridge-support' bridge flag > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > This change adds a new unit test for the > global flag > > > > > > > > > > > > > > > > > > > > > > > > 'acpi-pci-hotplug-with-bridge-support' which > is > > > > available > > > > > > > > > for cold plugged pci > > > > > > > > > > > > > > > > > > > > > > > > bridges in i440fx. The flag can be used to > turn off > > > > ACPI > > > > > > > > > based hotplug support > > > > > > > > > > > > > > > > > > > > > > > > on all pci bridges. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Here is the full DSDT header, attached: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > /* > > > > > > > > > > > > > > > > > > > > > > > > * Intel ACPI Component Architecture > > > > > > > > > > > > > > > > > > > > > > > > * AML/ASL+ Disassembler version 20190509 (64-bit > > > > version) > > > > > > > > > > > > > > > > > > > > > > > > * Copyright (c) 2000 - 2019 Intel Corporation > > > > > > > > > > > > > > > > > > > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > > * Disassembling to symbolic ASL+ operators > > > > > > > > > > > > > > > > > > > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > > * Disassembly of > tests/data/acpi/pc/DSDT.hpbridge, Tue > > > > Sep 29 > > > > > > > > > 06:51:03 2020 > > > > > > > > > > > > > > > > > > > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > > * Original Table Header: > > > > > > > > > > > > > > > > > > > > > > > > * Signature "DSDT" > > > > > > > > > > > > > > > > > > > > > > > > * Length 0x0000139D (5021) > > > > > > > > > > > > > > > > > > > > > > > > * Revision 0x01 **** 32-bit table > (V1), no > > > > 64-bit > > > > > > > > > math support > > > > > > > > > > > > > > > > > > > > > > > > * Checksum 0x05 > > > > > > > > > > > > > > > > > > > > > > > > * OEM ID "BOCHS " > > > > > > > > > > > > > > > > > > > > > > > > * OEM Table ID "BXPCDSDT" > > > > > > > > > > > > > > > > > > > > > > > > * OEM Revision 0x00000001 (1) > > > > > > > > > > > > > > > > > > > > > > > > * Compiler ID "BXPC" > > > > > > > > > > > > > > > > > > > > > > > > * Compiler Version 0x00000001 (1) > > > > > > > > > > > > > > > > > > > > > > > > */ > > > > > > > > > > > > > > > > > > > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", > "BXPCDSDT", > > > > > > > > > 0x00000001) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > > > > > > > > > > > MST > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > <div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Sep 30, 2020 at 1:37 PM Ani Sinha <<a href="mailto:ani@anisinha.ca">ani@anisinha.ca</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">On Wed, Sep 30, 2020 at 1:34 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>> wrote:<br><br>><br><br>> On Wed, Sep 30, 2020 at 01:17:53PM +0530, Ani Sinha wrote:<br><br>> ><br><br>> ><br><br>> > On Wed, Sep 30, 2020 at 1:14 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>> wrote:<br><br>> ><br><br>> > On Wed, Sep 30, 2020 at 01:09:09PM +0530, Ani Sinha wrote:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>><br><br>> > wrote:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin <<a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>><br><br>> ><br><br>> > > wrote:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha wrote:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > On Tue, Sep 29, 2020 at 4:45 PM Michael S. Tsirkin <<br><br>> > <a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>><br><br>> ><br><br>> > > wrote:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > On Tue, Sep 29, 2020 at 04:35:50PM +0530, Ani Sinha wrote:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > On Tue, Sep 29, 2020 at 4:25 PM Michael S. Tsirkin <<br><br>> ><br><br>> > > <a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>> wrote:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > On Tue, Sep 29, 2020 at 04:11:45PM +0530, Ani Sinha<br><br>> > wrote:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > On Tue, Sep 29, 2020 at 4:07 PM Michael S. Tsirkin <<br><br>> ><br><br>> > > <a href="mailto:mst@redhat.com" target="_blank">mst@redhat.com</a>> wrote:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > On Tue, Sep 29, 2020 at 04:02:07PM +0530, Ani Sinha<br><br>> > wrote:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > > On Tue, Sep 29, 2020 at 4:00 PM Ani Sinha <<br><br>> ><br><br>> > > <a href="mailto:ani@anisinha.ca" target="_blank">ani@anisinha.ca</a>> wrote:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > > > In your pull request the following patch is<br><br>> > completely<br><br>> ><br><br>> > > screwed up:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > > > commit cda2006eded0ed91974e1d9e7f9f288e65812a3e<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > > > Author: Ani Sinha <<a href="mailto:ani@anisinha.ca" target="_blank">ani@anisinha.ca</a>><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > > > Date: Tue Sep 29 03:22:52 2020 -0400<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > > > tests/acpi: update golden master DSDT binary<br><br>> > table<br><br>> ><br><br>> > > blobs for q35<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > > > This is not my patch. It has all sorts of changes<br><br>> > which<br><br>> ><br><br>> > > does not<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > > > belong there. Can you please check?<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > > See <a href="https://patchew.org/QEMU/" rel="noreferrer" target="_blank">https://patchew.org/QEMU/</a><br><br>> ><br><br>> > > <a href="http://20200929071948.281157-1-mst@redhat.com/" rel="noreferrer" target="_blank">20200929071948.281157-1-mst@redhat.com/</a><br><br>> ><br><br>> > > <a href="http://20200929071948.281157-46-mst@redhat.com/" rel="noreferrer" target="_blank">20200929071948.281157-46-mst@redhat.com/</a><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > I had to regenerate the binary, yes. That's par for<br><br>> > the<br><br>> ><br><br>> > > course.<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > But it looks like I added disasssembled files. Will<br><br>> > fix up<br><br>> ><br><br>> > > and drop,<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > > thanks for noticing this.<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > OK I pushed out a fixed variant. Pls take a look.<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > OK I am not used to this workflow. How am I supposed to get<br><br>> > it?<br><br>> ><br><br>> > > Which tag?<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > New for_upstream tag - I just sent in a pull request.<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > Can you please point me to your tree?<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > git://<a href="http://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git" rel="noreferrer" target="_blank">git.kernel.org/pub/scm/virt/kvm/mst/qemu.git</a> tags/<br><br>> > for_upstream<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > I have sent the updated patches based on your pull request tag. I<br><br>> > just<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > had to regenrated the blob for tests/data/acpi/pc/DSDT.hpbrroot.<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > make && make check-qtest-x86_64 V=1 passes.<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > The diff looks good.<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > Can you please send a pull request with these two patches ASAP?<br><br>> ><br><br>> > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > Thanks, I will queue them and merge in the next pull request.<br><br>> ><br><br>> > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > I'm willing to get down on my knees begging you to just do one another<br><br>> > pull<br><br>> ><br><br>> > > request for these two patches. Were so close with my entire work merged.<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > Please let's not wait another week or so.<br><br>> ><br><br>> ><br><br>> ><br><br>> ><br><br>> ><br><br>> > OK it's not too much work but ... could you please add justification<br><br>> ><br><br>> > about why adding this one unit test is needed so urgently?<br><br>> ><br><br>> > That motivation would be quite helpful for the pull request.<br><br>> ><br><br>> ><br><br>> > A patch without unit test doesn't complete the patch work. A unit test makes<br><br>> > sure that the change would not get broken by other changes that come in later.<br><br>> > Typically all code changes are accompanied by unit test in the same patch.<br><br>> > Hence since the main work has already been merged, the unit test should merge<br><br>> > ASAP so that no breakage can happen in between.<br><br>> ><br><br>> > Plus this completes an entire series of work which I've been working for a<br><br>> > while. I really would love to see it all merged cleanly and fully completed.<br><br>> ><br><br>><br><br>> Absolutely, thanks for the great work!<br><br>> I am not sure that's a good justification to rushing a pull request<br><br>> though ... are you waiting to get paid and it hinges on the test, or are<br><br>> under a deadline, or something like this? It's okay to say so if so.<br><br><br><br>Yes I am under a deadline too. Unfortunately can't disclose more details.</blockquote><div dir="auto"><br></div><div dir="auto">Thanks Michael. Very much appreciate your help here.</div><div dir="auto"><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)" dir="auto"><br><br><br><br>><br><br>> ><br><br>> ><br><br>> ><br><br>> ><br><br>> ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > I think DSDT.hbridge is wrong. The checksum looks<br><br>> > weird:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > + * Length 0x00000B89 (2953)<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > * Revision 0x01 **** 32-bit table (V1),<br><br>> > no<br><br>> ><br><br>> > > 64-bit math support<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > - * Checksum 0x05<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > What is weird about it?<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > > This file should be introduced just by one patch. my<br><br>> > patch.<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > I just re-run rebuild-expected-aml, no changes.<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > I have this:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > commit 5e3a486211f02d9ecb18939ca21087515ec81883<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > Author: Ani Sinha <<a href="mailto:ani@anisinha.ca" target="_blank">ani@anisinha.ca</a>><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > Date: Fri Sep 18 14:11:05 2020 +0530<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > tests/acpi: unit test for<br><br>> ><br><br>> > > 'acpi-pci-hotplug-with-bridge-support' bridge flag<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > This change adds a new unit test for the global flag<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > 'acpi-pci-hotplug-with-bridge-support' which is<br><br>> > available<br><br>> ><br><br>> > > for cold plugged pci<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > bridges in i440fx. The flag can be used to turn off<br><br>> > ACPI<br><br>> ><br><br>> > > based hotplug support<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > on all pci bridges.<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > Here is the full DSDT header, attached:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > /*<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > * Intel ACPI Component Architecture<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > * AML/ASL+ Disassembler version 20190509 (64-bit<br><br>> > version)<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > * Copyright (c) 2000 - 2019 Intel Corporation<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > *<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > * Disassembling to symbolic ASL+ operators<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > *<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > * Disassembly of tests/data/acpi/pc/DSDT.hpbridge, Tue<br><br>> > Sep 29<br><br>> ><br><br>> > > 06:51:03 2020<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > *<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > * Original Table Header:<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > * Signature "DSDT"<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > * Length 0x0000139D (5021)<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > * Revision 0x01 **** 32-bit table (V1), no<br><br>> > 64-bit<br><br>> ><br><br>> > > math support<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > * Checksum 0x05<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > * OEM ID "BOCHS "<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > * OEM Table ID "BXPCDSDT"<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > * OEM Revision 0x00000001 (1)<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > * Compiler ID "BXPC"<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > * Compiler Version 0x00000001 (1)<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > */<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT",<br><br>> ><br><br>> > > 0x00000001)<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > --<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > > MST<br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > > > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> > ><br><br>> ><br><br>> ><br><br>> ><br><br>> ><br><br>><br><br></blockquote></div></div>
On Wed, Sep 30, 2020 at 03:00:56PM +0530, Ani Sinha wrote: > > > >Â Â Â > Please let's not wait another week or so. > > > > > > > > > > > > > > > > > > > > > > > >Â Â Â OK it's not too much work but ... could you please add > justification > > > > > > > >Â Â Â about why adding this one unit test is needed so urgently? > > > > > > > >Â Â Â That motivation would be quite helpful for the pull request. > > > > > > > > > > > > A patch without unit test doesn't complete the patch work. A unit test > makes > > > > sure that the change would not get broken by other changes that come in > later. > > > > Typically all code changes are accompanied by unit test in the same > patch. > > > > Hence since the main work has already been merged, the unit test should > merge > > > > ASAP so that no breakage can happen in between. > > > > > > > > Plus this completes an entire series of work which I've been working > for a > > > > while. I really would love to see it all merged cleanly and fully > completed. > > > > > > > > > > Absolutely, thanks for the great work! > > > I am not sure that's a good justification to rushing a pull request > > > though ... are you waiting to get paid and it hinges on the test, or are > > > under a deadline, or something like this? It's okay to say so if so. > > > > Yes I am under a deadline too. Unfortunately can't disclose more details. > > > Thanks Michael. Very much appreciate your help here. > OK Peter merged this. Hope this helps. Let's not make this a pattern please. -- MST
On Wed, Sep 30, 2020 at 8:59 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > On Wed, Sep 30, 2020 at 03:00:56PM +0530, Ani Sinha wrote: > > > > > > > Please let's not wait another week or so. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > OK it's not too much work but ... could you please add > > justification > > > > > > > > > > > > about why adding this one unit test is needed so urgently? > > > > > > > > > > > > That motivation would be quite helpful for the pull request. > > > > > > > > > > > > > > > > > > A patch without unit test doesn't complete the patch work. A unit test > > makes > > > > > > sure that the change would not get broken by other changes that come in > > later. > > > > > > Typically all code changes are accompanied by unit test in the same > > patch. > > > > > > Hence since the main work has already been merged, the unit test should > > merge > > > > > > ASAP so that no breakage can happen in between. > > > > > > > > > > > > Plus this completes an entire series of work which I've been working > > for a > > > > > > while. I really would love to see it all merged cleanly and fully > > completed. > > > > > > > > > > > > > > > > Absolutely, thanks for the great work! > > > > > I am not sure that's a good justification to rushing a pull request > > > > > though ... are you waiting to get paid and it hinges on the test, or are > > > > > under a deadline, or something like this? It's okay to say so if so. > > > > > > > > Yes I am under a deadline too. Unfortunately can't disclose more details. > > > > > > Thanks Michael. Very much appreciate your help here. > > > > OK Peter merged this. Hope this helps. > Let's not make this a pattern please. No this is a one time thing. Thanks to you and Peter for making an exception. > > -- > MST >
Final patch series with all the patches reviewed or ack'd and marked as such. Thanks Julia and Igor for the reviews. Hope this series gets pulled in soon. --Ani Ani Sinha (13): tests/acpi: mark addition of table DSDT.roothp for unit testing root pci hotplug tests/acpi: add new unit test to test hotplug off/on feature on the root pci bus tests/acpi: add a new ACPI table in order to test root pci hotplug on/off Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus i440fx/acpi: do not add hotplug related amls for cold plugged bridges tests/acpi: list added acpi table binary file for pci bridge hotplug test tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag Add ACPI DSDT tables for q35 that are being updated by the next patch piix4: don't reserve hw resources when hotplug is off globally tests/acpi: update golden master DSDT binary table blobs for q35 tests/acpi: unit test exercising global pci hotplug off for i440fx tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug hw/acpi/pcihp.c | 15 +++++++++ hw/acpi/piix4.c | 6 ++-- hw/i386/acpi-build.c | 37 ++++++++++++++-------- tests/data/acpi/pc/DSDT.hpbridge | Bin 0 -> 4895 bytes tests/data/acpi/pc/DSDT.hpbrroot | Bin 0 -> 2953 bytes tests/data/acpi/pc/DSDT.roothp | Bin 0 -> 5130 bytes tests/data/acpi/q35/DSDT | Bin 7678 -> 7670 bytes tests/data/acpi/q35/DSDT.acpihmat | Bin 9002 -> 8994 bytes tests/data/acpi/q35/DSDT.bridge | Bin 7695 -> 7688 bytes tests/data/acpi/q35/DSDT.cphp | Bin 8141 -> 8133 bytes tests/data/acpi/q35/DSDT.dimmpxm | Bin 9331 -> 9323 bytes tests/data/acpi/q35/DSDT.ipmibt | Bin 7753 -> 7745 bytes tests/data/acpi/q35/DSDT.memhp | Bin 9037 -> 9029 bytes tests/data/acpi/q35/DSDT.mmio64 | Bin 8808 -> 8801 bytes tests/data/acpi/q35/DSDT.numamem | Bin 7684 -> 7676 bytes tests/data/acpi/q35/DSDT.tis | Bin 8283 -> 8276 bytes tests/qtest/bios-tables-test.c | 49 ++++++++++++++++++++++++++++++ 17 files changed, 92 insertions(+), 15 deletions(-) create mode 100644 tests/data/acpi/pc/DSDT.hpbridge create mode 100644 tests/data/acpi/pc/DSDT.hpbrroot create mode 100644 tests/data/acpi/pc/DSDT.roothp