mbox series

[net-next,v2,0/3] 100base Fx link modes

Message ID 20200918191453.13914-1-dmurphy@ti.com
Headers show
Series 100base Fx link modes | expand

Message

Dan Murphy Sept. 18, 2020, 7:14 p.m. UTC 
Hello

As per patch https://lore.kernel.org/patchwork/patch/1300241/ the link
modes for 100base FX full and half duplex modes did not exist.  Adding these
link modes to the core and ethtool allow devices like the DP83822, DP83869 and
Broadcomm PHYs to properly advertise the correct mode for Fiber 100Mbps.

Corresponding user land ethtool patches are available but rely on these patches
to be applied first.

Dan

Dan Murphy (3):
  ethtool: Add 100base-FX link mode entries
  net: dp83869: Add ability to advertise Fiber connection
  net: phy: dp83822: Update the fiber advertisement for speed

 drivers/net/phy/dp83822.c    | 13 +++++--
 drivers/net/phy/dp83869.c    | 73 ++++++++++++++++++++++++++++++++++++
 drivers/net/phy/phy-core.c   |  4 +-
 include/uapi/linux/ethtool.h |  2 +
 net/ethtool/common.c         |  2 +
 net/ethtool/linkmodes.c      |  2 +
 6 files changed, 92 insertions(+), 4 deletions(-)

Comments

Andrew Lunn Sept. 18, 2020, 7:24 p.m. UTC | #1 
On Fri, Sep 18, 2020 at 02:14:51PM -0500, Dan Murphy wrote:
> Add entries for the 100base-FX full and half duplex supported modes.

> 

> $ ethtool eth0

>         Supported ports: [ FIBRE ]

>         Supported link modes:  100baseFX/Half 100baseFX/Full

>         Supported pause frame use: Symmetric Receive-only

>         Supports auto-negotiation: No

>         Supported FEC modes: Not reported

>         Advertised link modes: 100baseFX/Half 100baseFX/Full

>         Advertised pause frame use: No

>         Advertised auto-negotiation: No

>         Advertised FEC modes: Not reported

>         Speed: 100Mb/s

>         Duplex: Full

>         Auto-negotiation: off

>         Port: MII

>         PHYAD: 1

>         Transceiver: external

>         Supports Wake-on: gs

>         Wake-on: d

>         SecureOn password: 00:00:00:00:00:00

>         Current message level: 0x00000000 (0)

> 

>         Link detected: yes

> 

> Signed-off-by: Dan Murphy <dmurphy@ti.com>


Reviewed-by: Andrew Lunn <andrew@lunn.ch>


    Andrew
Andrew Lunn Sept. 18, 2020, 7:29 p.m. UTC | #2 
On Fri, Sep 18, 2020 at 02:14:53PM -0500, Dan Murphy wrote:
> Update the fiber advertisement for speed and duplex modes with the

> 100base-FX full and half linkmode entries.

> 

> Signed-off-by: Dan Murphy <dmurphy@ti.com>


Reviewed-by: Andrew Lunn <andrew@lunn.ch>


    Andrew
Florian Fainelli Sept. 18, 2020, 8:14 p.m. UTC | #3 
On 9/18/2020 12:14 PM, Dan Murphy wrote:
> Add entries for the 100base-FX full and half duplex supported modes.

> 

> $ ethtool eth0

>          Supported ports: [ FIBRE ]

>          Supported link modes:  100baseFX/Half 100baseFX/Full

>          Supported pause frame use: Symmetric Receive-only

>          Supports auto-negotiation: No

>          Supported FEC modes: Not reported

>          Advertised link modes: 100baseFX/Half 100baseFX/Full

>          Advertised pause frame use: No

>          Advertised auto-negotiation: No

>          Advertised FEC modes: Not reported

>          Speed: 100Mb/s

>          Duplex: Full

>          Auto-negotiation: off

>          Port: MII

>          PHYAD: 1

>          Transceiver: external

>          Supports Wake-on: gs

>          Wake-on: d

>          SecureOn password: 00:00:00:00:00:00

>          Current message level: 0x00000000 (0)

> 

>          Link detected: yes

> 

> Signed-off-by: Dan Murphy <dmurphy@ti.com>


Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

-- 
Florian
Florian Fainelli Sept. 18, 2020, 8:17 p.m. UTC | #4 
On 9/18/2020 12:14 PM, Dan Murphy wrote:
> Update the fiber advertisement for speed and duplex modes with the
> 100base-FX full and half linkmode entries.
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
David Miller Sept. 19, 2020, 11:55 p.m. UTC | #5 
From: Dan Murphy <dmurphy@ti.com>
Date: Fri, 18 Sep 2020 14:14:50 -0500

> As per patch https://lore.kernel.org/patchwork/patch/1300241/ the link
> modes for 100base FX full and half duplex modes did not exist.  Adding these
> link modes to the core and ethtool allow devices like the DP83822, DP83869 and
> Broadcomm PHYs to properly advertise the correct mode for Fiber 100Mbps.
> 
> Corresponding user land ethtool patches are available but rely on these patches
> to be applied first.

Series applied, thank you.