| Message ID | 160250199940.765467.6896806997161856576.stgit@bahia.lan |
|---|---|
| State | Superseded |
| Headers | show |
| Series | spapr: Clarify why DR connectors aren't user creatable | expand |
On Mon, Oct 12, 2020 at 01:26:39PM +0200, Greg Kurz wrote: > DR connector is a device that emulates a firmware abstraction used by PAPR > compliant guests to manage hotplug/dynamic-reconfiguration of PHBs, PCI > devices, memory, and CPUs. > > It is internally created by the spapr platform and requires to be owned by > either the machine (PHBs, CPUs, memory) or by a PHB (PCI devices). > > Signed-off-by: Greg Kurz <groug@kaod.org> Applied to ppc-for-5.2, thanks. > --- > hw/ppc/spapr_drc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c > index 697b28c34305..77718cde1ff2 100644 > --- a/hw/ppc/spapr_drc.c > +++ b/hw/ppc/spapr_drc.c > @@ -586,7 +586,8 @@ static void spapr_dr_connector_class_init(ObjectClass *k, void *data) > dk->realize = realize; > dk->unrealize = unrealize; > /* > - * Reason: it crashes FIXME find and document the real reason > + * Reason: DR connector needs to be wired to either the machine or to a > + * PHB in spapr_dr_connector_new(). > */ > dk->user_creatable = false; > } > > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index 697b28c34305..77718cde1ff2 100644 --- a/hw/ppc/spapr_drc.c +++ b/hw/ppc/spapr_drc.c @@ -586,7 +586,8 @@ static void spapr_dr_connector_class_init(ObjectClass *k, void *data) dk->realize = realize; dk->unrealize = unrealize; /* - * Reason: it crashes FIXME find and document the real reason + * Reason: DR connector needs to be wired to either the machine or to a + * PHB in spapr_dr_connector_new(). */ dk->user_creatable = false; }
DR connector is a device that emulates a firmware abstraction used by PAPR compliant guests to manage hotplug/dynamic-reconfiguration of PHBs, PCI devices, memory, and CPUs. It is internally created by the spapr platform and requires to be owned by either the machine (PHBs, CPUs, memory) or by a PHB (PCI devices). Signed-off-by: Greg Kurz <groug@kaod.org> --- hw/ppc/spapr_drc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)