mbox series

[v2,0/4] MAINTAINERS: Update MIPS sections

Message ID 20201013101659.3557154-1-f4bug@amsat.org
Headers show
Series MAINTAINERS: Update MIPS sections | expand

Message

Philippe Mathieu-Daudé Oct. 13, 2020, 10:16 a.m. UTC
Volunteer to maintain MIPS TCG.
As discussed on list, Huacai will likely send a similar patch.

Few more adjustments (in particular around Boston board).

Based-on: <1602103041-32017-1-git-send-email-aleksandar.qemu.devel@gmail.com>
https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg01974.html

v2:
- Squashed Paul email address change with Boston downgrade (Thomas)

Philippe Mathieu-Daudé (4):
  MAINTAINERS: Put myself forward for MIPS target
  MAINTAINERS: Remove duplicated Malta test entries
  MAINTAINERS: Downgrade MIPS Boston to 'Odd Fixes', fix Paul Burton
    mail
  MAINTAINERS: Move MIPS GIC timer files to Boston board section

 MAINTAINERS | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

-- 
2.26.2

Comments

Thomas Huth Oct. 14, 2020, 12:54 p.m. UTC | #1
On 13/10/2020 12.16, Philippe Mathieu-Daudé wrote:
> The Malta tests are already covered in the Malta section.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d59e5c05c10..2de5943e388 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -238,8 +238,6 @@ F: include/hw/intc/mips_gic.h
>  F: include/hw/mips/
>  F: include/hw/misc/mips_*
>  F: include/hw/timer/mips_gictimer.h
> -F: tests/acceptance/linux_ssh_mips_malta.py
> -F: tests/acceptance/machine_mips_malta.py
>  F: tests/tcg/mips/
>  K: ^Subject:.*(?i)mips

Reviewed-by: Thomas Huth <thuth@redhat.com>
Jiaxun Yang Oct. 14, 2020, 3:13 p.m. UTC | #2
在 2020/10/13 18:16, Philippe Mathieu-Daudé 写道:
> To avoid the MIPS target being orphan, volunteer to keep an eye
> on it and put together pull requests.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Thanks for stepping out!

- Jiaxun

> ---
>   MAINTAINERS | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 426f52c1f63..d59e5c05c10 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -221,10 +221,11 @@ F: hw/microblaze/
>   F: disas/microblaze.c
>   
>   MIPS TCG CPUs
> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
>   R: Aurelien Jarno <aurelien@aurel32.net>
>   R: Jiaxun Yang <jiaxun.yang@flygoat.com>
>   R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
> -S: Orphaned
> +S: Odd Fixes
>   F: target/mips/
>   F: default-configs/*mips*
>   F: disas/*mips*
> @@ -2815,11 +2816,12 @@ F: tcg/i386/
>   F: disas/i386.c
>   
>   MIPS TCG target
> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
>   R: Aurelien Jarno <aurelien@aurel32.net>
>   R: Huacai Chen <chenhc@lemote.com>
>   R: Jiaxun Yang <jiaxun.yang@flygoat.com>
>   R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
> -S: Orphaned
> +S: Odd Fixes
>   F: tcg/mips/
>   
>   PPC TCG target
Philippe Mathieu-Daudé Oct. 14, 2020, 3:41 p.m. UTC | #3
On 10/14/20 5:13 PM, Jiaxun Yang wrote:
> 在 2020/10/13 18:16, Philippe Mathieu-Daudé 写道:

>> To avoid the MIPS target being orphan, volunteer to keep an eye

>> on it and put together pull requests.

>>

>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> 

> Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

> 

> Thanks for stepping out!


😥 in?

> 

> - Jiaxun

> 

>> ---

>>   MAINTAINERS | 6 ++++--

>>   1 file changed, 4 insertions(+), 2 deletions(-)

>>

>> diff --git a/MAINTAINERS b/MAINTAINERS

>> index 426f52c1f63..d59e5c05c10 100644

>> --- a/MAINTAINERS

>> +++ b/MAINTAINERS

>> @@ -221,10 +221,11 @@ F: hw/microblaze/

>>   F: disas/microblaze.c

>>   MIPS TCG CPUs

>> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>

>>   R: Aurelien Jarno <aurelien@aurel32.net>

>>   R: Jiaxun Yang <jiaxun.yang@flygoat.com>

>>   R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>

>> -S: Orphaned

>> +S: Odd Fixes

>>   F: target/mips/

>>   F: default-configs/*mips*

>>   F: disas/*mips*

>> @@ -2815,11 +2816,12 @@ F: tcg/i386/

>>   F: disas/i386.c

>>   MIPS TCG target

>> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>

>>   R: Aurelien Jarno <aurelien@aurel32.net>

>>   R: Huacai Chen <chenhc@lemote.com>

>>   R: Jiaxun Yang <jiaxun.yang@flygoat.com>

>>   R: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>

>> -S: Orphaned

>> +S: Odd Fixes

>>   F: tcg/mips/

>>   PPC TCG target

>
Philippe Mathieu-Daudé Oct. 16, 2020, 1:43 p.m. UTC | #4
On 10/14/20 3:39 PM, Thomas Huth wrote:
> On 13/10/2020 12.16, Philippe Mathieu-Daudé wrote:
>> The MIPS GIC timer is only used by the Boston board.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>   MAINTAINERS | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 702f73823fc..62db288bfc4 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -233,11 +233,9 @@ F: docs/system/cpu-models-mips.rst.inc
>>   F: hw/intc/mips_gic.c
>>   F: hw/mips/
>>   F: hw/misc/mips_*
>> -F: hw/timer/mips_gictimer.c
>>   F: include/hw/intc/mips_gic.h
>>   F: include/hw/mips/
>>   F: include/hw/misc/mips_*
>> -F: include/hw/timer/mips_gictimer.h
>>   F: tests/tcg/mips/
>>   K: ^Subject:.*(?i)mips
>>   
>> @@ -1167,7 +1165,9 @@ S: Odd Fixes
>>   F: hw/core/loader-fit.c
>>   F: hw/mips/boston.c
>>   F: hw/pci-host/xilinx-pcie.c
>> +F: hw/timer/mips_gictimer.c
>>   F: include/hw/pci-host/xilinx-pcie.h
>> +F: include/hw/timer/mips_gictimer.h
> 
> If I grep for mips_gictimer_init, it seems like this function is used from
> mips_gic_realize in hw/intc/mips_gic.c ... and mips_gic.c / TYPE_MIPS_GIC is
> also used from the malta board ... so are you really sure this is right? Or
> what did I miss?

We have another Frankenstein :(
Philippe Mathieu-Daudé Oct. 16, 2020, 1:45 p.m. UTC | #5
On 10/13/20 12:16 PM, Philippe Mathieu-Daudé wrote:
> Volunteer to maintain MIPS TCG.

> As discussed on list, Huacai will likely send a similar patch.

> 

> Few more adjustments (in particular around Boston board).

> 

> Based-on: <1602103041-32017-1-git-send-email-aleksandar.qemu.devel@gmail.com>

> https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg01974.html

> 

> v2:

> - Squashed Paul email address change with Boston downgrade (Thomas)

> 

> Philippe Mathieu-Daudé (4):

>    MAINTAINERS: Put myself forward for MIPS target

>    MAINTAINERS: Remove duplicated Malta test entries

>    MAINTAINERS: Downgrade MIPS Boston to 'Odd Fixes', fix Paul Burton

>      mail

>    MAINTAINERS: Move MIPS GIC timer files to Boston board section


Thanks, patches 1-3 applied to mips-next.