diff mbox series

[2/9] dev-serial: use USB_SERIAL QOM macro for USBSerialState assignments

Message ID 20201026083401.13231-3-mark.cave-ayland@ilande.co.uk
State Superseded
Headers show
Series dev-serial: minor fixes and improvements | expand

Commit Message

Mark Cave-Ayland Oct. 26, 2020, 8:33 a.m. UTC 
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 hw/usb/dev-serial.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Samuel Thibault Oct. 26, 2020, 9:37 a.m. UTC | #1 
Mark Cave-Ayland, le lun. 26 oct. 2020 08:33:54 +0000, a ecrit:
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>


> ---

>  hw/usb/dev-serial.c | 6 +++---

>  1 file changed, 3 insertions(+), 3 deletions(-)

> 

> diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c

> index 7a5fa3770e..77ce89d38b 100644

> --- a/hw/usb/dev-serial.c

> +++ b/hw/usb/dev-serial.c

> @@ -204,7 +204,7 @@ static void usb_serial_reset(USBSerialState *s)

>  

>  static void usb_serial_handle_reset(USBDevice *dev)

>  {

> -    USBSerialState *s = (USBSerialState *)dev;

> +    USBSerialState *s = USB_SERIAL(dev);

>  

>      DPRINTF("Reset\n");

>  

> @@ -243,7 +243,7 @@ static void usb_serial_handle_control(USBDevice *dev, USBPacket *p,

>                                        int request, int value, int index,

>                                        int length, uint8_t *data)

>  {

> -    USBSerialState *s = (USBSerialState *)dev;

> +    USBSerialState *s = USB_SERIAL(dev);

>      int ret;

>  

>      DPRINTF("got control %x, value %x\n", request, value);

> @@ -430,7 +430,7 @@ static void usb_serial_token_in(USBSerialState *s, USBPacket *p)

>  

>  static void usb_serial_handle_data(USBDevice *dev, USBPacket *p)

>  {

> -    USBSerialState *s = (USBSerialState *)dev;

> +    USBSerialState *s = USB_SERIAL(dev);

>      uint8_t devep = p->ep->nr;

>      struct iovec *iov;

>      int i;

> -- 

> 2.20.1

> 


-- 
Samuel
<h> t: bah c'est tendre le pattern pour se faire matcher, hein
Philippe Mathieu-Daudé Oct. 27, 2020, 9:04 a.m. UTC | #2 
On 10/26/20 9:33 AM, Mark Cave-Ayland wrote:
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

> ---

>  hw/usb/dev-serial.c | 6 +++---

>  1 file changed, 3 insertions(+), 3 deletions(-)


Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
diff mbox series

Patch

diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c
index 7a5fa3770e..77ce89d38b 100644
--- a/hw/usb/dev-serial.c
+++ b/hw/usb/dev-serial.c
@@ -204,7 +204,7 @@  static void usb_serial_reset(USBSerialState *s)
 
 static void usb_serial_handle_reset(USBDevice *dev)
 {
-    USBSerialState *s = (USBSerialState *)dev;
+    USBSerialState *s = USB_SERIAL(dev);
 
     DPRINTF("Reset\n");
 
@@ -243,7 +243,7 @@  static void usb_serial_handle_control(USBDevice *dev, USBPacket *p,
                                       int request, int value, int index,
                                       int length, uint8_t *data)
 {
-    USBSerialState *s = (USBSerialState *)dev;
+    USBSerialState *s = USB_SERIAL(dev);
     int ret;
 
     DPRINTF("got control %x, value %x\n", request, value);
@@ -430,7 +430,7 @@  static void usb_serial_token_in(USBSerialState *s, USBPacket *p)
 
 static void usb_serial_handle_data(USBDevice *dev, USBPacket *p)
 {
-    USBSerialState *s = (USBSerialState *)dev;
+    USBSerialState *s = USB_SERIAL(dev);
     uint8_t devep = p->ep->nr;
     struct iovec *iov;
     int i;