| Message ID | 20201023114017.GE18329@kadam |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2,v2] usb: typec: stusb160x: fix an IS_ERR() vs NULL check in probe | expand |
On Fri, Oct 23, 2020 at 02:40:17PM +0300, Dan Carpenter wrote: > The typec_register_port() function doesn't return NULL, it returns error > pointers. > > Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Ah, sorry. You had already fixed the commit message. Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > v2: Fix a typo in the commit message. s/return error pointers/return NULL/. > Thanks, Walter! > > drivers/usb/typec/stusb160x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c > index ce0bd7b3ad88..f7369e371dd4 100644 > --- a/drivers/usb/typec/stusb160x.c > +++ b/drivers/usb/typec/stusb160x.c > @@ -729,8 +729,8 @@ static int stusb160x_probe(struct i2c_client *client) > } > > chip->port = typec_register_port(chip->dev, &chip->capability); > - if (!chip->port) { > - ret = -ENODEV; > + if (IS_ERR(chip->port)) { > + ret = PTR_ERR(chip->port); > goto all_reg_disable; > } > > -- > 2.28.0 thanks,
Hi Dan, Thanks for the patch! On 10/23/20 1:40 PM, Dan Carpenter wrote: > The typec_register_port() function doesn't return NULL, it returns error > pointers. > > Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Amelie Delaunay <amelie.delaunay@st.com> > --- > v2: Fix a typo in the commit message. s/return error pointers/return NULL/. > Thanks, Walter! > > drivers/usb/typec/stusb160x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c > index ce0bd7b3ad88..f7369e371dd4 100644 > --- a/drivers/usb/typec/stusb160x.c > +++ b/drivers/usb/typec/stusb160x.c > @@ -729,8 +729,8 @@ static int stusb160x_probe(struct i2c_client *client) > } > > chip->port = typec_register_port(chip->dev, &chip->capability); > - if (!chip->port) { > - ret = -ENODEV; > + if (IS_ERR(chip->port)) { > + ret = PTR_ERR(chip->port); > goto all_reg_disable; > } > >
diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c index ce0bd7b3ad88..f7369e371dd4 100644 --- a/drivers/usb/typec/stusb160x.c +++ b/drivers/usb/typec/stusb160x.c @@ -729,8 +729,8 @@ static int stusb160x_probe(struct i2c_client *client) } chip->port = typec_register_port(chip->dev, &chip->capability); - if (!chip->port) { - ret = -ENODEV; + if (IS_ERR(chip->port)) { + ret = PTR_ERR(chip->port); goto all_reg_disable; }
The typec_register_port() function doesn't return NULL, it returns error pointers. Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- v2: Fix a typo in the commit message. s/return error pointers/return NULL/. Thanks, Walter! drivers/usb/typec/stusb160x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)