diff mbox series

[net-next] r8169: align number of tx descriptors with vendor driver

Message ID a52a6de4-f792-5038-ae2f-240d3b7860eb@gmail.com
State New
Headers show
Series [net-next] r8169: align number of tx descriptors with vendor driver | expand

Commit Message

Heiner Kallweit Nov. 1, 2020, 10:23 p.m. UTC
Lowest number of tx descriptors used in the vendor drivers is 256 in
r8169. r8101/r8168/r8125 use 1024 what seems to be the hw limit. Stay
on the safe side and go with 256, same as number of rx descriptors.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/ethernet/realtek/r8169_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski Nov. 4, 2020, 1:37 a.m. UTC | #1
On Sun, 1 Nov 2020 23:23:52 +0100 Heiner Kallweit wrote:
> Lowest number of tx descriptors used in the vendor drivers is 256 in

> r8169. r8101/r8168/r8125 use 1024 what seems to be the hw limit. Stay

> on the safe side and go with 256, same as number of rx descriptors.

> 

> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>


Applied, thanks!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index ecdc0c36c..a426eed78 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -67,7 +67,7 @@ 
 
 #define R8169_REGS_SIZE		256
 #define R8169_RX_BUF_SIZE	(SZ_16K - 1)
-#define NUM_TX_DESC	64	/* Number of Tx descriptor registers */
+#define NUM_TX_DESC	256	/* Number of Tx descriptor registers */
 #define NUM_RX_DESC	256U	/* Number of Rx descriptor registers */
 #define R8169_TX_RING_BYTES	(NUM_TX_DESC * sizeof(struct TxDesc))
 #define R8169_RX_RING_BYTES	(NUM_RX_DESC * sizeof(struct RxDesc))