| Message ID | 20201104092948.8560-1-vulab@iscas.ac.cn |
|---|---|
| State | Accepted |
| Commit | b5c17905fb97e4e3c2fccdd168f6d2e7d54076e5 |
| Headers | show |
| Series | media: i2c: mt9p031: Remove redundant null check before clk_disable_unprepare | expand |
Hi Xu Wang, Thank you for the patch. On Wed, Nov 04, 2020 at 09:29:48AM +0000, Xu Wang wrote: > Because clk_disable_unprepare() already checked NULL clock parameter, > so the additional check is unnecessary, just remove it. > > Signed-off-by: Xu Wang <vulab@iscas.ac.cn> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> I expect Sakari will pick this patch. > --- > drivers/media/i2c/mt9p031.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c > index dc23b9ed510a..a633b934d93e 100644 > --- a/drivers/media/i2c/mt9p031.c > +++ b/drivers/media/i2c/mt9p031.c > @@ -346,8 +346,7 @@ static void mt9p031_power_off(struct mt9p031 *mt9p031) > regulator_bulk_disable(ARRAY_SIZE(mt9p031->regulators), > mt9p031->regulators); > > - if (mt9p031->clk) > - clk_disable_unprepare(mt9p031->clk); > + clk_disable_unprepare(mt9p031->clk); > } > > static int __mt9p031_set_power(struct mt9p031 *mt9p031, bool on) -- Regards, Laurent Pinchart
diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index dc23b9ed510a..a633b934d93e 100644 --- a/drivers/media/i2c/mt9p031.c +++ b/drivers/media/i2c/mt9p031.c @@ -346,8 +346,7 @@ static void mt9p031_power_off(struct mt9p031 *mt9p031) regulator_bulk_disable(ARRAY_SIZE(mt9p031->regulators), mt9p031->regulators); - if (mt9p031->clk) - clk_disable_unprepare(mt9p031->clk); + clk_disable_unprepare(mt9p031->clk); } static int __mt9p031_set_power(struct mt9p031 *mt9p031, bool on)
Because clk_disable_unprepare() already checked NULL clock parameter, so the additional check is unnecessary, just remove it. Signed-off-by: Xu Wang <vulab@iscas.ac.cn> --- drivers/media/i2c/mt9p031.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)