| Message ID | 20201107083432.3175710-1-ndesaulniers@google.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ACPI: GED: fix -Wformat | expand |
On Sat, 7 Nov 2020 at 09:34, Nick Desaulniers <ndesaulniers@google.com> wrote: > > Clang is more aggressive about -Wformat warnings when the format flag > specifies a type smaller than the parameter. It turns out that gsi is an > int. Fixes: > > drivers/acpi/evged.c:105:48: warning: format specifies type 'unsigned > char' but the argument has type 'unsigned int' [-Wformat] > trigger == ACPI_EDGE_SENSITIVE ? 'E' : 'L', gsi); > ^~~ > > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > Fixes: commit ea6f3af4c5e6 ("ACPI: GED: add support for _Exx / _Lxx handler methods") Please drop the word 'commit' here > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Acked-by: Ard Biesheuvel <ardb@kernel.org> > --- > drivers/acpi/evged.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/evged.c b/drivers/acpi/evged.c > index b1a7f8d6965e..fe6b6792c8bb 100644 > --- a/drivers/acpi/evged.c > +++ b/drivers/acpi/evged.c > @@ -101,7 +101,7 @@ static acpi_status acpi_ged_request_interrupt(struct acpi_resource *ares, > > switch (gsi) { > case 0 ... 255: > - sprintf(ev_name, "_%c%02hhX", > + sprintf(ev_name, "_%c%02X", > trigger == ACPI_EDGE_SENSITIVE ? 'E' : 'L', gsi); > > if (ACPI_SUCCESS(acpi_get_handle(handle, ev_name, &evt_handle))) > -- > 2.29.2.222.g5d2a92d10f8-goog >
diff --git a/drivers/acpi/evged.c b/drivers/acpi/evged.c index b1a7f8d6965e..fe6b6792c8bb 100644 --- a/drivers/acpi/evged.c +++ b/drivers/acpi/evged.c @@ -101,7 +101,7 @@ static acpi_status acpi_ged_request_interrupt(struct acpi_resource *ares, switch (gsi) { case 0 ... 255: - sprintf(ev_name, "_%c%02hhX", + sprintf(ev_name, "_%c%02X", trigger == ACPI_EDGE_SENSITIVE ? 'E' : 'L', gsi); if (ACPI_SUCCESS(acpi_get_handle(handle, ev_name, &evt_handle)))
Clang is more aggressive about -Wformat warnings when the format flag specifies a type smaller than the parameter. It turns out that gsi is an int. Fixes: drivers/acpi/evged.c:105:48: warning: format specifies type 'unsigned char' but the argument has type 'unsigned int' [-Wformat] trigger == ACPI_EDGE_SENSITIVE ? 'E' : 'L', gsi); ^~~ Link: https://github.com/ClangBuiltLinux/linux/issues/378 Fixes: commit ea6f3af4c5e6 ("ACPI: GED: add support for _Exx / _Lxx handler methods") Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> --- drivers/acpi/evged.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.29.2.222.g5d2a92d10f8-goog