diff mbox

ODP build fails with the latest patches

Message ID CA+iXiiOUxaPWN2WOqim6JFQ_0+Cux4M9sFjq2k=Ki-M2beaJiQ@mail.gmail.com
State Accepted, archived
Headers show

Commit Message

Santosh Shukla March 14, 2014, 5 a.m. UTC 
I didn't saw build break in local build and my build env got -Werror
flag check enabled, Is jenkins has different setting?

Fix could be nothing beyond typecasting.

Petri, Can you confirm above build fix ?

Thanks.

On 13 March 2014 21:41, Mike Holmes <mike.holmes@linaro.org> wrote:
> https://ci.linaro.org/jenkins/job/odp-api-gcc-check-be/label=x86/23/console
>
> See
> <https://ci.linaro.org/jenkins/job/odp-api-gcc-check-be/label=x86/23/changes>
>
> Changes:
>
> [santosh.shukla] Packet IO test core count option
>
> [santosh.shukla] Timer API first draft
>
> [santosh.shukla] Timer implementation first draft
>
> [santosh.shukla] Add STD_LIBS into test app makefiles
>
> --
> You received this message because you are subscribed to the Google Groups
> "LNG ODP Sub-team - lng-odp@linaro.org" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to lng-odp+unsubscribe@linaro.org.
> To post to this group, send email to lng-odp@linaro.org.
> Visit this group at http://groups.google.com/a/linaro.org/group/lng-odp/.
> To view this discussion on the web visit
> https://groups.google.com/a/linaro.org/d/msgid/lng-odp/CADz3at1jvCf2HOeXb6G9UF4dMwtdEUjTkak1EhoemD-rGnN3aQ%40mail.gmail.com.
> For more options, visit https://groups.google.com/a/linaro.org/d/optout.

Comments

Petri Savolainen March 14, 2014, 7:32 a.m. UTC | #1 
Hi,

It seems that you have applied v1 instead of v2 of the patch.

-Petri


On Friday, 14 March 2014 07:00:01 UTC+2, Santosh Shukla wrote:
>
> I didn't saw build break in local build and my build env got -Werror 
> flag check enabled, Is jenkins has different setting? 
>
> Fix could be nothing beyond typecasting. 
>
> --- a/platform/linux-generic/source/odp_timer.c 
> +++ b/platform/linux-generic/source/odp_timer.c 
> @@ -250,7 +250,7 @@ odp_timer_tmo_t odp_timer_absolute_tmo(odp_timer_t 
> timer, uint64_t tmo_tick, 
>
>         add_tmo(&odp_timer.timer[id].tick[tick], new_tmo); 
>
> -       return (odp_timer_tmo_t) new_tmo; 
> +       return (odp_timer_tmo_t) new_tmo->timer_id; 
>  } 
>
> Petri, Can you confirm above build fix ? 
>
> Thanks. 
>
> On 13 March 2014 21:41, Mike Holmes <mike....@linaro.org <javascript:>> 
> wrote: 
> > 
> https://ci.linaro.org/jenkins/job/odp-api-gcc-check-be/label=x86/23/console 
> > 
> > See 
> > <
> https://ci.linaro.org/jenkins/job/odp-api-gcc-check-be/label=x86/23/changes> 
>
> > 
> > Changes: 
> > 
> > [santosh.shukla] Packet IO test core count option 
> > 
> > [santosh.shukla] Timer API first draft 
> > 
> > [santosh.shukla] Timer implementation first draft 
> > 
> > [santosh.shukla] Add STD_LIBS into test app makefiles 
> > 
> > -- 
> > You received this message because you are subscribed to the Google 
> Groups 
> > "LNG ODP Sub-team - lng...@linaro.org <javascript:>" group. 
> > To unsubscribe from this group and stop receiving emails from it, send 
> an 
> > email to lng-odp+u...@linaro.org <javascript:>. 
> > To post to this group, send email to lng...@linaro.org <javascript:>. 
> > Visit this group at http://groups.google.com/a/linaro.org/group/lng-odp/. 
>
> > To view this discussion on the web visit 
> > 
> https://groups.google.com/a/linaro.org/d/msgid/lng-odp/CADz3at1jvCf2HOeXb6G9UF4dMwtdEUjTkak1EhoemD-rGnN3aQ%40mail.gmail.com. 
>
> > For more options, visit https://groups.google.com/a/linaro.org/d/optout. 
>
>
Mike Holmes March 14, 2014, 11:42 a.m. UTC | #2 
flag check enabled, Is jenkins has different setting?

Yes,
Jenkins cross compiles ARM, native builds ARM and X86 and builds big endian.


Mike


On 14 March 2014 03:32, Petri Savolainen <petri.savolainen@linaro.org>wrote:

> Hi,
>
> It seems that you have applied v1 instead of v2 of the patch.
>
> -Petri
>
>
>
> On Friday, 14 March 2014 07:00:01 UTC+2, Santosh Shukla wrote:
>
>> I didn't saw build break in local build and my build env got -Werror
>> flag check enabled, Is jenkins has different setting?
>>
>> Fix could be nothing beyond typecasting.
>>
>> --- a/platform/linux-generic/source/odp_timer.c
>> +++ b/platform/linux-generic/source/odp_timer.c
>> @@ -250,7 +250,7 @@ odp_timer_tmo_t odp_timer_absolute_tmo(odp_timer_t
>> timer, uint64_t tmo_tick,
>>
>>         add_tmo(&odp_timer.timer[id].tick[tick], new_tmo);
>>
>> -       return (odp_timer_tmo_t) new_tmo;
>> +       return (odp_timer_tmo_t) new_tmo->timer_id;
>>  }
>>
>> Petri, Can you confirm above build fix ?
>>
>> Thanks.
>>
>> On 13 March 2014 21:41, Mike Holmes <mike....@linaro.org> wrote:
>> > https://ci.linaro.org/jenkins/job/odp-api-gcc-check-be/
>> label=x86/23/console
>> >
>> > See
>> > <https://ci.linaro.org/jenkins/job/odp-api-gcc-check-
>> be/label=x86/23/changes>
>> >
>> > Changes:
>> >
>> > [santosh.shukla] Packet IO test core count option
>> >
>> > [santosh.shukla] Timer API first draft
>> >
>> > [santosh.shukla] Timer implementation first draft
>> >
>> > [santosh.shukla] Add STD_LIBS into test app makefiles
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> Groups
>> > "LNG ODP Sub-team - lng...@linaro.org" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> an
>> > email to lng-odp+u...@linaro.org.
>> > To post to this group, send email to lng...@linaro.org.
>> > Visit this group at http://groups.google.com/a/
>> linaro.org/group/lng-odp/.
>> > To view this discussion on the web visit
>> > https://groups.google.com/a/linaro.org/d/msgid/lng-odp/
>> CADz3at1jvCf2HOeXb6G9UF4dMwtdEUjTkak1EhoemD-rGnN3aQ%40mail.gmail.com.
>> > For more options, visit https://groups.google.com/a/linaro.org/d/optout.
>>
>>
>
diff mbox

Patch

--- a/platform/linux-generic/source/odp_timer.c
+++ b/platform/linux-generic/source/odp_timer.c
@@ -250,7 +250,7 @@  odp_timer_tmo_t odp_timer_absolute_tmo(odp_timer_t
timer, uint64_t tmo_tick,

        add_tmo(&odp_timer.timer[id].tick[tick], new_tmo);

-       return (odp_timer_tmo_t) new_tmo;
+       return (odp_timer_tmo_t) new_tmo->timer_id;
 }