mbox series

[v11,0/7] soc: mediatek: SVS: introduce MTK SVS

Message ID 20210107024356.583-1-roger.lu@mediatek.com
Headers show
Series soc: mediatek: SVS: introduce MTK SVS | expand

Message

Roger Lu Jan. 7, 2021, 2:43 a.m. UTC 
1. SVS driver uses OPP adjust event in [1] to update OPP table voltage part.
2. SVS driver gets thermal/GPU device by node [2][3] and CPU device by
get_cpu_device(). After retrieving subsys device, SVS driver does
device_link_add() to make sure probe/suspend callback priority.
3. SVS dts refers to reset controller [4] to help reset SVS HW.

#mt8183 SVS related patches
[1] https://patchwork.kernel.org/patch/11193513/
[2] https://patchwork.kernel.org/project/linux-mediatek/patch/20201013102358.22588-2-michael.kao@mediatek.com/
[3] https://patchwork.kernel.org/project/linux-mediatek/patch/20200306041345.259332-3-drinkcat@chromium.org/

#mt8192 SVS related patches
[1] https://patchwork.kernel.org/patch/11193513/
[2] https://patchwork.kernel.org/project/linux-mediatek/patch/20201223074944.2061-1-michael.kao@mediatek.com/
[3] https://lore.kernel.org/patchwork/patch/1360551/
[4] https://patchwork.kernel.org/project/linux-mediatek/patch/20200817030324.5690-5-crystal.guo@mediatek.com/

changes since v10:
- Fix typos and remove duplicate GENASK()
- Use DIV_ROUND_UP instead of creating own math
- Remove fake_efuse related codes and some type casting
- Optimize svs_get_vops_v2() coding
- Check "supplier links.status DL_DEV_DRIVER_BOUND" to make
sure supplier is ready after doing device_link_add()

Roger Lu (7):
  [v11,1/7]: dt-bindings: soc: mediatek: add mtk svs dt-bindings
  [v11,2/7]: arm64: dts: mt8183: add svs device information
  [v11,3/7]: soc: mediatek: SVS: introduce MTK SVS engine
  [v11,4/7]: soc: mediatek: SVS: add debug commands
  [v11,5/7]: dt-bindings: soc: mediatek: add mt8192 svs dt-bindings
  [v11,6/7]: arm64: dts: mt8192: add svs device information
  [v11,7/7]: soc: mediatek: SVS: add mt8192 SVS GPU driver

 .../bindings/soc/mediatek/mtk-svs.yaml        |   89 +
 arch/arm64/boot/dts/mediatek/mt8183.dtsi      |   18 +
 arch/arm64/boot/dts/mediatek/mt8192.dtsi      |   34 +
 drivers/soc/mediatek/Kconfig                  |   10 +
 drivers/soc/mediatek/Makefile                 |    1 +
 drivers/soc/mediatek/mtk-svs.c                | 2492 +++++++++++++++++
 6 files changed, 2644 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml
 create mode 100644 drivers/soc/mediatek/mtk-svs.c

Comments

Rob Herring (Arm) Jan. 12, 2021, 2:48 p.m. UTC | #1 
On Thu, Jan 07, 2021 at 10:43:54AM +0800, Roger Lu wrote:
> Signed-off-by: Roger Lu <roger.lu@mediatek.com>

> ---

>  .../devicetree/bindings/soc/mediatek/mtk-svs.yaml        | 9 +++++++++

>  1 file changed, 9 insertions(+)

> 

> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml b/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml

> index bb8c345a0c0a..2e61b07921aa 100644

> --- a/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml

> +++ b/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml

> @@ -22,6 +22,7 @@ properties:

>    compatible:

>      enum:

>        - mediatek,mt8183-svs

> +      - mediatek,mt8192-svs

>  

>    reg:

>      description: Address range of the MTK SVS controller.

> @@ -47,6 +48,14 @@ properties:

>        - const: svs-calibration-data

>        - const: t-calibration-data

>  

> +  resets:

> +    description:

> +      svs reset control.


How many?

And you can drop the description given there's only 1.

> +

> +  reset-names:

> +    items:

> +      - const: svs_rst

> +

>  required:

>    - compatible

>    - reg

> -- 

> 2.18.0

>