diff mbox

[Xen-devel,OSSTEST] Debian: die if we are unable to find the override kernel deb

Message ID 1395138176-20111-1-git-send-email-ian.campbell@citrix.com
State New
Headers show

Commit Message

Ian Campbell March 18, 2014, 10:22 a.m. UTC
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 Osstest/Debian.pm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Ian Jackson March 18, 2014, 11:08 a.m. UTC | #1
Ian Campbell writes ("[PATCH OSSTEST] Debian: die if we are unable to find the override kernel deb"):
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

It looks like I misunderstood File::Copy's error behaviour.

Thanks,
Ian.
Ian Campbell March 18, 2014, 11:10 a.m. UTC | #2
On Tue, 2014-03-18 at 11:08 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST] Debian: die if we are unable to find the override kernel deb"):
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Thanks.

> It looks like I misunderstood File::Copy's error behaviour.

I think that was me...

Ian.
diff mbox

Patch

diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm
index 6759263..336043c 100644
--- a/Osstest/Debian.pm
+++ b/Osstest/Debian.pm
@@ -557,11 +557,13 @@  END
 	my $d_i= $c{TftpPath}.'/'.$c{TftpDiBase}.'/'.$r{arch}.'/'.$c{TftpDiVersion}.'-'.$ho->{Suite};
 
 	my $kurl = create_webfile($ho, "kernel", sub {
-	    copy("$d_i/$kp.deb", $_[0]);
+	    copy("$d_i/$kp.deb", $_[0])
+		or die "Copy kernel failed: $!";
         });
 
 	my $iurl = create_webfile($ho, "initramfs-tools", sub {
-	    copy("$d_i/initramfs-tools.deb", $_[0]);
+	    copy("$d_i/initramfs-tools.deb", $_[0])
+		or die "Copy initramfs-tools failed: $!";
         });
 
 	preseed_hook_command($ho, 'late_command', $sfx, <<END);