diff mbox series

[v2,3/4] rcar-vin: Stop stream when subdevice signal EOS

Message ID 20210115002148.4079591-4-niklas.soderlund+renesas@ragnatech.se
State New
Headers show
Series rcar-csi2: Update handling of transfer error | expand

Commit Message

Niklas Söderlund Jan. 15, 2021, 12:21 a.m. UTC 
When a subdevice signals end of stream stop the VIN in addition to
informing user-space of the event.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 drivers/media/platform/rcar-vin/rcar-v4l2.c | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

Comments

Hans Verkuil Jan. 25, 2021, 9:37 a.m. UTC | #1 
On 15/01/2021 01:21, Niklas Söderlund wrote:
> When a subdevice signals end of stream stop the VIN in addition to

> informing user-space of the event.

> 

> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

> ---

>  drivers/media/platform/rcar-vin/rcar-v4l2.c | 16 +++++++++++++++-

>  1 file changed, 15 insertions(+), 1 deletion(-)

> 

> diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c

> index 457a65bf6b664f05..176eae2dd5151ac9 100644

> --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c

> +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c

> @@ -969,9 +969,23 @@ void rvin_v4l2_unregister(struct rvin_dev *vin)

>  static void rvin_notify_video_device(struct rvin_dev *vin,

>  				     unsigned int notification, void *arg)

>  {

> +	const struct v4l2_event *event;

> +

>  	switch (notification) {

>  	case V4L2_DEVICE_NOTIFY_EVENT:

> -		v4l2_event_queue(&vin->vdev, arg);

> +		event = arg;

> +

> +		switch (event->type) {

> +		case V4L2_EVENT_EOS:

> +			rvin_stop_streaming(vin);

> +			v4l2_info(&vin->v4l2_dev,


Can you make this v4l2_dbg to avoid polluting the kernel log?

Regards,

	Hans

> +				  "Subdevice signaled end of stream, stopping.\n");

> +			break;

> +		default:

> +			break;

> +		}

> +

> +		v4l2_event_queue(&vin->vdev, event);

>  		break;

>  	default:

>  		break;

>
diff mbox series

Patch

diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c
index 457a65bf6b664f05..176eae2dd5151ac9 100644
--- a/drivers/media/platform/rcar-vin/rcar-v4l2.c
+++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c
@@ -969,9 +969,23 @@  void rvin_v4l2_unregister(struct rvin_dev *vin)
 static void rvin_notify_video_device(struct rvin_dev *vin,
 				     unsigned int notification, void *arg)
 {
+	const struct v4l2_event *event;
+
 	switch (notification) {
 	case V4L2_DEVICE_NOTIFY_EVENT:
-		v4l2_event_queue(&vin->vdev, arg);
+		event = arg;
+
+		switch (event->type) {
+		case V4L2_EVENT_EOS:
+			rvin_stop_streaming(vin);
+			v4l2_info(&vin->v4l2_dev,
+				  "Subdevice signaled end of stream, stopping.\n");
+			break;
+		default:
+			break;
+		}
+
+		v4l2_event_queue(&vin->vdev, event);
 		break;
 	default:
 		break;