| Message ID | 20210203113426.18964-2-parazyd@dyne.org |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
* Ivan Jelincic <parazyd@dyne.org> [210203 13:35]: > Update omap2plus_defconfig for options that have been dropped: > > - SIMPLE_PM_BUS no longer selected. Oh right, we now need to always select it. Will queue this for fixes after the merge window. The other one I'll be queueing for v5.13 as the merge window is about to open and I'll only queue fixes for the next few weeks :) Regards, Tony
On 04/02/2021 08:56, Tony Lindgren wrote: > * Ivan Jelincic <parazyd@dyne.org> [210203 13:35]: >> Update omap2plus_defconfig for options that have been dropped: >> >> - SIMPLE_PM_BUS no longer selected. > > Oh right, we now need to always select it. Will queue this for > fixes after the merge window. The other one I'll be queueing > for v5.13 as the merge window is about to open and I'll only > queue fixes for the next few weeks :) "- MICREL_PHY no longer selected." I do not agree with above as MICREL_PHY is selected by KS8851, but on many boards there is no explicit dependency from KS8851, but MICREL PHYs are in use. So, I'd prefer to have it enabled explicitly in omap2plus_defconfig. And not sure what exactly "no longer selected" means. -- Best regards, grygorii
On Fri, Feb 05, 2021 at 03:15:00PM +0200, Grygorii Strashko wrote: > > > On 04/02/2021 08:56, Tony Lindgren wrote: > > * Ivan Jelincic <parazyd@dyne.org> [210203 13:35]: > > > Update omap2plus_defconfig for options that have been dropped: > > > > > > - SIMPLE_PM_BUS no longer selected. > > > > Oh right, we now need to always select it. Will queue this for > > fixes after the merge window. The other one I'll be queueing > > for v5.13 as the merge window is about to open and I'll only > > queue fixes for the next few weeks :) > > "- MICREL_PHY no longer selected." > > I do not agree with above as MICREL_PHY is selected by KS8851, but on many boards there is no > explicit dependency from KS8851, but MICREL PHYs are in use. > So, I'd prefer to have it enabled explicitly in omap2plus_defconfig. > > And not sure what exactly "no longer selected" means. "no longer selected" means it went away after `make savedefconfig`. Best regards, Ivan
* Ivan J. <parazyd@dyne.org> [210205 13:18]: > On Fri, Feb 05, 2021 at 03:15:00PM +0200, Grygorii Strashko wrote: > > > > > > On 04/02/2021 08:56, Tony Lindgren wrote: > > > * Ivan Jelincic <parazyd@dyne.org> [210203 13:35]: > > > > Update omap2plus_defconfig for options that have been dropped: > > > > > > > > - SIMPLE_PM_BUS no longer selected. > > > > > > Oh right, we now need to always select it. Will queue this for > > > fixes after the merge window. The other one I'll be queueing > > > for v5.13 as the merge window is about to open and I'll only > > > queue fixes for the next few weeks :) > > > > "- MICREL_PHY no longer selected." > > > > I do not agree with above as MICREL_PHY is selected by KS8851, but on many boards there is no > > explicit dependency from KS8851, but MICREL PHYs are in use. > > So, I'd prefer to have it enabled explicitly in omap2plus_defconfig. > > > > And not sure what exactly "no longer selected" means. > > "no longer selected" means it went away after `make savedefconfig`. Grgorii, maybe send a patch selecting MICREL_PHY in the Kconfig for the other cases that do not use KS8851? Regards, Tony
Hi Tony, On 05/02/2021 15:30, Tony Lindgren wrote: > * Ivan J. <parazyd@dyne.org> [210205 13:18]: >> On Fri, Feb 05, 2021 at 03:15:00PM +0200, Grygorii Strashko wrote: >>> >>> >>> On 04/02/2021 08:56, Tony Lindgren wrote: >>>> * Ivan Jelincic <parazyd@dyne.org> [210203 13:35]: >>>>> Update omap2plus_defconfig for options that have been dropped: >>>>> >>>>> - SIMPLE_PM_BUS no longer selected. >>>> >>>> Oh right, we now need to always select it. Will queue this for >>>> fixes after the merge window. The other one I'll be queueing >>>> for v5.13 as the merge window is about to open and I'll only >>>> queue fixes for the next few weeks :) >>> >>> "- MICREL_PHY no longer selected." >>> >>> I do not agree with above as MICREL_PHY is selected by KS8851, but on many boards there is no >>> explicit dependency from KS8851, but MICREL PHYs are in use. >>> So, I'd prefer to have it enabled explicitly in omap2plus_defconfig. >>> >>> And not sure what exactly "no longer selected" means. >> >> "no longer selected" means it went away after `make savedefconfig`. > > Grgorii, maybe send a patch selecting MICREL_PHY in the Kconfig > for the other cases that do not use KS8851? The KS8851 config was added like 10years ago and is used on some omap4 platforms, it does select MICREL_PHY. From other side, *some* am57x, am437 platforms uses MICREL PHYs with no dependency from KS8851. The omap2plus_defconfig is also used as base for custom configs and first thing people are doing - remove not needed options. As result, removal of KS8851 plus this patch will immediately cause MICREL_PHY=n and so breakage on existing and custom platforms. I do not see how it can be resolved by using Kconfig changes within much-omap2. So, sry, but NACK for this patch as it is. if some Kconfig dependencies need to be sorted out - probably the best way might be to get rid of select MICREL_PHY in KS8851/KS8851_MLL. -- Best regards, grygorii
* Grygorii Strashko <grygorii.strashko@ti.com> [210205 14:25]: > On 05/02/2021 15:30, Tony Lindgren wrote: > > Grgorii, maybe send a patch selecting MICREL_PHY in the Kconfig > > for the other cases that do not use KS8851? > > The KS8851 config was added like 10years ago and is used on some omap4 platforms, > it does select MICREL_PHY. > > From other side, *some* am57x, am437 platforms uses MICREL PHYs with no dependency from KS8851. > > The omap2plus_defconfig is also used as base for custom configs and first thing people are doing - > remove not needed options. As result, removal of KS8851 plus this patch will immediately > cause MICREL_PHY=n and so breakage on existing and custom platforms. > > I do not see how it can be resolved by using Kconfig changes within much-omap2. > > So, sry, but NACK for this patch as it is. We can wait on this patch no problem while we figure this out. But certainly we need to fix things so make savedefconfig produces valid configs that don't need to be manually edited. > if some Kconfig dependencies need to be sorted out - probably the best way might be > to get rid of select MICREL_PHY in KS8851/KS8851_MLL. That will potentially break things too as the configs now expect it to be selected :) Looks like that got changed with commit f0791b92d2b6 ("net: ks8851: Select PHYLIB and MICREL_PHY in Kconfig"). So why can't we do similar patches to select MICREL_PHY for the other non-ks8851 configurations in drivers/net/ethernet Kconfig files as needed? Regards, Tony
On 05/02/2021 16:46, Tony Lindgren wrote: > * Grygorii Strashko <grygorii.strashko@ti.com> [210205 14:25]: >> On 05/02/2021 15:30, Tony Lindgren wrote: >>> Grgorii, maybe send a patch selecting MICREL_PHY in the Kconfig >>> for the other cases that do not use KS8851? >> >> The KS8851 config was added like 10years ago and is used on some omap4 platforms, >> it does select MICREL_PHY. >> >> From other side, *some* am57x, am437 platforms uses MICREL PHYs with no dependency from KS8851. >> >> The omap2plus_defconfig is also used as base for custom configs and first thing people are doing - >> remove not needed options. As result, removal of KS8851 plus this patch will immediately >> cause MICREL_PHY=n and so breakage on existing and custom platforms. >> >> I do not see how it can be resolved by using Kconfig changes within much-omap2. >> >> So, sry, but NACK for this patch as it is. > > We can wait on this patch no problem while we figure this out. > But certainly we need to fix things so make savedefconfig > produces valid configs that don't need to be manually edited. > >> if some Kconfig dependencies need to be sorted out - probably the best way might be >> to get rid of select MICREL_PHY in KS8851/KS8851_MLL. > > That will potentially break things too as the configs now expect > it to be selected :) Looks like that got changed with commit > f0791b92d2b6 ("net: ks8851: Select PHYLIB and MICREL_PHY in > Kconfig"). Yah. It's really has to be "depends on". > > So why can't we do similar patches to select MICREL_PHY for > the other non-ks8851 configurations in drivers/net/ethernet > Kconfig files as needed? because there is no dependency between Ethernet controller (CPSW) and Ethernet PHY - any MII capable PHY can be used with CPSW. -- Best regards, grygorii
* Grygorii Strashko <grygorii.strashko@ti.com> [210205 15:04]: > On 05/02/2021 16:46, Tony Lindgren wrote: > > That will potentially break things too as the configs now expect > > it to be selected :) Looks like that got changed with commit > > f0791b92d2b6 ("net: ks8851: Select PHYLIB and MICREL_PHY in > > Kconfig"). > > Yah. It's really has to be "depends on". Yeah that's almost always better than select for sure. > > So why can't we do similar patches to select MICREL_PHY for > > the other non-ks8851 configurations in drivers/net/ethernet > > Kconfig files as needed? > > because there is no dependency between Ethernet controller (CPSW) and > Ethernet PHY - any MII capable PHY can be used with CPSW. OK thanks for the info. Regards, Tony
diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig index 9847502d2c97..ac13cab9f69d 100644 --- a/arch/arm/configs/omap2plus_defconfig +++ b/arch/arm/configs/omap2plus_defconfig @@ -286,7 +286,6 @@ CONFIG_PCI_EPF_TEST=m CONFIG_DEVTMPFS=y CONFIG_DEVTMPFS_MOUNT=y CONFIG_OMAP_OCP2SCP=y -CONFIG_SIMPLE_PM_BUS=y CONFIG_CONNECTOR=m CONFIG_MTD=y CONFIG_MTD_CMDLINE_PARTS=y @@ -344,7 +343,6 @@ CONFIG_TI_CPSW_SWITCHDEV=y CONFIG_TI_CPTS=y # CONFIG_NET_VENDOR_VIA is not set # CONFIG_NET_VENDOR_WIZNET is not set -CONFIG_MICREL_PHY=y CONFIG_AT803X_PHY=y CONFIG_SMSC_PHY=y CONFIG_DP83848_PHY=y