| Message ID | 20210216164348.3018179-1-kai.vehmanen@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 8a353d7bafddb447fae136ca68899a6ba6187be6 |
| Headers | show |
| Series | ASoC: soc-pcm: fix hw param limits calculation for multi-DAI | expand |
Hi Kai > In case DPCM runtime has multiple CPU DAIs, dpcm_init_runtime_hw() > is called multiple times, once for each CPU DAI. This will > will lead to ignoring hw limits of all but the first DAI. > > Fix this by moving soc_pcm_hw_init() up by one level to > dpcm_init_runtime_hw(). > > Fixes: 140f553d1298 ("ASoC: soc-pcm: fix hwparams min/max init for dpcm") > Suggested-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> > --- Sorry I couldn't post patch because I had Holiday yesterday. Thank you for this patch ! I'm happy it could solve your issue. Thank you for your help !! Best regards --- Kuninori Morimoto
diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index 37094aeff440..14d85ca1e435 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -1531,10 +1531,12 @@ static void dpcm_init_runtime_hw(struct snd_pcm_runtime *runtime, { struct snd_pcm_hardware *hw = &runtime->hw; - soc_pcm_hw_init(hw); soc_pcm_hw_update_rate(hw, stream); soc_pcm_hw_update_chan(hw, stream); - soc_pcm_hw_update_format(hw, stream); + if (runtime->hw.formats) + runtime->hw.formats &= stream->formats; + else + runtime->hw.formats = stream->formats; } static void dpcm_runtime_merge_format(struct snd_pcm_substream *substream, @@ -1662,10 +1664,13 @@ static void dpcm_runtime_merge_rate(struct snd_pcm_substream *substream, static void dpcm_set_fe_runtime(struct snd_pcm_substream *substream) { struct snd_pcm_runtime *runtime = substream->runtime; + struct snd_pcm_hardware *hw = &runtime->hw; struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream); struct snd_soc_dai *cpu_dai; int i; + soc_pcm_hw_init(hw); + for_each_rtd_cpu_dais(rtd, i, cpu_dai) { /* * Skip CPUs which don't support the current stream
In case DPCM runtime has multiple CPU DAIs, dpcm_init_runtime_hw() is called multiple times, once for each CPU DAI. This will will lead to ignoring hw limits of all but the first DAI. Fix this by moving soc_pcm_hw_init() up by one level to dpcm_init_runtime_hw(). Fixes: 140f553d1298 ("ASoC: soc-pcm: fix hwparams min/max init for dpcm") Suggested-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> --- sound/soc/soc-pcm.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) base-commit: 140f553d1298e0ddbe21983efe5789fe8b484273