diff mbox series

[07/53] drm/amd/display/dc/bios/command_table: Remove unused variable and associated comment

Message ID 20210303134319.3160762-8-lee.jones@linaro.org
State New
Headers show
Series Rid GPU from W=1 warnings | expand

Commit Message

Lee Jones March 3, 2021, 1:42 p.m. UTC
Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c: In function ‘adjust_display_pll_v2’:
 drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1462:11: warning: unused variable ‘pixel_clock_10KHz_in’ [-Wunused-variable]

Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/gpu/drm/amd/display/dc/bios/command_table.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Alex Deucher March 3, 2021, 3:22 p.m. UTC | #1
On Wed, Mar 3, 2021 at 8:43 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c: In function ‘adjust_display_pll_v2’:
>  drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1462:11: warning: unused variable ‘pixel_clock_10KHz_in’ [-Wunused-variable]
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Same comment as patch 4.


Alex

> ---
>  drivers/gpu/drm/amd/display/dc/bios/command_table.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/command_table.c b/drivers/gpu/drm/amd/display/dc/bios/command_table.c
> index 9d3bc3a073821..e879ceb0c49ed 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/command_table.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/command_table.c
> @@ -1518,10 +1518,6 @@ static enum bp_result adjust_display_pll_v2(
>  {
>         enum bp_result result = BP_RESULT_FAILURE;
>
> -       /* We need to convert from KHz units into 10KHz units and then convert
> -        * output pixel clock back 10KHz-->KHz */
> -       uint32_t pixel_clock_10KHz_in = bp_params->pixel_clock / 10;
> -
>         bp->cmd_helper->encoder_id_to_atom(
>                 dal_graphics_object_id_get_encoder_id(bp_params->encoder_object_id));
>         bp->cmd_helper->encoder_mode_bp_to_atom(bp_params->signal_type, false);
> --
> 2.27.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox series

Patch

diff --git a/drivers/gpu/drm/amd/display/dc/bios/command_table.c b/drivers/gpu/drm/amd/display/dc/bios/command_table.c
index 9d3bc3a073821..e879ceb0c49ed 100644
--- a/drivers/gpu/drm/amd/display/dc/bios/command_table.c
+++ b/drivers/gpu/drm/amd/display/dc/bios/command_table.c
@@ -1518,10 +1518,6 @@  static enum bp_result adjust_display_pll_v2(
 {
 	enum bp_result result = BP_RESULT_FAILURE;
 
-	/* We need to convert from KHz units into 10KHz units and then convert
-	 * output pixel clock back 10KHz-->KHz */
-	uint32_t pixel_clock_10KHz_in = bp_params->pixel_clock / 10;
-
 	bp->cmd_helper->encoder_id_to_atom(
 		dal_graphics_object_id_get_encoder_id(bp_params->encoder_object_id));
 	bp->cmd_helper->encoder_mode_bp_to_atom(bp_params->signal_type, false);