| Message ID | 1614244522-64464-1-git-send-email-yang.lee@linux.alibaba.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | pinctrl: ingenic: add missing call to of_node_put() | expand |
On Thu, Feb 25, 2021 at 10:15 AM Yang Li <yang.lee@linux.alibaba.com> wrote: > In one of the error paths of the for_each_child_of_node() loop in > ingenic_gpio_probe, add missing call to of_node_put(). > > Fix the following coccicheck warning: > ./drivers/pinctrl/pinctrl-ingenic.c:2485:1-23: WARNING: Function > "for_each_child_of_node" should have of_node_put() before return around > line 2489. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Patch applied! Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c index f274612..b7294a2 100644 --- a/drivers/pinctrl/pinctrl-ingenic.c +++ b/drivers/pinctrl/pinctrl-ingenic.c @@ -2486,6 +2486,7 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev) if (of_match_node(ingenic_gpio_of_match, node)) { err = ingenic_gpio_probe(jzpc, node); if (err) + of_node_put(node); return err; } }
In one of the error paths of the for_each_child_of_node() loop in ingenic_gpio_probe, add missing call to of_node_put(). Fix the following coccicheck warning: ./drivers/pinctrl/pinctrl-ingenic.c:2485:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 2489. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/pinctrl/pinctrl-ingenic.c | 1 + 1 file changed, 1 insertion(+)