diff mbox series

[-next] ARM: OMAP: Use DEFINE_SPINLOCK() for spinlock

Message ID 20210327095227.105081-1-chenlifu@huawei.com
State New
Headers show
Series [-next] ARM: OMAP: Use DEFINE_SPINLOCK() for spinlock | expand

Commit Message

chenlifu March 27, 2021, 9:52 a.m. UTC 
From: Lifu Chen <chenlifu@huawei.com>

spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Lifu Chen <chenlifu@huawei.com>
---
 arch/arm/plat-omap/dma.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Tony Lindgren March 31, 2021, 5:59 a.m. UTC | #1 
* Chen Lifu <chenlifu@huawei.com> [210327 11:53]:
> From: Lifu Chen <chenlifu@huawei.com>

> 

> spinlock can be initialized automatically with DEFINE_SPINLOCK()

> rather than explicitly calling spin_lock_init().


Thanks applying into omap-for-v5.13/soc.

Tony
chenlifu March 31, 2021, 9:03 a.m. UTC | #2 
在 2021/3/31 13:59, Tony Lindgren 写道:
> * Chen Lifu <chenlifu@huawei.com> [210327 11:53]:

>> From: Lifu Chen <chenlifu@huawei.com>

>>

>> spinlock can be initialized automatically with DEFINE_SPINLOCK()

>> rather than explicitly calling spin_lock_init().

> 

> Thanks applying into omap-for-v5.13/soc.

> 

> Tony

> .

> 


Thanks!

---
Chen Lifu
diff mbox series

Patch

diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index 1eb59003bdec..9f11de46aaa9 100644
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -85,7 +85,7 @@  static int dma_lch_count;
 static int dma_chan_count;
 static int omap_dma_reserve_channels;
 
-static spinlock_t dma_chan_lock;
+static DEFINE_SPINLOCK(dma_chan_lock);
 static struct omap_dma_lch *dma_chan;
 
 static inline void disable_lnk(int lch);
@@ -902,7 +902,6 @@  static int omap_system_dma_probe(struct platform_device *pdev)
 	if (!dma_chan)
 		return -ENOMEM;
 
-	spin_lock_init(&dma_chan_lock);
 	for (ch = 0; ch < dma_chan_count; ch++) {
 		omap_clear_dma(ch);