| Message ID | 20210407083334.2762-1-thunder.leizhen@huawei.com |
|---|---|
| State | Accepted |
| Commit | 614f94b5416d3fdc3fb96876092a43872eff57a4 |
| Headers | show |
| Series | [1/1] drm/msm/dpu: remove unused local variable 'cmd_enc' | expand |
On 2021-04-07 01:33, Zhen Lei wrote: > Fixes the following W=1 kernel build warning: > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function > ‘dpu_encoder_phys_cmd_wait_for_commit_done’: > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning: > variable ‘cmd_enc’ set but not used [-Wunused-but-set-variable] > > Fixes: fe286893ed34 ("drm/msm/dpu: Remove unused call in > wait_for_commit_done") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > index b2be39b9144e449..088900841bf8baa 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > @@ -685,10 +685,6 @@ static int > dpu_encoder_phys_cmd_wait_for_tx_complete( > static int dpu_encoder_phys_cmd_wait_for_commit_done( > struct dpu_encoder_phys *phys_enc) > { > - struct dpu_encoder_phys_cmd *cmd_enc; > - > - cmd_enc = to_dpu_encoder_phys_cmd(phys_enc); > - > /* only required for master controller */ > if (!dpu_encoder_phys_cmd_is_master(phys_enc)) > return 0;
On 2021-04-07 01:33, Zhen Lei wrote: > Fixes the following W=1 kernel build warning: > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function > ‘dpu_encoder_phys_cmd_wait_for_commit_done’: > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning: > variable ‘cmd_enc’ set but not used [-Wunused-but-set-variable] > > Fixes: fe286893ed34 ("drm/msm/dpu: Remove unused call in > wait_for_commit_done") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > index b2be39b9144e449..088900841bf8baa 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > @@ -685,10 +685,6 @@ static int > dpu_encoder_phys_cmd_wait_for_tx_complete( > static int dpu_encoder_phys_cmd_wait_for_commit_done( > struct dpu_encoder_phys *phys_enc) > { > - struct dpu_encoder_phys_cmd *cmd_enc; > - > - cmd_enc = to_dpu_encoder_phys_cmd(phys_enc); > - > /* only required for master controller */ > if (!dpu_encoder_phys_cmd_is_master(phys_enc)) > return 0;
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c index b2be39b9144e449..088900841bf8baa 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c @@ -685,10 +685,6 @@ static int dpu_encoder_phys_cmd_wait_for_tx_complete( static int dpu_encoder_phys_cmd_wait_for_commit_done( struct dpu_encoder_phys *phys_enc) { - struct dpu_encoder_phys_cmd *cmd_enc; - - cmd_enc = to_dpu_encoder_phys_cmd(phys_enc); - /* only required for master controller */ if (!dpu_encoder_phys_cmd_is_master(phys_enc)) return 0;
Fixes the following W=1 kernel build warning: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function ‘dpu_encoder_phys_cmd_wait_for_commit_done’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning: variable ‘cmd_enc’ set but not used [-Wunused-but-set-variable] Fixes: fe286893ed34 ("drm/msm/dpu: Remove unused call in wait_for_commit_done") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ---- 1 file changed, 4 deletions(-)