| Message ID | 20210414025549.7403-1-masahisa.kojima@linaro.org |
|---|---|
| State | Accepted |
| Commit | b1a7a5e0b8822a0868ee9318d8d3fa9645efc12d |
| Headers | show |
| Series | efi_loader: fix possible buffer overflow | expand |
On Wed, Apr 14, 2021 at 11:55:49AM +0900, Masahisa Kojima wrote: > Variable "final" will have SHA512 digest, but currently > the array size is not sufficient. Let's fix it. > > Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org> > --- > lib/efi_loader/efi_tcg2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c > index ed86a220fb..d5eca68769 100644 > --- a/lib/efi_loader/efi_tcg2.c > +++ b/lib/efi_loader/efi_tcg2.c > @@ -515,7 +515,7 @@ static efi_status_t tcg2_create_digest(const u8 *input, u32 length, > sha1_context ctx; > sha256_context ctx_256; > sha512_context ctx_512; > - u8 final[TPM2_ALG_SHA512]; > + u8 final[TPM2_SHA512_DIGEST_SIZE]; > efi_status_t ret; > u32 active; > int i; > -- > 2.17.1 > Thanks! Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
On 4/14/21 7:43 AM, Ilias Apalodimas wrote: > On Wed, Apr 14, 2021 at 11:55:49AM +0900, Masahisa Kojima wrote: >> Variable "final" will have SHA512 digest, but currently >> the array size is not sufficient. Let's fix it. >> >> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org> >> --- >> lib/efi_loader/efi_tcg2.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c >> index ed86a220fb..d5eca68769 100644 >> --- a/lib/efi_loader/efi_tcg2.c >> +++ b/lib/efi_loader/efi_tcg2.c >> @@ -515,7 +515,7 @@ static efi_status_t tcg2_create_digest(const u8 *input, u32 length, >> sha1_context ctx; >> sha256_context ctx_256; >> sha512_context ctx_512; >> - u8 final[TPM2_ALG_SHA512]; >> + u8 final[TPM2_SHA512_DIGEST_SIZE]; >> efi_status_t ret; >> u32 active; >> int i; >> -- >> 2.17.1 >> > > Thanks! > > Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > I have queued the patch for my next pull request. Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c index ed86a220fb..d5eca68769 100644 --- a/lib/efi_loader/efi_tcg2.c +++ b/lib/efi_loader/efi_tcg2.c @@ -515,7 +515,7 @@ static efi_status_t tcg2_create_digest(const u8 *input, u32 length, sha1_context ctx; sha256_context ctx_256; sha512_context ctx_512; - u8 final[TPM2_ALG_SHA512]; + u8 final[TPM2_SHA512_DIGEST_SIZE]; efi_status_t ret; u32 active; int i;
Variable "final" will have SHA512 digest, but currently the array size is not sufficient. Let's fix it. Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org> --- lib/efi_loader/efi_tcg2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1