| Message ID | 1395404057-27835-16-git-send-email-ulf.hansson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On Fri, Mar 21, 2014 at 1:14 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote: > Add a node in DT for the proper regulator which means we can move away > from the mmci platform data which currently holds the corresponding OCR > mask. > > The mmci driver can then calculate the OCR mask based on the voltages > supported by the regulator, instead of relying on the platform data. > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > arch/arm/boot/dts/ste-href.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/ste-href.dtsi b/arch/arm/boot/dts/ste-href.dtsi > index be34beb..bf449de 100644 > --- a/arch/arm/boot/dts/ste-href.dtsi > +++ b/arch/arm/boot/dts/ste-href.dtsi > @@ -155,6 +155,7 @@ > bus-width = <8>; > cap-mmc-highspeed; > non-removable; > + vmmc-supply = <&db8500_vsmps2_reg>; Don't you need a similar oneliner to ste-snowball.dts? That board is not including this file... Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 25 March 2014 22:45, Linus Walleij <linus.walleij@linaro.org> wrote: > On Fri, Mar 21, 2014 at 1:14 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote: > >> Add a node in DT for the proper regulator which means we can move away >> from the mmci platform data which currently holds the corresponding OCR >> mask. >> >> The mmci driver can then calculate the OCR mask based on the voltages >> supported by the regulator, instead of relying on the platform data. >> >> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> >> --- >> arch/arm/boot/dts/ste-href.dtsi | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/boot/dts/ste-href.dtsi b/arch/arm/boot/dts/ste-href.dtsi >> index be34beb..bf449de 100644 >> --- a/arch/arm/boot/dts/ste-href.dtsi >> +++ b/arch/arm/boot/dts/ste-href.dtsi >> @@ -155,6 +155,7 @@ >> bus-width = <8>; >> cap-mmc-highspeed; >> non-removable; >> + vmmc-supply = <&db8500_vsmps2_reg>; > > Don't you need a similar oneliner to ste-snowball.dts? > That board is not including this file... Snowball don't have the poped eMMC, which mean the vsmps2 is not used as the vmmc-supply. I still plan to have a look at snowball, handled as a separate task, since I have heard people complaining about the SD card and/or the eMMC is working properly. Kind regards Ulf Hansson > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > Yours, > Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 26 March 2014 10:27, Ulf Hansson <ulf.hansson@linaro.org> wrote: > On 25 March 2014 22:45, Linus Walleij <linus.walleij@linaro.org> wrote: >> On Fri, Mar 21, 2014 at 1:14 PM, Ulf Hansson <ulf.hansson@linaro.org> wrote: >> >>> Add a node in DT for the proper regulator which means we can move away >>> from the mmci platform data which currently holds the corresponding OCR >>> mask. >>> >>> The mmci driver can then calculate the OCR mask based on the voltages >>> supported by the regulator, instead of relying on the platform data. >>> >>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> >>> --- >>> arch/arm/boot/dts/ste-href.dtsi | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm/boot/dts/ste-href.dtsi b/arch/arm/boot/dts/ste-href.dtsi >>> index be34beb..bf449de 100644 >>> --- a/arch/arm/boot/dts/ste-href.dtsi >>> +++ b/arch/arm/boot/dts/ste-href.dtsi >>> @@ -155,6 +155,7 @@ >>> bus-width = <8>; >>> cap-mmc-highspeed; >>> non-removable; >>> + vmmc-supply = <&db8500_vsmps2_reg>; >> >> Don't you need a similar oneliner to ste-snowball.dts? >> That board is not including this file... > > Snowball don't have the poped eMMC, which mean the vsmps2 is not used > as the vmmc-supply. > > I still plan to have a look at snowball, handled as a separate task, > since I have heard people complaining about the SD card and/or the > eMMC is working properly. /s /is /is not > > Kind regards > Ulf Hansson > >> >> Acked-by: Linus Walleij <linus.walleij@linaro.org> >> >> Yours, >> Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/ste-href.dtsi b/arch/arm/boot/dts/ste-href.dtsi index be34beb..bf449de 100644 --- a/arch/arm/boot/dts/ste-href.dtsi +++ b/arch/arm/boot/dts/ste-href.dtsi @@ -155,6 +155,7 @@ bus-width = <8>; cap-mmc-highspeed; non-removable; + vmmc-supply = <&db8500_vsmps2_reg>; pinctrl-names = "default", "sleep"; pinctrl-0 = <&sdi2_default_mode>; pinctrl-1 = <&sdi2_sleep_mode>;
Add a node in DT for the proper regulator which means we can move away from the mmci platform data which currently holds the corresponding OCR mask. The mmci driver can then calculate the OCR mask based on the voltages supported by the regulator, instead of relying on the platform data. Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- arch/arm/boot/dts/ste-href.dtsi | 1 + 1 file changed, 1 insertion(+)