| Message ID | 20210516024216.4576-2-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | e8713c31f8adab67155e245a217d0c7cad05fcf5 |
| Headers | show |
| Series | [RFC,1/3] dt-bindings: media: nxp,imx7-csi: Add i.MX8MM support | expand |
Am Sonntag, dem 16.05.2021 um 05:42 +0300 schrieb Laurent Pinchart: > The i.MX8MM integrates a CSI bridge IP core, as the i.MX7. There > seems > to be no difference between the two SoCs according to the reference > manual, but as documentation may not be accurate, add a compatible > string for the i.MX8MM, with a fallback on the compatible i.MX7. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > .../devicetree/bindings/media/nxp,imx7-csi.yaml | 12 ++++++++-- > -- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx7- > csi.yaml b/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > index d91575b8ebb9..5922a2795167 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/media/nxp,imx7-csi.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: i.MX7 CMOS Sensor Interface > +title: i.MX7 and i.MX8 CSI bridge (CMOS Sensor Interface) > > maintainers: > - Rui Miguel Silva <rmfrfs@gmail.com> > @@ -15,9 +15,13 @@ description: | > > properties: > compatible: > - enum: > - - fsl,imx7-csi > - - fsl,imx6ul-csi > + oneOf: > + - enum: > + - fsl,imx7-csi > + - fsl,imx6ul-csi > + - items: > + - const: fsl,imx8mm-csi > + - const: fsl,imx7-csi > > reg: > maxItems: 1 isn't the fsl,imx8mm-csi compatible missing in the driver then? thanks! martin
Hi Martin, On Tue, May 18, 2021 at 01:26:21PM +0200, Martin Kepplinger wrote: > Am Sonntag, dem 16.05.2021 um 05:42 +0300 schrieb Laurent Pinchart: > > The i.MX8MM integrates a CSI bridge IP core, as the i.MX7. There seems > > to be no difference between the two SoCs according to the reference > > manual, but as documentation may not be accurate, add a compatible > > string for the i.MX8MM, with a fallback on the compatible i.MX7. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > .../devicetree/bindings/media/nxp,imx7-csi.yaml | 12 ++++++++-- > > -- > > 1 file changed, 8 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx7- > > csi.yaml b/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > > index d91575b8ebb9..5922a2795167 100644 > > --- a/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > > +++ b/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > > @@ -4,7 +4,7 @@ > > $id: http://devicetree.org/schemas/media/nxp,imx7-csi.yaml# > > $schema: http://devicetree.org/meta-schemas/core.yaml# > > > > -title: i.MX7 CMOS Sensor Interface > > +title: i.MX7 and i.MX8 CSI bridge (CMOS Sensor Interface) > > > > maintainers: > > - Rui Miguel Silva <rmfrfs@gmail.com> > > @@ -15,9 +15,13 @@ description: | > > > > properties: > > compatible: > > - enum: > > - - fsl,imx7-csi > > - - fsl,imx6ul-csi > > + oneOf: > > + - enum: > > + - fsl,imx7-csi > > + - fsl,imx6ul-csi > > + - items: > > + - const: fsl,imx8mm-csi > > + - const: fsl,imx7-csi > > > > reg: > > maxItems: 1 > > isn't the fsl,imx8mm-csi compatible missing in the driver then? The driver will match on the "fsl,imx7-csi" compatible string, which the bindings makes mandatory as a fallback for i.MX8MM. If we later find differences between the CSI bridge in the i.MX7 and i.MX8MM, we can add the compatible string to the driver to enable device-specific code without any backward-compatibility issue. -- Regards, Laurent Pinchart
On Sun, 16 May 2021 05:42:14 +0300, Laurent Pinchart wrote: > The i.MX8MM integrates a CSI bridge IP core, as the i.MX7. There seems > to be no difference between the two SoCs according to the reference > manual, but as documentation may not be accurate, add a compatible > string for the i.MX8MM, with a fallback on the compatible i.MX7. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > .../devicetree/bindings/media/nxp,imx7-csi.yaml | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml b/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml index d91575b8ebb9..5922a2795167 100644 --- a/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml +++ b/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml @@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/media/nxp,imx7-csi.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: i.MX7 CMOS Sensor Interface +title: i.MX7 and i.MX8 CSI bridge (CMOS Sensor Interface) maintainers: - Rui Miguel Silva <rmfrfs@gmail.com> @@ -15,9 +15,13 @@ description: | properties: compatible: - enum: - - fsl,imx7-csi - - fsl,imx6ul-csi + oneOf: + - enum: + - fsl,imx7-csi + - fsl,imx6ul-csi + - items: + - const: fsl,imx8mm-csi + - const: fsl,imx7-csi reg: maxItems: 1
The i.MX8MM integrates a CSI bridge IP core, as the i.MX7. There seems to be no difference between the two SoCs according to the reference manual, but as documentation may not be accurate, add a compatible string for the i.MX8MM, with a fallback on the compatible i.MX7. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- .../devicetree/bindings/media/nxp,imx7-csi.yaml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)