| Message ID | 20210526184839.2937899-1-robh@kernel.org |
|---|---|
| Headers | show |
| Series | dt-bindings: Convert mux bindings to schema | expand |
On 26/05/2021 13:48:35-0500, Rob Herring wrote: > Convert the Philips PCF8563/Epson RTC8564 binding to DT schema format. > > Add 'interrupts' and 'wakeup-source' as this device has an interrupt > which was not documented, but in use. Add 'start-year' as well. > > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > v2: > - Add reference to rtc.yaml and wakeup-source and start-year properties > --- > .../devicetree/bindings/rtc/nxp,pcf8563.yaml | 56 +++++++++++++++++++ > .../devicetree/bindings/rtc/pcf8563.txt | 29 ---------- > 2 files changed, 56 insertions(+), 29 deletions(-) > create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml > delete mode 100644 Documentation/devicetree/bindings/rtc/pcf8563.txt > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml > new file mode 100644 > index 000000000000..a542b6c7ff44 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/nxp,pcf8563.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Philips PCF8563/Epson RTC8564 Real Time Clock > + > +maintainers: > + - Alexandre Belloni <alexandre.belloni@bootlin.com> > + > +allOf: > + - $ref: rtc.yaml# > + > +properties: > + compatible: > + enum: > + - epson,rtc8564 > + - microcrystal,rv8564 > + - nxp,pcf8563 > + - nxp,pca8565 > + > + reg: > + maxItems: 1 > + > + "#clock-cells": > + const: 0 > + > + clock-output-names: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + start-year: true > + wakeup-source: true > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + rtc@51 { > + compatible = "nxp,pcf8563"; > + reg = <0x51>; > + #clock-cells = <0>; > + }; > + }; > +... > diff --git a/Documentation/devicetree/bindings/rtc/pcf8563.txt b/Documentation/devicetree/bindings/rtc/pcf8563.txt > deleted file mode 100644 > index 0a900f7c8977..000000000000 > --- a/Documentation/devicetree/bindings/rtc/pcf8563.txt > +++ /dev/null > @@ -1,29 +0,0 @@ > -* Philips PCF8563/Epson RTC8564 Real Time Clock > - > -Philips PCF8563/Epson RTC8564 Real Time Clock > - > -Required properties: > -- compatible: Should contain "nxp,pcf8563", > - "epson,rtc8564" or > - "microcrystal,rv8564" or > - "nxp,pca8565" > -- reg: I2C address for chip. > - > -Optional property: > -- #clock-cells: Should be 0. > -- clock-output-names: > - overwrite the default clock name "pcf8563-clkout" > - > -Example: > - > -pcf8563: pcf8563@51 { > - compatible = "nxp,pcf8563"; > - reg = <0x51>; > - #clock-cells = <0>; > -}; > - > -device { > -... > - clocks = <&pcf8563>; > -... > -}; > -- > 2.27.0 >
On Wed, May 26, 2021 at 01:48:33PM -0500, Rob Herring wrote: > This series converts the mux-controller and some i2c mux bindings to DT > schema. This was a rabbit hole of trying to fix undocumented (by schema) > compatibles (enabled by setting DT_CHECKER_FLAGS=-m). So this is mux > bindings, and then a few others that are used in the mux binding > examples. So, I assume this should all go via your tree? That would be fine with me. Maybe Peter has some more comments, but for the procedure, here is my ack for the I2C parts of this series: Acked-by: Wolfram Sang <wsa@kernel.org>
On 2021-05-28 10:45, Wolfram Sang wrote: > On Wed, May 26, 2021 at 01:48:33PM -0500, Rob Herring wrote: >> This series converts the mux-controller and some i2c mux bindings to DT >> schema. This was a rabbit hole of trying to fix undocumented (by schema) >> compatibles (enabled by setting DT_CHECKER_FLAGS=-m). So this is mux >> bindings, and then a few others that are used in the mux binding >> examples. > > So, I assume this should all go via your tree? That would be fine with > me. Maybe Peter has some more comments, but for the procedure, here is > my ack for the I2C parts of this series: Hi Rob, Thanks for converting these! I can't call what I have done a review, because the details escape me, and I don't have time to spend at the moment. However, from where I'm looking, it all looks splendid. Ignorance is bliss! So, for patches 3-5 (where I'm the maintainer) you have my Acked-by: Peter Rosin <peda@axentia.se> Interesting times, being a maintainer of things I don't understand. I need to fix that... The main worry I have is the comment from Laurent about the intermediate "i2c-mux" node, which also applies to i2c-gate which has been converted to yaml before and to i2c-arb which is still in .txt format. I don't remember exactly what the issue was that made me add the optional level, but hopefully it is as you say, and that it is only MFD-type devices that need them and that those can specify the intermediate level themselves. My vision was to always have the intermediate level, since I thought the bindings looked clearer that way. But that's just a personal opinion, and it doesn't really matter... However, I also worry that the information needed by future authors of MFD bindings is lost and that they will have no readily available source of the information that the intermediate nodes should be called i2c-mux, i2c-arb or i2c-gate. The info was removed in the i2c-gate.txt -> .yaml conversion. But that problem is not present in this series, since the info is preserved in i2c-mux.txt -> .yaml conversion. So, please go ahead with this series. Thanks again! Cheers, Peter