| Message ID | 20210526172036.183223-1-krzysztof.kozlowski@canonical.com |
|---|---|
| Headers | show |
| Series | mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type | expand |
On Wed, 26 May 2021, Krzysztof Kozlowski wrote: > Hi, > > This is a v2 with only minor changes: > 1. Drop patches which landed in mainline. > 2. Add acks. > 3. Rebase max17040 power supply (dtschema conversion). > > Patches are independent and there are no external dependencies, so > please pick up freely. > > Best regards, > Krzysztof > > > Krzysztof Kozlowski (7): > mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type > mfd: max77686: Do not enforce (incorrect) interrupt trigger type > mfd: max77693: Do not enforce (incorrect) interrupt trigger type > mfd: max14577: Do not enforce (incorrect) interrupt trigger type > rtc: max77686: Do not enforce (incorrect) interrupt trigger type > power: supply: max17042: Do not enforce (incorrect) interrupt trigger > type > power: supply: max17040: Do not enforce (incorrect) interrupt trigger > type MFD patches (at least) do not apply. Please rebase and resubmit with my: For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
On 01/06/2021 17:41, Lee Jones wrote: > On Wed, 26 May 2021, Krzysztof Kozlowski wrote: > >> Hi, >> >> This is a v2 with only minor changes: >> 1. Drop patches which landed in mainline. >> 2. Add acks. >> 3. Rebase max17040 power supply (dtschema conversion). >> >> Patches are independent and there are no external dependencies, so >> please pick up freely. >> >> Best regards, >> Krzysztof >> >> >> Krzysztof Kozlowski (7): >> mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type >> mfd: max77686: Do not enforce (incorrect) interrupt trigger type >> mfd: max77693: Do not enforce (incorrect) interrupt trigger type >> mfd: max14577: Do not enforce (incorrect) interrupt trigger type >> rtc: max77686: Do not enforce (incorrect) interrupt trigger type >> power: supply: max17042: Do not enforce (incorrect) interrupt trigger >> type >> power: supply: max17040: Do not enforce (incorrect) interrupt trigger >> type > > MFD patches (at least) do not apply. > > Please rebase and resubmit with my: > > For my own reference (apply this as-is to your sign-off block): > > Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> I'll resend the MFD part. For the RTC and power, I hope these apply still cleanly. Best regards, Krzysztof
On Wed, 26 May 2021 13:20:36 -0400, Krzysztof Kozlowski wrote: > From: Krzysztof Kozlowski <krzk@kernel.org> > > Interrupt line can be configured on different hardware in different way, > even inverted. Therefore driver should not enforce specific trigger > type - edge falling - but instead rely on Devicetree to configure it. > > The Maxim 14577/77836 datasheets describe the interrupt line as active > low with a requirement of acknowledge from the CPU therefore the edge > falling is not correct. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > Acked-by: Iskren Chernev <iskren.chernev@gmail.com> > > --- > > Changes since v1: > 1. Remove the 'flags' variable. > 2. Added ack. > 3. Rebase - the bindings were converted to dtschema. > --- > .../devicetree/bindings/power/supply/maxim,max17040.yaml | 2 +- > drivers/power/supply/max17040_battery.c | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
Hi, On Wed, Jun 02, 2021 at 03:06:09PM -0500, Rob Herring wrote: > On Wed, 26 May 2021 13:20:36 -0400, Krzysztof Kozlowski wrote: > > From: Krzysztof Kozlowski <krzk@kernel.org> > > > > Interrupt line can be configured on different hardware in different way, > > even inverted. Therefore driver should not enforce specific trigger > > type - edge falling - but instead rely on Devicetree to configure it. > > > > The Maxim 14577/77836 datasheets describe the interrupt line as active > > low with a requirement of acknowledge from the CPU therefore the edge > > falling is not correct. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > Acked-by: Iskren Chernev <iskren.chernev@gmail.com> > > > > --- > > > > Changes since v1: > > 1. Remove the 'flags' variable. > > 2. Added ack. > > 3. Rebase - the bindings were converted to dtschema. > > --- > > .../devicetree/bindings/power/supply/maxim,max17040.yaml | 2 +- > > drivers/power/supply/max17040_battery.c | 4 +--- > > 2 files changed, 2 insertions(+), 4 deletions(-) > > > > Acked-by: Rob Herring <robh@kernel.org> Thanks, queued. -- Sebastian
On Wed, 26 May 2021 13:20:29 -0400, Krzysztof Kozlowski wrote: > This is a v2 with only minor changes: > 1. Drop patches which landed in mainline. > 2. Add acks. > 3. Rebase max17040 power supply (dtschema conversion). > > Patches are independent and there are no external dependencies, so > please pick up freely. > > [...] Applied, thanks! [5/7] rtc: max77686: Do not enforce (incorrect) interrupt trigger type commit: 742b0d7e15c333303daad4856de0764f4bc83601 Best regards,
Hi, This is a v2 with only minor changes: 1. Drop patches which landed in mainline. 2. Add acks. 3. Rebase max17040 power supply (dtschema conversion). Patches are independent and there are no external dependencies, so please pick up freely. Best regards, Krzysztof Krzysztof Kozlowski (7): mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type mfd: max77686: Do not enforce (incorrect) interrupt trigger type mfd: max77693: Do not enforce (incorrect) interrupt trigger type mfd: max14577: Do not enforce (incorrect) interrupt trigger type rtc: max77686: Do not enforce (incorrect) interrupt trigger type power: supply: max17042: Do not enforce (incorrect) interrupt trigger type power: supply: max17040: Do not enforce (incorrect) interrupt trigger type .../devicetree/bindings/clock/maxim,max77686.txt | 4 ++-- Documentation/devicetree/bindings/mfd/max14577.txt | 4 ++-- Documentation/devicetree/bindings/mfd/max77686.txt | 2 +- Documentation/devicetree/bindings/mfd/max77693.txt | 2 +- .../bindings/power/supply/maxim,max17040.yaml | 2 +- .../devicetree/bindings/regulator/max77686.txt | 2 +- drivers/mfd/max14577.c | 6 +++--- drivers/mfd/max77686.c | 3 +-- drivers/mfd/max77693.c | 12 ++++-------- drivers/mfd/sec-irq.c | 3 +-- drivers/power/supply/max17040_battery.c | 4 +--- drivers/power/supply/max17042_battery.c | 2 +- drivers/rtc/rtc-max77686.c | 4 ++-- 13 files changed, 21 insertions(+), 29 deletions(-)