mbox series

[PATCHv3,0/2] iommu/arm-smmu-qcom: Add SC7280 support

Message ID cover.1618898456.git.saiprakash.ranjan@codeaurora.org
Headers show
Series iommu/arm-smmu-qcom: Add SC7280 support | expand

Message

Sai Prakash Ranjan April 20, 2021, 6:04 a.m. UTC
Patch 1 adds the sc7280 smmu compatible.
Patch 2 moves the adreno smmu check before apss smmu to enable
adreno smmu specific implementation.

Note that dt-binding for sc7280 is already merged.

Changes in v3:
 * Collect acks and reviews
 * Rebase on top of for-joerg/arm-smmu/updates

Changes in v2:
 * Add a comment to make sure this order is not changed in future (Jordan)

Sai Prakash Ranjan (2):
  iommu/arm-smmu-qcom: Add SC7280 SMMU compatible
  iommu/arm-smmu-qcom: Move the adreno smmu specific impl earlier

 drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

Comments

Sai Prakash Ranjan May 24, 2021, 2:43 a.m. UTC | #1
Hi Will,

On 2021-04-20 11:34, Sai Prakash Ranjan wrote:
> Patch 1 adds the sc7280 smmu compatible.

> Patch 2 moves the adreno smmu check before apss smmu to enable

> adreno smmu specific implementation.

> 

> Note that dt-binding for sc7280 is already merged.

> 

> Changes in v3:

>  * Collect acks and reviews

>  * Rebase on top of for-joerg/arm-smmu/updates

> 

> Changes in v2:

>  * Add a comment to make sure this order is not changed in future 

> (Jordan)

> 

> Sai Prakash Ranjan (2):

>   iommu/arm-smmu-qcom: Add SC7280 SMMU compatible

>   iommu/arm-smmu-qcom: Move the adreno smmu specific impl earlier

> 

>  drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 14 +++++++++++---

>  1 file changed, 11 insertions(+), 3 deletions(-)


Gentle Ping!

Thanks,
Sai
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation
Bjorn Andersson May 25, 2021, 4:03 a.m. UTC | #2
On Tue 20 Apr 01:04 CDT 2021, Sai Prakash Ranjan wrote:

> Add compatible for SC7280 SMMU to use the Qualcomm Technologies, Inc.

> specific implementation.

> 


Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>


Regards,
Bjorn

> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>

> ---

>  drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 2 ++

>  1 file changed, 2 insertions(+)

> 

> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c

> index 98b3a1c2a181..bea3ee0dabc2 100644

> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c

> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c

> @@ -166,6 +166,7 @@ static const struct of_device_id qcom_smmu_client_of_match[] __maybe_unused = {

>  	{ .compatible = "qcom,mdss" },

>  	{ .compatible = "qcom,sc7180-mdss" },

>  	{ .compatible = "qcom,sc7180-mss-pil" },

> +	{ .compatible = "qcom,sc7280-mdss" },

>  	{ .compatible = "qcom,sc8180x-mdss" },

>  	{ .compatible = "qcom,sdm845-mdss" },

>  	{ .compatible = "qcom,sdm845-mss-pil" },

> @@ -330,6 +331,7 @@ static struct arm_smmu_device *qcom_smmu_create(struct arm_smmu_device *smmu,

>  static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = {

>  	{ .compatible = "qcom,msm8998-smmu-v2" },

>  	{ .compatible = "qcom,sc7180-smmu-500" },

> +	{ .compatible = "qcom,sc7280-smmu-500" },

>  	{ .compatible = "qcom,sc8180x-smmu-500" },

>  	{ .compatible = "qcom,sdm630-smmu-v2" },

>  	{ .compatible = "qcom,sdm845-smmu-500" },

> -- 

> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member

> of Code Aurora Forum, hosted by The Linux Foundation

>
Sai Prakash Ranjan June 7, 2021, 2:55 a.m. UTC | #3
Hi Will,

On 2021-05-24 08:13, Sai Prakash Ranjan wrote:
> Hi Will,

> 

> On 2021-04-20 11:34, Sai Prakash Ranjan wrote:

>> Patch 1 adds the sc7280 smmu compatible.

>> Patch 2 moves the adreno smmu check before apss smmu to enable

>> adreno smmu specific implementation.

>> 

>> Note that dt-binding for sc7280 is already merged.

>> 

>> Changes in v3:

>>  * Collect acks and reviews

>>  * Rebase on top of for-joerg/arm-smmu/updates

>> 

>> Changes in v2:

>>  * Add a comment to make sure this order is not changed in future 

>> (Jordan)

>> 

>> Sai Prakash Ranjan (2):

>>   iommu/arm-smmu-qcom: Add SC7280 SMMU compatible

>>   iommu/arm-smmu-qcom: Move the adreno smmu specific impl earlier

>> 

>>  drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 14 +++++++++++---

>>  1 file changed, 11 insertions(+), 3 deletions(-)

> 

> Gentle Ping!

> 


Is this going to be taken for 5.14 or needs one more release cycle?

Thanks,
Sai

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation
Will Deacon June 8, 2021, 12:01 p.m. UTC | #4
On Tue, Apr 20, 2021 at 11:34:55AM +0530, Sai Prakash Ranjan wrote:
> Patch 1 adds the sc7280 smmu compatible.

> Patch 2 moves the adreno smmu check before apss smmu to enable

> adreno smmu specific implementation.

> 

> Note that dt-binding for sc7280 is already merged.


This conflicts with what I've already got queued at [1]. Please can you
send an updated version, as I wasn't sure about the initialisation order
you need here wrt to the ACPI parts.

Thanks,

Will

[1] https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/log/?h=for-joerg/arm-smmu/updates
Sai Prakash Ranjan June 8, 2021, 12:32 p.m. UTC | #5
On 2021-06-08 17:31, Will Deacon wrote:
> On Tue, Apr 20, 2021 at 11:34:55AM +0530, Sai Prakash Ranjan wrote:

>> Patch 1 adds the sc7280 smmu compatible.

>> Patch 2 moves the adreno smmu check before apss smmu to enable

>> adreno smmu specific implementation.

>> 

>> Note that dt-binding for sc7280 is already merged.

> 

> This conflicts with what I've already got queued at [1]. Please can you

> send an updated version, as I wasn't sure about the initialisation 

> order

> you need here wrt to the ACPI parts.

> 

> Thanks,

> 

> Will

> 

> [1]

> https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/log/?h=for-joerg/arm-smmu/updates


Sure, have rebased and sent the updated patch [1] after testing for the 
order.

Thanks,
Sai

[1] 
https://lore.kernel.org/lkml/cover.1623155117.git.saiprakash.ranjan@codeaurora.org/

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation