diff mbox series

[PATCH/RFC,1/4] dt-bindings: i2c: renesas,riic: Add interrupt-names

Message ID a81d0e14e395f297666e8c3a8ce3e292d2606a65.1626267422.git.geert+renesas@glider.be
State Accepted
Commit 112dfa5ca16cc95dd6ceef7387a5f0f8a808da56
Headers show
Series dt-bindings: i2c: renesas,riic: Add interrupt-names | expand

Commit Message

Geert Uytterhoeven July 14, 2021, 1:20 p.m. UTC 
The Renesas RZ/A and RZ/G2L I2C Bus Interface has no less than 8
interrupts.  Hence document the "interrupt-names" property, to make it
easier to review the interrupt mappings in DTS files.

Note that this property cannot be made required yet, as the RIIC nodes
in all DTS files lack the property.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 .../devicetree/bindings/i2c/renesas,riic.yaml | 29 ++++++++++++++-----
 1 file changed, 21 insertions(+), 8 deletions(-)

Comments

Rob Herring July 16, 2021, 7:19 p.m. UTC | #1 
On Wed, 14 Jul 2021 15:20:00 +0200, Geert Uytterhoeven wrote:
> The Renesas RZ/A and RZ/G2L I2C Bus Interface has no less than 8

> interrupts.  Hence document the "interrupt-names" property, to make it

> easier to review the interrupt mappings in DTS files.

> 

> Note that this property cannot be made required yet, as the RIIC nodes

> in all DTS files lack the property.

> 

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

> ---

>  .../devicetree/bindings/i2c/renesas,riic.yaml | 29 ++++++++++++++-----

>  1 file changed, 21 insertions(+), 8 deletions(-)

> 


Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
index 52d92ec7ec0b2112..70f998f006305c25 100644
--- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
+++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
@@ -27,14 +27,25 @@  properties:
 
   interrupts:
     items:
-      - description: Transmit End Interrupt (TEI)
-      - description: Receive Data Full Interrupt (RI)
-      - description: Transmit Data Empty Interrupt (TI)
-      - description: Stop Condition Detection Interrupt (SPI)
-      - description: Start Condition Detection Interrupt (STI)
-      - description: NACK Reception Interrupt (NAKI)
-      - description: Arbitration-Lost Interrupt (ALI)
-      - description: Timeout Interrupt (TMOI)
+      - description: Transmit End Interrupt
+      - description: Receive Data Full Interrupt
+      - description: Transmit Data Empty Interrupt
+      - description: Stop Condition Detection Interrupt
+      - description: Start Condition Detection Interrupt
+      - description: NACK Reception Interrupt
+      - description: Arbitration-Lost Interrupt
+      - description: Timeout Interrupt
+
+  interrupt-names:
+    items:
+      - const: tei
+      - const: ri
+      - const: ti
+      - const: spi
+      - const: sti
+      - const: naki
+      - const: ali
+      - const: tmoi
 
   clock-frequency:
     description:
@@ -85,6 +96,8 @@  examples:
                          <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>,
                          <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
                          <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
+            interrupt-names = "tei", "ri", "ti", "spi", "sti", "naki", "ali",
+                              "tmoi";
             clocks = <&mstp9_clks R7S72100_CLK_I2C0>;
             clock-frequency = <100000>;
             power-domains = <&cpg_clocks>;