diff mbox series

[v2,08/11] memory: mtk-smi: Use devm_platform_ioremap_resource

Message ID 20210715121209.31024-9-yong.wu@mediatek.com
State New
Headers show
Series MT8195 SMI support | expand

Commit Message

Yong Wu (吴勇) July 15, 2021, 12:12 p.m. UTC
No functional change. Simplify probing code.

Signed-off-by: Yong Wu <yong.wu@mediatek.com>
---
 drivers/memory/mtk-smi.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

Comments

Ikjoon Jang July 21, 2021, 11:44 a.m. UTC | #1
On Thu, Jul 15, 2021 at 8:24 PM Yong Wu <yong.wu@mediatek.com> wrote:
>

> No functional change. Simplify probing code.

>

> Signed-off-by: Yong Wu <yong.wu@mediatek.com>


Reviewed-by: Ikjoon Jang <ikjn@chromium.org>


> ---

>  drivers/memory/mtk-smi.c | 11 +++--------

>  1 file changed, 3 insertions(+), 8 deletions(-)

>

> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c

> index ee49bb50f5f5..e5a34b3952a0 100644

> --- a/drivers/memory/mtk-smi.c

> +++ b/drivers/memory/mtk-smi.c

> @@ -317,7 +317,6 @@ static int mtk_smi_dts_clk_init(struct device *dev, struct mtk_smi *smi,

>  static int mtk_smi_larb_probe(struct platform_device *pdev)

>  {

>         struct mtk_smi_larb *larb;

> -       struct resource *res;

>         struct device *dev = &pdev->dev;

>         int ret;

>

> @@ -326,8 +325,7 @@ static int mtk_smi_larb_probe(struct platform_device *pdev)

>                 return -ENOMEM;

>

>         larb->larb_gen = of_device_get_match_data(dev);

> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

> -       larb->base = devm_ioremap_resource(dev, res);

> +       larb->base = devm_platform_ioremap_resource(pdev, 0);

>         if (IS_ERR(larb->base))

>                 return PTR_ERR(larb->base);

>

> @@ -447,7 +445,6 @@ static int mtk_smi_common_probe(struct platform_device *pdev)

>  {

>         struct device *dev = &pdev->dev;

>         struct mtk_smi *common;

> -       struct resource *res;

>         int ret;

>

>         common = devm_kzalloc(dev, sizeof(*common), GFP_KERNEL);

> @@ -468,8 +465,7 @@ static int mtk_smi_common_probe(struct platform_device *pdev)

>          * base.

>          */

>         if (common->plat->type == MTK_SMI_GEN1) {

> -               res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

> -               common->smi_ao_base = devm_ioremap_resource(dev, res);

> +               common->smi_ao_base = devm_platform_ioremap_resource(pdev, 0);

>                 if (IS_ERR(common->smi_ao_base))

>                         return PTR_ERR(common->smi_ao_base);

>

> @@ -481,8 +477,7 @@ static int mtk_smi_common_probe(struct platform_device *pdev)

>                 if (ret)

>                         return ret;

>         } else {

> -               res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

> -               common->base = devm_ioremap_resource(dev, res);

> +               common->base = devm_platform_ioremap_resource(pdev, 0);

>                 if (IS_ERR(common->base))

>                         return PTR_ERR(common->base);

>         }

> --

> 2.18.0

> _______________________________________________

> Linux-mediatek mailing list

> Linux-mediatek@lists.infradead.org

> http://lists.infradead.org/mailman/listinfo/linux-mediatek
diff mbox series

Patch

diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index ee49bb50f5f5..e5a34b3952a0 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c
@@ -317,7 +317,6 @@  static int mtk_smi_dts_clk_init(struct device *dev, struct mtk_smi *smi,
 static int mtk_smi_larb_probe(struct platform_device *pdev)
 {
 	struct mtk_smi_larb *larb;
-	struct resource *res;
 	struct device *dev = &pdev->dev;
 	int ret;
 
@@ -326,8 +325,7 @@  static int mtk_smi_larb_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	larb->larb_gen = of_device_get_match_data(dev);
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	larb->base = devm_ioremap_resource(dev, res);
+	larb->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(larb->base))
 		return PTR_ERR(larb->base);
 
@@ -447,7 +445,6 @@  static int mtk_smi_common_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct mtk_smi *common;
-	struct resource *res;
 	int ret;
 
 	common = devm_kzalloc(dev, sizeof(*common), GFP_KERNEL);
@@ -468,8 +465,7 @@  static int mtk_smi_common_probe(struct platform_device *pdev)
 	 * base.
 	 */
 	if (common->plat->type == MTK_SMI_GEN1) {
-		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		common->smi_ao_base = devm_ioremap_resource(dev, res);
+		common->smi_ao_base = devm_platform_ioremap_resource(pdev, 0);
 		if (IS_ERR(common->smi_ao_base))
 			return PTR_ERR(common->smi_ao_base);
 
@@ -481,8 +477,7 @@  static int mtk_smi_common_probe(struct platform_device *pdev)
 		if (ret)
 			return ret;
 	} else {
-		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		common->base = devm_ioremap_resource(dev, res);
+		common->base = devm_platform_ioremap_resource(pdev, 0);
 		if (IS_ERR(common->base))
 			return PTR_ERR(common->base);
 	}