| Message ID | 20210721140424.725744-16-maxime@cerno.tech |
|---|---|
| State | Accepted |
| Commit | 14a30238ecb8dcf52a9e2be514414e3ec443b536 |
| Headers | show |
| Series | ARM: dts: Last round of DT schema fixes | expand |
On Wed, 21 Jul 2021 16:03:45 +0200, Maxime Ripard wrote: > The original bindings was listing the length of the interrupts as either > 1 or 2, depending on the setup. This is also what is enforced by the top > level schema. > > However, that is further constrained with an if clause that require > exactly two interrupts, even though it might not make sense on those > devices or in some setups. > > Let's remove the clause entirely. > > Cc: Denis Ciocca <denis.ciocca@st.com> > Cc: Jonathan Cameron <jic23@kernel.org> > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: linux-iio@vger.kernel.org > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > --- > .../bindings/iio/st,st-sensors.yaml | 41 ------------------- > 1 file changed, 41 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Wed, Jul 21, 2021 at 4:05 PM Maxime Ripard <maxime@cerno.tech> wrote: > The original bindings was listing the length of the interrupts as either > 1 or 2, depending on the setup. This is also what is enforced by the top > level schema. > > However, that is further constrained with an if clause that require > exactly two interrupts, even though it might not make sense on those > devices or in some setups. > > Let's remove the clause entirely. > > Cc: Denis Ciocca <denis.ciocca@st.com> > Cc: Jonathan Cameron <jic23@kernel.org> > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: linux-iio@vger.kernel.org > Signed-off-by: Maxime Ripard <maxime@cerno.tech> Oops this was too ambitious. Sorry about that. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml index b2a1e42c56fa..71de5631ebae 100644 --- a/Documentation/devicetree/bindings/iio/st,st-sensors.yaml +++ b/Documentation/devicetree/bindings/iio/st,st-sensors.yaml @@ -152,47 +152,6 @@ allOf: maxItems: 1 st,drdy-int-pin: false - - if: - properties: - compatible: - enum: - # Two intertial interrupts i.e. accelerometer/gyro interrupts - - st,h3lis331dl-accel - - st,l3g4200d-gyro - - st,l3g4is-gyro - - st,l3gd20-gyro - - st,l3gd20h-gyro - - st,lis2de12 - - st,lis2dw12 - - st,lis2hh12 - - st,lis2dh12-accel - - st,lis331dl-accel - - st,lis331dlh-accel - - st,lis3de - - st,lis3dh-accel - - st,lis3dhh - - st,lis3mdl-magn - - st,lng2dm-accel - - st,lps331ap-press - - st,lsm303agr-accel - - st,lsm303dlh-accel - - st,lsm303dlhc-accel - - st,lsm303dlm-accel - - st,lsm330-accel - - st,lsm330-gyro - - st,lsm330d-accel - - st,lsm330d-gyro - - st,lsm330dl-accel - - st,lsm330dl-gyro - - st,lsm330dlc-accel - - st,lsm330dlc-gyro - - st,lsm9ds0-gyro - - st,lsm9ds1-magn - then: - properties: - interrupts: - maxItems: 2 - required: - compatible - reg
The original bindings was listing the length of the interrupts as either 1 or 2, depending on the setup. This is also what is enforced by the top level schema. However, that is further constrained with an if clause that require exactly two interrupts, even though it might not make sense on those devices or in some setups. Let's remove the clause entirely. Cc: Denis Ciocca <denis.ciocca@st.com> Cc: Jonathan Cameron <jic23@kernel.org> Cc: Lars-Peter Clausen <lars@metafoo.de> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: linux-iio@vger.kernel.org Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- .../bindings/iio/st,st-sensors.yaml | 41 ------------------- 1 file changed, 41 deletions(-)