mbox series

[v8,0/5] Implement SPM/SAW for MSM8998 and SDM6xx

Message ID 20210729155609.608159-1-angelogioacchino.delregno@somainline.org
Headers show
Series Implement SPM/SAW for MSM8998 and SDM6xx | expand

Message

AngeloGioacchino Del Regno July 29, 2021, 3:56 p.m. UTC 
Changes in v8:
- Rebased on next-20210728
- Fixed all YAML issues from dt_binding_check
- Fixed forgotten signoffs (truly, truly sorry about that)

Changes in v7:
- Fixed functionality breakage on ARM for cpuidle-qcom-spm... now it works :))
- Reworded description of patch 1/5

Changes in v6:
- Moved cpuidle_driver to be private to cpuidle-qcom-spm (unused in spm.c),
  now we are assigning the cpuidle_driver structure fields inside of the
  spm_cpuidle_register function; this also fixes the cpumask assignment
  issue from v5
- Fixed another contamination from 2/3 in 1/3 (argh!! :])
- Added dt-bindings documentation for the SPM driver

Changes in v5:
- Fixed contamination from patch 2/3 in patch 1/3
- Fixed missing bits in cpuidle-qcom-spm (thanks Stephan)

Changes in v4:
- Huge patch series has been split for better reviewability,
  as suggested by Bjorn

Changes in v3:
- Rebased (no changes - was in previous series' v3)

Changes in v2:
- Fixed MSM8998 SAW parameters on SPM driver

Tested on the following smartphones:
- Sony Xperia XA2        (SDM630)
- Sony Xperia XA2 Ultra  (SDM630)
- Sony Xperia 10         (SDM630)
- Sony Xperia XZ Premium (MSM8998)
- F(x)Tec Pro 1          (MSM8998)

This is a component that we can find on very old
chips, like MSM8974; there, it has been used to actually do the
power scaling basically "on its own" - sending the cores in a specific
sleep mode to save power.
On the newer ones, including MSM8998, SDM630, 660 and others, it is still
present! Though, this time, it's being used for the cluster caches and it
has a different firmware (and maybe it's also slightly different HW),
implementing the SAWv4.1 set and getting controlled *not by the OS* but
by other controllers in the SoC (like the OSM).

Contrary from MSM8974 and the like, this new version of the SPM just
requires us to set the initial parameters for AVS and *nothing else*, as
its states will be totally managed internally.
AngeloGioacchino Del Regno (5):
  cpuidle: qcom_spm: Detach state machine from main SPM handling
  dt-bindings: soc: qcom: Add devicetree binding for QCOM SPM
  soc: qcom: spm: Implement support for SAWv4.1, SDM630/660 L2 AVS
  soc: qcom: spm: Add compatible for MSM8998 SAWv4.1 L2
  dt-bindings: soc: qcom: spm: Document SDM660 and MSM8998 compatibles

 .../bindings/soc/qcom/qcom,spm.yaml           |  80 +++++
 drivers/cpuidle/Kconfig.arm                   |   1 +
 drivers/cpuidle/cpuidle-qcom-spm.c            | 318 ++++--------------
 drivers/soc/qcom/Kconfig                      |   9 +
 drivers/soc/qcom/Makefile                     |   1 +
 drivers/soc/qcom/spm.c                        | 254 ++++++++++++++
 include/soc/qcom/spm.h                        |  43 +++
 7 files changed, 456 insertions(+), 250 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,spm.yaml
 create mode 100644 drivers/soc/qcom/spm.c
 create mode 100644 include/soc/qcom/spm.h

Comments

Rob Herring (Arm) Aug. 2, 2021, 10:54 p.m. UTC | #1 
On Thu, 29 Jul 2021 17:56:09 +0200, AngeloGioacchino Del Regno wrote:
> The driver was updated to add SAW2 v4.1 support for new SoCs: document
> the new compatibles.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> ---
>  .../bindings/soc/qcom/qcom,spm.yaml           | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Daniel Lezcano Aug. 14, 2021, 10:46 a.m. UTC | #2 
On 05/08/2021 00:56, Bjorn Andersson wrote:
> On Thu 29 Jul 10:56 CDT 2021, AngeloGioacchino Del Regno wrote:

> 

>> In commit a871be6b8eee ("cpuidle: Convert Qualcomm SPM driver to a generic

>> CPUidle driver") the SPM driver has been converted to a

>> generic CPUidle driver: that was mainly made to simplify the

>> driver and that was a great accomplishment;

>> Though, at that time, this driver was only applicable to ARM 32-bit SoCs,

>> lacking logic about the handling of newer generation SAW.

>>

>> In preparation for the enablement of SPM features on AArch64/ARM64,

>> split the cpuidle-qcom-spm driver in two: the CPUIdle related

>> state machine (currently used only on ARM SoCs) stays there, while

>> the SPM communication handling lands back in soc/qcom/spm.c and

>> also making sure to not discard the simplifications that were

>> introduced in the aforementioned commit.

>>

>> Since now the "two drivers" are split, the SCM dependency in the

>> main SPM handling is gone and for this reason it was also possible

>> to move the SPM initialization early: this will also make sure that

>> whenever the SAW CPUIdle driver is getting initialized, the SPM

>> driver will be ready to do the job.

>>

>> Please note that the anticipation of the SPM initialization was

>> also done to optimize the boot times on platforms that have their

>> CPU/L2 idle states managed by other means (such as PSCI), while

>> needing SAW initialization for other purposes, like AVS control.

>>

>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>

>> Reviewed-by: Stephan Gerhold <stephan@gerhold.net>

>> Tested-by: Stephan Gerhold <stephan@gerhold.net>

> 

> Rafael, Daniel, any objections to me picking this patch through the qcom

> tree?

> 


Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>




-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog