| Message ID | 20210804020305.29812-1-islituo@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | mwifiex: drop redundant null-pointer check in mwifiex_dnld_cmd_to_fw() | expand |
On Tue, Aug 3, 2021 at 7:03 PM Tuo Li <islituo@gmail.com> wrote: > > There is no case in which the variable cmd_node->cmd_skb has no ->data, > and thus the variable host_cmd is guaranteed to be not NULL. Therefore, > the null-pointer check is redundant and can be dropped. > > Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> > Signed-off-by: Tuo Li <islituo@gmail.com> Tested-by: Brian Norris <briannorris@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org>
Tuo Li <islituo@gmail.com> wrote: > There is no case in which the variable cmd_node->cmd_skb has no ->data, > and thus the variable host_cmd is guaranteed to be not NULL. Therefore, > the null-pointer check is redundant and can be dropped. > > Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> > Signed-off-by: Tuo Li <islituo@gmail.com> > Tested-by: Brian Norris <briannorris@chromium.org> > Reviewed-by: Brian Norris <briannorris@chromium.org> Patch applied to wireless-drivers-next.git, thanks. 118934041c5f mwifiex: drop redundant null-pointer check in mwifiex_dnld_cmd_to_fw() -- https://patchwork.kernel.org/project/linux-wireless/patch/20210804020305.29812-1-islituo@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/marvell/mwifiex/cmdevt.c index 3a11342a6bde..171a25742600 100644 --- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c @@ -187,7 +187,7 @@ static int mwifiex_dnld_cmd_to_fw(struct mwifiex_private *priv, host_cmd = (struct host_cmd_ds_command *) (cmd_node->cmd_skb->data); /* Sanity test */ - if (host_cmd == NULL || host_cmd->size == 0) { + if (host_cmd->size == 0) { mwifiex_dbg(adapter, ERROR, "DNLD_CMD: host_cmd is null\t" "or cmd size is 0, not sending\n");
There is no case in which the variable cmd_node->cmd_skb has no ->data, and thus the variable host_cmd is guaranteed to be not NULL. Therefore, the null-pointer check is redundant and can be dropped. Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> Signed-off-by: Tuo Li <islituo@gmail.com> --- drivers/net/wireless/marvell/mwifiex/cmdevt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)