mbox series

[v2,0/3] can: provide GPIO based termination

Message ID 20210818071232.20585-1-o.rempel@pengutronix.de
Headers show
Series can: provide GPIO based termination | expand

Message

Oleksij Rempel Aug. 18, 2021, 7:12 a.m. UTC 
changes v3:
- use u32 instead of u16 for termination-ohms
- extend error handling

changes v2:
- add CAN_TERMINATION_GPIO_MAX
- remove fsl,scu-index from yaml example. It is not used on imx6q

Oleksij Rempel (3):
  dt-bindings: can-controller: add support for termination-gpios
  dt-bindings: can: fsl,flexcan: enable termination-* bindings
  can: dev: provide optional GPIO based termination support

 .../bindings/net/can/can-controller.yaml      |  9 +++
 .../bindings/net/can/fsl,flexcan.yaml         | 17 +++++
 drivers/net/can/dev/dev.c                     | 66 +++++++++++++++++++
 include/linux/can/dev.h                       |  8 +++
 4 files changed, 100 insertions(+)

Comments

Rob Herring (Arm) Aug. 18, 2021, 5:02 p.m. UTC | #1 
On Wed, 18 Aug 2021 09:12:31 +0200, Oleksij Rempel wrote:
> Enable termination-* binding and provide validation example for it.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  .../bindings/net/can/fsl,flexcan.yaml           | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Marc Kleine-Budde Aug. 19, 2021, 7:56 a.m. UTC | #2 
On 18.08.2021 09:12:29, Oleksij Rempel wrote:
> changes v3:

> - use u32 instead of u16 for termination-ohms

> - extend error handling

> 

> changes v2:

> - add CAN_TERMINATION_GPIO_MAX

> - remove fsl,scu-index from yaml example. It is not used on imx6q

> 

> Oleksij Rempel (3):

>   dt-bindings: can-controller: add support for termination-gpios

>   dt-bindings: can: fsl,flexcan: enable termination-* bindings

>   can: dev: provide optional GPIO based termination support


Applied to linux-can-next/testing

Thanks,
Marc
-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |