diff mbox

[Xen-devel,xen-unstable,test] 25742: tolerable FAIL - PUSHED

Message ID 1396602178.4211.163.camel@kazak.uk.xensource.com
State New
Headers show

Commit Message

Ian Campbell April 4, 2014, 9:02 a.m. UTC 
On Thu, 2014-04-03 at 20:47 +0100, xen.org wrote:
>  test-amd64-amd64-pv           1 xen-build-check(1)           blocked  n/a

Sigh, looks like I didn't test the final version of "make-flight: drop
another stray xend test from 4.5 onwards" properly enough...

-----------------8<-------------------

From 21b5e59cc8bfed9a49211ef741db5b8eccc9d5c1 Mon Sep 17 00:00:00 2001
From: Ian Campbell <ian.campbell@citrix.com>
Date: Fri, 4 Apr 2014 09:55:56 +0100
Subject: [PATCH] make-flight: really drop the stray xend test from 4.5 onwards

The precedence rules meant the test was:
  ( xend enabled AND arch = i386 ) OR ( arch = amd64 )
rather than the intended:
  ( xend enabled ) AND ( arch = i386 OR arch = amd64 )

I've confirmed that a xen-instable flight no longer has test jobs with
toolstack == xend and that a Xen 4.4 flight is unchanged.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 make-flight | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ian Jackson April 4, 2014, 11:03 a.m. UTC | #1 
Ian Campbell writes ("Re: [Xen-devel] [xen-unstable test] 25742: tolerable FAIL - PUSHED"):
> On Thu, 2014-04-03 at 20:47 +0100, xen.org wrote:
> >  test-amd64-amd64-pv           1 xen-build-check(1)           blocked  n/a
> 
> Sigh, looks like I didn't test the final version of "make-flight: drop
> another stray xend test from 4.5 onwards" properly enough...

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Ian.
diff mbox

Patch

diff --git a/make-flight b/make-flight
index 7f5e81b..92b813a 100755
--- a/make-flight
+++ b/make-flight
@@ -255,7 +255,7 @@  test_matrix_do_one () {
   esac
 
   # xend PV guest test on x86 only
-  if [ x$test_xend = xy -a $dom0arch = "i386" -o $dom0arch = "amd64" ]; then
+  if [ x$test_xend = xy -a \( $dom0arch = "i386" -o $dom0arch = "amd64" \) ]; then
     job_create_test test-$xenarch$kern-$dom0arch-pv test-debian xend \
             $xenarch $dom0arch                                       \
             $debian_runvars all_hostflags=$most_hostflags