| Message ID | 1631539062-28577-1-git-send-email-srivasam@codeaurora.org |
|---|---|
| Headers | show |
| Series | Machine driver to support LPASS SC7280 sound card registration | expand |
On 9/14/2021 1:19 AM, Stephen Boyd wrote: Thanks for Your time Stephen!!! > Quoting Srinivasa Rao Mandadapu (2021-09-13 06:17:42) >> diff --git a/sound/soc/qcom/sc7280.c b/sound/soc/qcom/sc7280.c >> new file mode 100644 >> index 0000000..906910c >> --- /dev/null >> +++ b/sound/soc/qcom/sc7280.c >> @@ -0,0 +1,343 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +// >> +// Copyright (c) 2020-2021, The Linux Foundation. All rights reserved. >> +// >> +// sc7280.c -- ALSA SoC Machine driver for sc7280 >> + >> +#include <linux/gpio.h> >> +#include <linux/gpio/consumer.h> >> +#include <linux/module.h> >> +#include <linux/of_device.h> >> +#include <linux/platform_device.h> >> +#include <sound/core.h> >> +#include <sound/jack.h> >> +#include <sound/pcm.h> >> +#include <sound/soc.h> >> +#include <uapi/linux/input-event-codes.h> > Looks like the include should be <linux/input.h> instead. I see that > practically no other code in the kernel is including the uapi header as > it's for userspace, not kernel. The uapi header is included in input.h > though so it's not actually all that different. Okay Will change accordingly!!! > >> + >> +#include <dt-bindings/sound/sc7180-lpass.h> >> +#include <dt-bindings/sound/qcom,q6afe.h> >> + >> +#include "../codecs/wcd938x.h" >> +#include "common.h" >> +#include "lpass.h" >> + > [...] >> +static int sc7280_snd_platform_probe(struct platform_device *pdev) >> +{ >> + struct snd_soc_card *card; >> + struct sc7280_snd_data *data; >> + struct device *dev = &pdev->dev; >> + struct snd_soc_dai_link *link; >> + int ret, i; >> + >> + /* Allocate the private data */ > This comment is worthless. Okay. Will remove it. > >> + data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); >> + if (!data) >> + return -ENOMEM; >> + >> + card = &data->card; >> + snd_soc_card_set_drvdata(card, data); >> + >> + card->owner = THIS_MODULE; >> + card->driver_name = "SC7280"; >> + card->dev = dev; >> + >> + ret = qcom_snd_parse_of(card); >> + if (ret) >> + return ret; >> + >> + for_each_card_prelinks(card, i, link) { >> + link->init = sc7280_init; >> + link->ops = &sc7280_ops; >> + } > Nitpick: Newline here. Okay. > >> + return devm_snd_soc_register_card(dev, card); >> +} >> +
This patch set is to add support for SC7280 sound card registration and to add dt-bindings documentation file. These patches depends on the dt-bindings header patch -- https://patchwork.kernel.org/project/alsa-devel/list/?series=543829 Srinivasa Rao Mandadapu (2): ASoC: google: dt-bindings: Add sc7280-herobrine machine bindings ASoC: qcom: SC7280: Add machine driver Chnages Since V1: -- Indentation changes and typo. .../bindings/sound/google,sc7280-herobrine.yaml | 169 ++++++++++ sound/soc/qcom/Kconfig | 12 + sound/soc/qcom/Makefile | 2 + sound/soc/qcom/sc7280.c | 343 +++++++++++++++++++++ 4 files changed, 526 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml create mode 100644 sound/soc/qcom/sc7280.c